Commit Graph

3464 Commits

Author SHA1 Message Date
Nicolas Micoud 1646074a59
IDEMPIERE-5446 : Property to know an AttachmentEntry has been updated (#1522)
* IDEMPIERE-5446 : Property to know an AttachmentEntry has been updated

https://idempiere.atlassian.net/browse/IDEMPIERE-5446

* IDEMPIERE-5446 : Property to know an AttachmentEntry has been updated - fix javadoc
2022-10-10 14:59:07 +08:00
Peter Takács a96c6e482d
IDEMPIERE-5432 - Performance Measure Calculation - Improve SQL Definition (#1500)
* IDEMPIERE-5432 - Performance Measure Calculation - Improve SQL Definition

* IDEMPIERE-5432 - IDEMPIERE-5432_PR1 patch
2022-10-07 14:01:12 +08:00
Deepak Pansheriya abae9f221d
IDEMPIERE-5349: Adding AlwaysUpdatableLogic on Column and Field. (#1408)
* IDEMPIERE-5349: Adding AlwaysUpdatableLogic on Column and Field.

* IDEMPIERE-5349: Making Always Updatable logic to work when isAlwaysUpdatable is false and iAlwaysUpdatable made higher priority

* IDEMPIERE-5349: fixing error SP2-0027 in oracle

* IDEMPIERE-5349 : Fixing AlwaysUpdatableLogic not set when isAlwaysUpdatableLogic is null

* IDEMPIERE-5349 : renaming migration script and updatong AD_Field_V and AD_Field_VT
2022-10-06 13:53:32 +08:00
hengsin 476e9ab71c
IDEMPIERE-5396 Replace CreateFrom form with Info Window Process (#1514)
- Fix Default AD_InfoWindow_ID value of AD_Column
2022-10-05 11:00:42 +02:00
Carlos Ruiz c1a1045d87
IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823) (#1498)
* IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823)

- Add column AD_Client.LoginPrefix

* - Implement logic to manage login prefix
- Add SysConfig keys LOGIN_PREFIX_SEPARATOR and LOGIN_WITH_TENANT_PREFIX

* - Rename methods as suggested by Heng Sin

* IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823)

For security reasons is better to ask for MFA before showing additional information from the user.
Refactoring the panels to show the MFA panel as soon as the tenant is defined.

* - Add uniqueness validations on tenant creation

* - Fix the Forgot My Password functionality

* - Fix the Change Expired Password functionality

* - minor javadoc improvement
- remove a redundant comment, the method is already mark as deprecated

Co-authored-by: hengsin <hengsin@gmail.com>
2022-10-04 11:14:05 +02:00
Nicolas Micoud 98c9dfc844
IDEMPIERE-5434 : Allow to define db view component with DISTINCT (#1505)
https://idempiere.atlassian.net/browse/IDEMPIERE-5434
2022-09-30 13:52:43 +08:00
Diego Ruiz 8a51fb8f4a
IDEMPIERE-2205 - Ask for secret input from within a process (#1501) 2022-09-26 19:46:09 +08:00
Carlos Ruiz aef93fb113
IDEMPIERE-5430 UPDATE generating unnecessary settings for null columns (#1496) 2022-09-23 15:25:51 +08:00
hengsin 536eda3546
IDEMPIERE-5427 Upgrade to Tycho 2.7.5 (#1493)
- restore .classpath to remove Tycho Configurator m2e connector
dependency
2022-09-21 14:21:27 +02:00
Elaine Tan 0b8b7da8e5
IDEMPIERE-5396 Replace CreateFrom form with Info Window Process (#1469)
* IDEMPIERE-5396 Replace CreateFrom form with Info Window Process
2022-09-19 18:30:24 +08:00
Carlos Ruiz 45516c6c91
IDEMPIERE-5425 Chosen Multiple Selection fields are not being copied with the Copy button (#1489) 2022-09-17 11:47:47 +08:00
Carlos Ruiz 1229faab34
IDEMPIERE-2058 Fix problem reading wrong column (#1484) 2022-09-14 10:24:05 +08:00
Carlos Ruiz 52e5e17fed
IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757) (#1483)
* IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757)

* IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757)
2022-09-13 18:57:13 +02:00
Carlos Ruiz 3c69ba56a4
IDEMPIERE-5415 Incomplete process log when output is > 2000 chars (#1476) 2022-09-11 15:22:52 +08:00
Jasper Siepkes 861e3ad01f
IDEMPIERE-5013 Implement HikariCP as a replacement for c3p0 (#926)
* Replaced PostgreSQL and Oracle connection pools with HikariCP.

Replaced C3P0 with HikariCP. HikariCP is a Apache licensed connection pool with substantially better performance and better resilience to failure (DB disconnects, etc.) then C3P0. Read more about it here: https://github.com/brettwooldridge/HikariCP .

Cleaned up the `getCachedConnection` method. With HikariCP there is no need to retry to obtain a connection since getting an connection will block until a free connection is available or until a timeout is reached (default 30 seconds) at which point an `SQLException` is thrown. This also removed calling `Runtime.getRuntime().runFinalization();`. HikariCP is currently configured to detect / log leaks when a connection hasn't returned to the pool for longer then 5 minutes.

Loading of pool config properties was cleaned up. Defaults are now loaded from a single file instead of defaults coming from both file and hardcoded properties. It is now also possible to specify any HikariCP property in the user pool property file.

Initialization of the datasource must happen in the `getDataSource()` method because at object construction not all JDBC config is known. However this method could (as far as I could tell) be called concurrently from multiple threads but had no mechanism to prevent initializing the DB pool multiple times. The variable in which the pool itself was stored (`m_ds`) also was not marked volatile or immutable which could lead to visibility issues. Instead of lazy initialization of the pool in the `getDataSource()` method the pool could probably better be initialized at object construction. However I wasn't able to achieve that without breakage therefor I made the initialization mechanism work correctly with concurrent invocations.

Various config options such as the `MaxStatementsPerConnection` options were removed because HikariCP doesn't support them.

* (Re)added Sequence time-out.
2022-09-10 12:21:57 +02:00
Deepak Pansheriya 8c5c0ecbfa
IDEMPIERE-5326: Parsing error for report view if where clause and vir… (#1385)
* IDEMPIERE-5326: Parsing error for report view if where clause and virtual column used in print format

* IDEMPIERE-5326: Fixing Compilation error

* IDEMPIERE-5326: Adding method back for backward compitability

* IDEMPIERE-5326: Adding constructors  for backward compitability
2022-09-07 21:45:23 +08:00
Peter Takács 1f4a23657a
IDEMPIERE-5400 - Dashboard Goal Content should render as single Gauge Indicator (#1458)
* IDEMPIERE-5400 - Dashboard Goal Content should render as single Gauge Indicator

* IDEMPIERE-5400 - better css responsivity

* IDEMPIERE-5400 - add update goal

* IDEMPIERE-5400 - fixes

* IDEMPIERE-5400 - resolved conflict, migration fix

* IDEMPIERE-5400 - fix bad merge
2022-09-07 21:40:29 +08:00
Peter Takács ee3476c3eb
IDEMPIERE-5409 - Dashboard Content - Maximizable checkbox (#1467)
* IDEMPIERE-5409 - Dashboard Content - Maximizable checkbox

* IDEMPIERE-5409 - IsMaximizable default 'Y'

* IDEMPIERE-5393 - fixes

* IDEMPIERE-5409 - fixed script name
2022-09-07 17:00:18 +08:00
Carlos Ruiz 8748f11ddf
IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757) (#1464) 2022-09-06 13:58:17 +02:00
Carlos Ruiz 0e71fa9884
IDEMPIERE-5407 Heavy query in MRole repeated too often (FHCA-3883) (#1465)
Removed the method MRole.loadTableInfo which loaded the arrays: m_tableAccessLevel, m_tableName, m_viewName, m_tableIdName
and replaced all usage with visits to cached information from tables or columns
2022-09-06 15:01:06 +08:00
Nicolas Micoud 537cb8b9b8
IDEMPIERE-5403 : Misleading error message on TimeUtil.getDay(int, int, int) (#1460)
https://idempiere.atlassian.net/browse/IDEMPIERE-5403
2022-09-05 13:13:36 +02:00
Nicolas Micoud 79d9efb8f5
IDEMPIERE-5395 : Validation Rules at Client level (#1451) 2022-08-30 13:25:01 +02:00
Peter Takács e528c6f8cb
IDEMPIERE-5389 - Dashboard row layout (#1448)
* IDEMPIERE-5389 - Dashboard row layout

* IDEMPIERE-5389 - taking changes related to ticket 5393

* IDEMPIERE-5389 - added Flex Grow to Preference

* IDEMPIERE-5389 - fixing gadget heights

* IDEMPIERE-5389 - center alignment for Status Line

* IDEMPIERE-5389 - fall back to column layout

* IDEMPIERE-5389 - pr1448 patch

* IDEMPIERE-5389 - FixOracleMigration patch
2022-08-30 10:11:42 +02:00
hengsin c45005be41
IDEMPIERE-5376 CConnection and DB clean up (#1457)
* IDEMPIERE-5376 CConnection and DB clean up

* IDEMPIERE-5376 CConnection and DB clean up

- More clean up

* IDEMPIERE-5376 CConnection and DB clean up

- Fix @Deprecated annotation
2022-08-29 21:36:50 +02:00
Nicolas Micoud d0d42ffaf1
IDEMPIERE-5361 : Jasper reports with Charts are not working (#1452)
* IDEMPIERE-5361 : Jasper reports with Charts are not working

* IDEMPIERE-5361 : patch from hengsin
2022-08-26 09:35:54 +08:00
Peter Takács 0aaf904e34
IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard (#1449)
* IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard

* IDEMPIERE-5393 - css class for status line

* IDEMPIERE-5393 - update default theme version
2022-08-24 15:49:06 +08:00
Carlos Ruiz 2dab2d9882
IDEMPIERE-5394 Export to XLSX in Info Windows and Account Viewer (#1450)
* IDEMPIERE-5394 Export to XLSX in Info Windows and Account Viewer
2022-08-24 09:33:12 +08:00
hengsin ce22d1cc51
IDEMPIERE-5391 Unit Test: Fix support for parallel execution of test (#1446) 2022-08-17 18:34:51 +02:00
Carlos Ruiz a558644949
IDEMPIERE-3340 Fix cross tenant in Favourites (#1445) 2022-08-17 18:17:13 +08:00
Peter Takács e670ebbd14
IDEMPIERE-5302 - Drill Assistant Feature with re-generated migration scripts (#1390)
* IDEMPIERE-5302 - Drill Assistant Feature with re-generated migration scripts

* IDEMPIERE-5302 - added IsShowInDrillOptions, ID fixes

* IDEMPIERE-5302 - added IsShowInDrillOptions default Y

* IDEMPIERE-5302 - creating Table Print Formats on Run Report

* IDEMPIERE-5302 - applied pr1390_fixes patch

* IDEMPIERE-5302 - applied pr1390_badimports patch
2022-08-17 18:08:45 +08:00
hengsin 288e96fe8d
IDEMPIERE-5376 CConnection and DB clean up (#1441)
* IDEMPIERE-5376 CConnection and DB clean up

* IDEMPIERE-5376 CConnection and DB clean up

- More clean up
2022-08-13 12:05:52 +02:00
Carlos Ruiz 165229d2db
IDEMPIERE-5380 StackOverflowError when try to login in application with substitute user (FHCA-3828) (#1437) 2022-08-13 10:15:31 +08:00
Carlos Ruiz 5e5c977733
IDEMPIERE-5382 Allow just one MFA registration per mechanism (FHCA-3822) (#1439) 2022-08-12 17:15:28 +08:00
Carlos Ruiz bc9808eb14
IDEMPIERE-5381 System users cannot revoke MFA trusted devices in GardenWorld (FHCA-3824) (#1438) 2022-08-12 17:13:54 +08:00
hengsin 3a2f0ff64d
IDEMPIERE-5376 CConnection and DB clean up (#1432) 2022-08-10 14:52:53 +02:00
Carlos Ruiz 5bd3af0d2f
IDEMPIERE-236 Centralization of hardcoded IDs (#1429)
* IDEMPIERE-236 Centralization of hardcoded IDs

* IDEMPIERE-236 Centralization of hardcoded IDs
2022-08-09 22:12:54 +08:00
Carlos Ruiz 0cb7216599
IDEMPIERE-5375 Read-only windows are not shown in Favourites dashboard (#1430) 2022-08-09 15:09:03 +08:00
hengsin 5f8e7be3c5
IDEMPIERE-5367 Logic expression IN doesn't works with quoted text (#1423)
* IDEMPIERE-5367 Logic expression IN doesn't works with quoted text

* IDEMPIERE-5367 Logic expression IN doesn't works with quoted text

- Fixed equal not working for quoted text with comma (e.g 'A,R,S')
2022-08-05 13:21:50 +02:00
Carlos Ruiz 464de082a5
IDEMPIERE-5355 Improve default trx name (FHCA-3765) (#1427)
Improve performance using StackWalker instead of Throwable->getStackTrace
2022-08-05 09:46:11 +08:00
Carlos Ruiz 9b812a315f
IDEMPIERE-3340 Fix cross tenant in Favourites (#1426) 2022-08-05 00:11:06 +02:00
hengsin 1fcbd5ea07
IDEMPIERE-5358 Refactor CreateFrom (#1413)
* IDEMPIERE-5358 Refactor CreateFrom

* IDEMPIERE-5358 Refactor CreateFrom

- Fix java doc

* IDEMPIERE-5358 Refactor CreateFrom

- Fix SQL error for Oracle (SELECT without FROM only works for
PostgreSQL).

* IDEMPIERE-5358 Refactor CreateFrom

- revert change of protected method name.
2022-08-04 12:42:53 +02:00
Elaine Tan 27c5d0fa53
IDEMPIERE-5339 GL AP/AR and RLL/RLG facts posted on wrong side in allocation reversal document using Payment Reverse-Accrual (#1420)
* IDEMPIERE-5339 GL AP/AR and RLL/RLG facts posted on wrong side in allocation reversal document using Payment Reverse-Accrual
2022-08-04 16:52:41 +08:00
hengsin 58813e8e83
IDEMPIERE-5359 Unit test not working with Oracle (#1419)
* IDEMPIERE-5359 Unit test not working with Oracle

- Fix local trx not rollback for SQLException
- Add test for getSQLValueObjectsEx and getSQLArrayObjectsEx
2022-08-04 16:21:29 +08:00
Peter Takács 5931f6ce8f
IDEMPIERE-5356 - Add Printing Support to ProcessInfoDialog (#1412)
* IDEMPIERE-5356 - Add Printing Support to ProcessInfoDialog
2022-08-02 17:10:52 +08:00
Alan Lescano 11962e1713
IDEMPIERE-5259 Labels feature (#1357)
* IDEMPIERE-5259 Labels feature
* IDEMPIERE-5259 Update the theme version timestamp
* IDEMPIERE-5259 Better javadoc
* Update 202205131118_IDEMPIERE-5259.sql
* Update 202205131118_IDEMPIERE-5259.sql
* IDEMPIERE-5259 New window Label Assignment
* IDEMPIERE-5259 Toggle issue
* IDEMPIERE-5259 MSysConfig is ordered alphabetically
* IDEMPIERE-5259 Default SysConfig
* IDEMPIERE-5259 Avoid duplicated records
Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-08-01 21:51:38 +02:00
Peter Takács c62a9ad066
IDEMPIERE-1965 - Implement Generate Invoices (manual) as Info Window (#1400)
* IDEMPIERE-1965 - Implement Generate Invoices (manual) as Info Window
* IDEMPIERE-1965 - fixes
* IDEMPIERE-1965 - Deprecate Form
* IDEMPIERE-1965 - backwards compatibility
* IDEMPIERE-1965 - vendor RMA form legacy
* IDEMPIERE-1965 - merge patch
* IDEMPIERE-1965 - 1965_PR patch
2022-08-01 20:41:39 +02:00
Carlos Ruiz 097ca0569e
IDEMPIERE-5363 - fix MRefList cache (#1417)
Co-authored-by: matheus-marcelinux <matheusmarcelino1998@hotmail.com>
2022-08-01 14:52:19 +02:00
hengsin edc96cca12
IDEMPIERE-5153 Cost Adjument Line Before Save: Update current cost price (#1411)
- Fix always getting current cost from primary accounting schema.
2022-07-26 21:26:58 +08:00
Carlos Ruiz 486ae19cdc
IDEMPIERE-5355 Improve default trx name (FHCA-3765) (#1407)
* IDEMPIERE-5355 Improve default trx name (FHCA-3765)

* IDEMPIERE-5355 Improve default trx name (FHCA-3765)

Implement suggestions from Heng Sin
Added SysConfig TRX_AUTOSET_DISPLAY_NAME (default false)

* Delete test/debugging code committed by mistake

* IDEMPIERE-5355 fix method wrongly named
2022-07-26 14:08:32 +08:00
Nicolas Micoud 58027792d8
IDEMPIERE-5342 : Ability to hide the title of the chart when displaye… (#1392)
* IDEMPIERE-5342 : Ability to hide the title of the chart when displayed on Home page
2022-07-21 20:09:11 +08:00
Nicolas Micoud e8b2a94b3f
IDEMPIERE-5348 : Validation of filenames (#1398) 2022-07-18 15:26:34 +02:00
Carlos Ruiz 9ed8c950f7
IDEMPIERE-5345 Login.getClients not validating role type (#1391)
* IDEMPIERE-5345 Login.getClients not validating role type

* Add null validation for whereRoleType
2022-07-14 09:35:36 +08:00
hengsin 73aecb1145
IDEMPIERE-5347 Minor scheduler improvement (#1393) 2022-07-13 23:09:54 +02:00
Carlos Ruiz 1846439e92 Revert "IDEMPIERE-5302 - Drill Assistant Feature (#1345)"
This reverts commit 809e3ae734.
2022-07-08 13:25:19 +02:00
Carlos Ruiz 2ba935a393
IDEMPIERE-5340 Log the exception in EventHelper.addError for future use (FHCA-3426) (#1386) 2022-07-07 14:29:59 +08:00
Deepak Pansheriya 9a64a1a11c
IDEMPIERE-5295: Trial Balance Report creates Opening balance per orga… (#1378)
* IDEMPIERE-5295: Trial Balance Report creates Opening balance per organization and setting opening date day before from date.

* IDEMPIERE-5295: Correction as per Hengsin's code review vomment.

* IDEMPIERE-5295: Opening Balance should be on first day of Period

* IDEMPIERE-5295: Removed unused import

* IDEMPIERE-5295: Fixing report view is not set on default print format
Co-authored-by: hengsin@gmail.com
2022-07-06 19:53:15 +08:00
Peter Takács 809e3ae734
IDEMPIERE-5302 - Drill Assistant Feature (#1345)
* IDEMPIERE-5302 - Drill Assistant Feature
2022-06-30 20:08:22 +08:00
hengsin 278fde8f72
IDEMPIERE-5332 Refactoring of Archive Viewer (#1376)
* IDEMPIERE-5332 Refactoring of Archive Viewer

* IDEMPIERE-5332 Refactoring of Archive Viewer

- remove join to AD_Process_Access
2022-06-30 19:28:19 +08:00
Carlos Ruiz 7246c56266
IDEMPIERE-5331 Create Production from Order (all Lines) (#1375)
* IDEMPIERE-5331 Create Production from Order (all Lines)

* Refactoring to remove redundant or unused code and parameters

* Clear the order line reference on production when voiding and reversing
2022-06-30 10:05:33 +08:00
lHeidbreder ddaf0d6af3
IDEMPIERE-4269 shipment (on availability) should be created only if products are available (#1329)
IDEMPIERE-4269 shipment (on availability) should be created only if products are available

Co-authored-by: hengsin <hengsin@gmail.com>
2022-06-29 22:15:08 +08:00
Peter Takács 5303a10da2
IDEMPIERE-5319 - Delete Record with Confirmation Logic (#1371)
* IDEMPIERE-5319 - Delete Record with Confirmation Logic

* IDEMPIERE-5319 - modified listener for more correct behavior

* IDEMPIERE-5319 - modified listener for more correct behavior

* IDEMPIERE-5319 - improved validation

* IDEMPIERE-5319 - exception, message translation, removed new buttons

* IDEMPIERE-5319 - merged validation on close
2022-06-27 11:26:38 +02:00
Peter Takács 1f9955fcc9
IDEMPIERE-2058 - ** New Report ** - improve for handling Forms too (#1335)
* IDEMPIERE-2058 - ** New Report ** - improve for handling Forms too

* IDEMPIERE-2058 - error fixed

* IDEMPIERE-2058 - dialogs added

* IDEMPIERE-2058 - latest WIP commit until final design stated

* IDEMPIERE-2058 - added cancel button, mandatory handling
2022-06-25 15:07:07 +02:00
iDempierePatch 06c41d2c68
IDEMPIERE-5300 ErrorMsg doesn't show full message + LifeTime Msg conf… (#1342)
* IDEMPIERE-5300 ErrorMsg doesn't show full message + LifeTime Msg configurable

* IDEMPIERE-5300 ErrorMsg doesn't show full message + LifeTime Msg configurable / peer review / solve issues requested by Heng Sin

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-06-24 16:34:19 +08:00
hengsin 006d47ce6a
IDEMPIERE-5320 Refactor unit test to use share constant for dictionary IDs (#1369) 2022-06-22 14:51:42 +02:00
hengsin c53fb6430e
IDEMPIERE-5316 Refactoring of Payment Allocation Form (#1364) 2022-06-14 14:20:06 +02:00
Peter Takács 5bd585c522
IDEMPIERE-5311 - Zoom Across Doesn't Allow Zoom from Different Windows of the Same Table (#1360)
* IDEMPIERE-5311 - (draft) Zoom Across Doesn't Allow Zoom from Different Windows of the Same Table

* IDEMPIERE-5311 - Suggested Patch
2022-06-14 13:20:49 +02:00
Carlos Ruiz 39a5fe5663
IDEMPIERE-5315 Mismatch in queries WWFActivity.getWhereActivities and DPActivitiesModel.getWorkflowCount (#1363)
* IDEMPIERE-5315 Mismatch in queries WWFActivity.getWhereActivities and DPActivitiesModel.getWorkflowCount

- Found that DPActivities is deprecated, so deprecated too the DPActivitiesModel
- Also found that DefaultDesktop had a dependency to show the total of DPActivities, refactored to do the same with the new DPDocumentStatus
- Moved the query to MWFActivity to use where required
- Refactored JDBC to Query

* Better name for method

* serialVersionUID
2022-06-14 13:19:19 +02:00
Peter Takács 0e4cb62479
IDEMPIERE-5307 - Report Summary Functions Not Working Properly (#1355)
* IDEMPIERE-5307 - Report Summary Functions Not Working Properly
2022-06-07 12:56:13 +08:00
Peter Takács bf32da5738
IDEMPIERE-4523 - Process Audit not mark AD_PInstance.IsProcessing on simple Reports (#1343)
* IDEMPIERE-4523 - Process Audit not mark AD_PInstance.IsProcessing on simple Reports

* IDEMPIERE-4523 - fixed workflow use case
2022-06-02 16:15:39 +08:00
Nicolas Micoud 20116c6144
IDEMPIERE-5305 : ORA-01704: string literal too long when trying to update a mail template (#1353) 2022-06-02 14:27:00 +08:00
PeterTakacs300 0dd6c2b4a9
IDEMPIERE-5304 - Missing Message from Payment (#1346)
* IDEMPIERE-5304 - Missing Message from Payment

* IDEMPIERE-5304 - replaced message type and Msg.translate method
2022-05-31 15:25:50 +08:00
Anozi Mada 935987bd9d
IDEMPIERE-5286 Fix ConcurrentModificationException in MPrintFormat.getAllItems Method (#1349) 2022-05-31 12:35:22 +08:00
hengsin ad7f78e3c1
IDEMPIERE-3294 Process Audit generate unused AD_PInstance_Para (#1344)
- Fix unit test error for RequisitionTest.testComplete()
2022-05-26 14:40:24 +08:00
PeterTakacs300 b2b31fb087
IDEMPIERE-3294 - check empty String parameter (#1336)
* IDEMPIERE-3294 - check empty String parameter
2022-05-25 14:48:37 +08:00
Nicolas Micoud 0959a1d313
IDEMPIERE-4863 : Enable save column width in WListBox - fix for System user (#1339) 2022-05-19 15:02:14 +02:00
Fr Jeremy Krieg 7af88c8c99
[IDEMPIERE-5014] Update Javadoc for new stream() method. (#1337) 2022-05-19 10:16:11 +08:00
hengsin 6ba272a732
IDEMPIERE-5014 Improve efficiency of Query for large result sets - using Stream (#1334)
- remove iterable() and restore the POIterator base iterate()
implementation.
2022-05-18 16:20:10 +02:00
Carlos Ruiz d67ca5b69b
IDEMPIERE-4723 remove minor warning in eclipse (#1332) 2022-05-18 10:08:38 +08:00
PeterTakacs300 13e0c8e1a4
IDEMPIERE-5275 - Tabular Report Re-Query button/close paramater window (#1306)
* IDEMPIERE-5275 - Tabular Report Re-Query button/close paramater window

* IDEMPIERE-5275 - fix bug with asynch. threads

* IDEMPIERE-5275 - BusyMask not showing correctly fix

* IDEMPIERE-5275 - icons added

* IDEMPIERE-5275 - sysconfig added

* IDEMPIERE-5275 - patch 1306_PeerReview applied

* IDEMPIERE-5275 - requested changes applied

* IDEMPIERE-5275 - small fixes

* IDEMPIERE-5275 - fixed wrong merge
2022-05-13 22:14:59 +08:00
hengsin a41aeb2205
IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing (#1277)
* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

- Fix rounding error
2022-05-12 11:12:05 +02:00
Carlos Ruiz cfb4ebe785
IDEMPIERE-5267 Make Cache Max Size configurable via system property (#1325)
* IDEMPIERE-5267 Make Cache Max Size configurable via system property

* Allow also value zero for cache max size
2022-05-12 16:58:38 +08:00
Carlos Ruiz fda23ef1ae
IDEMPIERE-5174 Disable System User (#1324)
Found also two minor performance improvements:
- avoid counting users when statistics not allowed
- change the query where to 1=0, better for the optimizer
2022-05-12 13:35:20 +08:00
hengsin 9e43a36862
IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing (#1313)
* IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing

* IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing

- Fix unit test error.
2022-05-11 18:39:58 +02:00
hengsin 4488537565
IDEMPIERE-5262 Implement readonly protection for DB.getSQLValueEx call (#1323)
- Avoid unnecessary commit call.
2022-05-11 18:03:03 +02:00
Nicolas Micoud 603743734d
IDEMPIERE-4863 : do not save when there is no customization (#1319) 2022-05-10 09:56:27 +08:00
Diego Ruiz 7d5f7f678c
IDEMPIERE-4723 - refactor MArchive.get to use the Query class instead… (#1314)
* IDEMPIERE-4723 - refactor MArchive.get to use the Query class instead of PreparedStatement, following best practices

* IDEMPIERE-4723 - refactor MArchive.get to use the Query class instead of PreparedStatement, following best practices
2022-05-06 17:57:54 +08:00
Carlos Ruiz 35cda7ffe8
IDEMPIERE-5284 Create method EMail.sendEx to have access to the full Exception when sending EMails (FHCA-3587) (#1316)
- improved also the dumpMessage, is just called when the level is finest, but it was logging on fine level, also the if must be out of the loop
2022-05-06 17:57:09 +08:00
hengsin d2e52bbb86
IDEMPIERE-5262 Implement readonly protection for DB.getSQLValueEx call (#1287)
* IDEMPIERE-5262 Implement readonly protection for DB.getSQLValueEx call

* IDEMPIERE-5262 Implement readonly protection for DB.getSQLValueEx call
2022-05-06 11:14:11 +02:00
Nicolas Micoud 440b9c27a1
IDEMPIERE-4863 : Enable save column width in WListBox - fix when panel has lots of columns (#1311) 2022-05-06 10:27:57 +08:00
hengsin a8958bf29d
IDEMPIERE-5261 Workflow EMail notification enhancement (#1299)
* IDEMPIERE-5261 Workflow EMail notification enhancement

* Update 202204190945_IDEMPIERE-5261.sql

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-05-05 18:51:11 +02:00
hengsin e91aa9d0d3
IDEMPIERE-5082 Drop Shipment: Pass shipper and tracking number from MR to Customer Shipment (#1284) 2022-05-04 23:05:54 +02:00
hengsin 3f6ec68f37
IDEMPIERE-5088 Implement Bank Transfer as Transactional Document like… (#1281)
* IDEMPIERE-5088 Implement Bank Transfer as Transactional Document like Payment

* IDEMPIERE-5088 Implement Bank Transfer as Transactional Document like Payment

- default to charge and to bpartner from the corresponding from fields
- add DateAcct, C_ConversionType_ID and IsOverrideCurrencyRate columns
- remove mandatory org linked bp requirement
- rename window to Bank/Cash Transfer and deactivate existing Bank/Cash
Transfer process.

* IDEMPIERE-5088 Change Bank Transfer Process to use (optionally) the new document

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-05-01 11:22:32 +08:00
Carlos Ruiz ef085e72d6
IDEMPIERE-5279 Improve PO to avoid calling cache reset unnecessarily (#1309) 2022-04-30 06:16:12 +08:00
Fr Jeremy Krieg 10db6177d0
IDEMPIERE-5014 Add stream interface to Query (#1298) 2022-04-29 10:27:26 +08:00
Nicolas Micoud 5476274f59
IDEMPIERE-5265 : Wizard for Chosen Multiple Selection List editor (#1289)
* IDEMPIERE-5265 : Wizard for Chosen Multiple Selection List editor

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>
2022-04-28 19:48:47 +08:00
Diego Ruiz 4bbb4f36fd
IDEMPIERE-5277 - Fixed list on Report dialogue not filtering inactive print formats (#1305) 2022-04-27 12:23:58 +08:00
Nicolas Micoud ac38581265
IDEMPIERE-3340 : Adaxa's User Favorite which allow user to organize their menu, create folders (#1304)
Menu items should use names defined in AD_UserDef... tables
2022-04-27 12:22:34 +08:00
Nicolas Micoud 00c112b263
IDEMPIERE-5276 : NPE on MInfoWindow.get (#1303) 2022-04-26 16:42:55 +08:00
hengsin 321a65bd66
IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone (#1300)
Fix unit test failure
2022-04-23 11:50:56 +02:00
hengsin 13b37c4acc
IDEMPIERE-5093 Scheduler cron pattern scheduling is always using serv… (#1270)
* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

* minor fix for oracle/202203240830_IDEMPIERE-5093.sql

* IDEMPIERE-5093 cheduler cron pattern scheduling is always using server time zone

- add time zone comment for cronpattern field
- use fix format for elapsed time (day'hour:minutes:seconds.millisecond)
- use time zone formatting at server monitor
- include etc/gmt* timezone id. fix handling of invalid user input
- fix wrong editor (date) use for timestamp with time zone field

* IDEMPIERE-5093 cheduler cron pattern scheduling is always using server time zone

- Fix MSchedule.getNextRunMS call.

* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

- add T_Timestamp to Test table and window.
- fix date time editor doesn't capture seconds for timestamp with time
zone.
- date time editor: use tenant time zone (if set), fallback to browser
time zone.
- date time editor: fix processing of timestamp with time zone value.
- time zone editor: drop the confusing etc/gmt* entries and support
entry of GMT(+/-)hh:mm custom zone id.

* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

Fix NPE

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-04-22 21:28:51 +02:00
igorpojzl 8d5f7768e4
IDEMPIERE-5256 Add Cache to MSession Refactor (#1283) 2022-04-20 19:00:13 +08:00
Nicolas Micoud e9ab40a18f
IDEMPIERE-5271 : Can't override reference in AD_UserDef_Proc_Parameter to use ChosenMultipleSelectionTable as report parameter (#1295) 2022-04-20 12:41:19 +02:00
PeterTakacs300 41c3e115b1
IDEMPIERE-5254 - AD create postgres sequences and ad_sequence for views (#1293)
* IDEMPIERE-5254 - AD create postgres sequences and ad_sequence for views

* IDEMPIERE-5254 - adjusting !isView condition
2022-04-20 12:29:15 +02:00
igorpojzl c13039cf82
IDEMPIERE-5268 Cache PA_DocumentStatus (#1291)
* IDEMPIERE-5268  Cache PA_DocumentStatus

* IDEMPIERE-5268 Cache PA_DocumentStatus
2022-04-15 15:51:40 +08:00
PeterTakacs300 d3b6c51655
IDEMPIERE-5255 - Print format Script Column SQL parse broken by space (#1285) 2022-04-15 15:48:40 +08:00
PeterTakacs300 f18d221b41
IDEMPIERE-5266 - AD_Column Caching changes (#1290) 2022-04-12 15:42:35 +08:00
Ricardo Santana b4922eaf12
IDEMPIERE-5264 - fix default report showing blank results (#1288) 2022-04-12 15:41:07 +08:00
Carlos Ruiz 6fde4b816d
IDEMPIERE-5258 Importing a print format in the same packin as the table throws errors (#1286)
IDEMPIERE-5258 #resolve
2022-04-12 15:39:51 +08:00
igorpojzl ef929dfae5
IDEMPIERE-5256 Add Cache to MSession (#1282) 2022-04-07 09:33:41 +08:00
PeterTakacs300 fb6aba0287
IDEMPIERE-5248 - Report View reference: list doesn't work (#1273)
* IDEMPIERE-5248 - Report View reference: list doesn't work

* IDEMPIERE-5248 - inconsistancy fixed
2022-04-06 18:18:56 +08:00
Carlos Ruiz 5d15bcf3ff
Implement @LINE@ script in print format item (#1280) 2022-04-05 10:35:52 +08:00
PeterTakacs300 a1d58852ed
IDEMPIERE-4753 Make printing filename configurable (#1251)
* IDEMPIERE-4753 Make printing filename configurable

* IDEMPIERE-4753 - Jasper report

* IDEMPIERE-4753 - fix NPE
2022-03-31 14:59:45 +02:00
Nicolas Micoud 0b54d2f4c6
IDEMPIERE-5241 : bugfixes for charts (#1262)
* IDEMPIERE-5241 : bugfixes for charts

fix WhereClause, WinHeight, TimeUnit (see details in ticket)

* IDEMPIERE-5214 : Bugfixes for charts - fix TabEditor when no chart is defined on field
2022-03-25 12:01:05 +01:00
Nicolas Micoud ab0db6e9aa
IDEMPIERE-5232 : Chart field at tenant level - filter datasource (System and current tenant only) (#1263) 2022-03-25 11:52:12 +01:00
hengsin 3090f2384b
IDEMPIERE-5056 Order and Invoice: Tax lookup interface (#1253)
* IDEMPIERE-5056 Order and Invoice: Tax lookup interface

* IDEMPIERE-5056 Order and Invoice: Tax lookup interface

- add default value for MSysConfig.getValue call.
2022-03-23 15:00:08 +01:00
hengsin d4532196a2
IDEMPIERE-5083 add FREIGHTCOSTRULE_CustomerAccount (#1261) 2022-03-22 19:27:04 +01:00
Nicolas Micoud 22c238e0d2
IDEMPIERE-5232 : Chart field at tenant level (#1249)
* IDEMPIERE-5232 : Chart field at tenant level

* IDEMPIERE-5232 : Chart field at tenant level - Change AccessLevel to System+Client

* IDEMPIERE-5232 : Chart field at tenant level - migration scripts to iD10

* IDEMPIERE-5232 : Chart field at tenant level - DataSource tab must be advanced

* IDEMPIERE-5232 : Chart field at tenant level - fix migration scripts

* IDEMPIERE-5232 : Chart field at tenant level - fix script
2022-03-22 18:57:53 +01:00
Layda Salas e3a44d924d
IDEMPIERE-2975 Password Validator translations (Passay lib) / integrating patch from Tomáš Švikruha (#1259) 2022-03-19 11:56:37 +01:00
hengsin 0f0ee411eb
IDEMPIERE-5089 Add MSysConfig.ALLOW_REVERSAL_OF_RECONCILED_PAYMENT (#1254) 2022-03-18 14:48:11 +01:00
Nicolas Micoud 98f31bc3eb
IDEMPIERE-5237 : Add tablename on log when a column is missing (#1258) 2022-03-18 14:39:37 +01:00
Diego Ruiz 4f5c3360fc
IDEMPIERE-5233 - Invoice created from the Commission Run window cannot be easly found after created (#1256) 2022-03-18 14:37:31 +01:00
Nicolas Micoud a7ab3a8345
IDEMPIERE-5235 : Usage of MOrg.getOfClient without PO (#1255)
* IDEMPIERE-5235 : Usage of MOrg.getOfClient without PO

* IDEMPIERE-5235 : Usage of MOrg.getOfClient without PO

changes suggested by @hengsin
2022-03-18 14:42:12 +08:00
PeterTakacs300 ccda5e4495
IDEMPIERE-5225 - HTML Report minification (#1237)
* IDEMPIERE-5225 - HTML Report minification

* IDEMPIERE-5225 - SysConfig added

* IDEMPIERE-5225 - minification default set to true
2022-03-17 15:36:02 +01:00
Carlos Ruiz 24836a7c6c
IDEMPIERE-5231 Create Payments from Bank Statement is not taking into account Discounts (#1248)
* IDEMPIERE-5231 Create Payments from Bank Statement is not taking into account Discounts #resolve

* - Remove misleading closing message
2022-03-15 15:11:06 +01:00
hengsin f15abe6522
IDEMPIERE-5224 Locator Field type Caching Improvement (#1242)
* IDEMPIERE-5224 Locator Field type Caching Improvement

- Replace M_Locator.get with MLocator ResultSet constructor
- Implement lazy loading for MLocatorLookup

* IDEMPIERE-5224 Locator Field type Caching Improvement

- Implement lazy loading without new constructor (as suggested by
Carlos)
2022-03-15 09:30:11 +01:00
Carlos Ruiz 1a51e92c42
IDEMPIERE-4586 Update translation of Client to Tenant (#1233)
* IDEMPIERE-4586 Update translation of Client to Tenant

* Exclude AD_Ref_List.Name from the update as it impacts too many constants generated in X_ classes

* * update the Updated column too so that it is easier to trace back which records have been updated (as suggested by Heng Sin)

* * Update some additional messages that becomes duplicated (as reported by Nicolas)

* * Add updates to AD_Tab.CommitWarning (as reported by Nicolas)
2022-03-12 16:59:32 +01:00
hengsin 9d0eea8fe3
IDEMPIERE-5094 Implement validation for costing level change ( Accounting Schema and Product Category Accounting ) (#1235) 2022-03-11 12:43:22 +01:00
Layda Salas ad70efcfa1
IDEMPIERE-1474 The class org.compiere.model.MPaymentValidate is not using translated error messages #resolve #fixversion 10 (#1234) 2022-03-09 10:35:37 +08:00
Carlos Ruiz 299454d5df
IDEMPIERE-5223 Allow attachment preview for xml and json (#1231) 2022-03-08 12:25:46 +08:00
Layda Salas dfb366f363
IDEMPIERE-1450 Translation missing for Matching Purchase Order #resolve #fixversion 10 (#1225) 2022-03-08 12:18:09 +08:00
PeterTakacs300 b4abd26307
IDEMPIERE-5216 - HTML Report - replace Record_ID with Identifier column (#1217)
* IDEMPIERE-5216 - HTML Report - replace Record_ID with Identifier column

* IDEMPIERE-5216 - multiple identifiers case fixed

* IDEMPIERE-5216 - NVL added
2022-03-08 11:38:54 +08:00
hengsin 89a1d0cd23
IDEMPIERE-5213 Flat view improvement for menu tree (#1212)
* IDEMPIERE-5213 Flat view improvement for menu tree

* IDEMPIERE-5213 Flat view improvement for menu tree

- fix annotation warning
2022-03-04 11:03:00 +01:00
Carlos Ruiz 715dfe8192
IDEMPIERE-5202 Implement auto save of current tab / add ZK_AUTO_SAVE_TABS_EXCLUDED, exclude Request windows (#1221) 2022-03-04 15:59:53 +08:00
Nicolas Micoud 7cabc12ebd
IDEMPIERE-5214 : Add AD_Role.IsClientAdministrator (#1220)
* IDEMPIERE-5214 : Add AD_Role.IsClientAdministrator

* IDEMPIERE-5214 : Add AD_Role.IsClientAdministrator - move scripts to i9

* IDEMPIERE-5214 : Add AD_Role.IsClientAdministrator - set value for new tenants

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
2022-03-03 16:19:54 +01:00
hengsin b6ce1e7cbe
IDEMPIERE-5202 Implement auto save of current tab (#1215)
- Fix auto save sometimes not happening for string field update
2022-03-03 15:37:55 +01:00
Nicolas Micoud 673db27766
IDEMPIERE-5217 : Default values in mail templates (#1218) 2022-03-03 14:54:32 +01:00
PeterTakacs300 32f26f8752
IDEMPIERE-5206 - HTML Report CSS style - add AD_FieldStyle_ID on AD_PrintFormatItem table (#1206)
* IDEMPIERE-5206 - HTML Report CSS style - add AD_FieldStyle_ID on AD_PrintFormatItem table

* IDEMPIERE-5206 - migration scripts

* IDEMPIERE-5206 - AD_FieldStyle_ID check, styleBuilder check added

* IDEMPIERE-5206 - moved the added code block to the right place
2022-03-03 16:13:39 +08:00
Carlos Ruiz 72ee50fcf5
IDEMPIERE-5212 Cross tenant PO writing in MFAUnregister #resolve #fixversion 10 #comment Solve Cross tenant PO (#1209) 2022-03-01 19:18:47 +01:00
hengsin 1ae1aa040e
IDEMPIERE-5202 Implement auto save of current tab (#1201)
* IDEMPIERE-5202 Implement auto save of current tab

* IDEMPIERE-5202 Implement auto save of current tab

- Fix auto save trigger for every keystore on text field.

* IDEMPIERE-5202 Implement auto save of current tab

- Fix handling of the confirmation dialog for close of tab.
- Focus tweak for child to parent tab navigation.
- Restore focus if user abandon closing of tab.

* IDEMPIERE-5202 Implement auto save of current tab

- Fix infinite error loop when auto save fail with error
2022-03-01 16:05:36 +08:00
Carlos Ruiz a38aefe92e
IDEMPIERE-5198 Print Format Cache do not reload Print Format Items (#1197)
* IDEMPIERE-5198 Print Format Cache do not reload Print Format Items

* IDEMPIERE-5198 Print Format Cache do not reload Print Format Items / add reset(int id) for the cache

* IDEMPIERE-5198 Print Format Cache do not reload Print Format Items / change cache key from String to StringBuilder

Co-authored-by: hengsin <hengsin@gmail.com>
2022-02-25 16:45:33 +08:00
igorpojzl c7465f8121
IDEMPIERE-5204 Cache the list/array of mreflist for AD_Reference_ID (#1202)
* IDEMPIERE-5204 Cache the list/array of mreflist for AD_Reference_ID

* IDEMPIERE-5204 Use StringBuilder for better performance
2022-02-25 16:44:28 +08:00
PeterTakacs300 3423e02780
IDEMPIERE-5091 - Before Save Set Default Locator From Product Or Warehouse when creating m_inout programatically (#1043)
* IDEMPIERE-5091 - Before Save Set Default Locator From Product Or Warehouse when creating m_inout programatically

* IDEMPIERE-5091 - inefficient methods replaced

Co-authored-by: Igor Pojzl <igor.pojzl@cloudempiere.com>
2022-02-23 06:50:48 +08:00
hengsin 193dd936e5
IDEMPIERE-5199 Refactoring: Move SQL code at AbstractProcessCtl and ServerProcessCtl to MPInstance (#1198) 2022-02-22 12:35:27 +01:00
igorpojzl 1156cd35fe
IDEMPIERE-5193 GridTable MaxQueryRecords Limit - Performance (#1189)
* IDEMPIERE-5193 GridTable MaxQueryRecords Limit - Performance

* IDEMPIERE-5193 Use Database Paging

* IDEMPIERE-5193 Fix Not Updating SQL variable
2022-02-22 12:28:02 +01:00
Carlos Ruiz bedf226a21
IDEMPIERE-5191 SEARCH FAILURE BY DATE AND HOUR / IDEMPIERE-4962 IDEMPIERE-4724 (#1188) 2022-02-18 13:32:45 +08:00
Carlos Ruiz 622727f9c9
IDEMPIERE-5192 Expand Detailed Zoom Across button to more references (#1185) 2022-02-16 15:33:14 +08:00
Carlos Ruiz 1dac88e6e9
IDEMPIERE-2580 Error with taxes and country groups (#1186) 2022-02-15 19:38:57 +01:00
Carlos Ruiz 0e66985292
IDEMPIERE-5190 Improve migration script generator (#1183) 2022-02-14 06:43:25 +08:00
Carlos Ruiz 69d11d0370
IDEMPIERE-4893 NPE on PDF report of Test record (#1180)
- Fix NPE trying to print any HTML content in PDF as form using internal engine
- Fix problem printing HTML content as plain text
2022-02-12 20:27:12 +08:00
Carlos Ruiz 26aac62a4a
IDEMPIERE-5174 Disable System User (#1174) (#1182)
Fix wrong comparison changed in commit a9c4f7b - test case failing
Improve traceability of unit test
2022-02-12 12:29:20 +01:00