Commit Graph

13666 Commits

Author SHA1 Message Date
hengsin 4c1ba12a3f
IDEMPIERE-3212 Quantity MatchPO wrong validation (#269)
Fix auto matching for matchpo and matchinv
2020-09-21 20:00:31 +02:00
Carlos Ruiz 1aa7565ad7
IDWS-8 Cannot update user info in WebStore (#267)
IDEMPIERE-4287
2020-09-21 18:01:21 +08:00
muriloht d875208a00
IDEMPIERE-3336 - Tables missing EntityType column (#258)
* IDEMPIERE-3336 - Tables missing EntityType column

* IDEMPIERE-3336 - fix PR review comments

* IDEMPIERE-3336 - fix PR review default value for entityType
2020-09-21 10:25:23 +02:00
hengsin dd2ef468b0
IDEMPIERE 4287 (#247)
* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
add support to make PO immutable

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added thread safe Immutable and Copy cache implementation for PO.
- migrate most of PO cache to immutable and copy cache.
- added pos sales order test.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- add test case for initial client setup and bank statement
- fix error for image editor, location editor, locator editor, initial
client setup, complete bank statement and migrate storage provider.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added ImmutablePOSupport interface. Model class implement this
interface for immutable PO support.
- remove usage of cache for transaction table (rfq, invoice, inventory).
- add getCopy method to some model class to support getting an
updateable copy of PO from the otherwise immutable PO cache.
- the added getCopy method is use to return updateable PO for indirect
PO reference, for e.g MColumn.getAD_Table() and MOrderLine.getProduct.
2020-09-21 14:03:00 +08:00
Nicolas Micoud 9509d95c7c
IDEMPIERE-4460 : User suggestions for field/context help : check perm… (#257)
* IDEMPIERE-4460 : User suggestions for field/context help : check permission

new method to check exclusion of a table for current role, used to determine if popups should be displayed or not

* IDEMPIERE-4460 : User suggestions for field/context help : check permission

Following @globalqss's recommandations : rename the method + add more controls inside

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-20 15:53:56 +02:00
igorpojzl dede5bd506
IDEMPIERE-4442 FIX NPE when locatorField is Empty (#260) 2020-09-18 21:38:15 +08:00
Elaine Tan 79d6c1e903
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#250)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2020-09-18 20:58:14 +08:00
Carlos Ruiz 599e13dda3
IDEMPIERE-4462 (#263)
Integrate patch from Paul Bowden (Adaxa)

Co-authored-by: Paul Bowden <pbowden@adaxa.com>
2020-09-18 12:45:20 +02:00
Carlos Ruiz 703ce7bda8
IDEMPIERE-4289 Implement Support for JUnit5 Unit Testing (#262)
Move the old Convert_PostgreSQLTest to the new structure
2020-09-18 12:17:40 +02:00
Carlos Ruiz d3c9804253
IDEMPIERE-4454 Implement filter for SQL debug - unify oracle and postgresql variable (#252) 2020-09-17 15:02:22 +02:00
muriloht 6771a696cc
IDEMPIERE-4029 - global search element id (#255) 2020-09-16 14:08:12 +02:00
Carlos Ruiz 51844316df
IDEMPIERE-4441 More shellcheck (#254)
Fix issue caused by previous commit - RUN_SyncDB broken
2020-09-14 21:03:55 +02:00
igorpojzl 7c096a4901
IDEMPIERE-4450 Info Window Performance (#251)
Pass ReadOnly Parameter to GridField from Info Window Column. For Better Performance of WTableDir Component.
2020-09-14 22:29:06 +08:00
Elaine Tan 236729e3f5
IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Re… (#239)
* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo

* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo - Added test case
2020-09-10 20:49:25 +08:00
Carlos Ruiz 970936d08c
IDEMPIERE-4441 FreeBSD find utility requires a target directory in postgresql/SyncDB.sh (#245)
Verify all scripts with shellcheck
https://www.shellcheck.net/
2020-09-08 19:37:00 +02:00
Deepak Pansheriya e72dfd66c0
IDEMPIERE-4067 : Support for Under/Over line and Blank line in finaci… (#244)
* IDEMPIERE-4067 : Support for Under/Over line and Blank line in finacial report line.

* IDEMPIERE-4067 : Adding support for blank line export in CSV, HTML, Excel. Also allowing to show description if provided. fixed all review comments fron Carlos Ruiz
2020-09-08 12:59:19 +02:00
igorpojzl e18d8001d4
IDEMPIERE-4442 Change Locator Dialog TableDirect (#242)
* IDEMPIERE-4442 Change Locator Dialog TableDirect

* IDEMPEIRE-4442 Fixed inconsitent Locator
2020-09-07 13:49:10 +02:00
Deepak Pansheriya ee48ef2be4
Idempiere 4066 (#235)
* IDEMPIERE-4066: Adding 'Relative Period To' on financial report column which allow to specify period range to produce YoY. QoQ like comparision report.

* IDEMPIERE-4066: Fixing defaulting RelativePeriodTo to Null issue

* IDEMPIERE-4066: Fix as per Carlos review.
1. Fixing compilation issue
2. Moving Column ID constants to systemIDs
3. Updating serial version for MReportColumn.

* IDEMPIERE-4066: Reverted GridField class changes and configured defailt for RelativePeriodTo to be 'NULL'
2020-09-05 12:17:40 +02:00
hieplq bd03a89d1c
IDEMPIERE-4361:Date is subtracted by 1 day in certain cases (#240)
* IDEMPIERE-4361:Date is subtracted by 1 day in certain cases

sun.util.calendar.ZoneInfo consider offset and "daylight saving time" changed on range 1900-2037
for out of that range then offset always return raw offset, make date incorrect 1 day on some days

offset change by history can reference at:
https://en.wikipedia.org/wiki/Time_in_Vietnam#Time_in_French_Indochina
https://www.timeanddate.com/time/zone/vietnam/hanoi

database for all change
https://www.iana.org/time-zones

* IDEMPIERE-4361:Date is subtracted by 1 day in certain cases (wrong at client side)

when value set from server by DateBox.setValue(Date) it convert that time (without respect history change when out of range 1900 until 2037) to UTC but at client it respect history change when convert to display timezoen so make mismatch

* IDEMPIERE-4361:Date is subtracted by 1 day in certain cases (for datetimebox)

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-05 10:55:33 +02:00
Carlos Ruiz be525d178c
IDEMPIERE-4447 Add offset to Query (#243)
Add method Query.setRecordstoSkip
2020-09-04 21:42:14 +02:00
Carlos Ruiz e93cdcb38c
IDEMPIERE-4440 NPE in DocAllocationHdr (#241) 2020-09-04 21:38:20 +02:00
Carlos Ruiz dcd7d6a41e
IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confir… (#227)
* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Implement void for movement confirm

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Voiding the confirmation voids the inventory move too

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Similar case found in MInOut - cannot void because of catch-22
Allow to void MInOut -> it automatically voids all pending confirmations

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Set quantities in zero when voiding movement confirmation
2020-08-31 14:23:33 +08:00
Nicolas Micoud 3384819c49
IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (#238)
* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo

* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (javadoc)
2020-08-28 16:14:45 +02:00
hengsin 7324dde78e
IDEMPIERE-4187 implement the usage of workflows in processes (#236)
Implement chaining of workflow through the use of Process Action
Implement overwrite of Record_ID for Process through Node Parameter
2020-08-27 14:34:26 +02:00
hengsin 9d614b985e
IDEMPIERE-4424 (#222)
* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Grid View - change click navigation to follow the same flow as toolbar
navigation.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

GridTable - added Updated and Processed concurrency checked against PO.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Incorporate fix suggested by Carlos
2020-08-27 12:40:44 +02:00
igorpojzl f13313760c
IDEMPIERE-4433 - MTable error - ConcurrentModificationException (#237)
Fix Putting into Cache outside Synchronized methods.
2020-08-26 20:35:16 +08:00
Carlos Ruiz 02f4d526dc
IDEMPIERE-4429 BOM Drop to Invoice is throwing error (#228)
IDEMPIERE-1314 getDocumentInfo methods should return translated String
2020-08-26 15:49:22 +08:00
Carlos Ruiz 75dcde96b3
IDEMPIERE-1482 Invoice with Payment Schedule is not displayed in Invoice Not Realized Gain/Loss (#225)
Fix problem reported by Anozi Mada
Fix issue found when testing - postgresql was failing with error
   org.postgresql.util.PSQLException: ERROR: la columna «c_doctypereval_id» es de tipo numeric pero la expresión es de tipo text
Avoid creating empty journal
2020-08-26 14:50:10 +08:00
hengsin 60b173699f
IDEMPIERE-4256 [2pack] issue with export org (non office id) (#223)
Incorporate patch from hieplq - not to export ad_org_id for ad_org table
Fix typo for ad_org_id exclude check. Remove ad_org_id from exclude list
to maintain backward compatiblity.
2020-08-25 10:08:38 +02:00
hengsin a978949593
IDEMPIERE-4255 [2pack] Packout reference table call wrong ElementHandler.packOut overloading (#230)
Base on patch from hieplq
GenericPOElementHandler Export Details - Fix the use of correct
ElementHandler for multi key detail table.
2020-08-25 10:00:30 +02:00
hengsin 0e9f36add9
IDEMPIERE-3197 Tab still keep editing indicator when move to next record (#229)
Update tab title after save
2020-08-24 18:39:27 +02:00
Carlos Ruiz b0fbbb7a16
IDEMPIERE-4425 Find Window improvements (#224)
* IDEMPIERE-4425 Find Window improvements

Fix for printing report parameters - it is printing OPERATOR_EQUAL on reports instead of =

* IDEMPIERE-4425 Find Window improvements

Previous commit broke the find function - must use SQL for Values
2020-08-24 23:08:07 +08:00
hengsin ab910e0dd2
IDEMPIERE-4430 Process_Production workflow missing transition node fro… (#232)
* IDEMPIERE-4430 rocess_Production workflow missing transition node from start to docprepare

add missing workflow transition node

* IDEMPIERE-4430 rocess_Production workflow missing transition node from start to docprepare

incorporate additonal fix from Carlos
2020-08-24 15:02:06 +02:00
hengsin 64a46577a6
IDEMPIERE-4122 missing font icons (#231)
Integrate patch from Murilo
2020-08-24 12:31:40 +02:00
Carlos Ruiz 2ad8fdfb3e
IDEMPIERE-2216:when make a warehouse order (in counter document test)… (#226)
* IDEMPIERE-2216:when make a warehouse order (in counter document test). new document material receipt is link with warehouse order not link with purchase order. it's correct?

* IDEMPIERE-2240:when create "On Credit Order" in counter document mode. invoice vendor make wrong reference to sale order

* IDEMPIERE-2257:can't complete invoice (vendor) generate from "order credit" by counter.

Integrating patch from Hiep hieplq@hasuvimex.vn
Changed syntax to be more readable
Used Processed instead of checking list of DocStatus

Co-authored-by: hieplq@hasuvimex.vn <hieplq@hasuvimex.vn>
2020-08-22 20:55:44 +02:00
Carlos Ruiz a9d24a2d5b
IDEMPIERE-4427 Changelog window reference lists dksplayed in wrong language (#221)
Ref IDEMPIERE-1540 e9e7486473
2020-08-21 20:56:34 +08:00
Carlos Ruiz e9338353c8
IDEMPIERE-4426 Fix add_months and adddays functions (#220)
Fix add_months function in postgresql to make it consistent with its oracle version
Fix adddays function to behave consistent as the add_months in both oracle and postgresql
Fix adddays in postgresql to add managing fractional days (same as oracle does), so it can add hours, minutes, seconds
Fix subtractdays performance making it immutable
2020-08-21 13:08:07 +02:00
Carlos Ruiz a68c5f1968
IDEMPIERE-4425 Find Window improvements (#219) 2020-08-21 13:07:01 +02:00
Nicolas Micoud 2322a79dda
IDEMPIERE-4422 : GL Distribution - add SeqNo (#217)
* IDEMPIERE-4422 : GL Distribution - add SeqNo

Add SeqNo column on GL Distribution to allow users to choose the lowest one when several records are retrieved.
Fix typo

* IDEMPIERE-4422 : GL Distribution - add SeqNo

Fix a missed typo
2020-08-21 11:20:33 +02:00
hieplq 23ed373e5d
IDEMPIERE-4413:Change Role, disfunction all keyboard shortcuts (#216)
remove keydown handle at client side
2020-08-20 08:47:01 +02:00
Carlos Ruiz 7892c54aa1
IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user (#188)
* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Allow saving Tab Customization for System user

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Fix copy/paste error

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Implement same suggestion on all the classes where setAD_User_ID must be allowed to explicitly set to System
There were already two classes with the Override approach: MUserPreference and MUserRoles, so this commit is to apply the same approach to all the classes with same approach
2020-08-13 18:20:59 +08:00
Carlos Ruiz 24e9fe8402
IDEMPIERE-3862 ORACLE - Update datatype NVARCHAR2 to VARCHAR2 (#207)
There are two scripts in this commit:
* 202008040100_IDEMPIERE-3862.sql - updates the whole core as of today, changing the columns VARCHAR2...BYTE and NVARCHAR2 to VARCHAR2...CHAR
* 202008040114_IDEMPIERE-3862.sql - updates the non-core tables, same algorithm, the first script was generated using this second for the core
** in case somebody doesn't want the second script to run on their database can simply change the line 39 to ->dryrun varchar2(1) := 'Y';
2020-08-13 12:34:00 +08:00
Carlos Ruiz 99c8d11f96
IDEMPIERE-4407 Reset Accounting showing Views in the table list (#213) 2020-08-12 17:25:38 +08:00
Martin Schönbeck 2b12ef3362
Idempiere 4162 (#171)
* IDEMPIERE-4162 ignore inactive products when looking for duplicate upc, handle errors on update without disturbing the import run.

* IDEMPIERE-4162 ignore inactive products when looking for duplicate upc, handle errors on update without disturbing the import run. 
changed ImportProduct to save errors even if the next product is in error, too.

* IDEMPIERE-4162 ignore inactive products when looking for duplicate upc, handle errors on update without disturbing the import run. 
changed ImportProduct to save errors even if the next product is in error, too.

* IDEMPIERE-4162 ignore inactive products when looking for duplicate upc, handle errors on update without disturbing the import run. 
Check for duplicate UPC in m_product

* IDEMPIERE-4162 ignore inactive products when looking for duplicate upc, handle errors on update without disturbing the import run. 
check for inactive products added
2020-08-12 16:53:14 +08:00
hengsin 60f4ea4215
IDEMPIERE-4406 Performance: PO Cache should not always reset all entr… (#212)
* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

PO update - reset cache by record id

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

refine unit test

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

add cache reset fix for delete

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

Fix exception when cache is empty
Expose hidden cache reset exception
2020-08-11 14:55:03 +02:00
Carlos Ruiz 29239b651b
IDEMPIERE-4404 Wrong characters + typos in Brazilian regions (#208)
This was probably caused years ago (2007) because off applying the script from commit 89c9a3b4 migration-historic/320-330/postgresql/001_add_brazilian_states.sql without the proper NLS_LANG variable set in oracle
It is important, when applying this script to set the NLS_LANG properly, suggested value is:
export NLS_LANG=AMERICAN_AMERICA.UTF8
2020-08-11 09:48:52 +02:00
hengsin 0ad8737829
IDEMPIERE-4405 Add basic cache statistics (#211)
fix wrong hit/miss count when cached value is null
2020-08-07 17:07:39 +02:00
hengsin 147eebb01b
IDEMPIERE-4405 Add basic cache statistics (#210)
add hit and miss count for cache
2020-08-07 13:05:34 +02:00
Carlos Ruiz 7894bd9ef4
IDEMPIERE-4398 Database inconsistency with dictionary for types CHAR (#209) 2020-08-07 16:16:43 +08:00
Carlos Ruiz a84adbad80
IDEMPIERE-4395 Cannot save valid strings in oracle - ORA-12899: value too large for column (#202) 2020-08-06 22:35:37 +08:00