midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-5174 Disable System User (#1324) 

Found also two minor performance improvements:
- avoid counting users when statistics not allowed
- change the query where to 1=0, better for the optimizer
This commit is contained in:
Carlos Ruiz 2022-05-12 07:35:20 +02:00 committed by GitHub
parent 9e43a36862
commit fda23ef1ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
org.adempiere.base/src/org/compiere/model/MSystem.java
View File

@ -352,9 +352,9 @@ public class MSystem extends X_AD_System
try try
{ {
setDBInfo(); setDBInfo();
setInternalUsers();
if (isAllowStatistics()) if (isAllowStatistics())
{ {
setInternalUsers();
setStatisticsInfo(getStatisticsInfo(true)); setStatisticsInfo(getStatisticsInfo(true));
setProfileInfo(getProfileInfo(true)); setProfileInfo(getProfileInfo(true));
} }
@ -377,7 +377,7 @@ public class MSystem extends X_AD_System
+ "FROM AD_User u" + "FROM AD_User u"
+ " INNER JOIN AD_User_Roles ur ON (u.AD_User_ID=ur.AD_User_ID) " + " INNER JOIN AD_User_Roles ur ON (u.AD_User_ID=ur.AD_User_ID) "
+ "WHERE u.AD_Client_ID<>11" // no Demo + "WHERE u.AD_Client_ID<>11" // no Demo
+ " AND u.AD_User_ID NOT IN (0,100)"; // no System/SuperUser + " AND u.AD_User_ID NOT IN (0,10,100)"; // no System/SuperUser
int internalUsers = DB.getSQLValue(null, sql); int internalUsers = DB.getSQLValue(null, sql);
setSupportUnits(internalUsers); setSupportUnits(internalUsers);
} // setInternalUsers } // setInternalUsers
@ -437,7 +437,7 @@ public class MSystem extends X_AD_System
+ " || '.' || SYS_CONTEXT('USERENV','DB_DOMAIN') AS DBName " + " || '.' || SYS_CONTEXT('USERENV','DB_DOMAIN') AS DBName "
+ "FROM DUAL"; + "FROM DUAL";
// //
return "SELECT NULL,NULL FROM AD_System WHERE AD_System_ID=-1"; return "SELECT NULL,NULL FROM DUAL WHERE 1=0";
} // getDBInfoSQL } // getDBInfoSQL