midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for ProcessCtl 

* organized imports
* fixed java generics warnings
This commit is contained in:
teo_sarca 2008-02-09 14:11:44 +00:00
parent 7a7bf13e74
commit fcf59d7f7f
1 changed files with 36 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
client/src/org/compiere/apps/ProcessCtl.java
View File

@ -16,22 +16,35 @@
*****************************************************************************/ *****************************************************************************/
package org.compiere.apps; package org.compiere.apps;
import java.awt.*; import java.awt.Container;
import java.io.*; import java.io.InvalidClassException;
import java.lang.reflect.*; import java.lang.reflect.UndeclaredThrowableException;
import java.rmi.*; import java.rmi.RemoteException;
import java.sql.*; import java.sql.PreparedStatement;
import java.util.logging.*; import java.sql.ResultSet;
import javax.swing.*; import java.util.logging.Level;
import javax.swing.JFrame;
import javax.swing.SwingUtilities;
import org.adempiere.util.ProcessUtil; import org.adempiere.util.ProcessUtil;
import org.compiere.db.*; import org.compiere.db.CConnection;
import org.compiere.interfaces.*; import org.compiere.interfaces.Server;
import org.compiere.model.*; import org.compiere.model.MPInstance;
import org.compiere.print.*; import org.compiere.model.MRule;
import org.compiere.process.*; import org.compiere.print.ReportCtl;
import org.compiere.util.*; import org.compiere.process.ClientProcess;
import org.compiere.wf.*; import org.compiere.process.ProcessInfo;
import org.compiere.process.ProcessInfoUtil;
import org.compiere.util.ASyncProcess;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
import org.compiere.util.Env;
import org.compiere.util.Ini;
import org.compiere.util.Msg;
import org.compiere.util.SecurityToken;
import org.compiere.util.Trx;
import org.compiere.wf.MWFProcess;
/** /**
* Process Interface Controller. * Process Interface Controller.
@ -294,12 +307,14 @@ public class ProcessCtl implements Runnable
+ "WHERE p.IsActive='Y'" + "WHERE p.IsActive='Y'"
+ " AND i.AD_PInstance_ID=?"; + " AND i.AD_PInstance_ID=?";
// //
PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
PreparedStatement pstmt = DB.prepareStatement(sql, pstmt = DB.prepareStatement(sql,
ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY, null); ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY, null);
pstmt.setInt(1, m_pi.getAD_PInstance_ID()); pstmt.setInt(1, m_pi.getAD_PInstance_ID());
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
m_pi.setTitle (rs.getString(1)); m_pi.setTitle (rs.getString(1));
@ -331,8 +346,6 @@ public class ProcessCtl implements Runnable
} }
else else
log.log(Level.SEVERE, "No AD_PInstance_ID=" + m_pi.getAD_PInstance_ID()); log.log(Level.SEVERE, "No AD_PInstance_ID=" + m_pi.getAD_PInstance_ID());
rs.close();
pstmt.close();
} }
catch (Throwable e) catch (Throwable e)
{ {
@ -341,6 +354,11 @@ public class ProcessCtl implements Runnable
log.log(Level.SEVERE, "run", e); log.log(Level.SEVERE, "run", e);
return; return;
} }
finally
{
DB.close(rs, pstmt);
rs = null; pstmt = null;
}
// No PL/SQL Procedure // No PL/SQL Procedure
if (ProcedureName == null) if (ProcedureName == null)