midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-4311 Implement cache for MAccount(C_ValidCombination) (#84) 

Implement cache for MAccount.get(ctx, C_ValidCombination_ID)
This commit is contained in:
hengsin 2020-05-29 19:53:32 +08:00 committed by GitHub
parent baac93f9e0
commit fca0963fd9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
org.adempiere.base/src/org/compiere/model/MAccount.java
View File

@ -22,6 +22,7 @@ import java.util.List;
import java.util.Properties; import java.util.Properties;
import java.util.logging.Level; import java.util.logging.Level;
import org.compiere.util.CCache;
import org.compiere.util.CLogger; import org.compiere.util.CLogger;
import org.compiere.util.Env; import org.compiere.util.Env;
@ -40,6 +41,8 @@ public class MAccount extends X_C_ValidCombination
* *
*/ */
private static final long serialVersionUID = 7980515458720808532L; private static final long serialVersionUID = 7980515458720808532L;
private static final CCache<Integer, MAccount> s_cache = new CCache<Integer, MAccount>(Table_Name, 100);
/* /*
* Deprecated - use the same method with trxName instead * Deprecated - use the same method with trxName instead
@ -365,8 +368,20 @@ public class MAccount extends X_C_ValidCombination
*/ */
public static MAccount get (Properties ctx, int C_ValidCombination_ID) public static MAccount get (Properties ctx, int C_ValidCombination_ID)
{ {
// Maybe later cache MAccount account = s_cache.get(C_ValidCombination_ID);
return new MAccount(ctx, C_ValidCombination_ID, null); if (account != null && account.getCtx() == ctx)
return account;
account = new MAccount(ctx, C_ValidCombination_ID, null);
if (account.getC_ValidCombination_ID() == C_ValidCombination_ID)
{
s_cache.put(C_ValidCombination_ID, account);
return account;
}
else
{
return null;
}
} // getAccount } // getAccount
/** /**

7
org.adempiere.base/src/org/compiere/model/MAccountLookup.java
View File

@ -145,12 +145,9 @@ public final class MAccountLookup extends Lookup implements Serializable
if (ID == C_ValidCombination_ID) // already loaded if (ID == C_ValidCombination_ID) // already loaded
return true; return true;
final String whereClause = "C_ValidCombination_ID=?"; MAccount account = MAccount.get(Env.getCtx(), ID);
MAccount account = new Query(Env.getCtx(),I_C_ValidCombination.Table_Name,whereClause,null)
.setParameters(ID)
.firstOnly();
if(account == null) if(account == null || account.getC_ValidCombination_ID() != ID)
return false; return false;
C_ValidCombination_ID = account.getC_ValidCombination_ID(); C_ValidCombination_ID = account.getC_ValidCombination_ID();