midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* Fixed leaking of database resources, bug [1631887]

This commit is contained in:
Heng Sin Low 2007-01-10 03:06:38 +00:00
parent 40a80a8d6d
commit fae6e66070
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
dbPort/src/org/compiere/model/MSequence.java
View File

@ -69,13 +69,16 @@ public class MSequence extends X_AD_Sequence
USE_PROCEDURE=false; USE_PROCEDURE=false;
} }
else else
//String selectSQL = "SELECT CurrentNext, CurrentNextSys, IncrementNo, AD_Sequence_ID " {
selectSQL = "SELECT CurrentNext, CurrentNextSys, IncrementNo, AD_Sequence_ID " selectSQL = "SELECT CurrentNext, CurrentNextSys, IncrementNo, AD_Sequence_ID "
//end vpj-cd e-evolution 09/02/2005 PostgreSQL
+ "FROM AD_Sequence " + "FROM AD_Sequence "
+ "WHERE Name=?" + "WHERE Name=?"
+ " AND IsActive='Y' AND IsTableID='Y' AND IsAutoSequence='Y' " + " AND IsActive='Y' AND IsTableID='Y' AND IsAutoSequence='Y' "
+ "FOR UPDATE"; // jz derby needs expicitly said it//OF CurrentNext, CurrentNextSys"; + "FOR UPDATE"; // jz derby needs expicitly said it//OF CurrentNext, CurrentNextSys";
USE_PROCEDURE = true;
}
Trx trx = trxName == null ? null : Trx.get(trxName, true); Trx trx = trxName == null ? null : Trx.get(trxName, true);
Connection conn = null; Connection conn = null;
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
@ -129,7 +132,8 @@ public class MSequence extends X_AD_Sequence
} }
updateSQL.setInt(1, incrementNo); updateSQL.setInt(1, incrementNo);
updateSQL.setInt(2, AD_Sequence_ID); updateSQL.setInt(2, AD_Sequence_ID);
updateSQL.executeUpdate(); updateSQL.executeUpdate();
updateSQL.close();
} }
if (trx == null) if (trx == null)
@ -271,6 +275,7 @@ public class MSequence extends X_AD_Sequence
else else
// selectSQL += " FOR UPDATE OF CurrentNext, CurrentNextSys "; //jz for update , no order by, 10.216 no need // selectSQL += " FOR UPDATE OF CurrentNext, CurrentNextSys "; //jz for update , no order by, 10.216 no need
selectSQL += "FOR UPDATE"; selectSQL += "FOR UPDATE";
USE_PROCEDURE = true;
} }
Connection conn = null; Connection conn = null;
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
@ -324,6 +329,7 @@ public class MSequence extends X_AD_Sequence
updateSQL.setInt(1, incrementNo); updateSQL.setInt(1, incrementNo);
updateSQL.setInt(2, AD_Sequence_ID); updateSQL.setInt(2, AD_Sequence_ID);
updateSQL.executeUpdate(); updateSQL.executeUpdate();
updateSQL.close();
} }
} }
else else
@ -422,13 +428,14 @@ public class MSequence extends X_AD_Sequence
USE_PROCEDURE=false; USE_PROCEDURE=false;
} }
else else
//String selectSQL = "SELECT CurrentNext, CurrentNextSys, IncrementNo, Prefix, Suffix, AD_Client_ID, AD_Sequence_ID " {
selectSQL = "SELECT CurrentNext, CurrentNextSys, IncrementNo, Prefix, Suffix, AD_Client_ID, AD_Sequence_ID " selectSQL = "SELECT CurrentNext, CurrentNextSys, IncrementNo, Prefix, Suffix, AD_Client_ID, AD_Sequence_ID "
//end vpj-cd e-evolution 09/02/2005 PostgreSQL //end vpj-cd e-evolution 09/02/2005 PostgreSQL
+ "FROM AD_Sequence " + "FROM AD_Sequence "
+ "WHERE AD_Sequence_ID=?" + "WHERE AD_Sequence_ID=?"
+ " AND IsActive='Y' AND IsTableID='N' AND IsAutoSequence='Y' "; + " AND IsActive='Y' AND IsTableID='N' AND IsAutoSequence='Y' ";
// + " FOR UPDATE"; USE_PROCEDURE = true;
}
Connection conn = null; Connection conn = null;
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
Trx trx = trxName == null ? null : Trx.get(trxName, true); Trx trx = trxName == null ? null : Trx.get(trxName, true);
@ -484,6 +491,7 @@ public class MSequence extends X_AD_Sequence
updateSQL.setInt(1, incrementNo); updateSQL.setInt(1, incrementNo);
updateSQL.setInt(2, AD_Sequence_ID); updateSQL.setInt(2, AD_Sequence_ID);
updateSQL.executeUpdate(); updateSQL.executeUpdate();
updateSQL.close();
} }
} }
else else