From f9fd4b80c539e39c05903a90aa0885f5ee76b9c5 Mon Sep 17 00:00:00 2001 From: Heng Sin Low Date: Thu, 4 Aug 2011 21:36:24 -0500 Subject: [PATCH] Fixed wrong checking on whether invoice is linked with order, reported at http://red1.org/adempiere/viewtopic.php?f=31&t=1337 Fixes IDEMPIERE-47 Customer Return - Generate Invoice error http://jira.idempiere.com/browse/IDEMPIERE-47 --- .../src/org/compiere/process/InOutCreateInvoice.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/org.adempiere.base.process/src/org/compiere/process/InOutCreateInvoice.java b/org.adempiere.base.process/src/org/compiere/process/InOutCreateInvoice.java index 7baa87fa06..36e725e84e 100644 --- a/org.adempiere.base.process/src/org/compiere/process/InOutCreateInvoice.java +++ b/org.adempiere.base.process/src/org/compiere/process/InOutCreateInvoice.java @@ -107,9 +107,9 @@ public class InOutCreateInvoice extends SvrProcess if (!line.save()) throw new IllegalArgumentException("Cannot save Invoice Line"); } - - MOrder order = new MOrder(getCtx(), invoice.getC_Order_ID(), get_TrxName()); - if (order != null) { + + if (invoice.getC_Order_ID() > 0) { + MOrder order = new MOrder(getCtx(), invoice.getC_Order_ID(), get_TrxName()); invoice.setPaymentRule(order.getPaymentRule()); invoice.setC_PaymentTerm_ID(order.getC_PaymentTerm_ID()); invoice.saveEx();