From f5061798f9c503cf481e327de0e97aac1bea04d3 Mon Sep 17 00:00:00 2001
From: "Redhuan D. Oon" <red1@red1.org>
Date: Tue, 19 Feb 2008 13:29:08 +0000
Subject: [PATCH] *BF [ 1874419 ] JDBC Statement not close in a finally block

---
 .../handler/DynValRuleElementHandler.java     | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/base/src/org/adempiere/pipo/handler/DynValRuleElementHandler.java b/base/src/org/adempiere/pipo/handler/DynValRuleElementHandler.java
index aee09da600..4cf742b7de 100644
--- a/base/src/org/adempiere/pipo/handler/DynValRuleElementHandler.java
+++ b/base/src/org/adempiere/pipo/handler/DynValRuleElementHandler.java
@@ -91,11 +91,12 @@ public class DynValRuleElementHandler extends AbstractElementHandler {
 		String sql = "SELECT Name FROM AD_Val_Rule WHERE  AD_Val_Rule_ID= " + AD_Val_Rule_ID;
 		AttributesImpl atts = new AttributesImpl();
 		PreparedStatement pstmt = null;
+		ResultSet rs = null;
 		pstmt = DB.prepareStatement (sql, getTrxName(ctx));		
 
 		try {
 
-			ResultSet rs = pstmt.executeQuery();		
+			rs = pstmt.executeQuery();		
 
 			while (rs.next())
 			{
@@ -104,21 +105,15 @@ public class DynValRuleElementHandler extends AbstractElementHandler {
 				document.startElement("","","dynvalrule",atts);
 				document.endElement("","","dynvalrule");
 			}
-			rs.close();
-			pstmt.close();
-			pstmt = null;
-		}
+ 		}
 
 		catch (Exception e){
 			log.log(Level.SEVERE,"getProcess", e);
 		}
-		finally{
-			try	{
-				if (pstmt != null)
-					pstmt.close ();
-			}
-			catch (Exception e){}
-			pstmt = null;
+		finally
+		{
+			DB.close(rs, pstmt);
+			rs = null; pstmt = null;
 		}
 		
 	}