midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MInvoice: 

* db fix
* minor error message fix
This commit is contained in:
teo_sarca 2008-05-30 16:16:08 +00:00
parent fc9dd192a8
commit e56e3a90ef
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
base/src/org/compiere/model/MInvoice.java
View File

@ -1088,11 +1088,12 @@ public class MInvoice extends X_C_Invoice implements DocAction
+ "WHERE al.C_Invoice_ID=?" + "WHERE al.C_Invoice_ID=?"
+ " AND ah.IsActive='Y' AND al.IsActive='Y'"; + " AND ah.IsActive='Y' AND al.IsActive='Y'";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement(sql, get_TrxName()); pstmt = DB.prepareStatement(sql, get_TrxName());
pstmt.setInt(1, getC_Invoice_ID()); pstmt.setInt(1, getC_Invoice_ID());
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
if (rs.next()) if (rs.next())
retValue = rs.getBigDecimal(1); retValue = rs.getBigDecimal(1);
rs.close(); rs.close();
@ -1103,15 +1104,10 @@ public class MInvoice extends X_C_Invoice implements DocAction
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close(); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
// log.fine("getAllocatedAmt - " + retValue); // log.fine("getAllocatedAmt - " + retValue);
// ? ROUND(NVL(v_AllocatedAmt,0), 2); // ? ROUND(NVL(v_AllocatedAmt,0), 2);
@ -1778,7 +1774,7 @@ public class MInvoice extends X_C_Invoice implements DocAction
MMatchInv inv = new MMatchInv(line, getDateInvoiced(), matchQty); MMatchInv inv = new MMatchInv(line, getDateInvoiced(), matchQty);
if (!inv.save(get_TrxName())) if (!inv.save(get_TrxName()))
{ {
m_processMsg = "Could not create Invoice Matching"; m_processMsg = CLogger.retrieveErrorString("Could not create Invoice Matching");
return DocAction.STATUS_Invalid; return DocAction.STATUS_Invalid;
} }
else else