From dc07ce8e37f742882609e8fdc60efbc826e9360f Mon Sep 17 00:00:00 2001 From: Richard Morales Date: Thu, 13 Dec 2012 18:11:15 -0500 Subject: [PATCH] IDEMPIERE-455 Discover and fix FindBugs problems / Pattern LSYC_LOCAL_SYNCHRONIZED - StringBuffer --- org.adempiere.base/src/org/compiere/model/MRole.java | 2 +- .../src/org/adempiere/pipo2/GridTab2PackExporter.java | 2 +- org.apache.ecs/src/org/apache/ecs/ElementAttributes.java | 2 +- org.apache.ecs/src/org/apache/ecs/GenericElement.java | 4 ++-- org.apache.ecs/src/org/apache/ecs/XhtmlDocument.java | 4 ++-- .../src/org/apache/ecs/filter/CharacterFilter.java | 2 +- org.apache.ecs/src/org/apache/ecs/filter/StringFilter.java | 3 +-- org.apache.ecs/src/org/apache/ecs/filter/WordFilter.java | 2 +- org.apache.ecs/src/org/apache/ecs/xhtml/comment.java | 4 ++-- org.apache.ecs/src/org/apache/ecs/xml/XMLDocument.java | 6 +++--- 10 files changed, 15 insertions(+), 16 deletions(-) diff --git a/org.adempiere.base/src/org/compiere/model/MRole.java b/org.adempiere.base/src/org/compiere/model/MRole.java index f177a9ad49..f6acef1d97 100644 --- a/org.adempiere.base/src/org/compiere/model/MRole.java +++ b/org.adempiere.base/src/org/compiere/model/MRole.java @@ -1881,7 +1881,7 @@ public final class MRole extends X_AD_Role public String addAccessSQL (String SQL, String TableNameIn, boolean fullyQualified, boolean rw) { - StringBuffer retSQL = new StringBuffer(); + StringBuilder retSQL = new StringBuilder(); // Cut off last ORDER BY clause String orderBy = ""; diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java b/org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java index 9b1a1661e3..e85da83e52 100644 --- a/org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java +++ b/org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java @@ -52,7 +52,7 @@ public class GridTab2PackExporter implements IGridTabExporter { List packoutItems = new ArrayList(); if (packOut.getHandler(tableName) == null) { properties.put(DataElementParameters.AD_TABLE_ID, gridTab.getAD_Table_ID()); - StringBuffer sql = new StringBuffer("SELECT * FROM "); + StringBuilder sql = new StringBuilder("SELECT * FROM "); sql.append(tableName); if (currentRowOnly) { sql.append(" WHERE ").append(gridTab.getTableModel().getWhereClause(gridTab.getCurrentRow())); diff --git a/org.apache.ecs/src/org/apache/ecs/ElementAttributes.java b/org.apache.ecs/src/org/apache/ecs/ElementAttributes.java index bbed3ae7d7..927a9ae9ae 100644 --- a/org.apache.ecs/src/org/apache/ecs/ElementAttributes.java +++ b/org.apache.ecs/src/org/apache/ecs/ElementAttributes.java @@ -293,7 +293,7 @@ public abstract class ElementAttributes extends GenericElement implements Attrib */ protected String createStartTag() { - StringBuffer out = new StringBuffer(); + StringBuilder out = new StringBuilder(); out.append(getStartTagChar()); diff --git a/org.apache.ecs/src/org/apache/ecs/GenericElement.java b/org.apache.ecs/src/org/apache/ecs/GenericElement.java index ff24655598..53d014265f 100644 --- a/org.apache.ecs/src/org/apache/ecs/GenericElement.java +++ b/org.apache.ecs/src/org/apache/ecs/GenericElement.java @@ -643,7 +643,7 @@ public abstract class GenericElement implements Element,Serializable protected String createStartTag() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getStartTagChar()); if(getBeginStartModifierDefined()) @@ -663,7 +663,7 @@ public abstract class GenericElement implements Element,Serializable protected String createEndTag() { setEndStartModifier('/'); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(getStartTagChar()); if(getEndStartModifierDefined()) diff --git a/org.apache.ecs/src/org/apache/ecs/XhtmlDocument.java b/org.apache.ecs/src/org/apache/ecs/XhtmlDocument.java index e0b81878e8..bf2f65744f 100644 --- a/org.apache.ecs/src/org/apache/ecs/XhtmlDocument.java +++ b/org.apache.ecs/src/org/apache/ecs/XhtmlDocument.java @@ -544,7 +544,7 @@ public class XhtmlDocument implements Serializable,Cloneable { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); if ( getCodeset() != null ) @@ -588,7 +588,7 @@ public class XhtmlDocument implements Serializable,Cloneable { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); if (doctype != null) diff --git a/org.apache.ecs/src/org/apache/ecs/filter/CharacterFilter.java b/org.apache.ecs/src/org/apache/ecs/filter/CharacterFilter.java index aed2980234..0da16d121b 100644 --- a/org.apache.ecs/src/org/apache/ecs/filter/CharacterFilter.java +++ b/org.apache.ecs/src/org/apache/ecs/filter/CharacterFilter.java @@ -115,7 +115,7 @@ public class CharacterFilter extends java.util.Hashtable impleme if ( to_process == null || to_process.length() == 0 ) return ""; - StringBuffer bs = new StringBuffer(to_process.length() + 50); + StringBuilder bs = new StringBuilder(to_process.length() + 50); StringCharacterIterator sci = new StringCharacterIterator(to_process); String tmp = null; diff --git a/org.apache.ecs/src/org/apache/ecs/filter/StringFilter.java b/org.apache.ecs/src/org/apache/ecs/filter/StringFilter.java index 641a036335..c19a9db40a 100644 --- a/org.apache.ecs/src/org/apache/ecs/filter/StringFilter.java +++ b/org.apache.ecs/src/org/apache/ecs/filter/StringFilter.java @@ -55,7 +55,7 @@ public class StringFilter extends java.util.Hashtable implements public String process(String to_process) { System.out.println("\nString to Process in StringFilter = "+to_process); String[] value = split(to_process); - StringBuffer new_value = new StringBuffer(); + StringBuilder new_value = new StringBuilder(); for(int x = 0; x < value.length; x++) { if(hasAttribute(value[x])) @@ -113,7 +113,6 @@ public class StringFilter extends java.util.Hashtable implements return array; } - StringBuffer sb = new StringBuffer(to_split.length()+50); StringCharacterIterator sci = new StringCharacterIterator(to_split); int length = 0; diff --git a/org.apache.ecs/src/org/apache/ecs/filter/WordFilter.java b/org.apache.ecs/src/org/apache/ecs/filter/WordFilter.java index 88f8da566e..57d3488216 100644 --- a/org.apache.ecs/src/org/apache/ecs/filter/WordFilter.java +++ b/org.apache.ecs/src/org/apache/ecs/filter/WordFilter.java @@ -72,7 +72,7 @@ public class WordFilter extends java.util.Hashtable implements F String tmp = ""; // the true at the end is the key to making it work StringTokenizer st = new StringTokenizer(to_process, " ", true); - StringBuffer newValue = new StringBuffer(to_process.length() + 50); + StringBuilder newValue = new StringBuilder(to_process.length() + 50); while ( st.hasMoreTokens() ) { tmp = st.nextToken(); diff --git a/org.apache.ecs/src/org/apache/ecs/xhtml/comment.java b/org.apache.ecs/src/org/apache/ecs/xhtml/comment.java index 47bff84ae5..8e47b44983 100644 --- a/org.apache.ecs/src/org/apache/ecs/xhtml/comment.java +++ b/org.apache.ecs/src/org/apache/ecs/xhtml/comment.java @@ -210,7 +210,7 @@ public class comment extends MultiPartElement implements Printable setEndTagChar(' '); - StringBuffer out = new StringBuffer(); + StringBuilder out = new StringBuilder(); out.append(getStartTagChar()); @@ -241,7 +241,7 @@ public class comment extends MultiPartElement implements Printable protected String createEndTag() { - StringBuffer out = new StringBuffer(); + StringBuilder out = new StringBuilder(); setStartTagChar(' '); diff --git a/org.apache.ecs/src/org/apache/ecs/xml/XMLDocument.java b/org.apache.ecs/src/org/apache/ecs/xml/XMLDocument.java index 6abee4a8fc..82ef6002ff 100644 --- a/org.apache.ecs/src/org/apache/ecs/xml/XMLDocument.java +++ b/org.apache.ecs/src/org/apache/ecs/xml/XMLDocument.java @@ -91,7 +91,7 @@ public class XMLDocument public XMLDocument (double version, boolean standalone) { prolog = new Vector (2); - StringBuffer versionStr = new StringBuffer (); + StringBuilder versionStr = new StringBuilder (); versionStr.append ("