peer review for 11539

FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
This commit is contained in:
Carlos Ruiz 2010-03-03 21:13:05 +00:00
parent 791f4a8624
commit d9b22ee7ed
4 changed files with 4 additions and 9 deletions

View File

@ -205,7 +205,7 @@ public class InOutGenerateRMA extends SvrProcess
// //
// Link to corresponding Invoice Line (if any) - teo_sarca [ 2818523 ] // Link to corresponding Invoice Line (if any) - teo_sarca [ 2818523 ]
// The MMatchInv records will be automatically generated on MInOut.completeIt() // The MMatchInv records will be automatically generated on MInOut.completeIt()
final MInvoiceLine invoiceLine = new Query(shipment.getCtx(), I_C_InvoiceLine.Table_Name, MInvoiceLine invoiceLine = new Query(shipment.getCtx(), I_C_InvoiceLine.Table_Name,
I_C_InvoiceLine.COLUMNNAME_M_RMALine_ID+"=?", I_C_InvoiceLine.COLUMNNAME_M_RMALine_ID+"=?",
shipment.get_TrxName()) shipment.get_TrxName())
.setParameters(rmaLine.getM_RMALine_ID()) .setParameters(rmaLine.getM_RMALine_ID())

View File

@ -41,9 +41,7 @@ public class MAccount extends X_C_ValidCombination
/** /**
* *
*/ */
private static final long serialVersionUID = -8887316767838767993L; private static final long serialVersionUID = -1936396369349550834L;
/** /**
* Get existing Account or create it * Get existing Account or create it
@ -243,7 +241,7 @@ public class MAccount extends X_C_ValidCombination
public static MAccount get (Properties ctx, int C_AcctSchema_ID, String alias) public static MAccount get (Properties ctx, int C_AcctSchema_ID, String alias)
{ {
final String whereClause = "C_AcctSchema_ID=? AND Alias=?"; final String whereClause = "C_AcctSchema_ID=? AND Alias=?";
MAccount retValue = new Query(ctx,I_C_ValidCombination.Table_Name,whereClause.toString(),null) MAccount retValue = new Query(ctx,I_C_ValidCombination.Table_Name,whereClause,null)
.setParameters(C_AcctSchema_ID,alias) .setParameters(C_AcctSchema_ID,alias)
.firstOnly(); .firstOnly();
return retValue; return retValue;

View File

@ -138,7 +138,7 @@ public final class MAccountLookup extends Lookup implements Serializable
if (ID == C_ValidCombination_ID) // already loaded if (ID == C_ValidCombination_ID) // already loaded
return true; return true;
String whereClause = "C_ValidCombination_ID=?"; final String whereClause = "C_ValidCombination_ID=?";
MAccount account = new Query(Env.getCtx(),I_C_ValidCombination.Table_Name,whereClause,null) MAccount account = new Query(Env.getCtx(),I_C_ValidCombination.Table_Name,whereClause,null)
.setParameters(ID) .setParameters(ID)
.firstOnly(); .firstOnly();

View File

@ -17,10 +17,7 @@
package org.compiere.process; package org.compiere.process;
import java.math.BigDecimal; import java.math.BigDecimal;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.Timestamp; import java.sql.Timestamp;
import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.logging.Level; import java.util.logging.Level;