From d78238b0f6b3d4984eb34d1ba413cf0f9aed2ecf Mon Sep 17 00:00:00 2001 From: Fr Jeremy Krieg Date: Fri, 5 Aug 2022 11:19:10 +0930 Subject: [PATCH] IDEMPIERE-5368 Pack In doesn't close resources properly on failure (#1424) Change code to use try-with-resources to ensure automatic cleanup. --- org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java b/org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java index 54b53b56d1..ca24a10f9c 100644 --- a/org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java +++ b/org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java @@ -131,8 +131,7 @@ public class PackIn { if (log.isLoggable(Level.INFO)) log.info("importXML:" + msg); return msg; } - try { - FileInputStream input = new FileInputStream(in); + try (FileInputStream input = new FileInputStream(in)) { return importXML(input, ctx, trxName); } catch (Exception e) { log.log(Level.SEVERE, "importXML:", e);