IDEMPIERE-4157: Quick Form for fast data entry with keyboard -- peer review - minor changes

This commit is contained in:
Carlos Ruiz 2020-02-26 16:09:28 +01:00
parent 434cbaf110
commit c5c3d8c743
18 changed files with 35 additions and 36 deletions

View File

@ -11,7 +11,7 @@ public class MTabCustomization extends X_AD_Tab_Customization {
/** /**
* *
*/ */
private static final long serialVersionUID = 3977886674683054829L; private static final long serialVersionUID = 786885789239156678L;
public MTabCustomization(Properties ctx, int AD_Tab_Customization_ID, String trxName) { public MTabCustomization(Properties ctx, int AD_Tab_Customization_ID, String trxName) {
super(ctx, AD_Tab_Customization_ID, trxName); super(ctx, AD_Tab_Customization_ID, trxName);

View File

@ -83,7 +83,7 @@ public class GridField
/** /**
* *
*/ */
private static final long serialVersionUID = 496387784464611123L; private static final long serialVersionUID = -632698704437797186L;
/** /**
* Field Constructor. * Field Constructor.

View File

@ -47,7 +47,7 @@ public class GridFieldVO implements Serializable
/** /**
* *
*/ */
private static final long serialVersionUID = -1752172363171842152L; private static final long serialVersionUID = -7810037179946135749L;
/** /**
* Return the SQL statement used for the MFieldVO.create * Return the SQL statement used for the MFieldVO.create

View File

@ -112,7 +112,7 @@ public class GridTab implements DataStatusListener, Evaluatee, Serializable
/** /**
* *
*/ */
private static final long serialVersionUID = 5057703093968124177L; private static final long serialVersionUID = -8153324039370820860L;
public static final String DEFAULT_STATUS_MESSAGE = "NavigateOrUpdate"; public static final String DEFAULT_STATUS_MESSAGE = "NavigateOrUpdate";

View File

@ -104,7 +104,7 @@ public class GridTable extends AbstractTableModel
/** /**
* *
*/ */
private static final long serialVersionUID = 817894725729408648L; private static final long serialVersionUID = -3190218965990521698L;
public static final String DATA_REFRESH_MESSAGE = "Refreshed"; public static final String DATA_REFRESH_MESSAGE = "Refreshed";
public static final String DATA_UPDATE_COPIED_MESSAGE = "UpdateCopied"; public static final String DATA_UPDATE_COPIED_MESSAGE = "UpdateCopied";

View File

@ -39,10 +39,10 @@ import org.compiere.util.DisplayType;
*/ */
public class MSysConfig extends X_AD_SysConfig public class MSysConfig extends X_AD_SysConfig
{ {
/** /**
* *
*/ */
private static final long serialVersionUID = 6662424546913925975L; private static final long serialVersionUID = -4014355086112902334L;
public static final String ADDRESS_VALIDATION = "ADDRESS_VALIDATION"; public static final String ADDRESS_VALIDATION = "ADDRESS_VALIDATION";
public static final String ALERT_SEND_ATTACHMENT_AS_XLS = "ALERT_SEND_ATTACHMENT_AS_XLS"; public static final String ALERT_SEND_ATTACHMENT_AS_XLS = "ALERT_SEND_ATTACHMENT_AS_XLS";
@ -135,6 +135,7 @@ public class MSysConfig extends X_AD_SysConfig
public static final String PROJECT_ID_USE_CENTRALIZED_ID = "PROJECT_ID_USE_CENTRALIZED_ID"; public static final String PROJECT_ID_USE_CENTRALIZED_ID = "PROJECT_ID_USE_CENTRALIZED_ID";
public static final String PROJECT_ID_USER = "PROJECT_ID_USER"; public static final String PROJECT_ID_USER = "PROJECT_ID_USER";
public static final String PROJECT_ID_WEBSITE = "PROJECT_ID_WEBSITE"; public static final String PROJECT_ID_WEBSITE = "PROJECT_ID_WEBSITE";
public static final String QUICKFORM_PAGE_SIZE = "QUICKFORM_PAGE_SIZE";
public static final String REAL_TIME_POS = "REAL_TIME_POS"; public static final String REAL_TIME_POS = "REAL_TIME_POS";
public static final String RecentItems_MaxSaved = "RecentItems_MaxSaved"; public static final String RecentItems_MaxSaved = "RecentItems_MaxSaved";
public static final String RecentItems_MaxShown = "RecentItems_MaxShown"; public static final String RecentItems_MaxShown = "RecentItems_MaxShown";
@ -194,7 +195,6 @@ public class MSysConfig extends X_AD_SysConfig
public static final String ZK_THEME_USE_FONT_ICON_FOR_IMAGE = "ZK_THEME_USE_FONT_ICON_FOR_IMAGE"; public static final String ZK_THEME_USE_FONT_ICON_FOR_IMAGE = "ZK_THEME_USE_FONT_ICON_FOR_IMAGE";
public static final String ZK_THEME = "ZK_THEME"; public static final String ZK_THEME = "ZK_THEME";
public static final String ZOOM_ACROSS_QUERY_TIMEOUT = "ZOOM_ACROSS_QUERY_TIMEOUT"; public static final String ZOOM_ACROSS_QUERY_TIMEOUT = "ZOOM_ACROSS_QUERY_TIMEOUT";
public static final String QUICKFORM_PAGE_SIZE = "QUICKFORM_PAGE_SIZE";
/** /**
* Standard Constructor * Standard Constructor

View File

@ -84,7 +84,7 @@ public class AdempiereWebUI extends Window implements EventListener<Event>, IWeb
/** /**
* *
*/ */
private static final long serialVersionUID = -3320656546509525766L; private static final long serialVersionUID = -6725805283410008847L;
private static final String SAVED_CONTEXT = "saved.context"; private static final String SAVED_CONTEXT = "saved.context";

View File

@ -77,7 +77,7 @@ public class ADSortTab extends Panel implements IADTabpanel
/** /**
* *
*/ */
private static final long serialVersionUID = -4161399343247477912L; private static final long serialVersionUID = -2238411612673317537L;
/** /**
* Sort Tab Constructor * Sort Tab Constructor
@ -126,9 +126,9 @@ public class ADSortTab extends Panel implements IADTabpanel
// //
SimpleListModel noModel = new SimpleListModel() { SimpleListModel noModel = new SimpleListModel() {
/** /**
* *
*/ */
private static final long serialVersionUID = -8261235952902938774L; private static final long serialVersionUID = 3488081120336708285L;
@Override @Override
public void addElement(Object obj) { public void addElement(Object obj) {
@ -739,9 +739,9 @@ public class ADSortTab extends Panel implements IADTabpanel
*/ */
private class ListElement extends NamePair { private class ListElement extends NamePair {
/** /**
* *
*/ */
private static final long serialVersionUID = -5645910649588308798L; private static final long serialVersionUID = -6319536467438753815L;
private int m_key; private int m_key;
private int m_AD_Client_ID; private int m_AD_Client_ID;
private int m_AD_Org_ID; private int m_AD_Org_ID;

View File

@ -139,7 +139,7 @@ DataStatusListener, IADTabpanel, IdSpace, IFieldEditorContainer
/** /**
* *
*/ */
private static final long serialVersionUID = 5117210424909609150L; private static final long serialVersionUID = -6023888511495744589L;
private static final String ON_SAVE_OPEN_PREFERENCE_EVENT = "onSaveOpenPreference"; private static final String ON_SAVE_OPEN_PREFERENCE_EVENT = "onSaveOpenPreference";

View File

@ -83,7 +83,7 @@ public class ADWindowToolbar extends FToolbar implements EventListener<Event>
/** /**
* *
*/ */
private static final long serialVersionUID = 2945672260455902597L; private static final long serialVersionUID = -8494819673584541046L;
public static final String BTNPREFIX = "Btn"; public static final String BTNPREFIX = "Btn";

View File

@ -58,7 +58,7 @@ public class DetailPane extends Panel implements EventListener<Event>, IdSpace {
/** /**
* *
*/ */
private static final long serialVersionUID = 2142502910734162453L; private static final long serialVersionUID = 8807016961597158305L;
private static final String BTN_PROCESS_ID = "BtnProcess"; private static final String BTN_PROCESS_ID = "BtnProcess";

View File

@ -74,7 +74,6 @@ import org.zkoss.zul.impl.CustomGridDataLoader;
*/ */
public class GridView extends Vlayout implements EventListener<Event>, IdSpace, IFieldEditorContainer, StateChangeListener public class GridView extends Vlayout implements EventListener<Event>, IdSpace, IFieldEditorContainer, StateChangeListener
{ {
/** /**
* *
*/ */
@ -84,7 +83,7 @@ public class GridView extends Vlayout implements EventListener<Event>, IdSpace,
private static final int DEFAULT_DETAIL_PAGE_SIZE = 10; private static final int DEFAULT_DETAIL_PAGE_SIZE = 10;
public static final int DEFAULT_MOBILE_PAGE_SIZE = 20; private static final int DEFAULT_MOBILE_PAGE_SIZE = 20;
private static final int DEFAULT_PAGE_SIZE = 20; private static final int DEFAULT_PAGE_SIZE = 20;

View File

@ -83,14 +83,16 @@ public class QuickGridView extends Vbox
/** /**
* *
*/ */
private static final long serialVersionUID = -2966799998482667434L; private static final long serialVersionUID = 228387400133234920L;
static CLogger log = CLogger.getCLogger(QuickGridView.class); static CLogger log = CLogger.getCLogger(QuickGridView.class);
private static final String HEADER_GRID_STYLE = "border: none; margin:0; padding: 0;"; private static final String HEADER_GRID_STYLE = "border: none; margin:0; padding: 0;";
private static final int DEFAULT_PAGE_SIZE = 20; private static final int DEFAULT_PAGE_SIZE = 20;
private static final int DEFAULT_MOBILE_PAGE_SIZE = 20;
private static final int MIN_COLUMN_WIDTH = 100; private static final int MIN_COLUMN_WIDTH = 100;
private static final int MAX_COLUMN_WIDTH = 300; private static final int MAX_COLUMN_WIDTH = 300;
@ -217,7 +219,7 @@ public class QuickGridView extends Vbox
if (ClientInfo.isMobile()) if (ClientInfo.isMobile())
{ {
//Should be <= 20 on mobile //Should be <= 20 on mobile
pageSize = MSysConfig.getIntValue(MSysConfig.ZK_MOBILE_PAGING_SIZE, GridView.DEFAULT_MOBILE_PAGE_SIZE, Env.getAD_Client_ID(Env.getCtx())); pageSize = MSysConfig.getIntValue(MSysConfig.ZK_MOBILE_PAGING_SIZE, DEFAULT_MOBILE_PAGE_SIZE, Env.getAD_Client_ID(Env.getCtx()));
String limit = Library.getProperty(CustomGridDataLoader.GRID_DATA_LOADER_LIMIT); String limit = Library.getProperty(CustomGridDataLoader.GRID_DATA_LOADER_LIMIT);
if (limit == null || !(limit.equals(Integer.toString(pageSize)))) { if (limit == null || !(limit.equals(Integer.toString(pageSize)))) {
Library.setProperty(CustomGridDataLoader.GRID_DATA_LOADER_LIMIT, Integer.toString(pageSize)); Library.setProperty(CustomGridDataLoader.GRID_DATA_LOADER_LIMIT, Integer.toString(pageSize));

View File

@ -51,11 +51,11 @@ import org.zkoss.zul.Space;
*/ */
public class StatusBar extends Panel implements EventListener<Event> public class StatusBar extends Panel implements EventListener<Event>
{ {
/** /**
* *
*/ */
private static final long serialVersionUID = 1519490416637936553L; private static final long serialVersionUID = 7091641684809092888L;
private Panel infoPanel; private Panel infoPanel;
private Html infoLine; private Html infoLine;

View File

@ -57,11 +57,10 @@ import org.zkoss.zul.Columns;
*/ */
public class WQuickForm extends Window implements EventListener <Event>, DataStatusListener public class WQuickForm extends Window implements EventListener <Event>, DataStatusListener
{ {
/** /**
* *
*/ */
private static final long serialVersionUID = -5095168843989540551L; private static final long serialVersionUID = -5363771364595732977L;
public Trx trx = null; public Trx trx = null;
@ -142,6 +141,7 @@ public class WQuickForm extends Window implements EventListener <Event>, DataSta
bCustomize.addEventListener(Events.ON_CLICK, this); bCustomize.addEventListener(Events.ON_CLICK, this);
bUnSort.addEventListener(Events.ON_CLICK, this); bUnSort.addEventListener(Events.ON_CLICK, this);
// @TODO: translate extra quickform tooltips
// Add Shortcut Key info in tool-tip // Add Shortcut Key info in tool-tip
bSave.setTooltiptext(bSave.getTooltiptext() + " (Alt+S) Save current record if modified"); bSave.setTooltiptext(bSave.getTooltiptext() + " (Alt+S) Save current record if modified");
bIgnore.setTooltiptext(bIgnore.getTooltiptext() + " (Alt+Z) Ignore un-save changes of current record"); bIgnore.setTooltiptext(bIgnore.getTooltiptext() + " (Alt+Z) Ignore un-save changes of current record");

View File

@ -77,7 +77,7 @@ public class CustomizeGridViewPanel extends Panel
/** /**
* *
*/ */
private static final long serialVersionUID = -6300916636341781651L; private static final long serialVersionUID = -6200912526954948898L;
private Map<Integer, String> m_columnsWidth; private Map<Integer, String> m_columnsWidth;
ArrayList<Integer> tableSeqs; ArrayList<Integer> tableSeqs;

View File

@ -68,11 +68,10 @@ import org.zkoss.zul.Vbox;
* @since Nov 08, 2017 * @since Nov 08, 2017
*/ */
public class QuickCustomizeGridViewPanel extends Panel { public class QuickCustomizeGridViewPanel extends Panel {
/** /**
* *
*/ */
private static final long serialVersionUID = 721233085611663253L; private static final long serialVersionUID = 7566420005952940208L;
static CLogger log = CLogger.getCLogger(QuickCustomizeGridViewPanel.class); static CLogger log = CLogger.getCLogger(QuickCustomizeGridViewPanel.class);
@ -458,11 +457,10 @@ public class QuickCustomizeGridViewPanel extends Panel {
* ListElement Item * ListElement Item
*/ */
private static class ListElement extends NamePair { private static class ListElement extends NamePair {
/** /**
* *
*/ */
private static final long serialVersionUID = 884539656654102968L; private static final long serialVersionUID = -4428985595605126841L;
private int m_key; private int m_key;

View File

@ -17,10 +17,10 @@ import org.compiere.util.Msg;
public class CustomizeGridViewDialog extends Window { public class CustomizeGridViewDialog extends Window {
/** /**
* generated serial id *
*/ */
private static final long serialVersionUID = -4093048147438176240L; private static final long serialVersionUID = -138153049225192685L;
private CustomizeGridViewPanel customizePanel; private CustomizeGridViewPanel customizePanel;
private QuickCustomizeGridViewPanel quickCustomizePanel; private QuickCustomizeGridViewPanel quickCustomizePanel;
private boolean isQuickForm = false; private boolean isQuickForm = false;