midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* [1921799] - disable reaonly optimization 

* Added autocommit checking, failure to set autocommit on connection is very dangerous.
This commit is contained in:
Heng Sin Low 2008-03-21 01:20:34 +00:00
parent 593a37a464
commit be285084f9
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
base/src/org/compiere/util/DB.java
View File

@ -419,6 +419,15 @@ public final class DB
}
**/
}
//hengsin: failed to set autocommit can lead to severe lock up of the system
try {
if (conn != null && conn.getAutoCommit() != autoCommit)
{
throw new IllegalStateException("Failed to set the requested auto commit mode on connection. [autoCommit=" + autoCommit +"]");
}
} catch (SQLException e) {}
return conn;
} // createConnection
@ -438,6 +447,8 @@ public final class DB
Connection conn = s_cc.getConnection (autoCommit, trxLevel);
//hengsin: this could be problematic as it can be reuse for readwrite activites after return to pool
/*
if (conn != null)
{
try
@ -449,12 +460,20 @@ public final class DB
conn = null;
log.log(Level.SEVERE, ex.getMessage(), ex);
}
}
}*/
if (conn == null)
{
throw new IllegalStateException("DB.getConnectionRO - @NoDBConnection@");
}
//hengsin: failed to set autocommit can lead to severe lock up of the system
try {
if (conn.getAutoCommit() != autoCommit)
{
throw new IllegalStateException("Failed to set the requested auto commit mode on connection. [autocommit=" + autoCommit +"]");
}
} catch (SQLException e) {}
return conn;
} // createConnection