From baac93f9e080db2f8da5852a8dde6c64ce54cede Mon Sep 17 00:00:00 2001
From: hengsin <hengsin@gmail.com>
Date: Fri, 29 May 2020 19:38:15 +0800
Subject: [PATCH] IDEMPIERE-4307 Quick Entry always retrieve all fields from db
 (#83)

add cache for MField
---
 .../src/org/compiere/model/MField.java        | 29 +++++++++++++++++--
 .../org/adempiere/webui/grid/WQuickEntry.java |  2 +-
 2 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/org.adempiere.base/src/org/compiere/model/MField.java b/org.adempiere.base/src/org/compiere/model/MField.java
index 305475b916..08f4313ae8 100644
--- a/org.adempiere.base/src/org/compiere/model/MField.java
+++ b/org.adempiere.base/src/org/compiere/model/MField.java
@@ -19,6 +19,8 @@ package org.compiere.model;
 import java.sql.ResultSet;
 import java.util.Properties;
 
+import org.compiere.util.CCache;
+
 
 /**
  *	Field Model
@@ -32,8 +34,31 @@ public class MField extends X_AD_Field
 	/**
 	 * 
 	 */
-	private static final long serialVersionUID = 7124162742037904113L;
-
+	private static final long serialVersionUID = 7243492167390659946L;
+	
+	/**	Cache						*/
+	private static CCache<Integer,MField> s_cache = new CCache<Integer,MField>(Table_Name, 20);
+	
+	/**
+	 * 
+	 * @param ctx
+	 * @param AD_Field_ID
+	 * @return MField
+	 */
+	public static MField get(Properties ctx, int AD_Field_ID)
+	{
+		Integer key = Integer.valueOf(AD_Field_ID);
+		MField retValue = s_cache.get (key);
+		if (retValue != null && retValue.getCtx() == ctx) {
+			return retValue;
+		}
+		retValue = new MField (ctx, AD_Field_ID, null);
+		if (retValue.get_ID () == AD_Field_ID) {
+			s_cache.put (key, retValue);
+		}
+		return retValue;
+	}
+	
 	/**
 	 * 	Standard Constructor
 	 *	@param ctx context
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/grid/WQuickEntry.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/grid/WQuickEntry.java
index 4fef53bdfc..13c5c7fdc3 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/grid/WQuickEntry.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/grid/WQuickEntry.java
@@ -212,7 +212,7 @@ public class WQuickEntry extends Window implements EventListener<Event>, ValueCh
 			if (!gridtab.isLoadComplete())
 				gridwindow.initTab(i);
 			for (GridField gridfield : gridtab.getFields()) {
-				MField field = new MField(Env.getCtx(), gridfield.getAD_Field_ID(), null);
+				MField field = MField.get(Env.getCtx(), gridfield.getAD_Field_ID());
 				if (field.isQuickEntry()) {
 					if (! isValidQuickEntryType(field.getAD_Reference_ID()))
 						continue;