midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-568 Review proper closing of JDBC statements and resultsets

This commit is contained in:
Carlos Ruiz 2013-02-20 21:33:19 -05:00
parent 65a9dc9adc
commit b3ac2521a1
1 changed files with 60 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
org.adempiere.base.process/src/org/compiere/process/TableCreateColumns.java
View File

@ -138,7 +138,9 @@ public class TableCreateColumns extends SvrProcess
{
// globalqss 2005-10-25
// ResultSet rs = md.getTables(catalog, schema, null, null);
ResultSet rs;
ResultSet rs = null;
ResultSet rsC = null;
try {
if (DB.isPostgreSQL())
rs = md.getTables(catalog, schema, null, new String [] {"TABLE", "VIEW"});
else
@ -187,9 +189,17 @@ public class TableCreateColumns extends SvrProcess
if (DB.isPostgreSQL())
tableName = tableName.toLowerCase();
// end globalqss 2005-10-24
ResultSet rsC = md.getColumns(catalog, schema, tableName, null);
rsC = md.getColumns(catalog, schema, tableName, null);
addTableColumn(rsC, table);
}
} catch (Exception e) {
throw e;
} finally {
DB.close(rs);
rs = null;
DB.close(rsC);
rsC = null;
}
} // addTable