midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-2488:Info Window run Query twice 

fix potential index issue.
This commit is contained in:
hieplq 2015-08-09 16:08:13 +08:00
parent c016319633
commit b398843bc7
1 changed files with 29 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/InfoPanel.java
View File

@ -747,7 +747,7 @@ public abstract class InfoPanel extends Window implements EventListener<Event>,
{
if (start+1 >= getCacheStart() && end+1 <= cacheEnd)
{
return end == -1 ? line : line.subList(start-getCacheStart()+1, end-getCacheStart()+1);
return end == -1 ? line : getSubList(start-getCacheStart()+1, end-getCacheStart()+1, line);
}
}
else
@ -756,7 +756,7 @@ public abstract class InfoPanel extends Window implements EventListener<Event>,
{
end = cacheEnd;
}
return line.subList(start, end);
return getSubList (start, end, line);
}
}
@ -850,11 +850,35 @@ public abstract class InfoPanel extends Window implements EventListener<Event>,
{
int fromIndex = start-getCacheStart()+1;
int toIndex = end-getCacheStart()+1;
return getSubList(fromIndex, toIndex, line);
}
}
/**
* fromIndex and toIndex calculate with assume always query record as {@link #testCount()}
* example after testCount we get calculate 6page.
* when user navigate to page 4. something change in system (a batch record change become don't match with search query)
* let we just get 5 page with current parameter.
* so when user navigate to page 6. user will face with index issue. (out of index or start index > end index)
* this function is fix for it.
* @param fromIndex
* @param toIndex
* @param line
* @return
*/
protected List<Object> getSubList (int fromIndex, int toIndex, List<Object> line){
if (toIndex > line.size())
toIndex = line.size();
if (fromIndex >= line.size())
fromIndex = line.size() - 1;
// case line.size = 0
if (fromIndex < 0)
fromIndex = 0;
return line.subList(fromIndex, toIndex);
}
}
protected String buildDataSQL(int start, int end) {
String dataSql;