*BF [ 1874419 ] JDBC Statement not close in a finally block

organize imports
This commit is contained in:
Redhuan D. Oon 2008-02-19 13:34:40 +00:00
parent 40c4adc801
commit b352e3960b
1 changed files with 24 additions and 21 deletions

View File

@ -16,14 +16,25 @@
*****************************************************************************/ *****************************************************************************/
package org.compiere.report; package org.compiere.report;
import java.math.*; import java.math.BigDecimal;
import java.sql.*; import java.sql.PreparedStatement;
import java.util.*; import java.sql.ResultSet;
import java.util.logging.*; import java.sql.Timestamp;
import org.compiere.model.*; import java.util.Calendar;
import org.compiere.print.*; import java.util.GregorianCalendar;
import org.compiere.process.*; import java.util.logging.Level;
import org.compiere.util.*;
import org.compiere.model.MAcctSchemaElement;
import org.compiere.model.MElementValue;
import org.compiere.model.MPeriod;
import org.compiere.print.MPrintFormat;
import org.compiere.process.ProcessInfoParameter;
import org.compiere.process.SvrProcess;
import org.compiere.util.DB;
import org.compiere.util.Env;
import org.compiere.util.Ini;
import org.compiere.util.Language;
import org.compiere.util.Msg;
/** /**
* Statement of Account * Statement of Account
@ -195,34 +206,26 @@ public class FinStatement extends SvrProcess
String sql = "SELECT StartDate, EndDate FROM C_Period WHERE C_Period_ID=?"; String sql = "SELECT StartDate, EndDate FROM C_Period WHERE C_Period_ID=?";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement(sql, null); pstmt = DB.prepareStatement(sql, null);
pstmt.setInt(1, p_C_Period_ID); pstmt.setInt(1, p_C_Period_ID);
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
p_DateAcct_From = rs.getTimestamp(1); p_DateAcct_From = rs.getTimestamp(1);
p_DateAcct_To = rs.getTimestamp(2); p_DateAcct_To = rs.getTimestamp(2);
} }
rs.close(); }
pstmt.close();
pstmt = null;
}
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
finally finally
{ {
try DB.close(rs, pstmt);
{ rs = null; pstmt = null;
if (pstmt != null)
pstmt.close ();
}
catch (Exception e)
{}
pstmt = null;
} }
} // setDateAcct } // setDateAcct