midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-3854 Conversion rate must validate period overlapping

This commit is contained in:
Carlos Ruiz 2019-03-29 16:37:21 -03:00
parent 6f7949c2bb
commit aea1502701
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
org.adempiere.base/src/org/compiere/model/MConversionRate.java
View File

@ -465,9 +465,10 @@ public class MConversionRate extends X_C_Conversion_Rate
return true; return true;
} // beforeSave } // beforeSave
private volatile static boolean recursiveCall = false;
@Override @Override
protected boolean afterSave(boolean newRecord, boolean success) { protected boolean afterSave(boolean newRecord, boolean success) {
if (success) { if (success && !recursiveCall) {
String whereClause = "ValidFrom=? AND ValidTo=? " String whereClause = "ValidFrom=? AND ValidTo=? "
+ "AND C_Currency_ID=? AND C_Currency_ID_To=? " + "AND C_Currency_ID=? AND C_Currency_ID_To=? "
+ "AND C_ConversionType_ID=? " + "AND C_ConversionType_ID=? "
@ -490,9 +491,15 @@ public class MConversionRate extends X_C_Conversion_Rate
reciprocal.setC_Currency_ID(getC_Currency_ID_To()); reciprocal.setC_Currency_ID(getC_Currency_ID_To());
reciprocal.setC_Currency_ID_To(getC_Currency_ID()); reciprocal.setC_Currency_ID_To(getC_Currency_ID());
} }
reciprocal.setDivideRate(getMultiplyRate()); // avoid recalculation
reciprocal.setMultiplyRate(getDivideRate()); reciprocal.set_Value(COLUMNNAME_DivideRate, getMultiplyRate());
reciprocal.saveEx(); reciprocal.set_Value(COLUMNNAME_MultiplyRate, getDivideRate());
recursiveCall = true;
try {
reciprocal.saveEx();
} finally {
recursiveCall = false;
}
} }
return success; return success;
} }