From 68e07a93b5d6134fc1b317f2ac17c8171f8e934f Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Fri, 10 May 2013 08:34:28 -0500 Subject: [PATCH 1/8] IDEMPIERE-914 Any user can obtain all passwords via field editor - thanks to Anthony Sossah (xolali) --- .../src/org/adempiere/webui/editor/WStringEditor.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java index dc9bbebcb0..3fcd4a7d87 100644 --- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java +++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java @@ -139,9 +139,12 @@ public class WStringEditor extends WEditor implements ContextMenuListener if (getComponent() instanceof Textbox) ((Textbox)getComponent()).setObscureType(obscureType); - popupMenu = new WEditorPopupMenu(false, false, isShowPreference()); - addTextEditorMenu(popupMenu); - addChangeLogMenu(popupMenu); + + if(!(this instanceof WPasswordEditor)){ // check password field + popupMenu = new WEditorPopupMenu(false, false, isShowPreference()); + addTextEditorMenu(popupMenu); + addChangeLogMenu(popupMenu); + } if (gridField.isAutocomplete()) { Combobox combo = (Combobox)getComponent(); From 0855c6e79cf3bfefe8c40eabe85eb1a4d99c32ce Mon Sep 17 00:00:00 2001 From: Richard Morales Date: Sun, 12 May 2013 14:11:19 -0500 Subject: [PATCH 2/8] IDEMPIERE-919 Inventory Move window - Values for Partner Location & User / Contact, no changes when value changed business partner --- .../oracle/201305101047_IDEMPIERE-919.sql | 12 ++++++++++++ .../postgresql/201305101047_IDEMPIERE-919.sql | 12 ++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 migration/i1.0b-release/oracle/201305101047_IDEMPIERE-919.sql create mode 100644 migration/i1.0b-release/postgresql/201305101047_IDEMPIERE-919.sql diff --git a/migration/i1.0b-release/oracle/201305101047_IDEMPIERE-919.sql b/migration/i1.0b-release/oracle/201305101047_IDEMPIERE-919.sql new file mode 100644 index 0000000000..2e5e1bae74 --- /dev/null +++ b/migration/i1.0b-release/oracle/201305101047_IDEMPIERE-919.sql @@ -0,0 +1,12 @@ +-- May 10, 2013 10:43:39 AM COT +-- IDEMPIERE-919 Values for "Partner Location & User / Contact", no changes when value changed business partner +UPDATE AD_Column SET AD_Reference_Value_ID=NULL, AD_Reference_ID=19, AD_Val_Rule_ID=123, DefaultValue='-1',Updated=TO_DATE('2013-05-10 10:43:39','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=53973 +; + +-- May 10, 2013 10:44:19 AM COT +-- IDEMPIERE-919 Values for "Partner Location & User / Contact", no changes when value changed business partner +UPDATE AD_Column SET AD_Reference_ID=19, AD_Val_Rule_ID=167,Updated=TO_DATE('2013-05-10 10:44:19','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=53975 +; + +SELECT register_migration_script('201305101047_IDEMPIERE-919.sql') FROM dual; + diff --git a/migration/i1.0b-release/postgresql/201305101047_IDEMPIERE-919.sql b/migration/i1.0b-release/postgresql/201305101047_IDEMPIERE-919.sql new file mode 100644 index 0000000000..f10ef88732 --- /dev/null +++ b/migration/i1.0b-release/postgresql/201305101047_IDEMPIERE-919.sql @@ -0,0 +1,12 @@ +-- May 10, 2013 10:43:39 AM COT +-- IDEMPIERE-919 Values for "Partner Location & User / Contact", no changes when value changed business partner +UPDATE AD_Column SET AD_Reference_Value_ID=NULL, AD_Reference_ID=19, AD_Val_Rule_ID=123, DefaultValue='-1',Updated=TO_TIMESTAMP('2013-05-10 10:43:39','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=53973 +; + +-- May 10, 2013 10:44:19 AM COT +-- IDEMPIERE-919 Values for "Partner Location & User / Contact", no changes when value changed business partner +UPDATE AD_Column SET AD_Reference_ID=19, AD_Val_Rule_ID=167,Updated=TO_TIMESTAMP('2013-05-10 10:44:19','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=53975 +; + +SELECT register_migration_script('201305101047_IDEMPIERE-919.sql') FROM dual; + From 5400d304437d9165dbc8bc8518628e370f3f401b Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Sun, 12 May 2013 14:53:35 -0500 Subject: [PATCH 3/8] IDEMPIERE-913 NPE when saving query with look-up field not visible on window / thanks to Anthony Sossah (xolali) it solves also IDEMPIERE-916 NPE in Tab : Included Roles --- .../src/org/adempiere/base/DefaultLookupFactory.java | 2 ++ org.adempiere.base/src/org/compiere/model/GridField.java | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/org.adempiere.base/src/org/adempiere/base/DefaultLookupFactory.java b/org.adempiere.base/src/org/adempiere/base/DefaultLookupFactory.java index d1fd5f9f64..8fa649585a 100644 --- a/org.adempiere.base/src/org/adempiere/base/DefaultLookupFactory.java +++ b/org.adempiere.base/src/org/adempiere/base/DefaultLookupFactory.java @@ -34,6 +34,8 @@ public class DefaultLookupFactory implements ILookupFactory{ @Override public Lookup getLookup(GridFieldVO gridFieldVO) { Lookup lookup = null; + if (gridFieldVO.lookupInfo == null) // IDEMPIERE-913 + gridFieldVO.loadLookupInfo(); if (gridFieldVO.displayType == Location) // not cached { lookup = new MLocationLookup (gridFieldVO.ctx, gridFieldVO.WindowNo); diff --git a/org.adempiere.base/src/org/compiere/model/GridField.java b/org.adempiere.base/src/org/compiere/model/GridField.java index c9b62d7b35..4c080e593c 100644 --- a/org.adempiere.base/src/org/compiere/model/GridField.java +++ b/org.adempiere.base/src/org/compiere/model/GridField.java @@ -233,9 +233,10 @@ public class GridField * @return lookup */ public Lookup getLookup() - { + { + if (m_lookup == null) loadLookupFromFactory(); // IDEMPIERE-913 return m_lookup; - } // getLookup + } // getLookup /** * Is this field a Lookup?. From 4ed60a0e67f92fddeed151b4d6cfd77ada1fab28 Mon Sep 17 00:00:00 2001 From: Richard Morales Date: Sun, 12 May 2013 15:22:35 -0500 Subject: [PATCH 4/8] IDEMPIERE-912 Export Dialog Buttons misaligned --- .../WEB-INF/src/org/adempiere/webui/window/ZkReportViewer.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/ZkReportViewer.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/ZkReportViewer.java index 3852b9a0f0..d4642d5c03 100644 --- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/ZkReportViewer.java +++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/ZkReportViewer.java @@ -822,7 +822,7 @@ public class ZkReportViewer extends Window implements EventListener, ITab winExportFile = new Window(); winExportFile.setTitle(Msg.getMsg(Env.getCtx(), "Export") + ": " + getTitle()); winExportFile.setWidth("450px"); - winExportFile.setHeight("300px"); + winExportFile.setHeight("150px"); winExportFile.setClosable(true); winExportFile.setBorder("normal"); winExportFile.setStyle("position:absolute"); @@ -857,7 +857,6 @@ public class ZkReportViewer extends Window implements EventListener, ITab vb.appendChild(hb); vb.appendChild(confirmPanel); confirmPanel.addActionListener(this); - confirmPanel.setVflex("0"); } winExportFile.setAttribute(Window.MODE_KEY, Window.MODE_HIGHLIGHTED); From 86a5c96e9dd6778ea7a2bd867d0d70ea530ebba7 Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Sun, 12 May 2013 15:30:11 -0500 Subject: [PATCH 5/8] IDEMPIERE-910 Add a direct link to Felix console --- org.adempiere.server/idempiere.html | 1 + 1 file changed, 1 insertion(+) diff --git a/org.adempiere.server/idempiere.html b/org.adempiere.server/idempiere.html index 603c64d13c..716345d707 100644 --- a/org.adempiere.server/idempiere.html +++ b/org.adempiere.server/idempiere.html @@ -190,6 +190,7 @@ Start iDempiere via RUN_Adempiere

iDempiere Server Management +
Felix Console

From cf769011c11737656a5bb9316717b42b536ce7f4 Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Mon, 13 May 2013 08:39:37 -0500 Subject: [PATCH 6/8] IDEMPIERE-913 Fix broken payment reference --- .../src/org/adempiere/base/DefaultLookupFactory.java | 2 +- org.adempiere.base/src/org/compiere/model/GridField.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.adempiere.base/src/org/adempiere/base/DefaultLookupFactory.java b/org.adempiere.base/src/org/adempiere/base/DefaultLookupFactory.java index 8fa649585a..d9c5927177 100644 --- a/org.adempiere.base/src/org/adempiere/base/DefaultLookupFactory.java +++ b/org.adempiere.base/src/org/adempiere/base/DefaultLookupFactory.java @@ -34,7 +34,7 @@ public class DefaultLookupFactory implements ILookupFactory{ @Override public Lookup getLookup(GridFieldVO gridFieldVO) { Lookup lookup = null; - if (gridFieldVO.lookupInfo == null) // IDEMPIERE-913 + if (gridFieldVO.lookupInfo == null && DisplayType.isLookup(gridFieldVO.displayType)) // IDEMPIERE-913 gridFieldVO.loadLookupInfo(); if (gridFieldVO.displayType == Location) // not cached { diff --git a/org.adempiere.base/src/org/compiere/model/GridField.java b/org.adempiere.base/src/org/compiere/model/GridField.java index 4c080e593c..fe591e214e 100644 --- a/org.adempiere.base/src/org/compiere/model/GridField.java +++ b/org.adempiere.base/src/org/compiere/model/GridField.java @@ -234,7 +234,7 @@ public class GridField */ public Lookup getLookup() { - if (m_lookup == null) loadLookupFromFactory(); // IDEMPIERE-913 + if (m_lookup == null) loadLookupNoValidate(); // IDEMPIERE-913 return m_lookup; } // getLookup From 81a67229c0a74f1324447f92d5ab9e1dac42482f Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Mon, 13 May 2013 17:02:51 -0500 Subject: [PATCH 7/8] IDEMPIERE-913 Fix trying to load lookup for non lookup fields --- org.adempiere.base/src/org/compiere/model/GridField.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.adempiere.base/src/org/compiere/model/GridField.java b/org.adempiere.base/src/org/compiere/model/GridField.java index fe591e214e..64928bdc7e 100644 --- a/org.adempiere.base/src/org/compiere/model/GridField.java +++ b/org.adempiere.base/src/org/compiere/model/GridField.java @@ -208,7 +208,7 @@ public class GridField * bypass isdisplay validation, used by findwindow */ public void loadLookupNoValidate() { - if (m_vo.lookupInfo == null) { + if (m_vo.lookupInfo == null && isLookup()) { m_vo.loadLookupInfo(); } if (m_vo.lookupInfo == null) { From f32075be4adc3f76f937b4c2d62da68d0c0c513e Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Mon, 13 May 2013 17:24:24 -0500 Subject: [PATCH 8/8] IDEMPIERE-921 Obscured fields show information when clicked --- org.adempiere.ui.swing/src/org/compiere/grid/ed/VString.java | 2 +- .../WEB-INF/src/org/adempiere/webui/component/Textbox.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/ed/VString.java b/org.adempiere.ui.swing/src/org/compiere/grid/ed/VString.java index 43543f05a0..1ffe8fdc11 100644 --- a/org.adempiere.ui.swing/src/org/compiere/grid/ed/VString.java +++ b/org.adempiere.ui.swing/src/org/compiere/grid/ed/VString.java @@ -369,7 +369,7 @@ public final class VString extends CTextField String text = super.getText(); if (m_obscure != null && text != null && text.length() > 0) { - if (text.equals(m_obscure.getObscuredValue())) + if (isReadWrite() && text.equals(m_obscure.getObscuredValue())) text = m_obscure.getClearValue(); } return text; diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Textbox.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Textbox.java index 8315f3f773..de8b39c282 100644 --- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Textbox.java +++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Textbox.java @@ -86,7 +86,7 @@ public class Textbox extends org.zkoss.zul.Textbox implements EventListener 0) { - if (value.equals(m_obscure.getObscuredValue())) + if (!isReadonly() && value.equals(m_obscure.getObscuredValue())) value = m_obscure.getClearValue(); } return value;