midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*BF [ 1874419 ] JDBC Statement not close in a finally block 

*Organize imports

*Parameterized entry <String>
This commit is contained in:
Redhuan D. Oon 2008-02-08 09:02:37 +00:00
parent 07d60791bc
commit a82a15d41f
1 changed files with 26 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
base/src/org/compiere/model/MRequest.java
View File

@ -16,12 +16,19 @@
*****************************************************************************/ *****************************************************************************/
package org.compiere.model; package org.compiere.model;
import java.io.*; import java.io.File;
import java.sql.*; import java.sql.PreparedStatement;
import java.util.*; import java.sql.ResultSet;
import java.sql.Timestamp;
import java.util.ArrayList;
import java.util.Properties;
import java.util.logging.Level;
import java.util.logging.*; import org.compiere.util.CLogger;
import org.compiere.util.*; import org.compiere.util.DB;
import org.compiere.util.Env;
import org.compiere.util.Msg;
import org.compiere.util.TimeUtil;
/** /**
* Request Model * Request Model
@ -963,6 +970,8 @@ public class MRequest extends X_R_Request
* Check the ability to send email. * Check the ability to send email.
* @return AD_Message or null if no error * @return AD_Message or null if no error
*/ */
/*
* TODO red1 - Never Used Locally - to check later
private String checkEMail() private String checkEMail()
{ {
// Mail Host // Mail Host
@ -999,7 +1008,7 @@ public class MRequest extends X_R_Request
return null; return null;
} // checkEMail } // checkEMail
*/
/** /**
* Set SalesRep_ID * Set SalesRep_ID
* @param SalesRep_ID id * @param SalesRep_ID id
@ -1031,7 +1040,7 @@ public class MRequest extends X_R_Request
} }
// Initial Mail // Initial Mail
if (newRecord) if (newRecord)
sendNotices(new ArrayList()); sendNotices(new ArrayList<String>());
// ChangeRequest - created in Request Processor // ChangeRequest - created in Request Processor
if (getM_ChangeRequest_ID() != 0 if (getM_ChangeRequest_ID() != 0
@ -1068,7 +1077,8 @@ public class MRequest extends X_R_Request
/** /**
* Send transfer Message * Send transfer Message
*/ */
private void sendTransferMessage () /*TODO - red1 Never used locally - check later
* private void sendTransferMessage ()
{ {
// Sender // Sender
int AD_User_ID = Env.getContextAsInt(p_ctx, "#AD_User_ID"); int AD_User_ID = Env.getContextAsInt(p_ctx, "#AD_User_ID");
@ -1094,13 +1104,13 @@ public class MRequest extends X_R_Request
// //
client.sendEMail(from, to, subject, message, createPDF()); client.sendEMail(from, to, subject, message, createPDF());
} // afterSaveTransfer } // afterSaveTransfer
*/
/** /**
* Send Update EMail/Notices * Send Update EMail/Notices
* @param list list of changes * @param list list of changes
*/ */
public void sendNotices(ArrayList list) public void sendNotices(ArrayList<String> list)
{ {
// Subject // Subject
String subject = Msg.translate(getCtx(), "R_Request_ID") String subject = Msg.translate(getCtx(), "R_Request_ID")
@ -1157,11 +1167,12 @@ public class MRequest extends X_R_Request
+ "WHERE ru.R_Request_ID=? " + "WHERE ru.R_Request_ID=? "
+ "GROUP BY u.AD_User_ID, u.NotificationType, u.EMail, u.Name"; + "GROUP BY u.AD_User_ID, u.NotificationType, u.EMail, u.Name";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
pstmt.setInt (1, getR_Request_ID()); pstmt.setInt (1, getR_Request_ID());
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
{ {
int AD_User_ID = rs.getInt(1); int AD_User_ID = rs.getInt(1);
@ -1246,25 +1257,16 @@ public class MRequest extends X_R_Request
notices++; notices++;
} }
} }
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
log.log (Level.SEVERE, sql, e); log.log (Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
} }
catch (Exception e)
{
pstmt = null;
}
log.info("EMail Success=" + success + ", Failure=" + failure log.info("EMail Success=" + success + ", Failure=" + failure
+ " - Notices=" + notices); + " - Notices=" + notices);
} // sendNotice } // sendNotice