midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-5296 Firefox 100: Horizontal scroll is broken for Grid with Frozen (#1338) 

- Temporary workaround: disable frozen for Firefox 100
This commit is contained in:
hengsin 2022-05-22 20:46:51 +08:00 committed by GitHub
parent 0959a1d313
commit a716db8ebd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/ClientInfo.java
View File

@ -21,6 +21,7 @@ import java.util.TimeZone;
import org.adempiere.webui.session.SessionManager; import org.adempiere.webui.session.SessionManager;
import org.compiere.util.Env; import org.compiere.util.Env;
import org.compiere.util.Util;
import org.zkoss.zk.ui.Component; import org.zkoss.zk.ui.Component;
import org.zkoss.zk.ui.event.Event; import org.zkoss.zk.ui.event.Event;
import org.zkoss.zk.ui.event.EventListener; import org.zkoss.zk.ui.event.EventListener;
@ -99,6 +100,18 @@ public class ClientInfo implements Serializable {
return "Y".equals(Env.getContext(Env.getCtx(), Env.CLIENT_INFO_MOBILE)); return "Y".equals(Env.getContext(Env.getCtx(), Env.CLIENT_INFO_MOBILE));
} }
/**
*
* @param version null to match all version
* @return true if browser is firefox and match the pass in version parameter
*/
public static boolean isFirefox(String version) {
StringBuilder ua = new StringBuilder("Firefox");
if (!Util.isEmpty(version, true))
ua.append("/").append(version);
return get() != null && get().userAgent != null && get().userAgent.contains(ua.toString());
}
/** /**
* @return the current clientinfo instance * @return the current clientinfo instance
*/ */

2
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridView.java
View File

@ -548,7 +548,7 @@ public class GridView extends Vlayout implements EventListener<Event>, IdSpace,
//frozen not working well on tablet devices yet //frozen not working well on tablet devices yet
//unlikely to be fixed since the working 'smooth scrolling frozen' is a zk ee only feature //unlikely to be fixed since the working 'smooth scrolling frozen' is a zk ee only feature
if (!ClientInfo.isMobile()) if (!ClientInfo.isMobile() && !ClientInfo.isFirefox("100."))
{ {
Frozen frozen = new Frozen(); Frozen frozen = new Frozen();
//freeze selection and indicator column //freeze selection and indicator column