midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-236 Centralization of hardcoded IDs / using naming convention for constants

This commit is contained in:
Nicolas Micoud 2012-04-18 16:04:01 +02:00
parent b0c67e8897
commit a53fd5c08f
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
org.adempiere.base/src/org/compiere/model/HardCodedIDs.java
View File

@ -23,9 +23,8 @@ package org.compiere.model;
public class HardCodedIDs { public class HardCodedIDs {
public static int referencePostingType = 125; public final static int REFERENCE_POSTING_TYPE = 125;
public final static int WINDOW_MY_REQUESTS = 237;
public static int windowMyRequests = 237;
} }

2
org.adempiere.ui.swing/src/org/compiere/acct/AcctViewerData.java
View File

@ -173,7 +173,7 @@ class AcctViewerData
*/ */
protected void fillPostingType (JComboBox cb) protected void fillPostingType (JComboBox cb)
{ {
int AD_Reference_ID = HardCodedIDs.referencePostingType; int AD_Reference_ID = HardCodedIDs.REFERENCE_POSTING_TYPE;
ValueNamePair[] pt = MRefList.getList(Env.getCtx(), AD_Reference_ID, true); ValueNamePair[] pt = MRefList.getList(Env.getCtx(), AD_Reference_ID, true);
for (int i = 0; i < pt.length; i++) for (int i = 0; i < pt.length; i++)
cb.addItem(pt[i]); cb.addItem(pt[i]);

2
org.adempiere.ui.swing/src/org/compiere/apps/AMenu.java
View File

@ -688,7 +688,7 @@ public final class AMenu extends CFrame
// + " INNER JOIN AD_TABLE t ON (t.AD_Window_ID=m.AD_Window_ID) " // + " INNER JOIN AD_TABLE t ON (t.AD_Window_ID=m.AD_Window_ID) "
// + "WHERE t.AD_Table_ID=?", 417); // + "WHERE t.AD_Table_ID=?", 417);
if (m_request_Menu_ID == 0) if (m_request_Menu_ID == 0)
m_request_Menu_ID = HardCodedIDs.windowMyRequests; // My Requests m_request_Menu_ID = HardCodedIDs.WINDOW_MY_REQUESTS; // My Requests
(new AMenuStartItem (m_request_Menu_ID, true, Msg.translate(m_ctx, "R_Request_ID"), this)).start(); // async load (new AMenuStartItem (m_request_Menu_ID, true, Msg.translate(m_ctx, "R_Request_ID"), this)).start(); // async load
} // gotoRequests } // gotoRequests