midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-455 Discover and fix FindBugs problems / Pattern SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE

This commit is contained in:
Carlos Ruiz 2012-12-10 15:11:21 -05:00
parent ad61a5e637
commit a3c1e9dc78
1 changed files with 15 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/LoggedSessionListener.java
View File

@ -1,8 +1,7 @@
package org.adempiere.webui;
import java.sql.ResultSet;
import java.sql.Statement;
import java.util.Hashtable;
import java.util.List;
import javax.servlet.ServletContextEvent;
import javax.servlet.ServletContextListener;
@ -10,8 +9,10 @@ import javax.servlet.http.HttpSession;
import javax.servlet.http.HttpSessionEvent;
import javax.servlet.http.HttpSessionListener;
import org.adempiere.exceptions.AdempiereException;
import org.compiere.Adempiere;
import org.compiere.model.MSession;
import org.compiere.model.Query;
import org.compiere.model.ServerStateChangeEvent;
import org.compiere.model.ServerStateChangeListener;
import org.compiere.util.DB;
@ -53,34 +54,25 @@ public class LoggedSessionListener implements HttpSessionListener, ServletContex
Adempiere.addServerStateChangeListener(this);
return;
}
String serverName = WebUtil.getServerName();
String sql = "UPDATE AD_Session SET processed = 'Y' WHERE processed ='N' AND servername = '"+serverName+"'";
Statement stmt = DB.createStatement();
try{
stmt.executeUpdate(sql);
}catch (Exception e) {
System.out.println("UpdateSession: "+e);
String sql = "UPDATE AD_Session SET Processed='Y' WHERE Processed='N' AND ServerName=?";
int no = DB.executeUpdate(sql, new Object[] {serverName}, false, null);
if (no < 0) {
throw new AdempiereException("UpdateSession: Cannot Destroy All Session");
}
Adempiere.removeServerStateChangeListener(this);
}
public void removeADSession(String sessionID, String serverName) {
StringBuilder sql = new StringBuilder("SELECT * FROM AD_Session WHERE websession = '");
sql.append(sessionID)
.append("' AND servername = '")
.append(serverName).append("' AND processed = 'N'");
Statement stmt = DB.createStatement();
try{
ResultSet rs = stmt.executeQuery(sql.toString());
if(rs.next()){
MSession mSession = new MSession(Env.getCtx(), rs, null);
mSession.setProcessed(true);
mSession.save();
}
}catch (Exception e) {
System.out.println("UpdateSession: "+e);
String whereClause = "WebSession=? AND ServerName=? AND Processed='N'";
List<MSession> sessions = new Query(Env.getCtx(), MSession.Table_Name, whereClause, null)
.setParameters(sessionID, serverName)
.list();
for (MSession session : sessions) {
session.setProcessed(true);
session.saveEx();
}
}