midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*BF [ 1874419 ] JDBC Statement not close in a finally block 

*Organize imports
This commit is contained in:
Redhuan D. Oon 2008-02-08 19:22:18 +00:00
parent 70159b94bf
commit a35c729673
1 changed files with 43 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
client/src/org/compiere/apps/form/VTreeMaintenance.java
View File

@ -16,17 +16,43 @@
*****************************************************************************/ *****************************************************************************/
package org.compiere.apps.form; package org.compiere.apps.form;
import java.awt.*; import java.awt.BorderLayout;
import java.awt.event.*; import java.awt.FlowLayout;
import java.beans.*; import java.awt.event.ActionEvent;
import java.sql.*; import java.awt.event.ActionListener;
import java.util.logging.*; import java.beans.PropertyChangeEvent;
import javax.swing.*; import java.beans.PropertyChangeListener;
import javax.swing.event.*; import java.sql.PreparedStatement;
import org.compiere.grid.tree.*; import java.sql.ResultSet;
import org.compiere.model.*; import java.util.logging.Level;
import org.compiere.swing.*;
import org.compiere.util.*; import javax.swing.DefaultListModel;
import javax.swing.JList;
import javax.swing.JScrollPane;
import javax.swing.JSplitPane;
import javax.swing.ListModel;
import javax.swing.ListSelectionModel;
import javax.swing.event.ListSelectionEvent;
import javax.swing.event.ListSelectionListener;
import org.compiere.grid.tree.VTreePanel;
import org.compiere.model.MRole;
import org.compiere.model.MTree;
import org.compiere.model.MTreeNode;
import org.compiere.model.MTree_Node;
import org.compiere.model.MTree_NodeBP;
import org.compiere.model.MTree_NodeMM;
import org.compiere.model.MTree_NodePR;
import org.compiere.swing.CButton;
import org.compiere.swing.CCheckBox;
import org.compiere.swing.CComboBox;
import org.compiere.swing.CLabel;
import org.compiere.swing.CPanel;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
import org.compiere.util.Env;
import org.compiere.util.KeyNamePair;
import org.compiere.util.Msg;
/** /**
* Tree Maintenance * Tree Maintenance
@ -207,33 +233,26 @@ public class VTreeMaintenance extends CPanel
log.config(sql); log.config(sql);
// //
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
{ {
ListItem item = new ListItem(rs.getInt(1), rs.getString(2), ListItem item = new ListItem(rs.getInt(1), rs.getString(2),
rs.getString(3), "Y".equals(rs.getString(4)), rs.getString(5)); rs.getString(3), "Y".equals(rs.getString(4)), rs.getString(5));
model.addElement(item); model.addElement(item);
} }
rs.close (); }
pstmt.close ();
pstmt = null;
}
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
// List // List
log.config("#" + model.getSize()); log.config("#" + model.getSize());