midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-751 Zk: WAssignmentEditor leak database statement object.

This commit is contained in:
Heng Sin Low 2013-03-16 00:16:37 +08:00
parent 63d373c71f
commit a1c61ee9a8
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WAssignmentEditor.java
View File

@ -30,13 +30,19 @@ import org.zkoss.zk.ui.event.Events;
public class WAssignmentEditor extends WEditor implements ContextMenuListener { public class WAssignmentEditor extends WEditor implements ContextMenuListener {
private static final String RETRIEVE_RESOURCE_ASSIGNMENT_SQL = "SELECT r.Name,ra.AssignDateFrom,ra.Qty,uom.UOMSymbol "
+ "FROM S_ResourceAssignment ra, S_Resource r, S_ResourceType rt, C_UOM uom "
+ "WHERE ra.S_ResourceAssignment_ID=?"
+ " AND ra.S_Resource_ID=r.S_Resource_ID"
+ " AND r.S_ResourceType_ID=rt.S_ResourceType_ID"
+ " and rt.C_UOM_ID=uom.C_UOM_ID";
private final static CLogger log = CLogger.getCLogger(WAssignmentEditor.class); private final static CLogger log = CLogger.getCLogger(WAssignmentEditor.class);
private static final String[] LISTENER_EVENTS = {Events.ON_CLICK}; private static final String[] LISTENER_EVENTS = {Events.ON_CLICK};
private boolean m_readWrite; private boolean m_readWrite;
private Object m_value; private Object m_value;
private PreparedStatement m_pstmt;
private DateFormat m_dateFormat = DisplayType.getDateFormat(DisplayType.DateTime); private DateFormat m_dateFormat = DisplayType.getDateFormat(DisplayType.DateTime);
private NumberFormat m_qtyFormat = DisplayType.getNumberFormat(DisplayType.Quantity); private NumberFormat m_qtyFormat = DisplayType.getNumberFormat(DisplayType.Quantity);
@ -105,20 +111,14 @@ public class WAssignmentEditor extends WEditor implements ContextMenuListener {
return; return;
} }
// Statement
if (m_pstmt == null)
m_pstmt = DB.prepareStatement("SELECT r.Name,ra.AssignDateFrom,ra.Qty,uom.UOMSymbol "
+ "FROM S_ResourceAssignment ra, S_Resource r, S_ResourceType rt, C_UOM uom "
+ "WHERE ra.S_ResourceAssignment_ID=?"
+ " AND ra.S_Resource_ID=r.S_Resource_ID"
+ " AND r.S_ResourceType_ID=rt.S_ResourceType_ID"
+ " and rt.C_UOM_ID=uom.C_UOM_ID", null);
// //
ResultSet rs = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
m_pstmt.setInt(1, S_ResourceAssignment_ID); pstmt = DB.prepareStatement(RETRIEVE_RESOURCE_ASSIGNMENT_SQL, null);
rs = m_pstmt.executeQuery(); pstmt.setInt(1, S_ResourceAssignment_ID);
rs = pstmt.executeQuery();
if (rs.next()) if (rs.next())
{ {
StringBuilder sb = new StringBuilder(rs.getString(1)); StringBuilder sb = new StringBuilder(rs.getString(1));
@ -136,7 +136,7 @@ public class WAssignmentEditor extends WEditor implements ContextMenuListener {
} }
finally finally
{ {
DB.close(rs); DB.close(rs, pstmt);
} }
} }