midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-1616 reversing of reconciled payments makes database inconsistent

This commit is contained in:
Carlos Ruiz 2015-02-04 11:38:55 -05:00
parent 050d1ccba0
commit a003c83177
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
org.adempiere.base/src/org/compiere/model/MPayment.java
View File

@ -2599,9 +2599,6 @@ public class MPayment extends X_C_Payment
} }
MPeriod.testPeriodOpen(getCtx(), dateAcct, getC_DocType_ID(), getAD_Org_ID()); MPeriod.testPeriodOpen(getCtx(), dateAcct, getC_DocType_ID(), getAD_Org_ID());
// Auto Reconcile if not on Bank Statement
boolean reconciled = getC_BankStatementLine_ID() == 0; //AZ Goodwill
// Create Reversal // Create Reversal
MPayment reversal = new MPayment (getCtx(), 0, get_TrxName()); MPayment reversal = new MPayment (getCtx(), 0, get_TrxName());
copyValues(this, reversal); copyValues(this, reversal);
@ -2620,7 +2617,7 @@ public class MPayment extends X_C_Payment
reversal.setOverUnderAmt(getOverUnderAmt().negate()); reversal.setOverUnderAmt(getOverUnderAmt().negate());
// //
reversal.setIsAllocated(true); reversal.setIsAllocated(true);
reversal.setIsReconciled(reconciled); // to put on bank statement reversal.setIsReconciled(false);
reversal.setIsOnline(false); reversal.setIsOnline(false);
reversal.setIsApproved(true); reversal.setIsApproved(true);
reversal.setR_PnRef(null); reversal.setR_PnRef(null);
@ -2650,7 +2647,6 @@ public class MPayment extends X_C_Payment
// Unlink & De-Allocate // Unlink & De-Allocate
deAllocate(accrual); deAllocate(accrual);
setIsReconciled (reconciled);
setIsAllocated (true); // the allocation below is overwritten setIsAllocated (true); // the allocation below is overwritten
// Set Status // Set Status
addDescription("(" + reversal.getDocumentNo() + "<-)"); addDescription("(" + reversal.getDocumentNo() + "<-)");