midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*BF [ 1874419 ] JDBC Statement not close in a finally block 

*Organize imports
This commit is contained in:
Redhuan D. Oon 2008-02-08 19:33:21 +00:00
parent 02b352fdb4
commit 9a9eeda926
1 changed files with 26 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
base/src/org/compiere/model/MAlertProcessor.java
View File

@ -16,10 +16,15 @@
*****************************************************************************/ *****************************************************************************/
package org.compiere.model; package org.compiere.model;
import java.sql.*; import java.sql.PreparedStatement;
import java.util.*; import java.sql.ResultSet;
import java.util.logging.*; import java.sql.Timestamp;
import org.compiere.util.*; import java.util.ArrayList;
import java.util.Properties;
import java.util.logging.Level;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
/** /**
@ -41,29 +46,22 @@ public class MAlertProcessor extends X_AD_AlertProcessor
ArrayList<MAlertProcessor> list = new ArrayList<MAlertProcessor>(); ArrayList<MAlertProcessor> list = new ArrayList<MAlertProcessor>();
String sql = "SELECT * FROM AD_AlertProcessor WHERE IsActive='Y'"; String sql = "SELECT * FROM AD_AlertProcessor WHERE IsActive='Y'";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
list.add (new MAlertProcessor (ctx, rs, null)); list.add (new MAlertProcessor (ctx, rs, null));
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
s_log.log(Level.SEVERE, sql, e); s_log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
MAlertProcessor[] retValue = new MAlertProcessor[list.size ()]; MAlertProcessor[] retValue = new MAlertProcessor[list.size ()];
list.toArray (retValue); list.toArray (retValue);
@ -132,30 +130,23 @@ public class MAlertProcessor extends X_AD_AlertProcessor
+ "WHERE AD_AlertProcessor_ID=? " + "WHERE AD_AlertProcessor_ID=? "
+ "ORDER BY Created DESC"; + "ORDER BY Created DESC";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
pstmt.setInt (1, getAD_AlertProcessor_ID()); pstmt.setInt (1, getAD_AlertProcessor_ID());
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
list.add (new MAlertProcessorLog (getCtx(), rs, null)); list.add (new MAlertProcessorLog (getCtx(), rs, null));
rs.close (); }
pstmt.close ();
pstmt = null;
}
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
MAlertProcessorLog[] retValue = new MAlertProcessorLog[list.size ()]; MAlertProcessorLog[] retValue = new MAlertProcessorLog[list.size ()];
list.toArray (retValue); list.toArray (retValue);
@ -191,30 +182,23 @@ public class MAlertProcessor extends X_AD_AlertProcessor
+ "WHERE AD_AlertProcessor_ID=?"; + "WHERE AD_AlertProcessor_ID=?";
ArrayList<MAlert> list = new ArrayList<MAlert>(); ArrayList<MAlert> list = new ArrayList<MAlert>();
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
pstmt.setInt (1, getAD_AlertProcessor_ID()); pstmt.setInt (1, getAD_AlertProcessor_ID());
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
list.add (new MAlert (getCtx(), rs, null)); list.add (new MAlert (getCtx(), rs, null));
rs.close (); }
pstmt.close ();
pstmt = null;
}
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
// //
m_alerts = new MAlert[list.size ()]; m_alerts = new MAlert[list.size ()];