IDEMPIERE-6329 Bug in BOM* SQL functions not getting the correct BOM children (#2586)

- fix as suggested by Vitor Santos at mattermost

db/oracle/functions/BOM_PriceLimit.sql

@@ -24,10 +24,10 @@ AS
 	CURSOR CUR_BOM IS
 		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=Product_ID
 		  AND b.M_ProductBOM_ID != Product_ID
-		  AND p.IsVerified='Y'
+		  AND (p.IsBOM='N' OR p.IsVerified='Y')
 		  AND b.IsActive='Y';
 	--
 BEGIN

db/oracle/functions/BOM_PriceList.sql

@@ -24,10 +24,10 @@ AS
 	CURSOR CUR_BOM IS
 		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=Product_ID
 		  AND b.M_ProductBOM_ID != Product_ID
-		  AND p.IsVerified='Y'
+		  AND (p.IsBOM='N' OR p.IsVerified='Y')
 		  AND b.IsActive='Y';
 	--
 BEGIN

db/oracle/functions/BOM_PriceStd.sql

@@ -24,10 +24,10 @@ AS
 	CURSOR CUR_BOM IS
 		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=Product_ID
 		  AND b.M_ProductBOM_ID != Product_ID
-		  AND p.IsVerified='Y'
+		  AND (p.IsBOM='N' OR p.IsVerified='Y')
 		  AND b.IsActive='Y';
 	--
 BEGIN

db/oracle/functions/BOM_Qty_OnHand.sql

@@ -23,13 +23,11 @@ AS
 	StdPrecision	NUMBER;
 	--	Get BOM Product info
 	CURSOR CUR_BOM IS
-		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=Product_ID
 		  AND b.M_ProductBOM_ID != Product_ID
-		  AND p.IsBOM='Y'
-		  AND p.IsVerified='Y'
 		  AND b.IsActive='Y';
 	--
 BEGIN
@@ -87,19 +85,14 @@ BEGIN
 			FROM 	M_Storageonhand s
 			  JOIN M_Locator l ON (s.M_Locator_ID=l.M_Locator_ID)
 			WHERE s.M_Product_ID=bom.M_ProductBOM_ID AND l.M_Warehouse_ID=myWarehouse_ID;
-			--	Get Rounding Precision
-			SELECT 	NVL(MAX(u.StdPrecision), 0)
-			  INTO	StdPrecision
-			FROM 	C_UOM u, M_PRODUCT p
-			WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=bom.M_ProductBOM_ID;
 			--	How much can we make with this product
-			ProductQty := ROUND (ProductQty/bom.BOMQty, StdPrecision);
+			ProductQty := ProductQty/bom.BOMQty;
 			--	How much can we make overall
 			IF (ProductQty < Quantity) THEN
 				Quantity := ProductQty;
 			END IF;
 		--	Another BOM
-		ELSIF (bom.IsBOM = 'Y') THEN
+		ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
 			ProductQty := Bomqtyonhand (bom.M_ProductBOM_ID, myWarehouse_ID, Locator_ID);
 			--	How much can we make overall
 			IF (ProductQty < Quantity) THEN
@@ -115,7 +108,7 @@ BEGIN
 		FROM 	C_UOM u, M_PRODUCT p
 		WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=Product_ID;
 		--
-		RETURN ROUND (Quantity, StdPrecision);
+		RETURN TRUNC(Quantity, StdPrecision); -- RoundDown
 	END IF;
 	RETURN 0;
 END Bomqtyonhand;

db/oracle/functions/BOM_Qty_OnHandForReservation.sql

@@ -23,13 +23,11 @@ AS
 	StdPrecision	NUMBER;
 	--	Get BOM Product info
 	CURSOR CUR_BOM IS
-		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=Product_ID
 		  AND b.M_ProductBOM_ID != Product_ID
-		  AND p.IsBOM='Y'
-		  AND p.IsVerified='Y'
 		  AND b.IsActive='Y';
 	--
 BEGIN
@@ -90,20 +88,15 @@ BEGIN
 			  JOIN M_Locator l ON (s.M_Locator_ID=l.M_Locator_ID)
 			  LEFT JOIN M_LocatorType lt ON (l.M_LocatorType_ID=lt.M_LocatorType_ID)
 			WHERE s.M_Product_ID=bom.M_ProductBOM_ID AND l.M_Warehouse_ID=myWarehouse_ID
-			  AND COALESCE(lt.IsAvailableForReservation,'Y')='Y';
+                          AND COALESCE(lt.IsAvailableForReservation,'Y')='Y';
-			--	Get Rounding Precision
-			SELECT 	NVL(MAX(u.StdPrecision), 0)
-			  INTO	StdPrecision
-			FROM 	C_UOM u, M_PRODUCT p
-			WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=bom.M_ProductBOM_ID;
 			--	How much can we make with this product
-			ProductQty := ROUND (ProductQty/bom.BOMQty, StdPrecision);
+			ProductQty := ProductQty/bom.BOMQty;
 			--	How much can we make overall
 			IF (ProductQty < Quantity) THEN
 				Quantity := ProductQty;
 			END IF;
 		--	Another BOM
-		ELSIF (bom.IsBOM = 'Y') THEN
+		ELSIF (bom.IsBOM = 'Y' AND bom.IsVerified = 'Y') THEN
 			ProductQty := BomqtyonhandForReservation (bom.M_ProductBOM_ID, myWarehouse_ID, Locator_ID);
 			--	How much can we make overall
 			IF (ProductQty < Quantity) THEN
@@ -119,7 +112,7 @@ BEGIN
 		FROM 	C_UOM u, M_PRODUCT p
 		WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=Product_ID;
 		--
-		RETURN ROUND (Quantity, StdPrecision);
+		RETURN TRUNC(Quantity, StdPrecision); -- RoundDown
 	END IF;
 	RETURN 0;
 END BOMQTYONHANDFORRESERVATION;

db/oracle/functions/BOM_Qty_Ordered.sql

@@ -23,13 +23,11 @@ AS
 	v_StdPrecision		NUMBER;
 	--	Get BOM Product info
 	CURSOR CUR_BOM IS
-		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=p_Product_ID
 		  AND b.M_ProductBOM_ID != p_Product_ID
-		  AND p.IsBOM='Y'
-		  AND p.IsVerified='Y'
 		  AND b.IsActive='Y';
 	--
 BEGIN
@@ -91,19 +89,14 @@ BEGIN
 			  AND M_Warehouse_ID=v_Warehouse_ID
 			  AND IsSOTrx='N'
 			  AND IsActive='Y';
-			--	Get Rounding Precision
-			SELECT 	NVL(MAX(u.StdPrecision), 0)
-			  INTO	v_StdPrecision
-			FROM 	C_UOM u, M_PRODUCT p
-			WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=bom.M_ProductBOM_ID;
 			--	How much can we make with this product
-			v_ProductQty := ROUND (v_ProductQty/bom.BOMQty, v_StdPrecision);
+			v_ProductQty := v_ProductQty/bom.BOMQty;
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
 				v_Quantity := v_ProductQty;
 			END IF;
 		--	Another BOM
-		ELSIF (bom.IsBOM = 'Y') THEN
+		ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
 			v_ProductQty := Bomqtyordered (bom.M_ProductBOM_ID, v_Warehouse_ID, p_Locator_ID);
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
@@ -124,7 +117,7 @@ BEGIN
 		FROM 	C_UOM u, M_PRODUCT p
 		WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=p_Product_ID;
 		--
-		RETURN ROUND (v_Quantity, v_StdPrecision);
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
 	END IF;
 	--
 	RETURN 0;

db/oracle/functions/BOM_Qty_Reserved.sql

@@ -23,13 +23,11 @@ AS
 	v_StdPrecision		NUMBER;
 	--	Get BOM Product info
 	CURSOR CUR_BOM IS
-		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=p_Product_ID
 		  AND b.M_ProductBOM_ID != p_Product_ID
-		  AND p.IsBOM='Y'
-		  AND p.IsVerified='Y'
 		  AND b.IsActive='Y';
 	--
 BEGIN
@@ -91,19 +89,14 @@ BEGIN
 			  AND M_Warehouse_ID=v_Warehouse_ID
 			  AND IsSOTrx='Y'
 			  AND IsActive='Y';
-			--	Get Rounding Precision
-			SELECT 	NVL(MAX(u.StdPrecision), 0)
-			  INTO	v_StdPrecision
-			FROM 	C_UOM u, M_PRODUCT p
-			WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=bom.M_ProductBOM_ID;
 			--	How much can we make with this product
-			v_ProductQty := ROUND (v_ProductQty/bom.BOMQty, v_StdPrecision);
+			v_ProductQty := v_ProductQty/bom.BOMQty;
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
 				v_Quantity := v_ProductQty;
 			END IF;
 		--	Another BOM
-		ELSIF (bom.IsBOM = 'Y') THEN
+		ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
 			v_ProductQty := Bomqtyreserved (bom.M_ProductBOM_ID, v_Warehouse_ID, p_Locator_ID);
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
@@ -124,7 +117,7 @@ BEGIN
 		FROM 	C_UOM u, M_PRODUCT p
 		WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=p_Product_ID;
 		--
-		RETURN ROUND (v_Quantity, v_StdPrecision);
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
 	END IF;
 	RETURN 0;
 END Bomqtyreserved;

db/postgresql/functions/BOM_PriceLimit.sql

@@ -17,10 +17,10 @@ BEGIN
 		FOR bom IN  
 			SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
 			FROM M_Product_BOM b, M_Product p
-			WHERE b.M_Product_ID=p.M_Product_ID
+			WHERE b.M_ProductBOM_ID=p.M_Product_ID
 			AND b.M_Product_ID=Product_ID
 			AND b.M_ProductBOM_ID != Product_ID
-			AND p.IsVerified='Y'
+			AND (p.IsBOM='N' OR p.IsVerified='Y')
 			AND b.IsActive='Y'
 		LOOP
 			v_ProductPrice := bomPriceLimit (bom.M_ProductBOM_ID, PriceList_Version_ID);

db/postgresql/functions/BOM_PriceList.sql

@@ -17,10 +17,10 @@ BEGIN
 		FOR bom IN  
 			SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
 			FROM M_Product_BOM b, M_Product p
-			WHERE b.M_Product_ID=p.M_Product_ID
+			WHERE b.M_ProductBOM_ID=p.M_Product_ID
 			AND b.M_Product_ID=Product_ID
 			AND b.M_ProductBOM_ID != Product_ID
-			AND p.IsVerified='Y'
+			AND (p.IsBOM='N' OR p.IsVerified='Y')
 			AND b.IsActive='Y'
 		LOOP
 			v_ProductPrice := bomPriceList (bom.M_ProductBOM_ID, PriceList_Version_ID);

db/postgresql/functions/BOM_PriceStd.sql

@@ -17,10 +17,10 @@ BEGIN
 		FOR bom IN  
 			SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
 			FROM M_Product_BOM b, M_Product p
-			WHERE b.M_Product_ID=p.M_Product_ID
+			WHERE b.M_ProductBOM_ID=p.M_Product_ID
 			AND b.M_Product_ID=Product_ID
 			AND b.M_ProductBOM_ID != Product_ID
-			AND p.IsVerified='Y'
+			AND (p.IsBOM='N' OR p.IsVerified='Y')
 			AND b.IsActive='Y'
 		LOOP
 			v_ProductPrice := bomPriceStd (bom.M_ProductBOM_ID, PriceList_Version_ID);

db/postgresql/functions/BOM_Qty_OnHand.sql

@@ -54,13 +54,11 @@ BEGIN
 
 	--	Go through BOM
 	FOR bom IN 	--	Get BOM Product info
-		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=product_ID
 		  AND b.M_ProductBOM_ID != Product_ID
-		  AND p.IsBOM='Y'
-		  AND p.IsVerified='Y'
 		  AND b.IsActive='Y'
 	LOOP
 		--	Stocked Items "leaf node"
@@ -71,19 +69,14 @@ BEGIN
 			FROM 	M_Storageonhand s
 			  JOIN M_Locator l ON (s.M_Locator_ID=l.M_Locator_ID)
 			WHERE s.M_Product_ID=bom.M_ProductBOM_ID AND l.M_Warehouse_ID=myWarehouse_ID;
-			--	Get Rounding Precision
-			SELECT 	COALESCE(MAX(u.StdPrecision), 0)
-			  INTO	v_StdPrecision
-			FROM 	C_UOM u, M_PRODUCT p
-			WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=bom.M_ProductBOM_ID;
 			--	How much can we make with this product
-			v_ProductQty := ROUND (v_ProductQty/bom.BOMQty, v_StdPrecision);
+			v_ProductQty := v_ProductQty/bom.BOMQty;
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
 				v_Quantity := v_ProductQty;
 			END IF;
 		--	Another BOM
-		ELSIF (bom.IsBOM = 'Y') THEN
+        ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
 			v_ProductQty := Bomqtyonhand (bom.M_ProductBOM_ID, myWarehouse_ID, Locator_ID);
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
@@ -99,7 +92,7 @@ BEGIN
 		FROM 	C_UOM u, M_PRODUCT p
 		WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=Product_ID;
 		--
-		RETURN ROUND (v_Quantity, v_StdPrecision);
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
 	END IF;
 	RETURN 0;
 END;

db/postgresql/functions/BOM_Qty_OnHandForReservation.sql

@@ -56,13 +56,11 @@ BEGIN
 
 	--	Go through BOM
 	FOR bom IN 	--	Get BOM Product info
-		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=product_ID
 		  AND b.M_ProductBOM_ID != Product_ID
-		  AND p.IsBOM='Y'
-		  AND p.IsVerified='Y'
 		  AND b.IsActive='Y'
 	LOOP
 		--	Stocked Items "leaf node"
@@ -75,19 +73,14 @@ BEGIN
 		  	  LEFT JOIN M_LocatorType lt ON (l.M_LocatorType_ID=lt.M_LocatorType_ID)
 			WHERE s.M_Product_ID=bom.M_ProductBOM_ID AND l.M_Warehouse_ID=myWarehouse_ID
 		  	  AND COALESCE(lt.IsAvailableForReservation,'Y')='Y';
-			--	Get Rounding Precision
-			SELECT 	COALESCE(MAX(u.StdPrecision), 0)
-			  INTO	v_StdPrecision
-			FROM 	C_UOM u, M_PRODUCT p
-			WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=bom.M_ProductBOM_ID;
 			--	How much can we make with this product
-			v_ProductQty := ROUND (v_ProductQty/bom.BOMQty, v_StdPrecision);
+			v_ProductQty := v_ProductQty/bom.BOMQty;
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
 				v_Quantity := v_ProductQty;
 			END IF;
 		--	Another BOM
-		ELSIF (bom.IsBOM = 'Y') THEN
+		ELSIF (bom.IsBOM = 'Y' AND bom.IsVerified = 'Y') THEN
 			v_ProductQty := BOMQtyOnHandForReservation (bom.M_ProductBOM_ID, myWarehouse_ID, Locator_ID);
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
@@ -103,7 +96,7 @@ BEGIN
 		FROM 	C_UOM u, M_PRODUCT p
 		WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=Product_ID;
 		--
-		RETURN ROUND (v_Quantity, v_StdPrecision);
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
 	END IF;
 	RETURN 0;
 END;

db/postgresql/functions/BOM_Qty_Ordered.sql

@@ -57,13 +57,11 @@ BEGIN
 	--	Go though BOM
 	FOR bom IN  		
 	--	Get BOM Product info
-		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=p_Product_ID
 		  AND b.M_ProductBOM_ID != p_Product_ID
-		  AND p.IsBOM='Y'
-		  AND p.IsVerified='Y'
 		  AND b.IsActive='Y'
 	LOOP
 		--	Stocked Items "leaf node"
@@ -76,20 +74,15 @@ BEGIN
 			  AND M_Warehouse_ID=v_Warehouse_ID
 			  AND IsSOTrx='N'
 			  AND IsActive='Y';
-			--	Get Rounding Precision
-			SELECT 	COALESCE(MAX(u.StdPrecision), 0)
-			  INTO	v_StdPrecision
-			FROM 	C_UOM u, M_PRODUCT p
-			WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=bom.M_ProductBOM_ID;
 			--	How much can we make with this product
-			v_ProductQty := ROUND (v_ProductQty/bom.BOMQty, v_StdPrecision );
+			v_ProductQty := v_ProductQty/bom.BOMQty;
 
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
 				v_Quantity := v_ProductQty;
 			END IF;
 		--	Another BOM
-		ELSIF (bom.IsBOM = 'Y') THEN
+		ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
 			v_ProductQty := Bomqtyordered (bom.M_ProductBOM_ID, v_Warehouse_ID, p_Locator_ID);
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
@@ -110,7 +103,7 @@ BEGIN
 		FROM 	C_UOM u, M_PRODUCT p
 		WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=p_Product_ID;
 		--
-		RETURN ROUND (v_Quantity, v_StdPrecision );
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
 	END IF;
 	--
 	RETURN 0;

db/postgresql/functions/BOM_Qty_Reserved.sql

@@ -57,13 +57,11 @@ BEGIN
 	--	Go though BOM
 	FOR bom IN 
 	--	Get BOM Product info
-		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
 		FROM M_PRODUCT_BOM b, M_PRODUCT p
-		WHERE b.M_Product_ID=p.M_Product_ID
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
 		  AND b.M_Product_ID=p_Product_ID
 		  AND b.M_ProductBOM_ID != p_Product_ID
-		  AND p.IsBOM='Y'
-		  AND p.IsVerified='Y'
 		  AND b.IsActive='Y'
 	LOOP
 		--	Stocked Items "leaf node"
@@ -76,19 +74,14 @@ BEGIN
 			  AND   M_Warehouse_ID =v_Warehouse_ID
 			  AND	IsSOTrx='Y'
 			  AND	IsActive='Y';
-			--	Get Rounding Precision
-			SELECT 	COALESCE(MAX(u.StdPrecision), 0)
-			  INTO	v_StdPrecision
-			FROM 	C_UOM u, M_PRODUCT p
-			WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=bom.M_ProductBOM_ID;
 			--	How much can we make with this product
-			v_ProductQty := ROUND (v_ProductQty/bom.BOMQty, v_StdPrecision);
+			v_ProductQty := v_ProductQty/bom.BOMQty;
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
 				v_Quantity := v_ProductQty;
 			END IF;
 		--	Another BOM
-		ELSIF (bom.IsBOM = 'Y') THEN
+		ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
 			v_ProductQty := Bomqtyreserved (bom.M_ProductBOM_ID, v_Warehouse_ID, p_Locator_ID);
 			--	How much can we make overall
 			IF (v_ProductQty < v_Quantity) THEN
@@ -109,7 +102,7 @@ BEGIN
 		FROM 	C_UOM u, M_PRODUCT p
 		WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=p_Product_ID;
 		--
-		RETURN ROUND (v_Quantity, v_StdPrecision);
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
 	END IF;
 	RETURN 0;
 END;

migration/iD11/postgresql/202412091327_IDEMPIERE-6329.sql

@@ -0,0 +1,548 @@
+-- IDEMPIERE-6329 Bug in BOM* SQL functions not getting the correct BOM children
+SELECT register_migration_script('202412091327_IDEMPIERE-6329.sql') FROM dual;
+
+CREATE OR REPLACE FUNCTION bompricelimit (in product_id numeric, in pricelist_version_id numeric) RETURNS numeric AS
+$BODY$
+DECLARE
+	v_Price	NUMERIC;
+	v_ProductPrice	NUMERIC;
+	bom RECORD;
+
+BEGIN
+	--	Try to get price from PriceList directly
+	SELECT	COALESCE (SUM(PriceLimit), 0)
+      	INTO	v_Price
+   	FROM	M_ProductPrice
+	WHERE IsActive='Y' AND M_PriceList_Version_ID=PriceList_Version_ID AND M_Product_ID=Product_ID;
+
+	--	No Price - Check if BOM
+	IF (v_Price = 0) THEN
+		FOR bom IN  
+			SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
+			FROM M_Product_BOM b, M_Product p
+			WHERE b.M_ProductBOM_ID=p.M_Product_ID
+			AND b.M_Product_ID=Product_ID
+			AND b.M_ProductBOM_ID != Product_ID
+			AND (p.IsBOM='N' OR p.IsVerified='Y')
+			AND b.IsActive='Y'
+		LOOP
+			v_ProductPrice := bomPriceLimit (bom.M_ProductBOM_ID, PriceList_Version_ID);
+			v_Price := v_Price + (bom.BOMQty * v_ProductPrice);
+		END LOOP;
+	END IF;
+	--
+	RETURN v_Price;
+	
+END;
+$BODY$
+LANGUAGE 'plpgsql' STABLE
+;
+
+CREATE OR REPLACE FUNCTION bompricelist (in product_id numeric, in pricelist_version_id numeric) RETURNS numeric AS
+$BODY$
+DECLARE
+	v_Price	NUMERIC;
+	v_ProductPrice	NUMERIC;
+	bom RECORD;
+
+BEGIN
+	--	Try to get price from pricelist directly
+	SELECT	COALESCE (SUM(PriceList), 0)
+	INTO	v_Price
+	FROM	M_ProductPrice
+	WHERE IsActive='Y' AND M_PriceList_Version_ID=PriceList_Version_ID AND M_Product_ID=Product_ID;
+
+	--	No Price - Check if BOM
+	IF (v_Price = 0) THEN
+		FOR bom IN  
+			SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
+			FROM M_Product_BOM b, M_Product p
+			WHERE b.M_ProductBOM_ID=p.M_Product_ID
+			AND b.M_Product_ID=Product_ID
+			AND b.M_ProductBOM_ID != Product_ID
+			AND (p.IsBOM='N' OR p.IsVerified='Y')
+			AND b.IsActive='Y'
+		LOOP
+			v_ProductPrice := bomPriceList (bom.M_ProductBOM_ID, PriceList_Version_ID);
+			v_Price := v_Price + (bom.BOMQty * v_ProductPrice);
+		END LOOP;
+	END IF;
+	--
+	RETURN v_Price;
+	
+END;
+$BODY$
+LANGUAGE 'plpgsql' STABLE
+;
+
+CREATE OR REPLACE FUNCTION bompricestd (in product_id numeric, in pricelist_version_id numeric) RETURNS numeric AS
+$BODY$
+DECLARE
+	v_Price	NUMERIC;
+	v_ProductPrice	NUMERIC;
+	bom RECORD;
+
+BEGIN
+	--	Try to get price from PriceList directly
+	SELECT	COALESCE(SUM(PriceStd), 0)
+	INTO	v_Price
+	FROM	M_ProductPrice
+	WHERE IsActive='Y' AND M_PriceList_Version_ID=PriceList_Version_ID AND M_Product_ID=Product_ID;
+
+	--	No Price - Check if BOM
+	IF (v_Price = 0) THEN
+		FOR bom IN  
+			SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM
+			FROM M_Product_BOM b, M_Product p
+			WHERE b.M_ProductBOM_ID=p.M_Product_ID
+			AND b.M_Product_ID=Product_ID
+			AND b.M_ProductBOM_ID != Product_ID
+			AND (p.IsBOM='N' OR p.IsVerified='Y')
+			AND b.IsActive='Y'
+		LOOP
+			v_ProductPrice := bomPriceStd (bom.M_ProductBOM_ID, PriceList_Version_ID);
+			v_Price := v_Price + (bom.BOMQty * v_ProductPrice);
+		END LOOP;
+	END IF;
+	--
+	RETURN v_Price;
+	
+END;
+$BODY$
+LANGUAGE 'plpgsql' STABLE
+;
+
+CREATE OR REPLACE FUNCTION BOMQtyOnHandForReservation (in product_id numeric, in warehouse_id numeric, in locator_id numeric) RETURNS numeric AS
+$BODY$
+DECLARE
+	myWarehouse_ID		numeric;
+ 	v_Quantity		numeric := 99999;	--	unlimited
+	v_IsBOM			CHAR(1);
+	v_IsStocked		CHAR(1);
+	v_ProductType		CHAR(1);
+ 	v_ProductQty		numeric;
+	v_StdPrecision		int;
+	bom			record;
+	
+BEGIN
+	--	Check Parameters
+	myWarehouse_ID := Warehouse_ID;
+	IF (myWarehouse_ID IS NULL) THEN
+		IF (Locator_ID IS NULL) THEN
+			RETURN 0;
+		ELSE
+			SELECT 	SUM(M_Warehouse_ID) INTO myWarehouse_ID
+			FROM	M_LOCATOR
+			WHERE	M_Locator_ID=Locator_ID;
+		END IF;
+	END IF;
+	IF (myWarehouse_ID IS NULL) THEN
+		RETURN 0;
+	END IF;
+
+	--	Check, if product exists and if it is stocked
+	BEGIN
+		SELECT	IsBOM, ProductType, IsStocked
+	 	  INTO	v_IsBOM, v_ProductType, v_IsStocked
+		FROM M_PRODUCT
+		WHERE M_Product_ID=Product_ID;
+		--
+	EXCEPTION	--	not found
+		WHEN OTHERS THEN
+			RETURN 0;
+	END;
+	--	Unlimited capacity if no item
+	IF (v_IsBOM='N' AND (v_ProductType<>'I' OR v_IsStocked='N')) THEN
+		RETURN v_Quantity;
+	--	Stocked item
+	ELSIF (v_IsStocked='Y') THEN
+		--	Get ProductQty
+		SELECT 	COALESCE(SUM(QtyOnHand), 0)
+		  INTO	v_ProductQty
+		FROM 	M_Storageonhand s
+		  JOIN M_Locator l ON (s.M_Locator_ID=l.M_Locator_ID)
+		  LEFT JOIN M_LocatorType lt ON (l.M_LocatorType_ID=lt.M_LocatorType_ID)
+		WHERE s.M_Product_ID=Product_ID AND l.M_Warehouse_ID=myWarehouse_ID
+		  AND COALESCE(lt.IsAvailableForReservation,'Y')='Y';
+		--
+		RETURN v_ProductQty;
+	END IF;
+
+	--	Go through BOM
+	FOR bom IN 	--	Get BOM Product info
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
+		FROM M_PRODUCT_BOM b, M_PRODUCT p
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
+		  AND b.M_Product_ID=product_ID
+		  AND b.M_ProductBOM_ID != Product_ID
+		  AND b.IsActive='Y'
+	LOOP
+		--	Stocked Items "leaf node"
+		IF (bom.ProductType = 'I' AND bom.IsStocked = 'Y') THEN
+			--	Get v_ProductQty
+			SELECT 	COALESCE(SUM(QtyOnHand), 0)
+			  INTO	v_ProductQty
+			FROM 	M_Storageonhand s
+			  JOIN M_Locator l ON (s.M_Locator_ID=l.M_Locator_ID)
+		  	  LEFT JOIN M_LocatorType lt ON (l.M_LocatorType_ID=lt.M_LocatorType_ID)
+			WHERE s.M_Product_ID=bom.M_ProductBOM_ID AND l.M_Warehouse_ID=myWarehouse_ID
+		  	  AND COALESCE(lt.IsAvailableForReservation,'Y')='Y';
+			--	How much can we make with this product
+			v_ProductQty := v_ProductQty/bom.BOMQty;
+			--	How much can we make overall
+			IF (v_ProductQty < v_Quantity) THEN
+				v_Quantity := v_ProductQty;
+			END IF;
+		--	Another BOM
+		ELSIF (bom.IsBOM = 'Y' AND bom.IsVerified = 'Y') THEN
+			v_ProductQty := BOMQtyOnHandForReservation (bom.M_ProductBOM_ID, myWarehouse_ID, Locator_ID);
+			--	How much can we make overall
+			IF (v_ProductQty < v_Quantity) THEN
+				v_Quantity := v_ProductQty;
+			END IF;
+		END IF;
+	END LOOP;	--	BOM
+
+	IF (v_Quantity > 0) THEN
+		--	Get Rounding Precision for Product
+		SELECT 	COALESCE(MAX(u.StdPrecision), 0)
+		  INTO	v_StdPrecision
+		FROM 	C_UOM u, M_PRODUCT p
+		WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=Product_ID;
+		--
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
+	END IF;
+	RETURN 0;
+END;
+$BODY$
+LANGUAGE 'plpgsql' STABLE
+;
+
+CREATE OR REPLACE FUNCTION BOMQtyOnHand (in product_id numeric, in warehouse_id numeric, in locator_id numeric) RETURNS numeric AS
+$BODY$
+DECLARE
+	myWarehouse_ID		numeric;
+ 	v_Quantity		numeric := 99999;	--	unlimited
+	v_IsBOM			CHAR(1);
+	v_IsStocked		CHAR(1);
+	v_ProductType		CHAR(1);
+ 	v_ProductQty		numeric;
+	v_StdPrecision		int;
+	bom			record;
+	
+BEGIN
+	--	Check Parameters
+	myWarehouse_ID := Warehouse_ID;
+	IF (myWarehouse_ID IS NULL) THEN
+		IF (Locator_ID IS NULL) THEN
+			RETURN 0;
+		ELSE
+			SELECT 	SUM(M_Warehouse_ID) INTO myWarehouse_ID
+			FROM	M_LOCATOR
+			WHERE	M_Locator_ID=Locator_ID;
+		END IF;
+	END IF;
+	IF (myWarehouse_ID IS NULL) THEN
+		RETURN 0;
+	END IF;
+
+	--	Check, if product exists and if it is stocked
+	BEGIN
+		SELECT	IsBOM, ProductType, IsStocked
+	 	  INTO	v_IsBOM, v_ProductType, v_IsStocked
+		FROM M_PRODUCT
+		WHERE M_Product_ID=Product_ID;
+		--
+	EXCEPTION	--	not found
+		WHEN OTHERS THEN
+			RETURN 0;
+	END;
+	--	Unlimited capacity if no item
+	IF (v_IsBOM='N' AND (v_ProductType<>'I' OR v_IsStocked='N')) THEN
+		RETURN v_Quantity;
+	--	Stocked item
+	ELSIF (v_IsStocked='Y') THEN
+		--	Get ProductQty
+		SELECT 	COALESCE(SUM(QtyOnHand), 0)
+		  INTO	v_ProductQty
+		FROM 	M_Storageonhand s
+		  JOIN M_Locator l ON (s.M_Locator_ID=l.M_Locator_ID)
+		WHERE s.M_Product_ID=Product_ID AND l.M_Warehouse_ID=myWarehouse_ID;
+		--
+		RETURN v_ProductQty;
+	END IF;
+
+	--	Go through BOM
+	FOR bom IN 	--	Get BOM Product info
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
+		FROM M_PRODUCT_BOM b, M_PRODUCT p
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
+		  AND b.M_Product_ID=product_ID
+		  AND b.M_ProductBOM_ID != Product_ID
+		  AND b.IsActive='Y'
+	LOOP
+		--	Stocked Items "leaf node"
+		IF (bom.ProductType = 'I' AND bom.IsStocked = 'Y') THEN
+			--	Get v_ProductQty
+			SELECT 	COALESCE(SUM(QtyOnHand), 0)
+			  INTO	v_ProductQty
+			FROM 	M_Storageonhand s
+			  JOIN M_Locator l ON (s.M_Locator_ID=l.M_Locator_ID)
+			WHERE s.M_Product_ID=bom.M_ProductBOM_ID AND l.M_Warehouse_ID=myWarehouse_ID;
+			--	How much can we make with this product
+			v_ProductQty := v_ProductQty/bom.BOMQty;
+			--	How much can we make overall
+			IF (v_ProductQty < v_Quantity) THEN
+				v_Quantity := v_ProductQty;
+			END IF;
+		--	Another BOM
+        ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
+			v_ProductQty := Bomqtyonhand (bom.M_ProductBOM_ID, myWarehouse_ID, Locator_ID);
+			--	How much can we make overall
+			IF (v_ProductQty < v_Quantity) THEN
+				v_Quantity := v_ProductQty;
+			END IF;
+		END IF;
+	END LOOP;	--	BOM
+
+	IF (v_Quantity > 0) THEN
+		--	Get Rounding Precision for Product
+		SELECT 	COALESCE(MAX(u.StdPrecision), 0)
+		  INTO	v_StdPrecision
+		FROM 	C_UOM u, M_PRODUCT p
+		WHERE u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=Product_ID;
+		--
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
+	END IF;
+	RETURN 0;
+END;
+$BODY$
+LANGUAGE 'plpgsql' STABLE
+;
+
+CREATE OR REPLACE FUNCTION bomqtyordered (in p_product_id numeric, in p_warehouse_id numeric, in p_locator_id numeric) RETURNS numeric AS
+$BODY$
+DECLARE
+	v_Warehouse_ID		numeric;
+ 	v_Quantity		numeric := 99999;	--	unlimited
+	v_IsBOM			CHAR(1);
+	v_IsStocked		CHAR(1);
+	v_ProductType		CHAR(1);
+ 	v_ProductQty		numeric;
+	v_StdPrecision		int;
+	bom 			record;	
+BEGIN
+	--	Check Parameters
+	v_Warehouse_ID := p_Warehouse_ID;
+	IF (v_Warehouse_ID IS NULL) THEN
+		IF (p_Locator_ID IS NULL) THEN
+			RETURN 0;
+		ELSE
+			SELECT 	MAX(M_Warehouse_ID) INTO v_Warehouse_ID
+			FROM	M_LOCATOR
+			WHERE	M_Locator_ID=p_Locator_ID;
+		END IF;
+	END IF;
+	IF (v_Warehouse_ID IS NULL) THEN
+		RETURN 0;
+	END IF;
+
+	--	Check, if product exists and if it is stocked
+	BEGIN
+		SELECT	IsBOM, ProductType, IsStocked
+		  INTO	v_IsBOM, v_ProductType, v_IsStocked
+		FROM 	M_PRODUCT
+		WHERE 	M_Product_ID=p_Product_ID;
+		--
+	EXCEPTION	--	not found
+		WHEN OTHERS THEN
+			RETURN 0;
+	END;
+
+	--	No reservation for non-stocked
+	IF (v_IsBOM='N' AND (v_ProductType<>'I' OR v_IsStocked='N')) THEN
+		RETURN 0;
+	--	Stocked item
+	ELSIF (v_IsStocked='Y') THEN
+		--	Get ProductQty
+		SELECT 	COALESCE(SUM(Qty), 0)
+		  INTO	v_ProductQty
+		FROM 	M_StorageReservation
+		WHERE M_Product_ID=p_Product_ID
+		  AND M_Warehouse_ID=v_Warehouse_ID
+		  AND IsSOTrx='N'
+		  AND IsActive='Y';
+		--
+		RETURN v_ProductQty;
+	END IF;
+
+	--	Go though BOM
+	FOR bom IN  		
+	--	Get BOM Product info
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
+		FROM M_PRODUCT_BOM b, M_PRODUCT p
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
+		  AND b.M_Product_ID=p_Product_ID
+		  AND b.M_ProductBOM_ID != p_Product_ID
+		  AND b.IsActive='Y'
+	LOOP
+		--	Stocked Items "leaf node"
+		IF (bom.ProductType = 'I' AND bom.IsStocked = 'Y') THEN
+			--	Get ProductQty
+			SELECT 	COALESCE(SUM(Qty), 0)
+			  INTO	v_ProductQty
+			FROM 	M_StorageReservation
+			WHERE M_Product_ID=p_Product_ID
+			  AND M_Warehouse_ID=v_Warehouse_ID
+			  AND IsSOTrx='N'
+			  AND IsActive='Y';
+			--	How much can we make with this product
+			v_ProductQty := v_ProductQty/bom.BOMQty;
+
+			--	How much can we make overall
+			IF (v_ProductQty < v_Quantity) THEN
+				v_Quantity := v_ProductQty;
+			END IF;
+		--	Another BOM
+		ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
+			v_ProductQty := Bomqtyordered (bom.M_ProductBOM_ID, v_Warehouse_ID, p_Locator_ID);
+			--	How much can we make overall
+			IF (v_ProductQty < v_Quantity) THEN
+				v_Quantity := v_ProductQty;
+			END IF;
+		END IF;
+	END LOOP;	--	BOM
+
+	--	Unlimited (e.g. only services)
+	IF (v_Quantity = 99999) THEN
+		RETURN 0;
+	END IF;
+
+	IF (v_Quantity > 0) THEN
+		--	Get Rounding Precision for Product
+		SELECT 	COALESCE(MAX(u.StdPrecision), 0)
+		  INTO	v_StdPrecision
+		FROM 	C_UOM u, M_PRODUCT p
+		WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=p_Product_ID;
+		--
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
+	END IF;
+	--
+	RETURN 0;
+END;
+$BODY$
+LANGUAGE 'plpgsql' STABLE
+;
+
+CREATE OR REPLACE FUNCTION bomqtyreserved (in p_product_id numeric, in p_warehouse_id numeric, in p_locator_id numeric) RETURNS numeric AS
+$BODY$
+DECLARE
+	v_Warehouse_ID			numeric;
+ 	v_Quantity			numeric := 99999;	--	unlimited
+	v_IsBOM				CHAR(1);
+	v_IsStocked			CHAR(1);
+	v_ProductType			CHAR(1);
+ 	v_ProductQty			numeric;
+	v_StdPrecision			int;
+	bom				record;
+BEGIN
+	--	Check Parameters
+	v_Warehouse_ID := p_Warehouse_ID;
+	IF (v_Warehouse_ID IS NULL) THEN
+		IF (p_Locator_ID IS NULL) THEN
+			RETURN 0;
+		ELSE
+			SELECT 	MAX(M_Warehouse_ID) INTO v_Warehouse_ID
+			FROM	M_LOCATOR
+			WHERE	M_Locator_ID=p_Locator_ID;
+		END IF;
+	END IF;
+	IF (v_Warehouse_ID IS NULL) THEN
+		RETURN 0;
+	END IF;
+
+	--	Check, if product exists and if it is stocked
+	BEGIN
+		SELECT	IsBOM, ProductType, IsStocked
+		  INTO	v_IsBOM, v_ProductType, v_IsStocked
+		FROM M_PRODUCT
+		WHERE M_Product_ID=p_Product_ID;
+		--
+	EXCEPTION	--	not found
+		WHEN OTHERS THEN
+			RETURN 0;
+	END;
+
+	--	No reservation for non-stocked
+	IF (v_IsBOM='N' AND (v_ProductType<>'I' OR v_IsStocked='N')) THEN
+		RETURN 0;
+	--	Stocked item
+	ELSIF (v_IsStocked='Y') THEN
+		--	Get ProductQty
+		SELECT 	COALESCE(SUM(Qty), 0)
+		  INTO	v_ProductQty
+		FROM 	M_StorageReservation
+		WHERE M_Product_ID=p_Product_ID
+		  AND M_Warehouse_ID=v_Warehouse_ID
+		  AND IsSOTrx='Y'
+		  AND IsActive='Y';
+		--
+		RETURN v_ProductQty;
+	END IF;
+
+	--	Go though BOM
+	FOR bom IN 
+	--	Get BOM Product info
+		SELECT b.M_ProductBOM_ID, b.BOMQty, p.IsBOM, p.IsStocked, p.ProductType, p.IsVerified
+		FROM M_PRODUCT_BOM b, M_PRODUCT p
+		WHERE b.M_ProductBOM_ID=p.M_Product_ID
+		  AND b.M_Product_ID=p_Product_ID
+		  AND b.M_ProductBOM_ID != p_Product_ID
+		  AND b.IsActive='Y'
+	LOOP
+		--	Stocked Items "leaf node"
+		IF (bom.ProductType = 'I' AND bom.IsStocked = 'Y') THEN
+			--	Get ProductQty
+			SELECT 	COALESCE(SUM(Qty), 0)
+			  INTO	v_ProductQty
+			FROM 	M_StorageReservation
+			WHERE 	M_Product_ID=bom.M_ProductBOM_ID
+			  AND   M_Warehouse_ID =v_Warehouse_ID
+			  AND	IsSOTrx='Y'
+			  AND	IsActive='Y';
+			--	How much can we make with this product
+			v_ProductQty := v_ProductQty/bom.BOMQty;
+			--	How much can we make overall
+			IF (v_ProductQty < v_Quantity) THEN
+				v_Quantity := v_ProductQty;
+			END IF;
+		--	Another BOM
+		ELSIF (bom.IsBOM = 'Y' AND BOM.IsVerified = 'Y') THEN
+			v_ProductQty := Bomqtyreserved (bom.M_ProductBOM_ID, v_Warehouse_ID, p_Locator_ID);
+			--	How much can we make overall
+			IF (v_ProductQty < v_Quantity) THEN
+				v_Quantity := v_ProductQty;
+			END IF;
+		END IF;
+	END LOOP;	--	BOM
+
+	--	Unlimited (e.g. only services)
+	IF (v_Quantity = 99999) THEN
+		RETURN 0;
+	END IF;
+
+	IF (v_Quantity > 0) THEN
+		--	Get Rounding Precision for Product
+		SELECT 	COALESCE(MAX(u.StdPrecision), 0)
+		  INTO	v_StdPrecision
+		FROM 	C_UOM u, M_PRODUCT p
+		WHERE 	u.C_UOM_ID=p.C_UOM_ID AND p.M_Product_ID=p_Product_ID;
+		--
+		RETURN TRUNC(v_Quantity, v_StdPrecision); -- RoundDown
+	END IF;
+	RETURN 0;
+END;
+$BODY$
+LANGUAGE 'plpgsql' STABLE
+;
+

org.idempiere.test/src/org/idempiere/test/DictionaryIDs.java

@@ -510,7 +510,18 @@ public final class DictionaryIDs {
 			this.id = id;
 		}
 	}
-	
+
+	public enum M_PriceList_Version {
+		STANDARD_2003(104),
+		IMPORT_2003(200000);
+
+		public final int id;
+
+		private M_PriceList_Version(int id) {
+			this.id = id;
+		}
+	}
+
 	public enum M_Product {
 		STANDARD(122,"c713192a-9ed3-4740-ad32-9583c30d0206"),
 		OAK(123,"220b7a9a-4917-4bb2-b431-1426afacd7b8"),
@@ -572,7 +583,19 @@ public final class DictionaryIDs {
 			this.id = id;
 		}
 	}
-	
+
+	public enum M_ProductPrice {
+		PATIOSET_STANDARD_2003(200084),
+		PATIOCHAIR_STANDARD_2003(200033),
+		PATIOCHAIR_IMPORT_2003(200095);
+
+		public final int id;
+
+		private M_ProductPrice(int id) {
+			this.id = id;
+		}
+	}
+
 	public enum M_RMAType {
 		DAMAGE_ON_ARRIVAL(100);
 		

org.idempiere.test/src/org/idempiere/test/base/GetBOMFunctionsTest.java

@@ -17,7 +17,6 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.math.BigDecimal;
 
-import org.compiere.model.MProduct;
 import org.compiere.model.MProductPrice;
 import org.compiere.util.DB;
 import org.compiere.util.Env;
@@ -32,7 +31,6 @@ import org.junit.jupiter.api.parallel.Isolated;
 @Isolated
 public class GetBOMFunctionsTest extends AbstractTestCase
 {
-	private static final int PRODUCT_PRICE_PATIOSET_STANDARD_2003 = 200084;
 
 	@Test
 	public void test_getBOMFunctions() throws Exception
@@ -42,46 +40,91 @@ public class GetBOMFunctionsTest extends AbstractTestCase
 
 		// Prices of PatioSet in Standard 2003 Price List Version
 
-		price = DB.getSQLValueBDEx(trxName, "SELECT bompricestd(145, 104) FROM Dual");
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricestd("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
 		assertTrue(BigDecimal.valueOf(500.0).compareTo(price) == 0, "Unexpected direct bompricestd");
 		
-		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelist(145, 104) FROM Dual");
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelist("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
 		assertTrue(BigDecimal.valueOf(520.0).compareTo(price) == 0, "Unexpected direct bompricelist");
 
-		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelimit(145, 104) FROM Dual");
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelimit("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
 		assertTrue(BigDecimal.valueOf(496.0).compareTo(price) == 0, "Unexpected direct bompricelimit");
 
-		MProductPrice productPrice = new MProductPrice(Env.getCtx(), PRODUCT_PRICE_PATIOSET_STANDARD_2003, trxName);
+		MProductPrice productPrice = new MProductPrice(Env.getCtx(), DictionaryIDs.M_ProductPrice.PATIOSET_STANDARD_2003.id, trxName);
 		productPrice.setIsActive(false);
 		productPrice.saveEx();
 
-		price = DB.getSQLValueBDEx(trxName, "SELECT bompricestd(145, 104) FROM Dual");
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricestd("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
 		assertTrue(BigDecimal.valueOf(225.0).compareTo(price) == 0, "Unexpected indirect bompricestd");
 
-		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelist(145, 104) FROM Dual");
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelist("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
 		assertTrue(BigDecimal.valueOf(220.0).compareTo(price) == 0, "Unexpected indirect bompricelist");
 
-		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelimit(145, 104) FROM Dual");
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelimit("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
 		assertTrue(BigDecimal.valueOf(180.0).compareTo(price) == 0, "Unexpected indirect bompricelimit");
 
+		productPrice = new MProductPrice(Env.getCtx(), DictionaryIDs.M_ProductPrice.PATIOCHAIR_STANDARD_2003.id, trxName);
+		productPrice.setIsActive(false);
+		productPrice.saveEx();
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricestd("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(90.0).compareTo(price) == 0, "Unexpected double indirect bompricestd");
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelist("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(88.0).compareTo(price) == 0, "Unexpected double indirect bompricelist");
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelimit("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.STANDARD_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(72.0).compareTo(price) == 0, "Unexpected double indirect bompricelimit");
+
+		// Prices of PatioSet in Import 2003 Price List Version
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricestd("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.IMPORT_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(153.0).compareTo(price) == 0, "Unexpected indirect bompricestd");
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelist("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.IMPORT_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(170.0).compareTo(price) == 0, "Unexpected indirect bompricelist");
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelimit("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.IMPORT_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(144.52).compareTo(price) == 0, "Unexpected indirect bompricelimit");
+
+		productPrice = new MProductPrice(Env.getCtx(), DictionaryIDs.M_ProductPrice.PATIOCHAIR_IMPORT_2003.id, trxName);
+		productPrice.setIsActive(false);
+		productPrice.saveEx();
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricestd("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.IMPORT_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(84.8).compareTo(price) == 0, "Unexpected double indirect bompricestd");
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelist("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.IMPORT_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(107.36).compareTo(price) == 0, "Unexpected double indirect bompricelist");
+
+		price = DB.getSQLValueBDEx(trxName, "SELECT bompricelimit("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_PriceList_Version.IMPORT_2003.id+") FROM Dual");
+		assertTrue(BigDecimal.valueOf(77.52).compareTo(price) == 0, "Unexpected double indirect bompricelimit");
+
 		// Quantities of PatioSet in Standard 2003 Price List Version
 
 		BigDecimal qty;
-		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyavailable(145, 103, 0) FROM Dual");
+		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyavailable("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_Warehouse.HQ.id+",0) FROM Dual");
 		assertTrue(BigDecimal.valueOf(0.0).compareTo(qty) == 0, "Unexpected direct bomqtyavailable");
 
-		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyonhand(145, 103, 0) FROM Dual");
+		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyonhand("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_Warehouse.HQ.id+",0) FROM Dual");
 		assertTrue(BigDecimal.valueOf(0.0).compareTo(qty) == 0, "Unexpected direct bomqtyonhand");
 
-		MProduct product = new MProduct(Env.getCtx(), DictionaryIDs.M_Product.PATIOSET.id, trxName);
+		// Set PatioSet as non-stocked
-		product.setIsStocked(false);
+		DB.executeUpdateEx("UPDATE M_Product SET IsStocked='N' WHERE M_Product_ID=?", new Object[] {DictionaryIDs.M_Product.PATIOSET.id}, trxName);
-		product.saveEx();
 
-		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyavailable(145, 103, 0) FROM Dual");
+		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyavailable("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_Warehouse.HQ.id+",0) FROM Dual");
-		assertTrue(BigDecimal.valueOf(12.0).compareTo(qty) == 0, "Unexpected indirect bomqtyavailable");
+		assertTrue(BigDecimal.valueOf(7.0).compareTo(qty) == 0, "Unexpected indirect bomqtyavailable");
 
-		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyonhand(145, 103, 0) FROM Dual");
+		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyonhand("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_Warehouse.HQ.id+",0) FROM Dual");
-		assertTrue(BigDecimal.valueOf(12.0).compareTo(qty) == 0, "Unexpected indirect bomqtyonhand");
+		assertTrue(BigDecimal.valueOf(7.0).compareTo(qty) == 0, "Unexpected indirect bomqtyonhand");
+
+		// Set PatioChair as non-stocked, directly to avoid error about existing stock
+		DB.executeUpdateEx("UPDATE M_Product SET IsStocked='N' WHERE M_Product_ID=?", new Object[] {DictionaryIDs.M_Product.P_CHAIR.id}, trxName);
+
+		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyavailable("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_Warehouse.HQ.id+",0) FROM Dual");
+		assertTrue(BigDecimal.valueOf(0.0).compareTo(qty) == 0, "Unexpected double indirect bomqtyavailable");
+
+		qty = DB.getSQLValueBDEx(trxName, "SELECT bomqtyonhand("+DictionaryIDs.M_Product.PATIOSET.id+","+DictionaryIDs.M_Warehouse.HQ.id+",0) FROM Dual");
+		assertTrue(BigDecimal.valueOf(0.0).compareTo(qty) == 0, "Unexpected double indirect bomqtyonhand");
 
 	}