From b5a2bd6dbab6674fd66c8e5ba93ae8659e07a0d3 Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Mon, 10 Dec 2012 13:05:43 -0500
Subject: [PATCH 01/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern RV_EXCEPTION_NOT_THROWN

---
 .../src/org/compiere/process/ExpenseAPInvoice.java        | 8 ++++----
 .../src/org/compiere/process/ExpenseSOrder.java           | 2 +-
 .../org/adempiere/webui/desktop/DashboardController.java  | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/org.adempiere.base.process/src/org/compiere/process/ExpenseAPInvoice.java b/org.adempiere.base.process/src/org/compiere/process/ExpenseAPInvoice.java
index 00eb9b7034..0f642e7d99 100644
--- a/org.adempiere.base.process/src/org/compiere/process/ExpenseAPInvoice.java
+++ b/org.adempiere.base.process/src/org/compiere/process/ExpenseAPInvoice.java
@@ -142,7 +142,7 @@ public class ExpenseAPInvoice extends SvrProcess
 						.append(DisplayType.getDateFormat(DisplayType.Date).format(te.getDateReport()));  
 					invoice.setDescription(descr.toString());
 					if (!invoice.save())
-						new IllegalStateException("Cannot save Invoice");
+						throw new IllegalStateException("Cannot save Invoice");
 					old_BPartner_ID = bp.getC_BPartner_ID();
 				}
 				MTimeExpenseLine[] tel = te.getLines(false);
@@ -164,7 +164,7 @@ public class ExpenseAPInvoice extends SvrProcess
 					if (line.getC_Project_ID() != 0 && line.getC_Project_ID() != invoice.getC_Project_ID())
 						invoice.setC_Project_ID(line.getC_Project_ID());
 					if (!invoice.save())
-						new IllegalStateException("Cannot save Invoice");
+						throw new IllegalStateException("Cannot save Invoice");
 					
 					//	Create OrderLine
 					MInvoiceLine il = new MInvoiceLine (invoice);
@@ -184,7 +184,7 @@ public class ExpenseAPInvoice extends SvrProcess
 					il.setPrice(line.getPriceReimbursed());	//
 					il.setTax();
 					if (!il.save())
-						new IllegalStateException("Cannot save Invoice Line");
+						throw new IllegalStateException("Cannot save Invoice Line");
 					//	Update TEL
 					line.setC_InvoiceLine_ID(il.getC_InvoiceLine_ID());
 					line.saveEx();
@@ -221,7 +221,7 @@ public class ExpenseAPInvoice extends SvrProcess
 			
 		}
 		if (!invoice.save())
-			new IllegalStateException("Cannot save Invoice");
+			throw new IllegalStateException("Cannot save Invoice");
 		//
 		m_noInvoices++;
 		addLog(invoice.get_ID(), invoice.getDateInvoiced(), 
diff --git a/org.adempiere.base.process/src/org/compiere/process/ExpenseSOrder.java b/org.adempiere.base.process/src/org/compiere/process/ExpenseSOrder.java
index b494651fb1..70ef7e9c6e 100644
--- a/org.adempiere.base.process/src/org/compiere/process/ExpenseSOrder.java
+++ b/org.adempiere.base.process/src/org/compiere/process/ExpenseSOrder.java
@@ -216,7 +216,7 @@ public class ExpenseSOrder extends SvrProcess
 			if (tel.getC_Campaign_ID() != 0 && tel.getC_Campaign_ID() != m_order.getC_Campaign_ID())
 				m_order.setC_Campaign_ID(tel.getC_Campaign_ID());
 			if (!m_order.save())
-				new IllegalStateException("Cannot save Order");
+				throw new IllegalStateException("Cannot save Order");
 		}
 		
 		//	OrderLine
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/DashboardController.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/DashboardController.java
index d0b71bbf7e..a650e11160 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/DashboardController.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/DashboardController.java
@@ -666,7 +666,7 @@ public class DashboardController implements EventListener<Event> {
 	private ReportEngine runReport(int AD_Process_ID, String parameters) {
    		MProcess process = MProcess.get(Env.getCtx(), AD_Process_ID);
 		if (!process.isReport() || process.getAD_ReportView_ID() == 0)
-			new IllegalArgumentException("Not a Report AD_Process_ID=" + process.getAD_Process_ID()
+			 throw new IllegalArgumentException("Not a Report AD_Process_ID=" + process.getAD_Process_ID()
 				+ " - " + process.getName());
 		//	Process
 		int AD_Table_ID = 0;
@@ -681,12 +681,12 @@ public class DashboardController implements EventListener<Event> {
 		pi.setAD_Client_ID(Env.getAD_Client_ID(Env.getCtx()));
 		pi.setAD_PInstance_ID(pInstance.getAD_PInstance_ID());		
 		if (!process.processIt(pi, null) && pi.getClassName() != null) 
-			new IllegalStateException("Process failed: (" + pi.getClassName() + ") " + pi.getSummary());
+			throw new IllegalStateException("Process failed: (" + pi.getClassName() + ") " + pi.getSummary());
 	
 		//	Report
 		ReportEngine re = ReportEngine.get(Env.getCtx(), pi);
 		if (re == null)
-			new IllegalStateException("Cannot create Report AD_Process_ID=" + process.getAD_Process_ID()
+			throw new IllegalStateException("Cannot create Report AD_Process_ID=" + process.getAD_Process_ID()
 				+ " - " + process.getName());
 		
 		return re;

From 05b0af19e55450073d4bd4639c11a5cbfefaaaeb Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Mon, 10 Dec 2012 13:06:55 -0500
Subject: [PATCH 02/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

---
 .../src/org/compiere/db/CConnection.java               |  1 +
 org.adempiere.base/src/org/compiere/util/DB.java       |  3 ++-
 .../src/org/adempiere/webui/panel/RolePanel.java       |  6 +++---
 .../src/org/adempiere/webui/window/FindWindow.java     | 10 ++++++----
 .../src/org/adempiere/webui/window/WEMailDialog.java   |  4 ----
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/org.adempiere.base/src/org/compiere/db/CConnection.java b/org.adempiere.base/src/org/compiere/db/CConnection.java
index a70c267353..8a452470c9 100644
--- a/org.adempiere.base/src/org/compiere/db/CConnection.java
+++ b/org.adempiere.base/src/org/compiere/db/CConnection.java
@@ -1276,6 +1276,7 @@ public class CConnection implements Serializable, Cloneable
 	 *  @param transactionIsolation Connection transaction level
 	 *  @return Connection
 	 */
+	@SuppressWarnings("unused")
 	public Connection getConnection (boolean autoCommit, int transactionIsolation)
 	{
 		Connection conn = null;
diff --git a/org.adempiere.base/src/org/compiere/util/DB.java b/org.adempiere.base/src/org/compiere/util/DB.java
index cde5a93922..26b874d567 100644
--- a/org.adempiere.base/src/org/compiere/util/DB.java
+++ b/org.adempiere.base/src/org/compiere/util/DB.java
@@ -347,8 +347,9 @@ public final class DB
             if (conn != null)
             {
                 conn.close();
+                success = true;
             }
-            success = (conn != null);
+            else success = false;
 		}
 		catch (Exception e)
 		{
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/RolePanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/RolePanel.java
index fbaf1264b8..0542cd2da7 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/RolePanel.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/RolePanel.java
@@ -575,9 +575,9 @@ public class RolePanel extends Window implements EventListener<Event>, Deferrabl
         // Elaine 2009/02/06 save preference to AD_Preference
         UserPreference userPreference = SessionManager.getSessionApplication().getUserPreference();
         userPreference.setProperty(UserPreference.P_LANGUAGE, Env.getContext(m_ctx, UserPreference.LANGUAGE_NAME));
-        userPreference.setProperty(UserPreference.P_ROLE, lstItemRole != null ? (String) lstItemRole.getValue() : "0");
-        userPreference.setProperty(UserPreference.P_CLIENT, lstItemClient != null ? (String) lstItemClient.getValue() : "0");
-        userPreference.setProperty(UserPreference.P_ORG, lstItemOrg != null ? (String) lstItemOrg.getValue() : "0");
+        userPreference.setProperty(UserPreference.P_ROLE, (String) lstItemRole.getValue());
+        userPreference.setProperty(UserPreference.P_CLIENT, (String) lstItemClient.getValue());
+        userPreference.setProperty(UserPreference.P_ORG, (String) lstItemOrg.getValue());
         userPreference.setProperty(UserPreference.P_WAREHOUSE, lstItemWarehouse != null ? (String) lstItemWarehouse.getValue() : "0");
         userPreference.savePreference();
         //
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java
index 091e80c085..3862dfae93 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java
@@ -1302,11 +1302,13 @@ public class FindWindow extends Window implements EventListener<Event>, ValueCha
             String lBrackets = listLeftBracket.getSelectedItem().getValue().toString();
 			if ( lBrackets != null )
 				openBrackets += lBrackets.length();
+			else lBrackets = "";
 			// Right brackets
             Listbox listRightBracket = (Listbox)row.getFellow("listRightBracket"+row.getId());
             String rBrackets = listRightBracket.getSelectedItem().getValue().toString();
 			if ( rBrackets != null )
 				openBrackets -= rBrackets.length();
+			else rBrackets = "";
 			// And Or
             Listbox listAndOr = (Listbox)row.getFellow("listAndOr"+row.getId());
             String andOr = listAndOr.getSelectedItem().getValue().toString();
@@ -1341,9 +1343,9 @@ public class FindWindow extends Window implements EventListener<Event>, ValueCha
         				.append(FIELD_SEPARATOR)
         				.append(andOr)
         				.append(FIELD_SEPARATOR)
-        				.append(lBrackets != null ? lBrackets : "")
+        				.append(lBrackets)
         				.append(FIELD_SEPARATOR)
-        				.append(rBrackets != null ? rBrackets : "");
+        				.append(rBrackets);
             	}
             	continue;
             }
@@ -1392,9 +1394,9 @@ public class FindWindow extends Window implements EventListener<Event>, ValueCha
             .append(FIELD_SEPARATOR)
             .append(andOr)
             .append(FIELD_SEPARATOR)
-            .append(lBrackets != null ? lBrackets : "")
+            .append(lBrackets)
             .append(FIELD_SEPARATOR)
-            .append(rBrackets != null ? rBrackets : "");
+            .append(rBrackets);
         }
         String selected = fQueryName.getValue();
 		if (selected != null) {
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/WEMailDialog.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/WEMailDialog.java
index 4cb601012e..4fee9ee274 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/WEMailDialog.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/WEMailDialog.java
@@ -516,8 +516,6 @@ public class WEMailDialog extends Window implements EventListener<Event>, ValueC
         
 		if (source.equals(fUser)) {
 			// fUser			
-			if (value == null)
-				fTo.setText("");
 			if (value instanceof Integer)
 			{
 				int AD_User_ID = ((Integer)value).intValue();
@@ -526,8 +524,6 @@ public class WEMailDialog extends Window implements EventListener<Event>, ValueC
 			}
 		} else {
 			// fCcUser
-			if (value == null)
-				fCc.setText("");
 			if (value instanceof Integer)
 			{
 				int AD_User_ID = ((Integer)value).intValue();

From ad61a5e63750593cee0b01b7e859897029326544 Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Mon, 10 Dec 2012 14:35:53 -0500
Subject: [PATCH 03/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern NS_DANGEROUS_NON_SHORT_CIRCUIT

---
 .../src/org/compiere/process/DistributionRun.java      | 10 +++++-----
 .../org/eevolution/process/ExportFormatGenerator.java  |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/org.adempiere.base.process/src/org/compiere/process/DistributionRun.java b/org.adempiere.base.process/src/org/compiere/process/DistributionRun.java
index 873e7f8d4d..e64142fa69 100644
--- a/org.adempiere.base.process/src/org/compiere/process/DistributionRun.java
+++ b/org.adempiere.base.process/src/org/compiere/process/DistributionRun.java
@@ -114,13 +114,13 @@ public class DistributionRun extends SvrProcess
 			}	
 			else if (name.equals("IsTest"))
 				p_IsTest = "Y".equals(para[i].getParameter());
-			else if (m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) & name.equals("M_Warehouse_ID"))
+			else if (m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) && name.equals("M_Warehouse_ID"))
 				p_M_Warehouse_ID=((BigDecimal)para[i].getParameter()).intValue();
-			else if (m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) & name.equals("ConsolidateDocument"))
+			else if (m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) && name.equals("ConsolidateDocument"))
 				p_ConsolidateDocument="Y".equals((String)para[i].getParameter());
-			else if (m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) & name.equals("M_DistributionList_ID"))
+			else if (m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) && name.equals("M_DistributionList_ID"))
 				p_M_DistributionList_ID=para[i].getParameterAsInt();
-			else if (m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) & name.equals("IsRequiredDRP"))
+			else if (m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) && name.equals("IsRequiredDRP"))
 				p_BasedInDamnd = "Y".equals((String)para[i].getParameter());
 			else
 				log.log(Level.SEVERE, "prepare - Unknown Parameter: " + name);		
@@ -160,7 +160,7 @@ public class DistributionRun extends SvrProcess
 		if (p_DatePromised == null)
 			p_DatePromised = m_DateOrdered;
 		
-		if(m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder)  & p_M_Warehouse_ID > 0)
+		if(m_docType.getDocBaseType().equals(MDocType.DOCBASETYPE_DistributionOrder) && p_M_Warehouse_ID > 0)
 		{
 			if(p_BasedInDamnd)
 			{
diff --git a/org.adempiere.base/src/org/eevolution/process/ExportFormatGenerator.java b/org.adempiere.base/src/org/eevolution/process/ExportFormatGenerator.java
index f56077e1ae..174e8ee7f9 100644
--- a/org.adempiere.base/src/org/eevolution/process/ExportFormatGenerator.java
+++ b/org.adempiere.base/src/org/eevolution/process/ExportFormatGenerator.java
@@ -95,7 +95,7 @@ public class ExportFormatGenerator extends SvrProcess
 			String format = null;
 			if(tab.isActive())
 			{
-				if(p_IsInsertRecord&tab.isInsertRecord())
+				if(p_IsInsertRecord && tab.isInsertRecord())
 				{	
 					table = new MTable(getCtx(), tab.getAD_Table_ID(), get_TrxName());				
 				    format = createFormat(table);

From a3c1e9dc78f4d09d2d65a2d3761ea406cf2b0689 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Mon, 10 Dec 2012 15:11:21 -0500
Subject: [PATCH 04/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE

---
 .../webui/LoggedSessionListener.java          | 38 ++++++++-----------
 1 file changed, 15 insertions(+), 23 deletions(-)

diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/LoggedSessionListener.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/LoggedSessionListener.java
index 02330372a6..7976a753df 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/LoggedSessionListener.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/LoggedSessionListener.java
@@ -1,8 +1,7 @@
 package org.adempiere.webui;
 
-import java.sql.ResultSet;
-import java.sql.Statement;
 import java.util.Hashtable;
+import java.util.List;
 
 import javax.servlet.ServletContextEvent;
 import javax.servlet.ServletContextListener;
@@ -10,8 +9,10 @@ import javax.servlet.http.HttpSession;
 import javax.servlet.http.HttpSessionEvent;
 import javax.servlet.http.HttpSessionListener;
 
+import org.adempiere.exceptions.AdempiereException;
 import org.compiere.Adempiere;
 import org.compiere.model.MSession;
+import org.compiere.model.Query;
 import org.compiere.model.ServerStateChangeEvent;
 import org.compiere.model.ServerStateChangeListener;
 import org.compiere.util.DB;
@@ -53,34 +54,25 @@ public class LoggedSessionListener implements HttpSessionListener, ServletContex
 			Adempiere.addServerStateChangeListener(this);
 			return;
 		}
-		
+
 		String serverName = WebUtil.getServerName();
-		String sql = "UPDATE AD_Session SET processed = 'Y' WHERE processed ='N' AND servername = '"+serverName+"'";
-		Statement stmt = DB.createStatement();
-		try{
-			stmt.executeUpdate(sql);
-		}catch (Exception e) {
-			System.out.println("UpdateSession: "+e);
+		String sql = "UPDATE AD_Session SET Processed='Y' WHERE Processed='N' AND ServerName=?";
+		int no = DB.executeUpdate(sql, new Object[] {serverName}, false, null);
+		if (no < 0) {
+			throw new AdempiereException("UpdateSession: Cannot Destroy All Session");
 		}
 		
 		Adempiere.removeServerStateChangeListener(this);
 	}
 	
 	public void removeADSession(String sessionID, String serverName) {
-		StringBuilder sql = new StringBuilder("SELECT * FROM AD_Session WHERE websession = '");
-		sql.append(sessionID)
-			.append("' AND servername = '")
-			.append(serverName).append("' AND processed = 'N'");
-		Statement stmt = DB.createStatement();
-		try{
-			ResultSet rs = stmt.executeQuery(sql.toString());
-			if(rs.next()){
-				MSession mSession = new MSession(Env.getCtx(), rs, null);
-				mSession.setProcessed(true);
-				mSession.save();
-			}
-		}catch (Exception e) {
-			System.out.println("UpdateSession: "+e);
+		String whereClause = "WebSession=? AND ServerName=? AND Processed='N'";
+		List<MSession> sessions = new Query(Env.getCtx(), MSession.Table_Name, whereClause, null)
+			.setParameters(sessionID, serverName)
+			.list();
+		for (MSession session : sessions) {
+			session.setProcessed(true);
+			session.saveEx();
 		}
 	}
 

From db87b54563f72246bb3dc1e8da120f002eaf3720 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Mon, 10 Dec 2012 15:23:43 -0500
Subject: [PATCH 05/29] IDEMPIERE-293  List of active session / fix findbug
 pattern SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE

---
 .../org/adempiere/webui/session/SessionContextListener.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/session/SessionContextListener.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/session/SessionContextListener.java
index 67688cf5ef..bb058512c8 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/session/SessionContextListener.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/session/SessionContextListener.java
@@ -316,7 +316,7 @@ public class SessionContextListener implements ExecutionInit,
 		MSession mSession = MSession.get(Env.getCtx(), false);
 		if(mSession!=null && !mSession.isProcessed() && (Env.getContext(Env.getCtx(), "isReloaded")==null  || Env.getContext(Env.getCtx(), "isReloaded").equals("")  || Env.getContext(Env.getCtx(), "isReloaded").equals("N"))){
 	        mSession.setProcessed(true);
-	        mSession.save();
+	        mSession.saveEx();
 		}
 		Env.setContext(Env.getCtx(), "isReloaded", "N");
 	}
@@ -331,7 +331,7 @@ public class SessionContextListener implements ExecutionInit,
 		MSession mSession = MSession.get(Env.getCtx(), false);
 		if(mSession!=null && mSession.isProcessed()){
 			mSession.setProcessed(false);
-			mSession.save();
+			mSession.saveEx();
 		}else if(mSession!=null){
 			Env.setContext(Env.getCtx(), "isReloaded", "Y");
 		}

From d9afbe27681347d61ecdc8470153a103eaaeeb3a Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Tue, 11 Dec 2012 16:48:34 -0500
Subject: [PATCH 06/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern OS_OPEN_STREAM

---
 .../base/equinox/ExtensionPriorityManager.java    | 13 ++++++++++++-
 .../src/org/adempiere/util/RestletUtil.java       | 11 ++++++++++-
 .../src/org/compiere/cm/CacheHandler.java         | 15 ++++++++++++---
 .../src/org/compiere/model/MPasswordRule.java     |  8 ++++++++
 .../src/org/compiere/util/StoredHtmlSrc.java      | 11 ++++++++++-
 .../src/org/compiere/install/KeyStoreMgt.java     |  8 ++++++++
 .../src/org/adempiere/pipo2/PackIn.java           | 10 ++++++++--
 .../src/org/adempiere/pipo2/Zipper.java           | 11 ++++++++++-
 .../plugin/utils/AdempiereActivator.java          | 10 +++++++++-
 .../org/adempiere/apps/graph/HtmlDashboard.java   | 11 ++++++++++-
 .../webui/desktop/DashboardController.java        | 12 ++++++++++--
 .../adempiere/db/oracle/config/ConfigOracle.java  | 11 ++++++++++-
 12 files changed, 117 insertions(+), 14 deletions(-)

diff --git a/org.adempiere.base/src/org/adempiere/base/equinox/ExtensionPriorityManager.java b/org.adempiere.base/src/org/adempiere/base/equinox/ExtensionPriorityManager.java
index d53a67b9e2..7df6c951a8 100644
--- a/org.adempiere.base/src/org/adempiere/base/equinox/ExtensionPriorityManager.java
+++ b/org.adempiere.base/src/org/adempiere/base/equinox/ExtensionPriorityManager.java
@@ -39,8 +39,10 @@ public class ExtensionPriorityManager {
 		URL url = location.getURL();
 		File file = new File(url.getPath(), "extensions-priorty.properties");
 		if (file.exists() && file.canRead()) {
+			FileInputStream fileInput = null;
 			try {
-				priorityMap.load(new FileInputStream(file));
+				fileInput = new FileInputStream(file);
+				priorityMap.load(fileInput);
 			} catch (FileNotFoundException e) {
 				// TODO Auto-generated catch block
 				e.printStackTrace();
@@ -48,6 +50,15 @@ public class ExtensionPriorityManager {
 				// TODO Auto-generated catch block
 				e.printStackTrace();
 			}
+			finally{
+				if (fileInput != null) {
+					try {
+						fileInput.close();
+					} catch (Exception e2) {}
+					fileInput = null;
+				}
+			}
+			
 		}
 	}
 
diff --git a/org.adempiere.base/src/org/adempiere/util/RestletUtil.java b/org.adempiere.base/src/org/adempiere/util/RestletUtil.java
index ed4ba160e1..dec3fc5b68 100644
--- a/org.adempiere.base/src/org/adempiere/util/RestletUtil.java
+++ b/org.adempiere.base/src/org/adempiere/util/RestletUtil.java
@@ -37,6 +37,7 @@ public class RestletUtil {
 	 */
 	@SuppressWarnings("unchecked")
 	public static <T> T toObject(Representation entity) {
+		ObjectInputStream ois = null;
 		try {
 			if (entity instanceof WrapperRepresentation) {
 				entity = ((WrapperRepresentation)entity).getWrappedRepresentation();
@@ -46,7 +47,7 @@ public class RestletUtil {
 				return (T) or.getObject();
 			} else if (entity instanceof InputRepresentation) {
 				InputRepresentation ir = (InputRepresentation) entity;
-				ObjectInputStream ois = new ObjectInputStream(ir.getStream());
+				ois = new ObjectInputStream(ir.getStream());
 				return (T) ois.readObject();
 			} else {
 				return null;
@@ -55,5 +56,13 @@ public class RestletUtil {
 			log.log(Level.SEVERE, e.getLocalizedMessage(), e);
 			return null;
 		}
+		finally{
+			if (ois != null) {
+				try {
+					ois.close();
+				} catch (Exception e2) {}
+				ois = null;
+			}
+		}
 	}
 }
diff --git a/org.adempiere.base/src/org/compiere/cm/CacheHandler.java b/org.adempiere.base/src/org/compiere/cm/CacheHandler.java
index ad5522704a..7999aa75b3 100644
--- a/org.adempiere.base/src/org/compiere/cm/CacheHandler.java
+++ b/org.adempiere.base/src/org/compiere/cm/CacheHandler.java
@@ -145,6 +145,7 @@ public class CacheHandler {
 	private void runURLRequest(String cache, String ID) {
 		String thisURL = null;
 		for(int i=0; i<cacheURLs.length; i++) {
+			
 			try {
 				thisURL = "http://" + cacheURLs[i] + "/cache/Service?Cache=" + cache + "&ID=" + ID;
 				URL url = new URL(thisURL);
@@ -153,18 +154,26 @@ public class CacheHandler {
 			    URLConnection urlConn = url.openConnection(thisProxy);
 			    urlConn.setUseCaches(false);
 			    urlConn.connect();
-			    Reader stream =             new java.io.InputStreamReader(
-			                                urlConn.getInputStream());
+			    Reader stream =  null; 
 			    StringBuilder srvOutput = new StringBuilder();
 
 			    	try {
+			    		stream = new java.io.InputStreamReader(urlConn.getInputStream());
 			    		int c;
 			    		while ( (c=stream.read()) != -1 )
 			    			srvOutput.append( (char)c );
 			    		
 			    	} catch (Exception E2) {
 			    		E2.printStackTrace();
-			    	}				
+			    	}	
+			    	finally{
+			    		if (stream != null) {
+			    			try {
+			    				stream.close();
+							} catch (Exception e) {}
+							stream = null;
+						}
+			    	}
 			} catch (IOException E) {
 				if (log!=null)
 					log.warning("Can't clean cache at:" + thisURL + " be carefull, your deployment server may use invalid or old cache data!");
diff --git a/org.adempiere.base/src/org/compiere/model/MPasswordRule.java b/org.adempiere.base/src/org/compiere/model/MPasswordRule.java
index 0516bde83a..d7d9713cde 100644
--- a/org.adempiere.base/src/org/compiere/model/MPasswordRule.java
+++ b/org.adempiere.base/src/org/compiere/model/MPasswordRule.java
@@ -244,6 +244,14 @@ public class MPasswordRule extends X_AD_PasswordRule {
 		} catch (Exception e) {
 			props = null;
 		}
+		finally{
+			if (in != null) {
+				try {
+					in.close();
+				} catch (Exception e2) {}
+				in = null;
+			}
+		}
 		if (props == null)
 			return new MessageResolver();
 		else
diff --git a/org.adempiere.base/src/org/compiere/util/StoredHtmlSrc.java b/org.adempiere.base/src/org/compiere/util/StoredHtmlSrc.java
index f7ec48f4d3..1c93ac6215 100644
--- a/org.adempiere.base/src/org/compiere/util/StoredHtmlSrc.java
+++ b/org.adempiere.base/src/org/compiere/util/StoredHtmlSrc.java
@@ -36,9 +36,10 @@ public class StoredHtmlSrc extends MultiPartElement implements Printable {
 			return;
 		}			
 		InputStreamReader ins;
+		BufferedReader bufferedReader = null;
 		try {
 			ins = new InputStreamReader(url.openStream());
-			BufferedReader bufferedReader = new BufferedReader( ins );
+			bufferedReader = new BufferedReader( ins );
 			String cssLine;
 			String result="";
 			while ((cssLine = bufferedReader.readLine()) != null) 
@@ -47,5 +48,13 @@ public class StoredHtmlSrc extends MultiPartElement implements Printable {
 		} catch (IOException e1) {
 			log.warning("failed to load html-src: " + srcLocation);
 		}
+		finally{
+			if (bufferedReader != null) {
+				try {
+					bufferedReader.close();
+				} catch (IOException e) {}
+				bufferedReader = null;
+			}
+		}
 	}
 }
diff --git a/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java b/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java
index d7de111bd0..67511f2b7e 100644
--- a/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java
+++ b/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java
@@ -162,6 +162,14 @@ public class KeyStoreMgt
 				log.log(Level.SEVERE, "load", e);
 				return null;
 			}
+			finally{
+				if (is != null) {
+					try {
+						is.close();
+					} catch (Exception e2) {}
+					is = null;
+				}
+			}
 			m_keyStore.load(is, m_password);
 		}
 		else
diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java b/org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java
index 5752a50a26..5ae72bf39c 100644
--- a/org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java
+++ b/org.adempiere.pipo/src/org/adempiere/pipo2/PackIn.java
@@ -196,10 +196,10 @@ public class PackIn {
 		byte[] data = null;
 		File file = new File(m_packageDirectory+File.separator+"blobs"+File.separator, fileName);
 		FileInputStream fis = null;
-
+		BufferedInputStream bis = null;
 		try {
 			fis = new FileInputStream(file);
-			BufferedInputStream bis = new BufferedInputStream(fis);
+			bis = new BufferedInputStream(fis);
 			ByteArrayOutputStream baos = new ByteArrayOutputStream();
 			while (true) {
 				int b = bis.read();
@@ -215,6 +215,12 @@ public class PackIn {
 					fis.close();
 				} catch (IOException e) {}
 			}
+			if (bis != null) {
+				try {
+					bis.close();
+				} catch (Exception e) {}
+				bis = null;
+			}
 		}
 		return data;
 	}
diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/Zipper.java b/org.adempiere.pipo/src/org/adempiere/pipo2/Zipper.java
index be9ca8b5f8..676d894360 100644
--- a/org.adempiere.pipo/src/org/adempiere/pipo2/Zipper.java
+++ b/org.adempiere.pipo/src/org/adempiere/pipo2/Zipper.java
@@ -101,8 +101,9 @@ public class Zipper {
      }
 	static public String getParentDir(File zipFilepath)
     {
+		ZipFile zipFile = null;
 		try {
-		ZipFile zipFile = new ZipFile(zipFilepath);
+		zipFile = new ZipFile(zipFilepath);
 		Enumeration<? extends ZipEntry> entries = zipFile.entries();
 		ZipEntry entry = entries.nextElement();
 		File tempfile = new File(entry.getName());
@@ -114,6 +115,14 @@ public class Zipper {
 		      ioe.printStackTrace();
 		      return "";
 	    }
+		finally{
+			if (zipFile != null) {
+				try {
+					zipFile.close();
+				} catch (Exception e) {}
+				zipFile = null;
+			}
+		}
      }
 	}//	CreateZipFile
 
diff --git a/org.adempiere.plugin.utils/src/org/adempiere/plugin/utils/AdempiereActivator.java b/org.adempiere.plugin.utils/src/org/adempiere/plugin/utils/AdempiereActivator.java
index 3c2f44130e..5566639762 100644
--- a/org.adempiere.plugin.utils/src/org/adempiere/plugin/utils/AdempiereActivator.java
+++ b/org.adempiere.plugin.utils/src/org/adempiere/plugin/utils/AdempiereActivator.java
@@ -75,11 +75,12 @@ public class AdempiereActivator implements BundleActivator {
 		URL packout = context.getBundle().getEntry("/META-INF/2Pack.zip");
 		if (packout != null) {
 			IDictionaryService service = Service.locator().locate(IDictionaryService.class).getService();
+			FileOutputStream zipstream = null;
 			try {
 				// copy the resource to a temporary file to process it with 2pack
 				InputStream stream = context.getBundle().getEntry("/META-INF/2Pack.zip").openStream();
 				File zipfile = File.createTempFile(getName(), ".zip");
-				FileOutputStream zipstream = new FileOutputStream(zipfile);
+				zipstream = new FileOutputStream(zipfile);
 			    byte[] buffer = new byte[1024];
 			    int read;
 			    while((read = stream.read(buffer)) != -1){
@@ -90,6 +91,13 @@ public class AdempiereActivator implements BundleActivator {
 			} catch (Exception e) {
 				logger.log(Level.SEVERE, "Error on Dictionary service", e);
 			}
+			finally{
+				if (zipstream != null) {
+					try {
+						zipstream.close();
+					} catch (Exception e2) {}
+				}
+			}
 		} 
 	}
 
diff --git a/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java b/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java
index dbea264cc5..19bbfc19f8 100644
--- a/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java
+++ b/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java
@@ -114,9 +114,10 @@ public class HtmlDashboard extends JPanel implements MouseListener,
 		URL url = getClass().getClassLoader().
 			getResource("org/compiere/css/PAPanel.css");
 		InputStreamReader ins;
+		BufferedReader bufferedReader = null;
 		try {
 			ins = new InputStreamReader(url.openStream());
-			BufferedReader bufferedReader = new BufferedReader( ins );
+			bufferedReader = new BufferedReader( ins );
 			String cssLine;
 			result.append("<style type=\"text/css\">");
 			while ((cssLine = bufferedReader.readLine()) != null) 
@@ -125,6 +126,14 @@ public class HtmlDashboard extends JPanel implements MouseListener,
 		} catch (IOException e1) {
 			log.log(Level.SEVERE, e1.getLocalizedMessage(), e1);
 		}
+		finally{
+			if (bufferedReader != null) {
+				try {
+					bufferedReader.close();
+				} catch (Exception e) {}
+				bufferedReader = null;
+			}
+		}
 		//System.out.println(result);
 		switch (requestPage) {
 		    case PAGE_LOGO:
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/DashboardController.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/DashboardController.java
index a650e11160..70e273d4f1 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/DashboardController.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/DashboardController.java
@@ -210,9 +210,10 @@ public class DashboardController implements EventListener<Event> {
 
 		    		URL url = getClass().getClassLoader().getResource("org/compiere/css/PAPanel.css");
 					InputStreamReader ins;
+					BufferedReader bufferedReader = null;
 					try {
 						ins = new InputStreamReader(url.openStream());
-						BufferedReader bufferedReader = new BufferedReader( ins );
+						bufferedReader = new BufferedReader( ins );
 						String cssLine;
 						result.append("<style type=\"text/css\">");
 						while ((cssLine = bufferedReader.readLine()) != null)
@@ -221,7 +222,14 @@ public class DashboardController implements EventListener<Event> {
 					} catch (Exception e1) {
 						logger.log(Level.SEVERE, e1.getLocalizedMessage(), e1);
 					}
-
+					finally{
+						if (bufferedReader != null) {
+							try {
+								bufferedReader.close();
+							} catch (Exception e) {}
+							bufferedReader = null;
+						}
+					}
 					result.append("</head><body><div class=\"content\">\n");
 
 //	            	if(description != null)
diff --git a/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java b/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java
index 216b3b6bcc..241af0c067 100644
--- a/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java
+++ b/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java
@@ -207,9 +207,10 @@ public class ConfigOracle implements IDatabaseConfig
 
 		log.fine(tnsnames);
 		StringBuffer sb = new StringBuffer();
+		FileReader fr = null;
 		try
 		{
-			FileReader fr = new FileReader (tnsfile);
+			fr = new FileReader (tnsfile);
 			int c;
 			while ((c = fr.read()) != -1)
 				sb.append((char)c);
@@ -220,6 +221,14 @@ public class ConfigOracle implements IDatabaseConfig
 			ex.printStackTrace();
 			return null;
 		}
+		finally{
+			if (fr != null) {
+				try {
+					fr.close();
+				} catch (Exception e) {}
+				fr = null;
+			}
+		}
 		if (sb.length() == 0)
 			return null;
 		return sb;

From 2309693b808829e211bf0317181b92d85016ed96 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Tue, 11 Dec 2012 17:11:56 -0500
Subject: [PATCH 07/29] Fix problem reported by Thomas Bayen on IRC - wrong
 target on properties

---
 .../buckminster_linux_gtk_x86.properties                        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.adempiere.server-feature/buckminster_linux_gtk_x86.properties b/org.adempiere.server-feature/buckminster_linux_gtk_x86.properties
index 4695ef0fee..734b87a812 100644
--- a/org.adempiere.server-feature/buckminster_linux_gtk_x86.properties
+++ b/org.adempiere.server-feature/buckminster_linux_gtk_x86.properties
@@ -8,7 +8,7 @@ qualifier.replacement.*=generator:buildTimestamp
 generator.buildTimestamp.format='v'yyyyMMdd-HHmm
 target.os=linux
 target.ws=gtk
-target.arch=x86_64
+target.arch=x86
 
 product.features=org.idempiere.eclipse.platform.feature.group, org.idempiere.fitnesse.feature.group  
 product.profile=DefaultProfile

From 5e425251c97b388b7f04e4f3e1aa65c377ee56c3 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Tue, 11 Dec 2012 18:09:31 -0500
Subject: [PATCH 08/29] Fix Packin showing errors about classnotfound

---
 org.adempiere.pipo/META-INF/MANIFEST.MF | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.adempiere.pipo/META-INF/MANIFEST.MF b/org.adempiere.pipo/META-INF/MANIFEST.MF
index 3987c75f95..36df9e1497 100644
--- a/org.adempiere.pipo/META-INF/MANIFEST.MF
+++ b/org.adempiere.pipo/META-INF/MANIFEST.MF
@@ -8,7 +8,7 @@ Import-Package: org.apache.commons.codec;version="1.3.0",
  org.apache.commons.codec.binary;version="1.3.0",
  org.apache.tools.ant,
  org.apache.tools.ant.taskdefs,
- org.apache.xerces.jaxp;version="2.9.0",
+ org.apache.xerces.jaxp,
  org.osgi.framework
 Export-Package: org.adempiere.pipo.srv,
  org.adempiere.pipo2,

From d42b5a12c3fb3b44e66e0bb8a638a507ba0bbbcc Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Tue, 11 Dec 2012 19:14:19 -0500
Subject: [PATCH 09/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern HE_EQUALS_USE_HASHCODE

---
 org.adempiere.base/src/org/compiere/model/MLocation.java    | 6 ++++++
 org.adempiere.base/src/org/compiere/model/MLookup.java      | 6 ++++++
 .../src/org/compiere/model/MRfQResponseLineQty.java         | 6 ++++++
 org.adempiere.base/src/org/compiere/model/MultiMap.java     | 6 ++++++
 org.adempiere.base/src/org/compiere/model/PO.java           | 6 ++++++
 org.adempiere.base/src/org/compiere/print/CPaper.java       | 6 ++++++
 org.adempiere.base/src/org/compiere/util/MSort.java         | 6 ++++++
 .../src/org/compiere/install/util/ALayoutConstraint.java    | 6 ++++++
 .../src/org/compiere/apps/ALayoutConstraint.java            | 6 ++++++
 9 files changed, 54 insertions(+)

diff --git a/org.adempiere.base/src/org/compiere/model/MLocation.java b/org.adempiere.base/src/org/compiere/model/MLocation.java
index a03457b4c4..bce8c7112e 100644
--- a/org.adempiere.base/src/org/compiere/model/MLocation.java
+++ b/org.adempiere.base/src/org/compiere/model/MLocation.java
@@ -419,6 +419,12 @@ public class MLocation extends X_C_Location implements Comparator<Object>
 		return equals(cmp);
 	}	//	equals
 
+	public int hashCode()
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
+
 	/**
 	 * 	Print Address Reverse Order
 	 *	@return true if reverse depending on country
diff --git a/org.adempiere.base/src/org/compiere/model/MLookup.java b/org.adempiere.base/src/org/compiere/model/MLookup.java
index 020bd58603..8f84a1d4ca 100644
--- a/org.adempiere.base/src/org/compiere/model/MLookup.java
+++ b/org.adempiere.base/src/org/compiere/model/MLookup.java
@@ -276,6 +276,12 @@ public final class MLookup extends Lookup implements Serializable
 		}
 		return false;
 	}	//	equals
+	
+	public int hashCode()
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
 
 	/**
 	 *	Return Size
diff --git a/org.adempiere.base/src/org/compiere/model/MRfQResponseLineQty.java b/org.adempiere.base/src/org/compiere/model/MRfQResponseLineQty.java
index ba200cb4b7..28ea7556f4 100644
--- a/org.adempiere.base/src/org/compiere/model/MRfQResponseLineQty.java
+++ b/org.adempiere.base/src/org/compiere/model/MRfQResponseLineQty.java
@@ -231,6 +231,12 @@ public class MRfQResponseLineQty extends X_C_RfQResponseLineQty implements Compa
     	}
     	return false;
 	}	//	equals
+    
+    public int hashCode()
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
 
 	/**
 	 * 	Before Save
diff --git a/org.adempiere.base/src/org/compiere/model/MultiMap.java b/org.adempiere.base/src/org/compiere/model/MultiMap.java
index 4efe4e4a72..13eb594554 100644
--- a/org.adempiere.base/src/org/compiere/model/MultiMap.java
+++ b/org.adempiere.base/src/org/compiere/model/MultiMap.java
@@ -234,6 +234,12 @@ public final class MultiMap<K,V> implements Map<K,V>, Serializable
 	{
 		throw new java.lang.UnsupportedOperationException("Method equals() not implemented.");
 	}
+	
+	public int hashCode()
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
 
 	/**************************************************************************
 	 *  Returns class name and number of entries
diff --git a/org.adempiere.base/src/org/compiere/model/PO.java b/org.adempiere.base/src/org/compiere/model/PO.java
index 10f8dad895..d9c3038c66 100644
--- a/org.adempiere.base/src/org/compiere/model/PO.java
+++ b/org.adempiere.base/src/org/compiere/model/PO.java
@@ -313,6 +313,12 @@ public abstract class PO
 				return ((PO)cmp).get_ID() == get_ID();
 		return super.equals(cmp);
 	}	//	equals
+	
+	public int hashCode()
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
 
 	/**
 	 * 	Compare based on DocumentNo, Value, Name, Description
diff --git a/org.adempiere.base/src/org/compiere/print/CPaper.java b/org.adempiere.base/src/org/compiere/print/CPaper.java
index 1f91a54c43..ca70af8898 100644
--- a/org.adempiere.base/src/org/compiere/print/CPaper.java
+++ b/org.adempiere.base/src/org/compiere/print/CPaper.java
@@ -411,6 +411,12 @@ public class CPaper extends Paper
 		}
 		return false;
 	}	//	equals
+	
+	public int hashCode()
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
 
 	/*************************************************************************/
 
diff --git a/org.adempiere.base/src/org/compiere/util/MSort.java b/org.adempiere.base/src/org/compiere/util/MSort.java
index 37e50e067e..04d1492d0e 100644
--- a/org.adempiere.base/src/org/compiere/util/MSort.java
+++ b/org.adempiere.base/src/org/compiere/util/MSort.java
@@ -164,6 +164,12 @@ public final class MSort implements Comparator<Object>, Serializable
 		}
 		return false;
 	}	//	equals
+	
+	public int hashCode()
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
 
 	/**
 	 * 	String Representation
diff --git a/org.adempiere.install/src/org/compiere/install/util/ALayoutConstraint.java b/org.adempiere.install/src/org/compiere/install/util/ALayoutConstraint.java
index 34474d0634..5554860dcc 100644
--- a/org.adempiere.install/src/org/compiere/install/util/ALayoutConstraint.java
+++ b/org.adempiere.install/src/org/compiere/install/util/ALayoutConstraint.java
@@ -104,6 +104,12 @@ public class ALayoutConstraint implements Comparable<Object>
 		return false;
 	}   //  equal
 
+	public int hashCode() 
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
+	
 	/**
 	 *  To String
 	 *  @return info
diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/ALayoutConstraint.java b/org.adempiere.ui.swing/src/org/compiere/apps/ALayoutConstraint.java
index d517b7e14b..718fce2006 100644
--- a/org.adempiere.ui.swing/src/org/compiere/apps/ALayoutConstraint.java
+++ b/org.adempiere.ui.swing/src/org/compiere/apps/ALayoutConstraint.java
@@ -103,6 +103,12 @@ public class ALayoutConstraint implements Comparable<Object>
 			return compareTo(o) == 0;
 		return false;
 	}   //  equal
+	
+	public int hashCode() 
+	{
+	  assert false : "hashCode not designed";
+	  return 42; // any arbitrary constant will do
+	}
 
 	/**
 	 *  To String

From 2035b8c7d3381c67e5e7e484b8923084aec474af Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Tue, 11 Dec 2012 19:21:13 -0500
Subject: [PATCH 10/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern SS_SHOULD_BE_STATIC

---
 org.adempiere.base/src/org/compiere/acct/Doc_AssetReval.java    | 2 +-
 .../src/org/adempiere/pipo2/handler/AdElementHandler.java       | 2 +-
 org.adempiere.ui/src/org/compiere/grid/PaymentFormCash.java     | 2 +-
 org.adempiere.ui/src/org/compiere/grid/PaymentFormCheck.java    | 2 +-
 .../src/org/compiere/grid/PaymentFormCreditCard.java            | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/org.adempiere.base/src/org/compiere/acct/Doc_AssetReval.java b/org.adempiere.base/src/org/compiere/acct/Doc_AssetReval.java
index 1c73d5b089..7260f13f17 100644
--- a/org.adempiere.base/src/org/compiere/acct/Doc_AssetReval.java
+++ b/org.adempiere.base/src/org/compiere/acct/Doc_AssetReval.java
@@ -20,7 +20,7 @@ public class Doc_AssetReval extends Doc
 {
 
 	
-	private final String POSTINGTYPE_Actual = "A";
+	private static final String POSTINGTYPE_Actual = "A";
 	public Doc_AssetReval (MAcctSchema as, ResultSet rs, String trxName)
 	{
 		super(as, MAssetReval.class, rs, MDocType.DOCBASETYPE_GLJournal, trxName);
diff --git a/org.adempiere.pipo.handlers/src/org/adempiere/pipo2/handler/AdElementHandler.java b/org.adempiere.pipo.handlers/src/org/adempiere/pipo2/handler/AdElementHandler.java
index 3b77579416..2b5294afa3 100644
--- a/org.adempiere.pipo.handlers/src/org/adempiere/pipo2/handler/AdElementHandler.java
+++ b/org.adempiere.pipo.handlers/src/org/adempiere/pipo2/handler/AdElementHandler.java
@@ -41,7 +41,7 @@ public class AdElementHandler extends AbstractElementHandler {
 
 	private List<Integer> processedElements = new ArrayList<Integer>();
 
-	private final String AD_ELEMENT = "AD_Element";
+	private static final String AD_ELEMENT = "AD_Element";
 
 
 	public void startElement(PIPOContext ctx, Element element)
diff --git a/org.adempiere.ui/src/org/compiere/grid/PaymentFormCash.java b/org.adempiere.ui/src/org/compiere/grid/PaymentFormCash.java
index 1bf4be7e0f..e662d066ba 100644
--- a/org.adempiere.ui/src/org/compiere/grid/PaymentFormCash.java
+++ b/org.adempiere.ui/src/org/compiere/grid/PaymentFormCash.java
@@ -43,7 +43,7 @@ import org.compiere.util.TimeUtil;
  *
  */
 public abstract class PaymentFormCash extends PaymentForm {
-	private final String PAYMENTRULE = MInvoice.PAYMENTRULE_Cash;
+	private static final String PAYMENTRULE = MInvoice.PAYMENTRULE_Cash;
 	
 	/** Start Payment */
 	public int 					m_C_Payment_ID = 0;
diff --git a/org.adempiere.ui/src/org/compiere/grid/PaymentFormCheck.java b/org.adempiere.ui/src/org/compiere/grid/PaymentFormCheck.java
index 18ac394fbc..1289a5045a 100644
--- a/org.adempiere.ui/src/org/compiere/grid/PaymentFormCheck.java
+++ b/org.adempiere.ui/src/org/compiere/grid/PaymentFormCheck.java
@@ -39,7 +39,7 @@ import org.compiere.util.Msg;
  *
  */
 public abstract class PaymentFormCheck extends PaymentForm {
-	private final String PAYMENTRULE = MInvoice.PAYMENTRULE_Check;
+	private static final String PAYMENTRULE = MInvoice.PAYMENTRULE_Check;
 	
 	/** Start Payment */
 	public int 					m_C_Payment_ID = 0;
diff --git a/org.adempiere.ui/src/org/compiere/grid/PaymentFormCreditCard.java b/org.adempiere.ui/src/org/compiere/grid/PaymentFormCreditCard.java
index b47727163c..e313d2415e 100644
--- a/org.adempiere.ui/src/org/compiere/grid/PaymentFormCreditCard.java
+++ b/org.adempiere.ui/src/org/compiere/grid/PaymentFormCreditCard.java
@@ -36,7 +36,7 @@ import org.compiere.util.ValueNamePair;
  *
  */
 public abstract class PaymentFormCreditCard extends PaymentForm {
-	private final String PAYMENTRULE = MInvoice.PAYMENTRULE_CreditCard;
+	private static final String PAYMENTRULE = MInvoice.PAYMENTRULE_CreditCard;
 	
 	/** Start Payment */
 	public int 					m_C_Payment_ID = 0;

From 5662475b92092f1444ebd4144f6424686398c9d4 Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Tue, 11 Dec 2012 19:47:25 -0500
Subject: [PATCH 11/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern SIC_INNER_SHOULD_BE_STATIC

---
 .../src/org/compiere/process/InOutGenerate.java               | 2 +-
 .../src/org/compiere/process/IndentedBOM.java                 | 2 +-
 .../src/org/compiere/process/InventoryCountCreate.java        | 2 +-
 .../src/org/compiere/process/M_PriceList_Create.java          | 2 +-
 org.adempiere.base/src/org/compiere/acct/Fact.java            | 2 +-
 .../src/org/compiere/impexp/OFXBankStatementHandler.java      | 2 +-
 .../src/org/compiere/model/AccessSqlParser.java               | 2 +-
 org.adempiere.base/src/org/compiere/model/GridWorkbench.java  | 2 +-
 org.adempiere.base/src/org/compiere/model/MMailText.java      | 2 +-
 .../src/org/compiere/model/MProductCategory.java              | 2 +-
 org.adempiere.base/src/org/compiere/print/MPrintPaper.java    | 2 +-
 org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java | 2 +-
 .../src/org/compiere/report/ReportStarter.java                | 4 ++--
 .../src/org/adempiere/apps/graph/HtmlDashboard.java           | 2 +-
 org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java   | 2 +-
 org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java | 4 ++--
 .../WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java  | 2 +-
 .../src/org/adempiere/webui/adwindow/GridTabRowRenderer.java  | 2 +-
 .../WEB-INF/src/org/adempiere/webui/component/Group.java      | 2 +-
 .../src/org/adempiere/webui/panel/CustomizeGridViewPanel.java | 2 +-
 .../src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java    | 2 +-
 .../src/org/adempiere/webui/panel/WRC3SortCriteriaPanel.java  | 2 +-
 .../WEB-INF/src/org/adempiere/webui/window/FindWindow.java    | 2 +-
 org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java    | 2 +-
 .../src/org/compiere/apps/form/TreeMaintenance.java           | 2 +-
 .../WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java        | 2 +-
 26 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/org.adempiere.base.process/src/org/compiere/process/InOutGenerate.java b/org.adempiere.base.process/src/org/compiere/process/InOutGenerate.java
index 221cbbcb97..629b8e4b7c 100644
--- a/org.adempiere.base.process/src/org/compiere/process/InOutGenerate.java
+++ b/org.adempiere.base.process/src/org/compiere/process/InOutGenerate.java
@@ -601,7 +601,7 @@ public class InOutGenerate extends SvrProcess
 	/**
 	 * 	InOutGenerate Parameter
 	 */
-	class SParameter
+	static class SParameter
 	{
 		/**
 		 * 	Parameter
diff --git a/org.adempiere.base.process/src/org/compiere/process/IndentedBOM.java b/org.adempiere.base.process/src/org/compiere/process/IndentedBOM.java
index cfaf0631c8..8c29b4b643 100644
--- a/org.adempiere.base.process/src/org/compiere/process/IndentedBOM.java
+++ b/org.adempiere.base.process/src/org/compiere/process/IndentedBOM.java
@@ -185,7 +185,7 @@ public class IndentedBOM extends SvrProcess
 		return list;
 	}
 	
-	private class llCost {
+	private static class llCost {
 		BigDecimal currentCost = Env.ZERO;
 		BigDecimal futureCost = Env.ZERO;
 	}
diff --git a/org.adempiere.base.process/src/org/compiere/process/InventoryCountCreate.java b/org.adempiere.base.process/src/org/compiere/process/InventoryCountCreate.java
index 8dc4f07571..7dcedb7afc 100644
--- a/org.adempiere.base.process/src/org/compiere/process/InventoryCountCreate.java
+++ b/org.adempiere.base.process/src/org/compiere/process/InventoryCountCreate.java
@@ -399,7 +399,7 @@ public class InventoryCountCreate extends SvrProcess
 	 * @author Karsten Thiemann, kthiemann@adempiere.org
 	 *
 	 */
-	private class SimpleTreeNode {
+	private static class SimpleTreeNode {
 
 		private int nodeId;
 
diff --git a/org.adempiere.base.process/src/org/compiere/process/M_PriceList_Create.java b/org.adempiere.base.process/src/org/compiere/process/M_PriceList_Create.java
index 95474c617e..4f2dfc2491 100644
--- a/org.adempiere.base.process/src/org/compiere/process/M_PriceList_Create.java
+++ b/org.adempiere.base.process/src/org/compiere/process/M_PriceList_Create.java
@@ -785,7 +785,7 @@ public class M_PriceList_Create extends SvrProcess {
 	 * @author Karsten Thiemann, kthiemann@adempiere.org
 	 *
 	 */
-	private class SimpleTreeNode {
+	private static class SimpleTreeNode {
 
 		private int nodeId;
 
diff --git a/org.adempiere.base/src/org/compiere/acct/Fact.java b/org.adempiere.base/src/org/compiere/acct/Fact.java
index 9ddd5cbe10..edc2c8d543 100644
--- a/org.adempiere.base/src/org/compiere/acct/Fact.java
+++ b/org.adempiere.base/src/org/compiere/acct/Fact.java
@@ -859,7 +859,7 @@ public final class Fact
 	 *  @author Jorg Janke
 	 *  @version $Id: Fact.java,v 1.2 2006/07/30 00:53:33 jjanke Exp $
 	 */
-	public class Balance
+	public static class Balance
 	{
 		/**
 		 * 	New Balance
diff --git a/org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java b/org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java
index a9d70e2e82..549788e212 100644
--- a/org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java
+++ b/org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java
@@ -782,7 +782,7 @@ public abstract class OFXBankStatementHandler extends DefaultHandler
 	 * @author ET
 	 * @version $Id: OFXBankStatementHandler.java,v 1.3 2006/07/30 00:51:05 jjanke Exp $
 	 */
-	class StatementLine
+	static class StatementLine
 	{
 		protected String routingNo = null;
 		protected String bankAccountNo = null;
diff --git a/org.adempiere.base/src/org/compiere/model/AccessSqlParser.java b/org.adempiere.base/src/org/compiere/model/AccessSqlParser.java
index 08466815ef..9b11a5b45b 100644
--- a/org.adempiere.base/src/org/compiere/model/AccessSqlParser.java
+++ b/org.adempiere.base/src/org/compiere/model/AccessSqlParser.java
@@ -389,7 +389,7 @@ public class AccessSqlParser
 	/**
 	 * 	Table Info VO
 	 */
-	public class TableInfo
+	public static class TableInfo
 	{
 		/**
 		 * 	Constructor
diff --git a/org.adempiere.base/src/org/compiere/model/GridWorkbench.java b/org.adempiere.base/src/org/compiere/model/GridWorkbench.java
index afefcf2b8d..080ce9544e 100644
--- a/org.adempiere.base/src/org/compiere/model/GridWorkbench.java
+++ b/org.adempiere.base/src/org/compiere/model/GridWorkbench.java
@@ -512,7 +512,7 @@ public class GridWorkbench implements Serializable
 	/**************************************************************************
 	 *  Window Type
 	 */
-	class WBWindow
+	static class WBWindow
 	{
 		/**
 		 * 	WBWindow
diff --git a/org.adempiere.base/src/org/compiere/model/MMailText.java b/org.adempiere.base/src/org/compiere/model/MMailText.java
index 27c4843d7c..7d954b6b15 100644
--- a/org.adempiere.base/src/org/compiere/model/MMailText.java
+++ b/org.adempiere.base/src/org/compiere/model/MMailText.java
@@ -379,7 +379,7 @@ public class MMailText extends X_R_MailText
 	/**
 	 *	MailText Translation VO
 	 */
-	class MMailTextTrl
+	static class MMailTextTrl
 	{
 		/** Language			*/
 		String		AD_Language = null;
diff --git a/org.adempiere.base/src/org/compiere/model/MProductCategory.java b/org.adempiere.base/src/org/compiere/model/MProductCategory.java
index ca01c72f80..011001eb91 100644
--- a/org.adempiere.base/src/org/compiere/model/MProductCategory.java
+++ b/org.adempiere.base/src/org/compiere/model/MProductCategory.java
@@ -276,7 +276,7 @@ public class MProductCategory extends X_M_Product_Category
 	 * @author Karsten Thiemann, kthiemann@adempiere.org
 	 *
 	 */
-	private class SimpleTreeNode {
+	private static class SimpleTreeNode {
 		/** id of the node */
 		private int nodeId;
 		/** id of the nodes parent */
diff --git a/org.adempiere.base/src/org/compiere/print/MPrintPaper.java b/org.adempiere.base/src/org/compiere/print/MPrintPaper.java
index 81b650d3d1..70155232b2 100644
--- a/org.adempiere.base/src/org/compiere/print/MPrintPaper.java
+++ b/org.adempiere.base/src/org/compiere/print/MPrintPaper.java
@@ -249,7 +249,7 @@ public class MPrintPaper extends X_AD_PrintPaper
 	/**
 	 * 	Media Size Name 
 	 */
-	class CMediaSizeName extends MediaSizeName
+	static class CMediaSizeName extends MediaSizeName
 	{
 		/**
 		 * 
diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java b/org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java
index 64c4877dc4..772a63ccab 100644
--- a/org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java
+++ b/org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java
@@ -424,7 +424,7 @@ public class PackInHandler extends DefaultHandler {
 		}
 	}
 
-	class DeferEntry {
+	static class DeferEntry {
 		Element element;
 		boolean startElement = false;
 
diff --git a/org.adempiere.report.jasper/src/org/compiere/report/ReportStarter.java b/org.adempiere.report.jasper/src/org/compiere/report/ReportStarter.java
index 979158cc4f..70e74deb43 100644
--- a/org.adempiere.report.jasper/src/org/compiere/report/ReportStarter.java
+++ b/org.adempiere.report.jasper/src/org/compiere/report/ReportStarter.java
@@ -1221,7 +1221,7 @@ public class ReportStarter implements ProcessCall, ClientProcess
         }
     }
 
-    class ReportData {
+    static class ReportData {
         private String reportFilePath;
         private boolean directPrint;
 
@@ -1275,7 +1275,7 @@ public class ReportStarter implements ProcessCall, ClientProcess
         }
     }
 
-    class FileFilter implements FilenameFilter {
+    static class FileFilter implements FilenameFilter {
         private String reportStart;
         private File directory;
         private String extension;
diff --git a/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java b/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java
index 19bbfc19f8..9b600eab1d 100644
--- a/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java
+++ b/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java
@@ -456,7 +456,7 @@ public class HtmlDashboard extends JPanel implements MouseListener,
 		}
 	}
 	
-	class PageLoader implements Runnable
+	static class PageLoader implements Runnable
 	{
 	    private JEditorPane html;
 	    private URL         url;
diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java b/org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java
index 7c591949a5..725ed7b007 100644
--- a/org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java
+++ b/org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java
@@ -44,7 +44,7 @@ public class StatusBar extends CPanel implements IStatusBar
 	/******************************************************************************
 	 *  Mouse Adapter for Status Bar (statusDB)
 	 */
-	class StatusBar_mouseAdapter extends java.awt.event.MouseAdapter
+	static class StatusBar_mouseAdapter extends java.awt.event.MouseAdapter
 	{
 		private StatusBar adaptee;
 
diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java b/org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java
index a736952143..fe01049a3b 100644
--- a/org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java
+++ b/org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java
@@ -1410,7 +1410,7 @@ public final class Find extends CDialog
 	 * @author Karsten Thiemann, kthiemann@adempiere.org
 	 *
 	 */
-	private class SimpleTreeNode {
+	private static class SimpleTreeNode {
 
 		private int nodeId;
 
@@ -1728,7 +1728,7 @@ public final class Find extends CDialog
 		&& MColumn.isSuggestSelectionColumn(field.getColumnName(), true);
 	}
 	
-	private class ProxyRenderer implements TableCellRenderer
+	private static class ProxyRenderer implements TableCellRenderer
 	{
 		/**
 		 * Creates a Find.ProxyRenderer.
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java
index 5938f41604..5115435eab 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java
@@ -1138,7 +1138,7 @@ DataStatusListener, IADTabpanel, IdSpace
 		Events.sendEvent(this, new Event(ON_SWITCH_VIEW_EVENT, this));
 	}
 
-	class ZoomListener implements EventListener<Event> {
+	static class ZoomListener implements EventListener<Event> {
 
 		private IZoomableEditor searchEditor;
 
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java
index a7e2922786..ecc540b1ae 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java
@@ -641,7 +641,7 @@ public class GridTabRowRenderer implements RowRenderer<Object[]>, RowRendererExt
 		this.gridPanel = gridPanel;
 	}
 
-	class RowListener implements EventListener<Event> {
+	static class RowListener implements EventListener<Event> {
 
 		private Grid _grid;
 
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Group.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Group.java
index b06403f39b..e4f8ec0241 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Group.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Group.java
@@ -79,7 +79,7 @@ public class Group extends org.zkoss.zul.Group {
 		m_rows.add(row);
 	}
 
-	public class GroupHeader extends Div implements EventListener<Event>
+	public static class GroupHeader extends Div implements EventListener<Event>
 	{
 		/**
 		 * 
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java
index 7a1169bc7e..a8faf65e56 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java
@@ -584,7 +584,7 @@ public class CustomizeGridViewPanel extends Panel
 	 * List Item
 	 * @author Teo Sarca
 	 */
-	private class ListElement extends NamePair {
+	private static class ListElement extends NamePair {
 		/**
 		 *
 		 */
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java
index e4dd536322..b40b5df86f 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java
@@ -318,7 +318,7 @@ public class WRC2FieldOrderPanel extends WRCTabPanel implements EventListener<Ev
 	/**
 	 * List Item
 	 */
-	public class ListElement extends NamePair {
+	public static class ListElement extends NamePair {
 		/**
 		 *
 		 */
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC3SortCriteriaPanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC3SortCriteriaPanel.java
index 72f718d0a7..cb78bed63a 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC3SortCriteriaPanel.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC3SortCriteriaPanel.java
@@ -427,7 +427,7 @@ public class WRC3SortCriteriaPanel extends WRCTabPanel implements  EventListener
 	/**
 	 * List Item
 	 */
-	public class ListElement extends NamePair {
+	public static class ListElement extends NamePair {
 		/**
 		 *
 		 */
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java
index 3862dfae93..d0aecbb909 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java
@@ -1954,7 +1954,7 @@ public class FindWindow extends Window implements EventListener<Event>, ValueCha
      * @author Karsten Thiemann, kthiemann@adempiere.org
      *
     **/
-    private class SimpleTreeNode {
+    private static class SimpleTreeNode {
 
         private int nodeId;
 
diff --git a/org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java b/org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java
index dfcfd0980f..93c82d4ed2 100644
--- a/org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java
+++ b/org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java
@@ -435,7 +435,7 @@ public class PaySelect
 	/**************************************************************************
 	 *  Bank Account Info
 	 */
-	public class BankInfo
+	public static class BankInfo
 	{
 		/**
 		 * 	BankInfo
diff --git a/org.adempiere.ui/src/org/compiere/apps/form/TreeMaintenance.java b/org.adempiere.ui/src/org/compiere/apps/form/TreeMaintenance.java
index 33c80cd965..748e48732b 100644
--- a/org.adempiere.ui/src/org/compiere/apps/form/TreeMaintenance.java
+++ b/org.adempiere.ui/src/org/compiere/apps/form/TreeMaintenance.java
@@ -158,7 +158,7 @@ public class TreeMaintenance {
 	/**************************************************************************
 	 * 	Tree Maintenance List Item
 	 */
-	public class ListItem
+	public static class ListItem
 	{
 		/**
 		 * 	ListItem
diff --git a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java
index 9afe6530b7..b2784b4ec6 100644
--- a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java
+++ b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java
@@ -20,7 +20,7 @@ import org.compiere.model.MQuery;
 
 public class WWindowStatus 
 {
-	public class AD_WrongTabException extends Exception
+	public static class AD_WrongTabException extends Exception
 	{
 		public AD_WrongTabException( String msg ) {
 			super(msg);

From 6c06ec9f47b2e7907739889d85a2138848e7fb28 Mon Sep 17 00:00:00 2001
From: Juan David Arboleda <juan.arboleda@globalqss.com>
Date: Tue, 11 Dec 2012 19:57:48 -0500
Subject: [PATCH 12/29] IDEMPIERE-364 Improve Grid Layout / Refactor
 customizegrid, enable multi-selection and drag-drop events both sides of the
 list

---
 .../webui/panel/CustomizeGridViewPanel.java   | 96 ++++++++++---------
 1 file changed, 51 insertions(+), 45 deletions(-)

diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java
index a8faf65e56..40cc1ebc76 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java
@@ -185,36 +185,7 @@ public class CustomizeGridViewPanel extends Panel
 
 		bDown.setImage("images/Detail24.png");
 		bDown.addEventListener(Events.ON_CLICK, actionListener);
-
-		EventListener<Event> yesListMouseMotionListener = new EventListener<Event>()
-		{
-			public void onEvent(Event event) throws Exception {
-				if (event instanceof DropEvent)
-				{
-					DropEvent me = (DropEvent) event;
-					ListItem startItem = (ListItem) me.getDragged();
-					ListItem endItem = (ListItem) me.getTarget();
-					if (startItem.getListbox() == endItem.getListbox() && startItem.getListbox() == yesList)
-					{
-						int startIndex = yesList.getIndexOfItem(startItem);
-						int endIndex = yesList.getIndexOfItem(endItem);
-						Object endElement = yesModel.getElementAt(endIndex);
-						Object element = yesModel.getElementAt(startIndex);
-						yesModel.removeElement(element);
-						endIndex = yesModel.indexOf(endElement);
-						yesModel.add(endIndex, element);
-						yesList.setSelectedIndex(endIndex);
-						if ( yesList.getSelectedItem() != null)
-						{
-							AuFocus focus = new AuFocus(yesList.getSelectedItem());
-							Clients.response(focus);
-						}
-					}
-				}
-			}
-		};
-		yesList.addOnDropListener(yesListMouseMotionListener);
-
+		
 		ListHead listHead = new ListHead();
 		listHead.setParent(yesList);
 		ListHeader listHeader = new ListHeader();
@@ -397,10 +368,15 @@ public class CustomizeGridViewPanel extends Panel
 		}
 		Listbox listFrom = (source == bAdd || source == noList) ? noList : yesList;
 		Listbox listTo =  (source == bAdd || source == noList) ? yesList : noList;
-		migrateLists (listFrom,listTo);	
+		int endIndex = yesList.getIndexOfItem(listTo.getSelectedItem());	
+		//Listto is empty. 
+		if (endIndex<0 )
+			endIndex=0;
+		
+		migrateLists (listFrom,listTo,endIndex);	
 	}
 
-	void migrateLists (Listbox listFrom , Listbox listTo)
+	void migrateLists (Listbox listFrom , Listbox listTo , int endIndex	)
 	{
 		int index = 0;
 		SimpleListModel lmFrom = (SimpleListModel) listFrom.getModel();
@@ -419,21 +395,32 @@ public class CustomizeGridViewPanel extends Panel
 				continue;
 
 			lmFrom.removeElement(selObject);
-			lmTo.addElement(selObject);
-		}
-		index = 0;
-		for (ListElement selObject : selObjects)
-		{
+			lmTo.add(endIndex, selObject);
+			endIndex++;			
 			index = lmTo.indexOf(selObject);
 			listTo.setSelectedIndex(index);
 		}
-		if ( listTo.getSelectedItem() != null)
-		{
-			AuFocus focus = new AuFocus(listTo.getSelectedItem());
-			Clients.response(focus);
-		}	
 	}
 	
+	/**
+	 * 	Move within Yes List with Drag Event and Multiple Choice
+	 *	@param event event
+	 */
+	void migrateValueWithinYesList (int endIndex, List<ListElement> selObjects)
+	{
+		int length = selObjects.size();
+		int iniIndex =0;
+		Arrays.sort(selObjects.toArray());	
+		ListElement endObject = (ListElement)yesModel.getElementAt(endIndex);
+
+		for (int i = 0; i < length; i++) {
+			iniIndex = yesModel.indexOf(selObjects.get(i));
+			ListElement selObject = (ListElement)yesModel.getElementAt(iniIndex);
+			yesModel.removeElement(selObject);
+			endIndex = yesModel.indexOf(endObject);
+			yesModel.add(endIndex, selObject);
+		}		
+	}
 	/**
 	 * 	Move within Yes List
 	 *	@param event event
@@ -672,14 +659,33 @@ public class CustomizeGridViewPanel extends Panel
 		public void onEvent(Event event) throws Exception {
 			if (event instanceof DropEvent)
 			{	
+				int endIndex = 0;
 				DropEvent me = (DropEvent) event;
 				ListItem endItem = (ListItem) me.getTarget();
 				ListItem startItem = (ListItem) me.getDragged();
+				
+				if (!startItem.isSelected())
+					startItem.setSelected(true);
+					
 				if (!(startItem.getListbox() == endItem.getListbox()))
-				{
+				{			
 					Listbox listFrom = (Listbox)startItem.getListbox();
-					Listbox listTo =  (Listbox)endItem.getListbox();
-					migrateLists (listFrom,listTo);
+					Listbox listTo =  (Listbox)endItem.getListbox();		
+					endIndex = yesList.getIndexOfItem(endItem);
+					migrateLists (listFrom,listTo,endIndex);
+					
+				}else if (startItem.getListbox() == endItem.getListbox() && startItem.getListbox() == yesList)
+				{  
+					List<ListElement> selObjects = new ArrayList<ListElement>();
+					endIndex = yesList.getIndexOfItem(endItem);	
+					for (Object obj : yesList.getSelectedItems()) {
+						ListItem listItem = (ListItem) obj;
+						int index = yesList.getIndexOfItem(listItem);
+						ListElement selObject = (ListElement)yesModel.getElementAt(index);				
+						selObjects.add(selObject);						
+					}
+					migrateValueWithinYesList (endIndex, selObjects);
+					yesList.clearSelection();
 				}
 			}
 		}

From 4d83adf84104c12c52ab65fc2a1a50e8e52807c4 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Tue, 11 Dec 2012 20:18:20 -0500
Subject: [PATCH 13/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern OS_OPEN_STREAM  / Fix problem created closing the stream before
 reading it

---
 org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java b/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java
index 67511f2b7e..99926afd6c 100644
--- a/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java
+++ b/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java
@@ -156,6 +156,7 @@ public class KeyStoreMgt
 			try
 			{
 				is = new FileInputStream (m_file);
+				m_keyStore.load(is, m_password);
 			}
 			catch (Exception e)
 			{
@@ -170,7 +171,6 @@ public class KeyStoreMgt
 					is = null;
 				}
 			}
-			m_keyStore.load(is, m_password);
 		}
 		else
 			return null;	//	does not exist

From e107e8f452e23554973176c203cfecafabe200cc Mon Sep 17 00:00:00 2001
From: Nicolas Micoud <nmicoud@tgi.fr>
Date: Thu, 4 Oct 2012 13:37:34 +0200
Subject: [PATCH 14/29] IDEMPIERE-448 - Add CopyFrom on Bank Statement

---
 .../oracle/201212120818_IDEMPIERE-448.sql     | 107 +++++++++++++++++
 .../postgresql/201212120818_IDEMPIERE-448.sql | 107 +++++++++++++++++
 .../compiere/process/CopyFromBankStmt.java    | 111 ++++++++++++++++++
 3 files changed, 325 insertions(+)
 create mode 100644 migration/i1.0a-release/oracle/201212120818_IDEMPIERE-448.sql
 create mode 100644 migration/i1.0a-release/postgresql/201212120818_IDEMPIERE-448.sql
 create mode 100644 org.adempiere.base.process/src/org/compiere/process/CopyFromBankStmt.java

diff --git a/migration/i1.0a-release/oracle/201212120818_IDEMPIERE-448.sql b/migration/i1.0a-release/oracle/201212120818_IDEMPIERE-448.sql
new file mode 100644
index 0000000000..e8958432fd
--- /dev/null
+++ b/migration/i1.0a-release/oracle/201212120818_IDEMPIERE-448.sql
@@ -0,0 +1,107 @@
+-- Oct 4, 2012 1:29:34 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Process (AD_Client_ID,AD_Org_ID,AD_Process_ID,AccessLevel,Classname,CopyFromProcess,Created,CreatedBy,Description,EntityType,IsActive,IsBetaFunctionality,IsDirectPrint,IsReport,IsServerProcess,Name,ShowHelp,Statistic_Count,Statistic_Seconds,Updated,UpdatedBy,Value) VALUES (0,0,200012,'1','org.compiere.process.CopyFromBankStmt','N',TO_DATE('2012-10-04 13:29:33','YYYY-MM-DD HH24:MI:SS'),100,'Copy Lines from other bank statement','D','Y','N','N','N','N','Copy Lines','Y',0,0,TO_DATE('2012-10-04 13:29:33','YYYY-MM-DD HH24:MI:SS'),100,'C_BankStatement CopyFrom')
+;
+
+-- Oct 4, 2012 1:29:35 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Process_Trl (AD_Language,AD_Process_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Process_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Process t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Process_ID=200012 AND NOT EXISTS (SELECT * FROM AD_Process_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Process_ID=t.AD_Process_ID)
+;
+
+-- Oct 4, 2012 1:30:09 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Val_Rule (AD_Client_ID,AD_Org_ID,AD_Val_Rule_ID,Code,Created,CreatedBy,EntityType,IsActive,Name,Type,Updated,UpdatedBy) VALUES (0,0,200008,'C_BankStatement.C_BankAccount_ID=@C_BankAccount_ID@',TO_DATE('2012-10-04 13:30:09','YYYY-MM-DD HH24:MI:SS'),100,'D','Y','BankStatement of BankAccount','S',TO_DATE('2012-10-04 13:30:09','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- Oct 4, 2012 1:30:16 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Process_Para (AD_Client_ID,AD_Element_ID,AD_Org_ID,AD_Process_ID,AD_Process_Para_ID,AD_Reference_ID,AD_Val_Rule_ID,ColumnName,Created,CreatedBy,Description,EntityType,FieldLength,Help,IsActive,IsCentrallyMaintained,IsEncrypted,IsMandatory,IsRange,Name,SeqNo,Updated,UpdatedBy) VALUES (0,1381,0,200012,200043,30,200008,'C_BankStatement_ID',TO_DATE('2012-10-04 13:30:16','YYYY-MM-DD HH24:MI:SS'),100,'Bank Statement of account','D',0,'The Bank Statement identifies a unique Bank Statement for a defined time period.  The statement defines all transactions that occurred','Y','Y','N','Y','N','Bank Statement',10,TO_DATE('2012-10-04 13:30:16','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- Oct 4, 2012 1:30:17 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Process_Para_Trl (AD_Language,AD_Process_Para_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Process_Para_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Process_Para t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Process_Para_ID=200043 AND NOT EXISTS (SELECT * FROM AD_Process_Para_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Process_Para_ID=t.AD_Process_Para_ID)
+;
+
+-- Oct 4, 2012 1:30:34 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Column (AD_Client_ID,AD_Column_ID,AD_Element_ID,AD_Org_ID,AD_Process_ID,AD_Reference_ID,AD_Table_ID,ColumnName,Created,CreatedBy,DefaultValue,Description,EntityType,FieldLength,Help,IsActive,IsAllowCopy,IsAllowLogging,IsAlwaysUpdateable,IsAutocomplete,IsEncrypted,IsIdentifier,IsKey,IsMandatory,IsParent,IsSelectionColumn,IsSyncDatabase,IsTranslated,IsUpdateable,Name,SeqNo,Updated,UpdatedBy,Version) VALUES (0,200585,2037,0,200012,28,392,'CopyFrom',TO_DATE('2012-10-04 13:30:33','YYYY-MM-DD HH24:MI:SS'),100,'N','Copy From Record','D',1,'Copy From Record','Y','Y','Y','N','N','N','N','N','N','N','N','N','N','Y','Copy From',0,TO_DATE('2012-10-04 13:30:33','YYYY-MM-DD HH24:MI:SS'),100,0)
+;
+
+-- Oct 4, 2012 1:30:34 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Column_Trl (AD_Language,AD_Column_ID, Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Column_ID, t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Column t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Column_ID=200585 AND NOT EXISTS (SELECT * FROM AD_Column_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Column_ID=t.AD_Column_ID)
+;
+
+-- Oct 4, 2012 1:30:36 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+ALTER TABLE C_BankStatement ADD CopyFrom CHAR(1) DEFAULT 'N'
+;
+
+-- Oct 4, 2012 1:30:48 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,200585,200599,0,328,TO_DATE('2012-10-04 13:30:48','YYYY-MM-DD HH24:MI:SS'),100,'Copy From Record',1,'D','Copy From Record','Y','Y','Y','N','N','N','N','N','Copy From',TO_DATE('2012-10-04 13:30:48','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- Oct 4, 2012 1:30:48 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=200599 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
+;
+
+-- Oct 4, 2012 1:30:49 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,59035,200600,0,328,TO_DATE('2012-10-04 13:30:49','YYYY-MM-DD HH24:MI:SS'),100,'The date+time (expressed in decimal format) when the document has been processed',20,'D','The ProcessedOn Date+Time save the exact moment (nanoseconds precision if allowed by the DB) when a document has been processed.','Y','Y','Y','N','N','N','N','N','Processed On',TO_DATE('2012-10-04 13:30:49','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- Oct 4, 2012 1:30:49 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=200600 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=0,IsDisplayed='N' WHERE AD_Field_ID=200600
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=140,IsDisplayed='Y' WHERE AD_Field_ID=200599
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=150,IsDisplayed='Y' WHERE AD_Field_ID=8686
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=160,IsDisplayed='Y' WHERE AD_Field_ID=8687
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=170,IsDisplayed='Y' WHERE AD_Field_ID=10585
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=180,IsDisplayed='Y' WHERE AD_Field_ID=10586
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=190,IsDisplayed='Y' WHERE AD_Field_ID=10587
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=200,IsDisplayed='Y' WHERE AD_Field_ID=3999
+;
+
+-- Oct 4, 2012 1:31:11 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET IsSameLine='Y',Updated=TO_DATE('2012-10-04 13:31:11','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=200599
+;
+
+SELECT register_migration_script('201212120818_IDEMPIERE-448.sql') FROM dual
+;
\ No newline at end of file
diff --git a/migration/i1.0a-release/postgresql/201212120818_IDEMPIERE-448.sql b/migration/i1.0a-release/postgresql/201212120818_IDEMPIERE-448.sql
new file mode 100644
index 0000000000..1a6fb88549
--- /dev/null
+++ b/migration/i1.0a-release/postgresql/201212120818_IDEMPIERE-448.sql
@@ -0,0 +1,107 @@
+-- Oct 4, 2012 1:29:34 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Process (AD_Client_ID,AD_Org_ID,AD_Process_ID,AccessLevel,Classname,CopyFromProcess,Created,CreatedBy,Description,EntityType,IsActive,IsBetaFunctionality,IsDirectPrint,IsReport,IsServerProcess,Name,ShowHelp,Statistic_Count,Statistic_Seconds,Updated,UpdatedBy,Value) VALUES (0,0,200012,'1','org.compiere.process.CopyFromBankStmt','N',TO_TIMESTAMP('2012-10-04 13:29:33','YYYY-MM-DD HH24:MI:SS'),100,'Copy Lines from other bank statement','D','Y','N','N','N','N','Copy Lines','Y',0,0,TO_TIMESTAMP('2012-10-04 13:29:33','YYYY-MM-DD HH24:MI:SS'),100,'C_BankStatement CopyFrom')
+;
+
+-- Oct 4, 2012 1:29:35 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Process_Trl (AD_Language,AD_Process_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Process_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Process t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Process_ID=200012 AND NOT EXISTS (SELECT * FROM AD_Process_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Process_ID=t.AD_Process_ID)
+;
+
+-- Oct 4, 2012 1:30:09 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Val_Rule (AD_Client_ID,AD_Org_ID,AD_Val_Rule_ID,Code,Created,CreatedBy,EntityType,IsActive,Name,Type,Updated,UpdatedBy) VALUES (0,0,200008,'C_BankStatement.C_BankAccount_ID=@C_BankAccount_ID@',TO_TIMESTAMP('2012-10-04 13:30:09','YYYY-MM-DD HH24:MI:SS'),100,'D','Y','BankStatement of BankAccount','S',TO_TIMESTAMP('2012-10-04 13:30:09','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- Oct 4, 2012 1:30:16 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Process_Para (AD_Client_ID,AD_Element_ID,AD_Org_ID,AD_Process_ID,AD_Process_Para_ID,AD_Reference_ID,AD_Val_Rule_ID,ColumnName,Created,CreatedBy,Description,EntityType,FieldLength,Help,IsActive,IsCentrallyMaintained,IsEncrypted,IsMandatory,IsRange,Name,SeqNo,Updated,UpdatedBy) VALUES (0,1381,0,200012,200043,30,200008,'C_BankStatement_ID',TO_TIMESTAMP('2012-10-04 13:30:16','YYYY-MM-DD HH24:MI:SS'),100,'Bank Statement of account','D',0,'The Bank Statement identifies a unique Bank Statement for a defined time period.  The statement defines all transactions that occurred','Y','Y','N','Y','N','Bank Statement',10,TO_TIMESTAMP('2012-10-04 13:30:16','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- Oct 4, 2012 1:30:17 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Process_Para_Trl (AD_Language,AD_Process_Para_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Process_Para_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Process_Para t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Process_Para_ID=200043 AND NOT EXISTS (SELECT * FROM AD_Process_Para_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Process_Para_ID=t.AD_Process_Para_ID)
+;
+
+-- Oct 4, 2012 1:30:34 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Column (AD_Client_ID,AD_Column_ID,AD_Element_ID,AD_Org_ID,AD_Process_ID,AD_Reference_ID,AD_Table_ID,ColumnName,Created,CreatedBy,DefaultValue,Description,EntityType,FieldLength,Help,IsActive,IsAllowCopy,IsAllowLogging,IsAlwaysUpdateable,IsAutocomplete,IsEncrypted,IsIdentifier,IsKey,IsMandatory,IsParent,IsSelectionColumn,IsSyncDatabase,IsTranslated,IsUpdateable,Name,SeqNo,Updated,UpdatedBy,Version) VALUES (0,200585,2037,0,200012,28,392,'CopyFrom',TO_TIMESTAMP('2012-10-04 13:30:33','YYYY-MM-DD HH24:MI:SS'),100,'N','Copy From Record','D',1,'Copy From Record','Y','Y','Y','N','N','N','N','N','N','N','N','N','N','Y','Copy From',0,TO_TIMESTAMP('2012-10-04 13:30:33','YYYY-MM-DD HH24:MI:SS'),100,0)
+;
+
+-- Oct 4, 2012 1:30:34 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Column_Trl (AD_Language,AD_Column_ID, Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Column_ID, t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Column t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Column_ID=200585 AND NOT EXISTS (SELECT * FROM AD_Column_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Column_ID=t.AD_Column_ID)
+;
+
+-- Oct 4, 2012 1:30:36 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+ALTER TABLE C_BankStatement ADD COLUMN CopyFrom CHAR(1) DEFAULT 'N' 
+;
+
+-- Oct 4, 2012 1:30:48 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,200585,200599,0,328,TO_TIMESTAMP('2012-10-04 13:30:48','YYYY-MM-DD HH24:MI:SS'),100,'Copy From Record',1,'D','Copy From Record','Y','Y','Y','N','N','N','N','N','Copy From',TO_TIMESTAMP('2012-10-04 13:30:48','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- Oct 4, 2012 1:30:48 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=200599 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
+;
+
+-- Oct 4, 2012 1:30:49 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,59035,200600,0,328,TO_TIMESTAMP('2012-10-04 13:30:49','YYYY-MM-DD HH24:MI:SS'),100,'The date+time (expressed in decimal format) when the document has been processed',20,'D','The ProcessedOn Date+Time save the exact moment (nanoseconds precision if allowed by the DB) when a document has been processed.','Y','Y','Y','N','N','N','N','N','Processed On',TO_TIMESTAMP('2012-10-04 13:30:49','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- Oct 4, 2012 1:30:49 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=200600 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=0,IsDisplayed='N' WHERE AD_Field_ID=200600
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=140,IsDisplayed='Y' WHERE AD_Field_ID=200599
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=150,IsDisplayed='Y' WHERE AD_Field_ID=8686
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=160,IsDisplayed='Y' WHERE AD_Field_ID=8687
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=170,IsDisplayed='Y' WHERE AD_Field_ID=10585
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=180,IsDisplayed='Y' WHERE AD_Field_ID=10586
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=190,IsDisplayed='Y' WHERE AD_Field_ID=10587
+;
+
+-- Oct 4, 2012 1:31:05 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET SeqNo=200,IsDisplayed='Y' WHERE AD_Field_ID=3999
+;
+
+-- Oct 4, 2012 1:31:11 PM CEST
+-- IDEMPIERE-344 - Improve usability for GL Journal
+UPDATE AD_Field SET IsSameLine='Y',Updated=TO_TIMESTAMP('2012-10-04 13:31:11','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=200599
+;
+
+SELECT register_migration_script('201212120818_IDEMPIERE-448.sql') FROM dual
+;
\ No newline at end of file
diff --git a/org.adempiere.base.process/src/org/compiere/process/CopyFromBankStmt.java b/org.adempiere.base.process/src/org/compiere/process/CopyFromBankStmt.java
new file mode 100644
index 0000000000..e9a4fe5b0a
--- /dev/null
+++ b/org.adempiere.base.process/src/org/compiere/process/CopyFromBankStmt.java
@@ -0,0 +1,111 @@
+/******************************************************************************
+ * Product: Adempiere ERP & CRM Smart Business Solution                       *
+ * Copyright (C) 1999-2006 ComPiere, Inc. All Rights Reserved.                *
+ * This program is free software; you can redistribute it and/or modify it    *
+ * under the terms version 2 of the GNU General Public License as published   *
+ * by the Free Software Foundation. This program is distributed in the hope   *
+ * that it will be useful, but WITHOUT ANY WARRANTY; without even the implied *
+ * warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.           *
+ * See the GNU General Public License for more details.                       *
+ * You should have received a copy of the GNU General Public License along    *
+ * with this program; if not, write to the Free Software Foundation, Inc.,    *
+ * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.                     *
+ * For the text or an alternative of this public license, you may reach us    *
+ * ComPiere, Inc., 2620 Augustine Dr. #245, Santa Clara, CA 95054, USA        *
+ * or via info@compiere.org or http://www.compiere.org/license.html           *
+ *****************************************************************************/
+package org.compiere.process;
+
+import java.math.BigDecimal;
+import java.util.logging.Level;
+
+import org.compiere.model.MBankStatement;
+import org.compiere.model.MBankStatementLine;
+import org.compiere.model.MPayment;
+import org.compiere.model.X_C_BankStatement;
+import org.compiere.util.DB;
+
+/**
+ *  Copy BankStatement Lines :
+ *   - lines without payment only if bank statement is CO/CL (otherwise, line amounts are set to 0)
+ *   - lines with a payment only if this payment is not on another CO/CL/DR bank statement
+ *
+ *	@author Nicolas Micoud - IDEMPIERE 448
+ */
+public class CopyFromBankStmt extends SvrProcess
+{
+	private int		m_C_BankStatement_ID = 0;
+
+	/**
+	 *  Prepare - e.g., get Parameters.
+	 */
+	protected void prepare()
+	{
+		ProcessInfoParameter[] para = getParameter();
+		for (int i = 0; i < para.length; i++)
+		{
+			String name = para[i].getParameterName();
+			if (para[i].getParameter() == null)
+				;
+			else if (name.equals("C_BankStatement_ID"))
+				m_C_BankStatement_ID = ((BigDecimal)para[i].getParameter()).intValue();
+			else
+				log.log(Level.SEVERE, "prepare - Unknown Parameter: " + name);
+		}
+	}	//	prepare
+
+	/**
+	 *  Perform process.
+	 *  @return Message 
+	 *  @throws Exception if not successful
+	 */
+	protected String doIt() throws Exception
+	{
+		int To_C_BankStatement_ID = getRecord_ID();
+		log.info("From C_BankStatement_ID=" + m_C_BankStatement_ID + " to " + To_C_BankStatement_ID);
+		if (To_C_BankStatement_ID == 0)
+			throw new IllegalArgumentException("Target C_BankStatement_ID == 0");
+		if (m_C_BankStatement_ID == 0)
+			throw new IllegalArgumentException("Source C_BankStatement_ID == 0");
+
+		MBankStatement from = new MBankStatement(getCtx(), m_C_BankStatement_ID, get_TrxName());
+		MBankStatement to = new MBankStatement (getCtx(), To_C_BankStatement_ID, get_TrxName());
+		int no = 0;
+
+		MBankStatementLine[] fromLines = from.getLines(false);
+		for (int i = 0; i < fromLines.length; i++)
+		{
+			MBankStatementLine fromLine = fromLines[i];
+
+			if (fromLine.getC_Payment_ID() > 0)
+			{
+				// check if payment is used on another statement
+				String sql = "SELECT C_BankStatementLine_ID"
+						+ " FROM C_BankStatementLine bsl, C_BankStatement bs"
+						+ " WHERE bs.C_BankStatement_ID=bsl.C_BankStatement_ID"
+						+ " AND bs.DocStatus IN ('DR', 'CO', 'CL')"
+						+ " AND bsl.C_Payment_ID="+fromLine.getC_Payment_ID();
+				if (DB.getSQLValueEx(get_TrxName(), sql) == 0)
+				{
+					MBankStatementLine toLine = new MBankStatementLine(to);
+					toLine.setPayment(new MPayment(getCtx(), fromLine.getC_Payment_ID(), get_TrxName()));
+					toLine.saveEx();
+					no++;
+				}
+			}
+			else if (from.getDocStatus().equals(X_C_BankStatement.DOCSTATUS_Completed) || from.getDocStatus().equals(X_C_BankStatement.DOCSTATUS_Closed))
+			{
+				MBankStatementLine toLine = new MBankStatementLine(to);
+				toLine.setC_Currency_ID(fromLine.getC_Currency_ID());
+				toLine.setC_Charge_ID(fromLine.getC_Charge_ID());
+				toLine.setStmtAmt(fromLine.getStmtAmt());
+				toLine.setTrxAmt(fromLine.getTrxAmt());
+				toLine.setChargeAmt(fromLine.getChargeAmt());
+				toLine.setInterestAmt(fromLine.getInterestAmt());
+				toLine.saveEx();
+				no++;
+			}
+		}
+		return "@Copied@=" + no;
+	}	//	doIt
+}	//	CopyFromBankStmt
\ No newline at end of file

From 9cbce666198b1856e817e178fe8595b30b94970f Mon Sep 17 00:00:00 2001
From: Nicolas Micoud <nmicoud@tgi.fr>
Date: Fri, 30 Nov 2012 18:05:28 +0100
Subject: [PATCH 15/29] Tree updates fails (swing mode) ; refer to
 https://groups.google.com/forum/#!topic/idempiere/ETF7fymVZRM

---
 .../src/org/compiere/grid/tree/AdempiereTreeModel.java          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/tree/AdempiereTreeModel.java b/org.adempiere.ui.swing/src/org/compiere/grid/tree/AdempiereTreeModel.java
index 76213745b2..7fbda8c7d5 100644
--- a/org.adempiere.ui.swing/src/org/compiere/grid/tree/AdempiereTreeModel.java
+++ b/org.adempiere.ui.swing/src/org/compiere/grid/tree/AdempiereTreeModel.java
@@ -77,7 +77,7 @@ public class AdempiereTreeModel extends DefaultTreeModel {
 				no = DB.executeUpdate(sql.toString(),trx.getTrxName());
 			}
 			if (from != to)
-				for (int i = 0; i < to.getChildCount(); i++)
+				for (int i = 0; i < to.getChildCount()-1; i++)
 				{
 					MTreeNode nd = (MTreeNode)to.getChildAt(i);
 					StringBuffer sql = new StringBuffer("UPDATE ");

From b148b488fa2488424fb5e6795bdf64e73f5eae41 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Wed, 12 Dec 2012 09:02:41 -0500
Subject: [PATCH 16/29] IDEMPIERE-448 Add CopyFrom on Bank Statement / Peer
 review

---
 .../oracle/201212120818_IDEMPIERE-448.sql     | 28 ++++---------------
 .../postgresql/201212120818_IDEMPIERE-448.sql | 28 ++++---------------
 .../compiere/process/CopyFromBankStmt.java    | 17 +++++------
 3 files changed, 21 insertions(+), 52 deletions(-)

diff --git a/migration/i1.0a-release/oracle/201212120818_IDEMPIERE-448.sql b/migration/i1.0a-release/oracle/201212120818_IDEMPIERE-448.sql
index e8958432fd..540f03d2a0 100644
--- a/migration/i1.0a-release/oracle/201212120818_IDEMPIERE-448.sql
+++ b/migration/i1.0a-release/oracle/201212120818_IDEMPIERE-448.sql
@@ -1,107 +1,91 @@
 -- Oct 4, 2012 1:29:34 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
+-- IDEMPIERE-448 Add CopyFrom on Bank Statement
 INSERT INTO AD_Process (AD_Client_ID,AD_Org_ID,AD_Process_ID,AccessLevel,Classname,CopyFromProcess,Created,CreatedBy,Description,EntityType,IsActive,IsBetaFunctionality,IsDirectPrint,IsReport,IsServerProcess,Name,ShowHelp,Statistic_Count,Statistic_Seconds,Updated,UpdatedBy,Value) VALUES (0,0,200012,'1','org.compiere.process.CopyFromBankStmt','N',TO_DATE('2012-10-04 13:29:33','YYYY-MM-DD HH24:MI:SS'),100,'Copy Lines from other bank statement','D','Y','N','N','N','N','Copy Lines','Y',0,0,TO_DATE('2012-10-04 13:29:33','YYYY-MM-DD HH24:MI:SS'),100,'C_BankStatement CopyFrom')
 ;
 
 -- Oct 4, 2012 1:29:35 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Process_Trl (AD_Language,AD_Process_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Process_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Process t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Process_ID=200012 AND NOT EXISTS (SELECT * FROM AD_Process_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Process_ID=t.AD_Process_ID)
 ;
 
 -- Oct 4, 2012 1:30:09 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Val_Rule (AD_Client_ID,AD_Org_ID,AD_Val_Rule_ID,Code,Created,CreatedBy,EntityType,IsActive,Name,Type,Updated,UpdatedBy) VALUES (0,0,200008,'C_BankStatement.C_BankAccount_ID=@C_BankAccount_ID@',TO_DATE('2012-10-04 13:30:09','YYYY-MM-DD HH24:MI:SS'),100,'D','Y','BankStatement of BankAccount','S',TO_DATE('2012-10-04 13:30:09','YYYY-MM-DD HH24:MI:SS'),100)
 ;
 
 -- Oct 4, 2012 1:30:16 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Process_Para (AD_Client_ID,AD_Element_ID,AD_Org_ID,AD_Process_ID,AD_Process_Para_ID,AD_Reference_ID,AD_Val_Rule_ID,ColumnName,Created,CreatedBy,Description,EntityType,FieldLength,Help,IsActive,IsCentrallyMaintained,IsEncrypted,IsMandatory,IsRange,Name,SeqNo,Updated,UpdatedBy) VALUES (0,1381,0,200012,200043,30,200008,'C_BankStatement_ID',TO_DATE('2012-10-04 13:30:16','YYYY-MM-DD HH24:MI:SS'),100,'Bank Statement of account','D',0,'The Bank Statement identifies a unique Bank Statement for a defined time period.  The statement defines all transactions that occurred','Y','Y','N','Y','N','Bank Statement',10,TO_DATE('2012-10-04 13:30:16','YYYY-MM-DD HH24:MI:SS'),100)
 ;
 
 -- Oct 4, 2012 1:30:17 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Process_Para_Trl (AD_Language,AD_Process_Para_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Process_Para_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Process_Para t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Process_Para_ID=200043 AND NOT EXISTS (SELECT * FROM AD_Process_Para_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Process_Para_ID=t.AD_Process_Para_ID)
 ;
 
 -- Oct 4, 2012 1:30:34 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Column (AD_Client_ID,AD_Column_ID,AD_Element_ID,AD_Org_ID,AD_Process_ID,AD_Reference_ID,AD_Table_ID,ColumnName,Created,CreatedBy,DefaultValue,Description,EntityType,FieldLength,Help,IsActive,IsAllowCopy,IsAllowLogging,IsAlwaysUpdateable,IsAutocomplete,IsEncrypted,IsIdentifier,IsKey,IsMandatory,IsParent,IsSelectionColumn,IsSyncDatabase,IsTranslated,IsUpdateable,Name,SeqNo,Updated,UpdatedBy,Version) VALUES (0,200585,2037,0,200012,28,392,'CopyFrom',TO_DATE('2012-10-04 13:30:33','YYYY-MM-DD HH24:MI:SS'),100,'N','Copy From Record','D',1,'Copy From Record','Y','Y','Y','N','N','N','N','N','N','N','N','N','N','Y','Copy From',0,TO_DATE('2012-10-04 13:30:33','YYYY-MM-DD HH24:MI:SS'),100,0)
 ;
 
 -- Oct 4, 2012 1:30:34 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Column_Trl (AD_Language,AD_Column_ID, Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Column_ID, t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Column t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Column_ID=200585 AND NOT EXISTS (SELECT * FROM AD_Column_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Column_ID=t.AD_Column_ID)
 ;
 
 -- Oct 4, 2012 1:30:36 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 ALTER TABLE C_BankStatement ADD CopyFrom CHAR(1) DEFAULT 'N'
 ;
 
 -- Oct 4, 2012 1:30:48 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,200585,200599,0,328,TO_DATE('2012-10-04 13:30:48','YYYY-MM-DD HH24:MI:SS'),100,'Copy From Record',1,'D','Copy From Record','Y','Y','Y','N','N','N','N','N','Copy From',TO_DATE('2012-10-04 13:30:48','YYYY-MM-DD HH24:MI:SS'),100)
 ;
 
 -- Oct 4, 2012 1:30:48 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=200599 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
 ;
 
 -- Oct 4, 2012 1:30:49 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,59035,200600,0,328,TO_DATE('2012-10-04 13:30:49','YYYY-MM-DD HH24:MI:SS'),100,'The date+time (expressed in decimal format) when the document has been processed',20,'D','The ProcessedOn Date+Time save the exact moment (nanoseconds precision if allowed by the DB) when a document has been processed.','Y','Y','Y','N','N','N','N','N','Processed On',TO_DATE('2012-10-04 13:30:49','YYYY-MM-DD HH24:MI:SS'),100)
 ;
 
 -- Oct 4, 2012 1:30:49 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=200600 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=0,IsDisplayed='N' WHERE AD_Field_ID=200600
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=140,IsDisplayed='Y' WHERE AD_Field_ID=200599
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=150,IsDisplayed='Y' WHERE AD_Field_ID=8686
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=160,IsDisplayed='Y' WHERE AD_Field_ID=8687
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=170,IsDisplayed='Y' WHERE AD_Field_ID=10585
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=180,IsDisplayed='Y' WHERE AD_Field_ID=10586
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=190,IsDisplayed='Y' WHERE AD_Field_ID=10587
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=200,IsDisplayed='Y' WHERE AD_Field_ID=3999
 ;
 
 -- Oct 4, 2012 1:31:11 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET IsSameLine='Y',Updated=TO_DATE('2012-10-04 13:31:11','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=200599
 ;
 
+-- Dec 12, 2012 8:59:07 AM COT
+UPDATE AD_Val_Rule SET Code='C_BankStatement.C_BankAccount_ID=@C_BankAccount_ID@ AND C_BankStatement.DocStatus IN (''CO'',''CL'')',Updated=TO_DATE('2012-12-12 08:59:07','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Val_Rule_ID=200008
+;
+
 SELECT register_migration_script('201212120818_IDEMPIERE-448.sql') FROM dual
-;
\ No newline at end of file
+;
diff --git a/migration/i1.0a-release/postgresql/201212120818_IDEMPIERE-448.sql b/migration/i1.0a-release/postgresql/201212120818_IDEMPIERE-448.sql
index 1a6fb88549..c89e6fea29 100644
--- a/migration/i1.0a-release/postgresql/201212120818_IDEMPIERE-448.sql
+++ b/migration/i1.0a-release/postgresql/201212120818_IDEMPIERE-448.sql
@@ -1,107 +1,91 @@
 -- Oct 4, 2012 1:29:34 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
+-- IDEMPIERE-448 Add CopyFrom on Bank Statement
 INSERT INTO AD_Process (AD_Client_ID,AD_Org_ID,AD_Process_ID,AccessLevel,Classname,CopyFromProcess,Created,CreatedBy,Description,EntityType,IsActive,IsBetaFunctionality,IsDirectPrint,IsReport,IsServerProcess,Name,ShowHelp,Statistic_Count,Statistic_Seconds,Updated,UpdatedBy,Value) VALUES (0,0,200012,'1','org.compiere.process.CopyFromBankStmt','N',TO_TIMESTAMP('2012-10-04 13:29:33','YYYY-MM-DD HH24:MI:SS'),100,'Copy Lines from other bank statement','D','Y','N','N','N','N','Copy Lines','Y',0,0,TO_TIMESTAMP('2012-10-04 13:29:33','YYYY-MM-DD HH24:MI:SS'),100,'C_BankStatement CopyFrom')
 ;
 
 -- Oct 4, 2012 1:29:35 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Process_Trl (AD_Language,AD_Process_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Process_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Process t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Process_ID=200012 AND NOT EXISTS (SELECT * FROM AD_Process_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Process_ID=t.AD_Process_ID)
 ;
 
 -- Oct 4, 2012 1:30:09 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Val_Rule (AD_Client_ID,AD_Org_ID,AD_Val_Rule_ID,Code,Created,CreatedBy,EntityType,IsActive,Name,Type,Updated,UpdatedBy) VALUES (0,0,200008,'C_BankStatement.C_BankAccount_ID=@C_BankAccount_ID@',TO_TIMESTAMP('2012-10-04 13:30:09','YYYY-MM-DD HH24:MI:SS'),100,'D','Y','BankStatement of BankAccount','S',TO_TIMESTAMP('2012-10-04 13:30:09','YYYY-MM-DD HH24:MI:SS'),100)
 ;
 
 -- Oct 4, 2012 1:30:16 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Process_Para (AD_Client_ID,AD_Element_ID,AD_Org_ID,AD_Process_ID,AD_Process_Para_ID,AD_Reference_ID,AD_Val_Rule_ID,ColumnName,Created,CreatedBy,Description,EntityType,FieldLength,Help,IsActive,IsCentrallyMaintained,IsEncrypted,IsMandatory,IsRange,Name,SeqNo,Updated,UpdatedBy) VALUES (0,1381,0,200012,200043,30,200008,'C_BankStatement_ID',TO_TIMESTAMP('2012-10-04 13:30:16','YYYY-MM-DD HH24:MI:SS'),100,'Bank Statement of account','D',0,'The Bank Statement identifies a unique Bank Statement for a defined time period.  The statement defines all transactions that occurred','Y','Y','N','Y','N','Bank Statement',10,TO_TIMESTAMP('2012-10-04 13:30:16','YYYY-MM-DD HH24:MI:SS'),100)
 ;
 
 -- Oct 4, 2012 1:30:17 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Process_Para_Trl (AD_Language,AD_Process_Para_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Process_Para_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Process_Para t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Process_Para_ID=200043 AND NOT EXISTS (SELECT * FROM AD_Process_Para_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Process_Para_ID=t.AD_Process_Para_ID)
 ;
 
 -- Oct 4, 2012 1:30:34 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Column (AD_Client_ID,AD_Column_ID,AD_Element_ID,AD_Org_ID,AD_Process_ID,AD_Reference_ID,AD_Table_ID,ColumnName,Created,CreatedBy,DefaultValue,Description,EntityType,FieldLength,Help,IsActive,IsAllowCopy,IsAllowLogging,IsAlwaysUpdateable,IsAutocomplete,IsEncrypted,IsIdentifier,IsKey,IsMandatory,IsParent,IsSelectionColumn,IsSyncDatabase,IsTranslated,IsUpdateable,Name,SeqNo,Updated,UpdatedBy,Version) VALUES (0,200585,2037,0,200012,28,392,'CopyFrom',TO_TIMESTAMP('2012-10-04 13:30:33','YYYY-MM-DD HH24:MI:SS'),100,'N','Copy From Record','D',1,'Copy From Record','Y','Y','Y','N','N','N','N','N','N','N','N','N','N','Y','Copy From',0,TO_TIMESTAMP('2012-10-04 13:30:33','YYYY-MM-DD HH24:MI:SS'),100,0)
 ;
 
 -- Oct 4, 2012 1:30:34 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Column_Trl (AD_Language,AD_Column_ID, Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Column_ID, t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Column t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Column_ID=200585 AND NOT EXISTS (SELECT * FROM AD_Column_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Column_ID=t.AD_Column_ID)
 ;
 
 -- Oct 4, 2012 1:30:36 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 ALTER TABLE C_BankStatement ADD COLUMN CopyFrom CHAR(1) DEFAULT 'N' 
 ;
 
 -- Oct 4, 2012 1:30:48 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,200585,200599,0,328,TO_TIMESTAMP('2012-10-04 13:30:48','YYYY-MM-DD HH24:MI:SS'),100,'Copy From Record',1,'D','Copy From Record','Y','Y','Y','N','N','N','N','N','Copy From',TO_TIMESTAMP('2012-10-04 13:30:48','YYYY-MM-DD HH24:MI:SS'),100)
 ;
 
 -- Oct 4, 2012 1:30:48 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=200599 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
 ;
 
 -- Oct 4, 2012 1:30:49 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,59035,200600,0,328,TO_TIMESTAMP('2012-10-04 13:30:49','YYYY-MM-DD HH24:MI:SS'),100,'The date+time (expressed in decimal format) when the document has been processed',20,'D','The ProcessedOn Date+Time save the exact moment (nanoseconds precision if allowed by the DB) when a document has been processed.','Y','Y','Y','N','N','N','N','N','Processed On',TO_TIMESTAMP('2012-10-04 13:30:49','YYYY-MM-DD HH24:MI:SS'),100)
 ;
 
 -- Oct 4, 2012 1:30:49 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=200600 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=0,IsDisplayed='N' WHERE AD_Field_ID=200600
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=140,IsDisplayed='Y' WHERE AD_Field_ID=200599
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=150,IsDisplayed='Y' WHERE AD_Field_ID=8686
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=160,IsDisplayed='Y' WHERE AD_Field_ID=8687
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=170,IsDisplayed='Y' WHERE AD_Field_ID=10585
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=180,IsDisplayed='Y' WHERE AD_Field_ID=10586
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=190,IsDisplayed='Y' WHERE AD_Field_ID=10587
 ;
 
 -- Oct 4, 2012 1:31:05 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET SeqNo=200,IsDisplayed='Y' WHERE AD_Field_ID=3999
 ;
 
 -- Oct 4, 2012 1:31:11 PM CEST
--- IDEMPIERE-344 - Improve usability for GL Journal
 UPDATE AD_Field SET IsSameLine='Y',Updated=TO_TIMESTAMP('2012-10-04 13:31:11','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=200599
 ;
 
+-- Dec 12, 2012 8:59:07 AM COT
+UPDATE AD_Val_Rule SET Code='C_BankStatement.C_BankAccount_ID=@C_BankAccount_ID@ AND C_BankStatement.DocStatus IN (''CO'',''CL'')',Updated=TO_TIMESTAMP('2012-12-12 08:59:07','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Val_Rule_ID=200008
+;
+
 SELECT register_migration_script('201212120818_IDEMPIERE-448.sql') FROM dual
-;
\ No newline at end of file
+;
diff --git a/org.adempiere.base.process/src/org/compiere/process/CopyFromBankStmt.java b/org.adempiere.base.process/src/org/compiere/process/CopyFromBankStmt.java
index e9a4fe5b0a..a117bd8214 100644
--- a/org.adempiere.base.process/src/org/compiere/process/CopyFromBankStmt.java
+++ b/org.adempiere.base.process/src/org/compiere/process/CopyFromBankStmt.java
@@ -22,7 +22,6 @@ import java.util.logging.Level;
 import org.compiere.model.MBankStatement;
 import org.compiere.model.MBankStatementLine;
 import org.compiere.model.MPayment;
-import org.compiere.model.X_C_BankStatement;
 import org.compiere.util.DB;
 
 /**
@@ -71,12 +70,12 @@ public class CopyFromBankStmt extends SvrProcess
 		MBankStatement from = new MBankStatement(getCtx(), m_C_BankStatement_ID, get_TrxName());
 		MBankStatement to = new MBankStatement (getCtx(), To_C_BankStatement_ID, get_TrxName());
 		int no = 0;
+		
+		if ( ! (MBankStatement.DOCSTATUS_Completed.equals(from.getDocStatus()) || MBankStatement.DOCSTATUS_Closed.equals(from.getDocStatus())) )
+			throw new IllegalArgumentException("Source must be closed or complete");
 
-		MBankStatementLine[] fromLines = from.getLines(false);
-		for (int i = 0; i < fromLines.length; i++)
+		for (MBankStatementLine fromLine : from.getLines(false))
 		{
-			MBankStatementLine fromLine = fromLines[i];
-
 			if (fromLine.getC_Payment_ID() > 0)
 			{
 				// check if payment is used on another statement
@@ -84,16 +83,18 @@ public class CopyFromBankStmt extends SvrProcess
 						+ " FROM C_BankStatementLine bsl, C_BankStatement bs"
 						+ " WHERE bs.C_BankStatement_ID=bsl.C_BankStatement_ID"
 						+ " AND bs.DocStatus IN ('DR', 'CO', 'CL')"
-						+ " AND bsl.C_Payment_ID="+fromLine.getC_Payment_ID();
-				if (DB.getSQLValueEx(get_TrxName(), sql) == 0)
+						+ " AND bsl.C_Payment_ID=?";
+				if (DB.getSQLValueEx(get_TrxName(), sql, fromLine.getC_Payment_ID()) < 0)
 				{
 					MBankStatementLine toLine = new MBankStatementLine(to);
 					toLine.setPayment(new MPayment(getCtx(), fromLine.getC_Payment_ID(), get_TrxName()));
 					toLine.saveEx();
 					no++;
+				} else {
+					log.info("C_BankStatementLine not copied - related to a payment already present in a bank statement");
 				}
 			}
-			else if (from.getDocStatus().equals(X_C_BankStatement.DOCSTATUS_Completed) || from.getDocStatus().equals(X_C_BankStatement.DOCSTATUS_Closed))
+			else
 			{
 				MBankStatementLine toLine = new MBankStatementLine(to);
 				toLine.setC_Currency_ID(fromLine.getC_Currency_ID());

From efe1098479321aad40225d4356f19eb636d56631 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Wed, 12 Dec 2012 10:28:08 -0500
Subject: [PATCH 17/29] hg backout f4f8ef565103

---
 .../src/org/compiere/grid/tree/AdempiereTreeModel.java          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/tree/AdempiereTreeModel.java b/org.adempiere.ui.swing/src/org/compiere/grid/tree/AdempiereTreeModel.java
index e892c9445b..c716d3c92d 100644
--- a/org.adempiere.ui.swing/src/org/compiere/grid/tree/AdempiereTreeModel.java
+++ b/org.adempiere.ui.swing/src/org/compiere/grid/tree/AdempiereTreeModel.java
@@ -77,7 +77,7 @@ public class AdempiereTreeModel extends DefaultTreeModel {
 				no = DB.executeUpdate(sql.toString(),trx.getTrxName());
 			}
 			if (from != to)
-				for (int i = 0; i < to.getChildCount()-1; i++)
+				for (int i = 0; i < to.getChildCount(); i++)
 				{
 					MTreeNode nd = (MTreeNode)to.getChildAt(i);
 					StringBuilder sql = new StringBuilder("UPDATE ");

From 4c16922d20027749cb08c0847e60c3fdfc540ccf Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Wed, 12 Dec 2012 10:49:56 -0500
Subject: [PATCH 18/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern NP_NULL_ON_SOME_PATH_EXCEPTION

---
 .../process/ApplyMigrationScripts.java        |  2 +-
 .../adempiere/base/DefaultModelFactory.java   |  2 +-
 .../src/org/compiere/print/PrintData.java     | 13 +++++++-----
 .../src/org/compiere/util/Ini.java            |  8 ++++---
 .../src/org/compiere/util/Secure.java         | 21 +++++++++++--------
 .../adempiere/pipo2/GridTab2PackExporter.java |  2 +-
 .../src/org/compiere/db/DB_PostgreSQL.java    |  2 +-
 7 files changed, 29 insertions(+), 21 deletions(-)

diff --git a/org.adempiere.base.process/src/org/adempiere/process/ApplyMigrationScripts.java b/org.adempiere.base.process/src/org/adempiere/process/ApplyMigrationScripts.java
index 0c2debd39f..c2d1c7db58 100644
--- a/org.adempiere.base.process/src/org/adempiere/process/ApplyMigrationScripts.java
+++ b/org.adempiere.base.process/src/org/adempiere/process/ApplyMigrationScripts.java
@@ -156,7 +156,7 @@ public class ApplyMigrationScripts extends SvrProcess {
 						log.saveError("Error", msglog.toString());
 						log.severe(e.getMessage());
 					} finally {
-						stmt.close();
+						if (stmt != null)stmt.close();
 						if(execOk)
 							conn.commit();
 						else
diff --git a/org.adempiere.base/src/org/adempiere/base/DefaultModelFactory.java b/org.adempiere.base/src/org/adempiere/base/DefaultModelFactory.java
index cf53ee176c..83abb2d5ff 100644
--- a/org.adempiere.base/src/org/adempiere/base/DefaultModelFactory.java
+++ b/org.adempiere.base/src/org/adempiere/base/DefaultModelFactory.java
@@ -269,7 +269,7 @@ public class DefaultModelFactory implements IModelFactory {
 				s_log.warning("No transaction Constructor for " + clazz + " (" + msg + ")");
 			}
 
-			PO po = (PO)constructor.newInstance(new Object[] {Env.getCtx(), new Integer(Record_ID), trxName});
+			PO po = constructor!=null ? (PO)constructor.newInstance(new Object[] {Env.getCtx(), new Integer(Record_ID), trxName}) : null;
 			return po;
 		}
 		catch (Exception e)
diff --git a/org.adempiere.base/src/org/compiere/print/PrintData.java b/org.adempiere.base/src/org/compiere/print/PrintData.java
index 937880f3da..b57ee3d98c 100644
--- a/org.adempiere.base/src/org/compiere/print/PrintData.java
+++ b/org.adempiere.base/src/org/compiere/print/PrintData.java
@@ -639,11 +639,14 @@ public class PrintData implements Serializable
 			e.printStackTrace();
 		}
 		//	Root
-		Element root = document.createElement(PrintData.XML_TAG);
-		root.setAttribute(XML_ATTRIBUTE_NAME, getName());
-		root.setAttribute(XML_ATTRIBUTE_COUNT, String.valueOf(getRowCount()));
-		document.appendChild(root);
-		processXML (this, document, root);
+		if (document != null) {
+			Element root = document.createElement(PrintData.XML_TAG);
+			root.setAttribute(XML_ATTRIBUTE_NAME, getName());
+			root.setAttribute(XML_ATTRIBUTE_COUNT, String.valueOf(getRowCount()));
+			document.appendChild(root);
+			processXML (this, document, root);
+		}
+		
 		return document;
 	}	//	getDocument
 
diff --git a/org.adempiere.base/src/org/compiere/util/Ini.java b/org.adempiere.base/src/org/compiere/util/Ini.java
index 4b1facb955..b39307c61e 100644
--- a/org.adempiere.base/src/org/compiere/util/Ini.java
+++ b/org.adempiere.base/src/org/compiere/util/Ini.java
@@ -329,9 +329,11 @@ public final class Ini implements Serializable
 
 		try
 		{
-			InputStream is = fc.getInputStream();
-			s_prop.load(is);
-			is.close();
+			if (fc != null) {
+				InputStream is = fc.getInputStream();
+				s_prop.load(is);
+				is.close();
+			}			
 		}
 		catch (Throwable t)
 		{
diff --git a/org.adempiere.base/src/org/compiere/util/Secure.java b/org.adempiere.base/src/org/compiere/util/Secure.java
index 3b79e27273..d6fa0c4492 100644
--- a/org.adempiere.base/src/org/compiere/util/Secure.java
+++ b/org.adempiere.base/src/org/compiere/util/Secure.java
@@ -352,16 +352,19 @@ public class Secure implements SecureInterface
 				nsae.printStackTrace();
 			}
 		}
-		//	Reset MessageDigest object
-		m_md.reset();
-		//	Convert String to array of bytes
+        //	Convert String to array of bytes
 		byte[] input = value.getBytes();
-		//	feed this array of bytes to the MessageDigest object
-		m_md.update(input);
-		//	 Get the resulting bytes after the encryption process
-		byte[] output = m_md.digest();
-		m_md.reset();
-		//
+		byte[] output = null;
+		//	Reset MessageDigest object
+		if (m_md != null) {
+			m_md.reset();		
+			//	feed this array of bytes to the MessageDigest object
+			m_md.update(input);
+			//	 Get the resulting bytes after the encryption process
+			output = m_md.digest();
+			m_md.reset();
+			//
+		}
 		return convertToHexString(output);
 	}	//	getDigest
 
diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java b/org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java
index e0800d898c..9b1a1661e3 100644
--- a/org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java
+++ b/org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java
@@ -103,7 +103,7 @@ public class GridTab2PackExporter implements IGridTabExporter {
 			}
 		}
 		try {
-			packOut.export(getPackoutDirectory(), file.getAbsolutePath(), packoutDocument, packoutItems, null);
+			packOut.export(getPackoutDirectory(), file!=null ? file.getAbsolutePath() : null , packoutDocument, packoutItems, null);
 		} catch (Exception e) {
 			throw new AdempiereException(e);
 		}
diff --git a/org.compiere.db.postgresql.provider/src/org/compiere/db/DB_PostgreSQL.java b/org.compiere.db.postgresql.provider/src/org/compiere/db/DB_PostgreSQL.java
index f8f54ae402..2f9339f2f7 100755
--- a/org.compiere.db.postgresql.provider/src/org/compiere/db/DB_PostgreSQL.java
+++ b/org.compiere.db.postgresql.provider/src/org/compiere/db/DB_PostgreSQL.java
@@ -1032,7 +1032,7 @@ public class DB_PostgreSQL implements AdempiereDatabase
 				throw new DBException("Could not lock record for " + po.toString() + " caused by " + e.getLocalizedMessage());
 			} finally {
 				try {
-					setStatementTimeout(stmt.getConnection(), currentTimeout);
+					if(stmt!=null)setStatementTimeout(stmt.getConnection(), currentTimeout);
 				} catch (SQLException e) {}
 				DB.close(rs, stmt);
 			}			

From e377f62aec2101efd4533b6a2b9fd7527d2209ae Mon Sep 17 00:00:00 2001
From: Paul Bowden <pbowden@adaxa.com>
Date: Tue, 26 Jul 2011 15:32:37 +1000
Subject: [PATCH 19/29] Fixes #22 post bank statement on statement date
 (transplanted and modified for idempiere from
 http://adempiere.hg.sourceforge.net/hgweb/adempiere/contribution_adaxa/rev/069a8413c27d)

---
 ...IDEMPIERE-480_780.11_StatementDateAcct.sql | 137 +++++++++++++++++
 ...IDEMPIERE-480_780.11_StatementDateAcct.sql | 139 ++++++++++++++++++
 .../src/org/compiere/acct/DocLine.java        |  23 +++
 .../src/org/compiere/acct/DocLine_Bank.java   |   1 +
 .../org/compiere/acct/Doc_BankStatement.java  |   6 +-
 .../src/org/compiere/acct/FactLine.java       |  12 +-
 6 files changed, 312 insertions(+), 6 deletions(-)
 create mode 100644 migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
 create mode 100644 migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql

diff --git a/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql b/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
new file mode 100644
index 0000000000..a879714def
--- /dev/null
+++ b/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
@@ -0,0 +1,137 @@
+-- 22/07/2011 5:13:40 PM
+-- --
+INSERT INTO AD_Column (AD_Client_ID,AD_Column_ID,AD_Element_ID,AD_Org_ID,AD_Reference_ID,AD_Table_ID,ColumnName,Created,CreatedBy,Description,EntityType,FieldLength,Help,IsActive,IsAllowLogging,IsAlwaysUpdateable,IsAutocomplete,IsEncrypted,IsIdentifier,IsKey,IsMandatory,IsParent,IsSelectionColumn,IsSyncDatabase,IsTranslated,IsUpdateable,Name,SeqNo,Updated,UpdatedBy,Version) VALUES (0,61939,263,0,15,392,'DateAcct',TO_DATE('2011-07-22 17:13:37','YYYY-MM-DD HH24:MI:SS'),100,'Accounting Date','D',7,'The Accounting Date indicates the date to be used on the General Ledger account entries generated from this document. It is also used for any currency conversion.','Y','Y','N','N','N','N','N','Y','N','N','N','N','Y','Account Date',0,TO_DATE('2011-07-22 17:13:37','YYYY-MM-DD HH24:MI:SS'),100,0)
+;
+
+-- 22/07/2011 5:13:40 PM
+-- --
+INSERT INTO AD_Column_Trl (AD_Language,AD_Column_ID, Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Column_ID, t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Column t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Column_ID=61939 AND NOT EXISTS (SELECT * FROM AD_Column_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Column_ID=t.AD_Column_ID)
+;
+
+-- 22/07/2011 5:13:47 PM
+-- --
+ALTER TABLE C_BankStatement ADD DateAcct DATE
+;
+
+update c_bankstatement set dateacct=statementdate;
+
+-- 22/07/2011 5:32:05 PM
+-- --
+ALTER TABLE C_BankStatement MODIFY DateAcct DATE
+;
+
+-- 22/07/2011 5:32:05 PM
+-- --
+ALTER TABLE C_BankStatement MODIFY DateAcct NOT NULL
+;
+
+
+-- 22/07/2011 5:14:50 PM
+-- --
+INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,61939,61967,0,328,TO_DATE('2011-07-22 17:14:49','YYYY-MM-DD HH24:MI:SS'),100,'Accounting Date',7,'D','The Accounting Date indicates the date to be used on the General Ledger account entries generated from this document. It is also used for any currency conversion.','Y','Y','Y','N','N','N','N','N','Account Date',TO_DATE('2011-07-22 17:14:49','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- 22/07/2011 5:14:50 PM
+-- --
+INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=61967 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
+;
+
+-- 22/07/2011 5:14:52 PM
+-- --
+INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,59035,61968,0,328,TO_DATE('2011-07-22 17:14:50','YYYY-MM-DD HH24:MI:SS'),100,'The date+time (expressed in decimal format) when the document has been processed',20,'D','The ProcessedOn Date+Time save the exact moment (nanoseconds precision if allowed by the DB) when a document has been processed.','Y','Y','Y','N','N','N','N','N','Processed On',TO_DATE('2011-07-22 17:14:50','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- 22/07/2011 5:14:52 PM
+-- --
+INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=61968 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=0,IsDisplayed='N' WHERE AD_Field_ID=61968
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=60,IsDisplayed='Y' WHERE AD_Field_ID=61967
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=70,IsDisplayed='Y' WHERE AD_Field_ID=3996
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=80,IsDisplayed='Y' WHERE AD_Field_ID=3998
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=90,IsDisplayed='Y' WHERE AD_Field_ID=4119
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=100,IsDisplayed='Y' WHERE AD_Field_ID=3993
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=110,IsDisplayed='Y' WHERE AD_Field_ID=4365
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=120,IsDisplayed='Y' WHERE AD_Field_ID=4003
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=130,IsDisplayed='Y' WHERE AD_Field_ID=8933
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=140,IsDisplayed='Y' WHERE AD_Field_ID=3997
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=150,IsDisplayed='Y' WHERE AD_Field_ID=8686
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=160,IsDisplayed='Y' WHERE AD_Field_ID=8687
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=170,IsDisplayed='Y' WHERE AD_Field_ID=10585
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=180,IsDisplayed='Y' WHERE AD_Field_ID=10586
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=190,IsDisplayed='Y' WHERE AD_Field_ID=10587
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=200,IsDisplayed='Y' WHERE AD_Field_ID=3999
+;
+
+-- 22/07/2011 5:15:20 PM
+-- --
+UPDATE AD_Field SET IsSameLine='Y',Updated=TO_DATE('2011-07-22 17:15:20','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=61967
+;
+
+-- 26/07/2011 3:12:34 PM
+-- --
+UPDATE AD_Column SET Callout='org.compiere.model.CalloutEngine.dateAcct',Updated=TO_DATE('2011-07-26 15:12:34','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=4918
+;
\ No newline at end of file
diff --git a/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql b/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
new file mode 100644
index 0000000000..197b123770
--- /dev/null
+++ b/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
@@ -0,0 +1,139 @@
+-- 22/07/2011 5:13:40 PM
+-- --
+INSERT INTO AD_Column (AD_Client_ID,AD_Column_ID,AD_Element_ID,AD_Org_ID,AD_Reference_ID,AD_Table_ID,ColumnName,Created,CreatedBy,Description,EntityType,FieldLength,Help,IsActive,IsAllowLogging,IsAlwaysUpdateable,IsAutocomplete,IsEncrypted,IsIdentifier,IsKey,IsMandatory,IsParent,IsSelectionColumn,IsSyncDatabase,IsTranslated,IsUpdateable,Name,SeqNo,Updated,UpdatedBy,Version) VALUES (0,61939,263,0,15,392,'DateAcct',TO_TIMESTAMP('2011-07-22 17:13:37','YYYY-MM-DD HH24:MI:SS'),100,'Accounting Date','D',7,'The Accounting Date indicates the date to be used on the General Ledger account entries generated from this document. It is also used for any currency conversion.','Y','Y','N','N','N','N','N','Y','N','N','N','N','Y','Account Date',0,TO_TIMESTAMP('2011-07-22 17:13:37','YYYY-MM-DD HH24:MI:SS'),100,0)
+;
+
+-- 22/07/2011 5:13:40 PM
+-- --
+INSERT INTO AD_Column_Trl (AD_Language,AD_Column_ID, Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Column_ID, t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Column t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Column_ID=61939 AND NOT EXISTS (SELECT * FROM AD_Column_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Column_ID=t.AD_Column_ID)
+;
+
+-- 22/07/2011 5:13:47 PM
+-- --
+ALTER TABLE C_BankStatement ADD COLUMN DateAcct TIMESTAMP
+;
+
+update c_bankstatement set dateacct=statementdate;
+
+-- 22/07/2011 5:32:05 PM
+-- --
+INSERT INTO t_alter_column values('c_bankstatement','DateAcct','TIMESTAMP',null,null)
+;
+
+-- 22/07/2011 5:32:05 PM
+-- --
+INSERT INTO t_alter_column values('c_bankstatement','DateAcct',null,'NOT NULL',null)
+;
+
+
+-- 22/07/2011 5:14:50 PM
+-- --
+INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,61939,61967,0,328,TO_TIMESTAMP('2011-07-22 17:14:49','YYYY-MM-DD HH24:MI:SS'),100,'Accounting Date',7,'D','The Accounting Date indicates the date to be used on the General Ledger account entries generated from this document. It is also used for any currency conversion.','Y','Y','Y','N','N','N','N','N','Account Date',TO_TIMESTAMP('2011-07-22 17:14:49','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- 22/07/2011 5:14:50 PM
+-- --
+INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=61967 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
+;
+
+-- 22/07/2011 5:14:52 PM
+-- --
+INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,59035,61968,0,328,TO_TIMESTAMP('2011-07-22 17:14:50','YYYY-MM-DD HH24:MI:SS'),100,'The date+time (expressed in decimal format) when the document has been processed',20,'D','The ProcessedOn Date+Time save the exact moment (nanoseconds precision if allowed by the DB) when a document has been processed.','Y','Y','Y','N','N','N','N','N','Processed On',TO_TIMESTAMP('2011-07-22 17:14:50','YYYY-MM-DD HH24:MI:SS'),100)
+;
+
+-- 22/07/2011 5:14:52 PM
+-- --
+INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=61968 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=0,IsDisplayed='N' WHERE AD_Field_ID=61968
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=60,IsDisplayed='Y' WHERE AD_Field_ID=61967
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=70,IsDisplayed='Y' WHERE AD_Field_ID=3996
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=80,IsDisplayed='Y' WHERE AD_Field_ID=3998
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=90,IsDisplayed='Y' WHERE AD_Field_ID=4119
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=100,IsDisplayed='Y' WHERE AD_Field_ID=3993
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=110,IsDisplayed='Y' WHERE AD_Field_ID=4365
+;
+
+-- 22/07/2011 5:15:05 PM
+-- --
+UPDATE AD_Field SET SeqNo=120,IsDisplayed='Y' WHERE AD_Field_ID=4003
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=130,IsDisplayed='Y' WHERE AD_Field_ID=8933
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=140,IsDisplayed='Y' WHERE AD_Field_ID=3997
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=150,IsDisplayed='Y' WHERE AD_Field_ID=8686
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=160,IsDisplayed='Y' WHERE AD_Field_ID=8687
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=170,IsDisplayed='Y' WHERE AD_Field_ID=10585
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=180,IsDisplayed='Y' WHERE AD_Field_ID=10586
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=190,IsDisplayed='Y' WHERE AD_Field_ID=10587
+;
+
+-- 22/07/2011 5:15:06 PM
+-- --
+UPDATE AD_Field SET SeqNo=200,IsDisplayed='Y' WHERE AD_Field_ID=3999
+;
+
+-- 22/07/2011 5:15:20 PM
+-- --
+UPDATE AD_Field SET IsSameLine='Y',Updated=TO_TIMESTAMP('2011-07-22 17:15:20','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=61967
+;
+
+-- 26/07/2011 3:12:34 PM
+-- --
+UPDATE AD_Column SET Callout='org.compiere.model.CalloutEngine.dateAcct',Updated=TO_TIMESTAMP('2011-07-26 15:12:34','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=4918
+;
+
+
diff --git a/org.adempiere.base/src/org/compiere/acct/DocLine.java b/org.adempiere.base/src/org/compiere/acct/DocLine.java
index 4476cafa67..a28f11b81b 100644
--- a/org.adempiere.base/src/org/compiere/acct/DocLine.java
+++ b/org.adempiere.base/src/org/compiere/acct/DocLine.java
@@ -344,6 +344,29 @@ public class DocLine
 		return m_DateAcct;
 	}   //  getDateAcct
 
+	/**
+	 *  Get FX Conversion Date
+	 *  
+	 *  The foreign exchange rate conversion date may be different from the accounting posting date in some cases (e.g. bank statement)
+	 *  
+	 *  @return FX conversion date 
+	 */
+	public Timestamp getDateConv ()
+	{
+		Timestamp dateConv = null;
+		int index = p_po.get_ColumnIndex("DateAcct");
+		if (index != -1)
+		{
+			dateConv = (Timestamp)p_po.get_Value(index);
+		}
+		
+
+		if (dateConv == null)
+			dateConv = getDateAcct();
+		
+		return dateConv;
+	}   //  getDateAcct
+	
 	/**
 	 *  Set Document Date
 	 *  @param dateDoc doc date
diff --git a/org.adempiere.base/src/org/compiere/acct/DocLine_Bank.java b/org.adempiere.base/src/org/compiere/acct/DocLine_Bank.java
index 81b9262ff4..9a49c8a873 100644
--- a/org.adempiere.base/src/org/compiere/acct/DocLine_Bank.java
+++ b/org.adempiere.base/src/org/compiere/acct/DocLine_Bank.java
@@ -46,6 +46,7 @@ public class DocLine_Bank extends DocLine
 		m_TrxAmt = line.getTrxAmt();
 		//
 		setDateDoc(line.getValutaDate());
+		setDateAcct(doc.getDateAcct());  // adaxa-pb use statement date
 		setC_BPartner_ID(line.getC_BPartner_ID());
 	}   //  DocLine_Bank
 
diff --git a/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java b/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
index 6902151eef..595872e40a 100644
--- a/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
+++ b/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
@@ -68,7 +68,7 @@ public class Doc_BankStatement extends Doc
 	{
 		MBankStatement bs = (MBankStatement)getPO();
 		setDateDoc(bs.getStatementDate());
-		setDateAcct(bs.getStatementDate());	//	Overwritten on Line Level
+		setDateAcct(bs.getDateAcct());
 
 		m_C_BankAccount_ID = bs.getC_BankAccount_ID();
 		//	Amounts
@@ -102,9 +102,7 @@ public class Doc_BankStatement extends Doc
 		{
 			MBankStatementLine line = lines[i];
 			DocLine_Bank docLine = new DocLine_Bank(line, this);
-			//	Set Date Acct
-			if (i == 0)
-				setDateAcct(line.getDateAcct());
+			
 			MPeriod period = MPeriod.get(getCtx(), line.getDateAcct(), line.getAD_Org_ID());
 			if (period != null && period.isOpen(DOCTYPE_BankStatement, line.getDateAcct()))
 				docLine.setC_Period_ID(period.getC_Period_ID());
diff --git a/org.adempiere.base/src/org/compiere/acct/FactLine.java b/org.adempiere.base/src/org/compiere/acct/FactLine.java
index 276ed52563..8b211785d3 100644
--- a/org.adempiere.base/src/org/compiere/acct/FactLine.java
+++ b/org.adempiere.base/src/org/compiere/acct/FactLine.java
@@ -20,6 +20,7 @@ import java.math.BigDecimal;
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
+import java.sql.Timestamp;
 import java.util.Properties;
 import java.util.logging.Level;
 
@@ -705,14 +706,21 @@ public final class FactLine extends X_Fact_Acct
 			if (AD_Org_ID == 0)
 				AD_Org_ID = m_doc.getAD_Org_ID();
 		}
+		
+		Timestamp convDate = getDateAcct();
+
+		if ( m_doc instanceof Doc_BankStatement )
+			convDate = m_docLine.getDateConv();				
+			
+		
 		setAmtAcctDr (MConversionRate.convert (getCtx(),
 			getAmtSourceDr(), getC_Currency_ID(), m_acctSchema.getC_Currency_ID(),
-			getDateAcct(), C_ConversionType_ID, m_doc.getAD_Client_ID(), AD_Org_ID));
+			convDate, C_ConversionType_ID, m_doc.getAD_Client_ID(), AD_Org_ID));
 		if (getAmtAcctDr() == null)
 			return false;
 		setAmtAcctCr (MConversionRate.convert (getCtx(),
 			getAmtSourceCr(), getC_Currency_ID(), m_acctSchema.getC_Currency_ID(),
-			getDateAcct(), C_ConversionType_ID, m_doc.getAD_Client_ID(), AD_Org_ID));
+			convDate, C_ConversionType_ID, m_doc.getAD_Client_ID(), AD_Org_ID));
 		return true;
 	}	//	convert
 

From ccf712f7d64d33a5a8e13da8ba8f3bd50832d10c Mon Sep 17 00:00:00 2001
From: Paul Bowden <pbowden@adaxa.com>
Date: Wed, 9 Nov 2011 12:23:30 +1100
Subject: [PATCH 20/29] Bank statement posting period incorrect. Fixes #272
 (transplanted and modified for idempiere from
 http://adempiere.hg.sourceforge.net/hgweb/adempiere/contribution_adaxa/rev/53b4ceb2ecaa)

---
 .../src/org/compiere/acct/Doc_BankStatement.java              | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java b/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
index 595872e40a..59acb3922c 100644
--- a/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
+++ b/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
@@ -103,10 +103,6 @@ public class Doc_BankStatement extends Doc
 			MBankStatementLine line = lines[i];
 			DocLine_Bank docLine = new DocLine_Bank(line, this);
 			
-			MPeriod period = MPeriod.get(getCtx(), line.getDateAcct(), line.getAD_Org_ID());
-			if (period != null && period.isOpen(DOCTYPE_BankStatement, line.getDateAcct()))
-				docLine.setC_Period_ID(period.getC_Period_ID());
-			//
 			list.add(docLine);
 		}
 

From ba35f250bab681b2c599339672debf0de1a66626 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Wed, 12 Dec 2012 11:55:40 -0500
Subject: [PATCH 21/29] IDEMPIERE-480 Huge bug with FactAcctReset and Automatic
 Accounting / Peer review

---
 ...IDEMPIERE-480_780.11_StatementDateAcct.sql | 56 ++++++++++++++++++-
 ...IDEMPIERE-480_780.11_StatementDateAcct.sql | 52 +++++++++++++++++
 .../org/compiere/model/I_C_BankStatement.java | 26 +++++++++
 .../compiere/model/MBankStatementLine.java    |  4 +-
 .../org/compiere/model/X_C_BankStatement.java | 37 +++++++++++-
 5 files changed, 172 insertions(+), 3 deletions(-)

diff --git a/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql b/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
index a879714def..f335ccd20b 100644
--- a/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
+++ b/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
@@ -134,4 +134,58 @@ UPDATE AD_Field SET IsSameLine='Y',Updated=TO_DATE('2011-07-22 17:15:20','YYYY-M
 -- 26/07/2011 3:12:34 PM
 -- --
 UPDATE AD_Column SET Callout='org.compiere.model.CalloutEngine.dateAcct',Updated=TO_DATE('2011-07-26 15:12:34','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=4918
-;
\ No newline at end of file
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET ColumnSpan=2, SeqNo=60, IsDisplayed='Y', XPosition=4,Updated=TO_DATE('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=61967
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=150,Updated=TO_DATE('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=3997
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=160,Updated=TO_DATE('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=8686
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=170,Updated=TO_DATE('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=8687
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=180,Updated=TO_DATE('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=10585
+;
+
+-- Dec 12, 2012 11:39:17 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=190,Updated=TO_DATE('2012-12-12 11:39:17','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=10586
+;
+
+-- Dec 12, 2012 11:39:17 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=200, IsDisplayed='Y', XPosition=5,Updated=TO_DATE('2012-12-12 11:39:17','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=10587
+;
+
+-- Dec 12, 2012 11:39:17 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=210,Updated=TO_DATE('2012-12-12 11:39:17','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=3999
+;
+
+-- Dec 12, 2012 11:41:08 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Column SET DefaultValue='@DateAcct@',Updated=TO_DATE('2012-12-12 11:41:08','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=5216
+;
+
+-- Dec 12, 2012 11:41:34 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET IsReadOnly='Y',Updated=TO_DATE('2012-12-12 11:41:34','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=4121
+;
+
+SELECT register_migration_script('201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql') FROM dual
+;
+
diff --git a/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql b/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
index 197b123770..4834ab8b6e 100644
--- a/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
+++ b/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
@@ -136,4 +136,56 @@ UPDATE AD_Field SET IsSameLine='Y',Updated=TO_TIMESTAMP('2011-07-22 17:15:20','Y
 UPDATE AD_Column SET Callout='org.compiere.model.CalloutEngine.dateAcct',Updated=TO_TIMESTAMP('2011-07-26 15:12:34','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=4918
 ;
 
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET ColumnSpan=2, SeqNo=60, IsDisplayed='Y', XPosition=4,Updated=TO_TIMESTAMP('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=61967
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=150,Updated=TO_TIMESTAMP('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=3997
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=160,Updated=TO_TIMESTAMP('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=8686
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=170,Updated=TO_TIMESTAMP('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=8687
+;
+
+-- Dec 12, 2012 11:39:16 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=180,Updated=TO_TIMESTAMP('2012-12-12 11:39:16','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=10585
+;
+
+-- Dec 12, 2012 11:39:17 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=190,Updated=TO_TIMESTAMP('2012-12-12 11:39:17','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=10586
+;
+
+-- Dec 12, 2012 11:39:17 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=200, IsDisplayed='Y', XPosition=5,Updated=TO_TIMESTAMP('2012-12-12 11:39:17','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=10587
+;
+
+-- Dec 12, 2012 11:39:17 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET SeqNo=210,Updated=TO_TIMESTAMP('2012-12-12 11:39:17','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=3999
+;
+
+-- Dec 12, 2012 11:41:08 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Column SET DefaultValue='@DateAcct@',Updated=TO_TIMESTAMP('2012-12-12 11:41:08','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=5216
+;
+
+-- Dec 12, 2012 11:41:34 AM COT
+-- IDEMPIERE-480 Huge bug with FactAcctReset and Automatic Accounting
+UPDATE AD_Field SET IsReadOnly='Y',Updated=TO_TIMESTAMP('2012-12-12 11:41:34','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Field_ID=4121
+;
+
+SELECT register_migration_script('201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql') FROM dual
+;
 
diff --git a/org.adempiere.base/src/org/compiere/model/I_C_BankStatement.java b/org.adempiere.base/src/org/compiere/model/I_C_BankStatement.java
index 8232c304e8..fa40d567c3 100644
--- a/org.adempiere.base/src/org/compiere/model/I_C_BankStatement.java
+++ b/org.adempiere.base/src/org/compiere/model/I_C_BankStatement.java
@@ -112,6 +112,19 @@ public interface I_C_BankStatement
 	/** Get C_BankStatement_UU	  */
 	public String getC_BankStatement_UU();
 
+    /** Column name CopyFrom */
+    public static final String COLUMNNAME_CopyFrom = "CopyFrom";
+
+	/** Set Copy From.
+	  * Copy From Record
+	  */
+	public void setCopyFrom (String CopyFrom);
+
+	/** Get Copy From.
+	  * Copy From Record
+	  */
+	public String getCopyFrom();
+
     /** Column name Created */
     public static final String COLUMNNAME_Created = "Created";
 
@@ -141,6 +154,19 @@ public interface I_C_BankStatement
 	  */
 	public String getCreateFrom();
 
+    /** Column name DateAcct */
+    public static final String COLUMNNAME_DateAcct = "DateAcct";
+
+	/** Set Account Date.
+	  * Accounting Date
+	  */
+	public void setDateAcct (Timestamp DateAcct);
+
+	/** Get Account Date.
+	  * Accounting Date
+	  */
+	public Timestamp getDateAcct();
+
     /** Column name Description */
     public static final String COLUMNNAME_Description = "Description";
 
diff --git a/org.adempiere.base/src/org/compiere/model/MBankStatementLine.java b/org.adempiere.base/src/org/compiere/model/MBankStatementLine.java
index 16ddc6f419..d2eb6c99e1 100644
--- a/org.adempiere.base/src/org/compiere/model/MBankStatementLine.java
+++ b/org.adempiere.base/src/org/compiere/model/MBankStatementLine.java
@@ -206,7 +206,9 @@ import org.compiere.util.Msg;
 		if (amt.compareTo(getChargeAmt()) != 0)
 			setChargeAmt (amt);
 		//
-		
+		// IDEMPIERE-480
+		setDateAcct(getParent().getDateAcct());
+
 		return true;
 	}	//	beforeSave
 	
diff --git a/org.adempiere.base/src/org/compiere/model/X_C_BankStatement.java b/org.adempiere.base/src/org/compiere/model/X_C_BankStatement.java
index 5d090a4f7a..b23984d113 100644
--- a/org.adempiere.base/src/org/compiere/model/X_C_BankStatement.java
+++ b/org.adempiere.base/src/org/compiere/model/X_C_BankStatement.java
@@ -33,7 +33,7 @@ public class X_C_BankStatement extends PO implements I_C_BankStatement, I_Persis
 	/**
 	 *
 	 */
-	private static final long serialVersionUID = 20121031L;
+	private static final long serialVersionUID = 20121212L;
 
     /** Standard Constructor */
     public X_C_BankStatement (Properties ctx, int C_BankStatement_ID, String trxName)
@@ -43,6 +43,7 @@ public class X_C_BankStatement extends PO implements I_C_BankStatement, I_Persis
         {
 			setC_BankAccount_ID (0);
 			setC_BankStatement_ID (0);
+			setDateAcct (new Timestamp( System.currentTimeMillis() ));
 			setDocAction (null);
 // CO
 			setDocStatus (null);
@@ -175,6 +176,23 @@ public class X_C_BankStatement extends PO implements I_C_BankStatement, I_Persis
 		return (String)get_Value(COLUMNNAME_C_BankStatement_UU);
 	}
 
+	/** Set Copy From.
+		@param CopyFrom 
+		Copy From Record
+	  */
+	public void setCopyFrom (String CopyFrom)
+	{
+		set_Value (COLUMNNAME_CopyFrom, CopyFrom);
+	}
+
+	/** Get Copy From.
+		@return Copy From Record
+	  */
+	public String getCopyFrom () 
+	{
+		return (String)get_Value(COLUMNNAME_CopyFrom);
+	}
+
 	/** Set Create lines from.
 		@param CreateFrom 
 		Process which will generate a new document lines based on an existing document
@@ -192,6 +210,23 @@ public class X_C_BankStatement extends PO implements I_C_BankStatement, I_Persis
 		return (String)get_Value(COLUMNNAME_CreateFrom);
 	}
 
+	/** Set Account Date.
+		@param DateAcct 
+		Accounting Date
+	  */
+	public void setDateAcct (Timestamp DateAcct)
+	{
+		set_Value (COLUMNNAME_DateAcct, DateAcct);
+	}
+
+	/** Get Account Date.
+		@return Accounting Date
+	  */
+	public Timestamp getDateAcct () 
+	{
+		return (Timestamp)get_Value(COLUMNNAME_DateAcct);
+	}
+
 	/** Set Description.
 		@param Description 
 		Optional short description of the record

From e652439bc09082520f251794916c2dfb5c2cad33 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Wed, 12 Dec 2012 14:50:51 -0500
Subject: [PATCH 22/29] IDEMPIERE-480 Huge bug with FactAcctReset and Automatic
 Accounting / Fix dup field error on migration script

---
 ...12121120_IDEMPIERE-480_780.11_StatementDateAcct.sql | 10 ----------
 ...12121120_IDEMPIERE-480_780.11_StatementDateAcct.sql | 10 ----------
 2 files changed, 20 deletions(-)

diff --git a/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql b/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
index f335ccd20b..e3ab5a5974 100644
--- a/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
+++ b/migration/i1.0a-release/oracle/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
@@ -36,16 +36,6 @@ INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,
 INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=61967 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
 ;
 
--- 22/07/2011 5:14:52 PM
--- --
-INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,59035,61968,0,328,TO_DATE('2011-07-22 17:14:50','YYYY-MM-DD HH24:MI:SS'),100,'The date+time (expressed in decimal format) when the document has been processed',20,'D','The ProcessedOn Date+Time save the exact moment (nanoseconds precision if allowed by the DB) when a document has been processed.','Y','Y','Y','N','N','N','N','N','Processed On',TO_DATE('2011-07-22 17:14:50','YYYY-MM-DD HH24:MI:SS'),100)
-;
-
--- 22/07/2011 5:14:52 PM
--- --
-INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=61968 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
-;
-
 -- 22/07/2011 5:15:05 PM
 -- --
 UPDATE AD_Field SET SeqNo=0,IsDisplayed='N' WHERE AD_Field_ID=61968
diff --git a/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql b/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
index 4834ab8b6e..73bf6da3c6 100644
--- a/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
+++ b/migration/i1.0a-release/postgresql/201212121120_IDEMPIERE-480_780.11_StatementDateAcct.sql
@@ -36,16 +36,6 @@ INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,
 INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=61967 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
 ;
 
--- 22/07/2011 5:14:52 PM
--- --
-INSERT INTO AD_Field (AD_Client_ID,AD_Column_ID,AD_Field_ID,AD_Org_ID,AD_Tab_ID,Created,CreatedBy,Description,DisplayLength,EntityType,Help,IsActive,IsCentrallyMaintained,IsDisplayed,IsEncrypted,IsFieldOnly,IsHeading,IsReadOnly,IsSameLine,Name,Updated,UpdatedBy) VALUES (0,59035,61968,0,328,TO_TIMESTAMP('2011-07-22 17:14:50','YYYY-MM-DD HH24:MI:SS'),100,'The date+time (expressed in decimal format) when the document has been processed',20,'D','The ProcessedOn Date+Time save the exact moment (nanoseconds precision if allowed by the DB) when a document has been processed.','Y','Y','Y','N','N','N','N','N','Processed On',TO_TIMESTAMP('2011-07-22 17:14:50','YYYY-MM-DD HH24:MI:SS'),100)
-;
-
--- 22/07/2011 5:14:52 PM
--- --
-INSERT INTO AD_Field_Trl (AD_Language,AD_Field_ID, Description,Help,Name, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language,t.AD_Field_ID, t.Description,t.Help,t.Name, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Field t WHERE l.IsActive='Y' AND l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N' AND t.AD_Field_ID=61968 AND NOT EXISTS (SELECT * FROM AD_Field_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Field_ID=t.AD_Field_ID)
-;
-
 -- 22/07/2011 5:15:05 PM
 -- --
 UPDATE AD_Field SET SeqNo=0,IsDisplayed='N' WHERE AD_Field_ID=61968

From 24e4972406e74e228a2046b31cc3f4348e45debe Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Wed, 12 Dec 2012 16:30:06 -0500
Subject: [PATCH 23/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern NP_NULL_ON_SOME_PATH (Thanks to Richard Morales)

---
 .../util/AbstractDocumentSearch.java          |  8 +++--
 .../src/org/compiere/acct/Doc_MatchPO.java    |  9 ++---
 .../src/org/compiere/model/GridWindowVO.java  |  2 +-
 .../org/compiere/model/MAssetAddition.java    |  6 ++--
 .../src/org/compiere/model/MCost.java         |  2 +-
 .../org/compiere/model/MLookupFactory.java    |  4 +++
 .../src/org/compiere/report/FinReport.java    |  4 +--
 .../idempiere/fa/model/ModelValidator.java    |  2 +-
 .../src/org/adempiere/pipo2/PoFiller.java     |  6 ++--
 .../adempiere/webui/acct/WAcctViewerData.java |  2 +-
 .../webui/adwindow/GridTabRowRenderer.java    | 34 ++++++++++++-------
 .../adempiere/webui/apps/form/WBOMDrop.java   |  2 +-
 .../adempiere/webui/component/WListbox.java   |  2 +-
 .../org/adempiere/webui/panel/RolePanel.java  |  2 +-
 .../db/oracle/config/ConfigOracle.java        |  2 +-
 .../postgresql/config/ConfigPostgreSQL.java   |  2 +-
 .../compiere/dbPort/Convert_PostgreSQL.java   |  2 +-
 .../fitnesse/fixture/CreateRecord.java        |  2 +-
 .../org/idempiere/fitnesse/fixture/Login.java |  2 +-
 .../fitnesse/fixture/ReadRecord.java          |  2 +-
 .../src/com/_3e/ADInterface/ADLookup.java     |  4 +--
 .../com/_3e/ADInterface/ADServiceImpl.java    |  3 +-
 22 files changed, 60 insertions(+), 44 deletions(-)

diff --git a/org.adempiere.base/src/org/adempiere/util/AbstractDocumentSearch.java b/org.adempiere.base/src/org/adempiere/util/AbstractDocumentSearch.java
index 2c21c936bb..aa1436a58f 100644
--- a/org.adempiere.base/src/org/adempiere/util/AbstractDocumentSearch.java
+++ b/org.adempiere.base/src/org/adempiere/util/AbstractDocumentSearch.java
@@ -284,10 +284,12 @@ public abstract class AbstractDocumentSearch {
 				}
 			}
 		}
-		log.fine(whereString.toString());
-		
+
 		final MQuery query = new MQuery(tableName);
-		query.addRestriction(whereString.toString());
+		if (whereString != null) {
+			log.fine(whereString.toString());
+			query.addRestriction(whereString.toString());
+		}
 		final boolean ok = openWindow(windowId, query);
 		if (!ok) {
 			StringBuilder msglog = new StringBuilder("Unable to open window: ").append(whereString.toString());			
diff --git a/org.adempiere.base/src/org/compiere/acct/Doc_MatchPO.java b/org.adempiere.base/src/org/compiere/acct/Doc_MatchPO.java
index bdf68c0f24..33d644db91 100644
--- a/org.adempiere.base/src/org/compiere/acct/Doc_MatchPO.java
+++ b/org.adempiere.base/src/org/compiere/acct/Doc_MatchPO.java
@@ -207,6 +207,7 @@ public class Doc_MatchPO extends Doc
 			FactLine cr = fact.createLine(null,
 				m_pc.getAccount(ProductCost.ACCTTYPE_P_PPV, as),
 				as.getC_Currency_ID(), isReturnTrx ? difference.negate() : difference);
+			MAccount acct_cr = null;
 			if (cr != null)
 			{
 				cr.setQty(isReturnTrx ? getQty().negate() : getQty());
@@ -219,12 +220,14 @@ public class Doc_MatchPO extends Doc
 				cr.setC_UOM_ID(m_oLine.getC_UOM_ID());
 				cr.setUser1_ID(m_oLine.getUser1_ID());
 				cr.setUser2_ID(m_oLine.getUser2_ID());
+				acct_cr = cr.getAccount(); // PPV Offset
 			}
 
 			//  PPV Offset
 			FactLine dr = fact.createLine(null,
 				getAccount(Doc.ACCTTYPE_PPVOffset, as),
 				as.getC_Currency_ID(), isReturnTrx ? difference : difference.negate());
+			MAccount acct_db = null;
 			if (dr != null)
 			{
 				dr.setQty(isReturnTrx ? getQty() : getQty().negate());
@@ -237,16 +240,14 @@ public class Doc_MatchPO extends Doc
 				dr.setC_UOM_ID(m_oLine.getC_UOM_ID());
 				dr.setUser1_ID(m_oLine.getUser1_ID());
 				dr.setUser2_ID(m_oLine.getUser2_ID());
+				acct_db =  dr.getAccount(); // PPV
 			}
 
 			// Avoid usage of clearing accounts
 			// If both accounts Purchase Price Variance and Purchase Price Variance Offset are equal
 			// then remove the posting
 
-			MAccount acct_db =  dr.getAccount(); // PPV
-			MAccount acct_cr = cr.getAccount(); // PPV Offset
-
-			if ((!as.isPostIfClearingEqual()) && acct_db.equals(acct_cr) && (!isInterOrg)) {
+			if ((!as.isPostIfClearingEqual()) && acct_db!=null && acct_db.equals(acct_cr) && (!isInterOrg)) {
 
 				BigDecimal debit = dr.getAmtSourceDr();
 				BigDecimal credit = cr.getAmtSourceCr();
diff --git a/org.adempiere.base/src/org/compiere/model/GridWindowVO.java b/org.adempiere.base/src/org/compiere/model/GridWindowVO.java
index 742f56c8da..23684ca28f 100644
--- a/org.adempiere.base/src/org/compiere/model/GridWindowVO.java
+++ b/org.adempiere.base/src/org/compiere/model/GridWindowVO.java
@@ -165,7 +165,7 @@ public class GridWindowVO implements Serializable
 		}
 		// Ensure ASP exceptions
 		MRole role = MRole.getDefault(ctx, false);
-		final Boolean windowAccess = role.getWindowAccess(vo.AD_Window_ID);
+		final Boolean windowAccess = vo!=null ? role.getWindowAccess(vo.AD_Window_ID) : null;
 		if (vo != null && windowAccess == null)
 			vo = null;		//	Not found
 		if (vo != null && windowAccess != null)
diff --git a/org.adempiere.base/src/org/compiere/model/MAssetAddition.java b/org.adempiere.base/src/org/compiere/model/MAssetAddition.java
index de9f65b4da..40741be988 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetAddition.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetAddition.java
@@ -170,9 +170,9 @@ public class MAssetAddition extends X_A_Asset_Addition
 			asset.setA_Asset_Group_ID(product.getA_Asset_Group_ID());
 			MAttributeSetInstance asi = MAttributeSetInstance.create(Env.getCtx(), product, null);
 			asset.setM_AttributeSetInstance_ID(asi.getM_AttributeSetInstance_ID());
-		}
-		asset.setName(product.getName().concat(project.getName()));
-		asset.setValue(product.getName().concat(project.getName()));	
+			asset.setName(product.getName().concat(project.getName()));
+			asset.setValue(product.getName().concat(project.getName()));
+		}	
 		asset.saveEx();
 		asset.dump();
 		
diff --git a/org.adempiere.base/src/org/compiere/model/MCost.java b/org.adempiere.base/src/org/compiere/model/MCost.java
index ea84d9e3d7..e44bd238bc 100644
--- a/org.adempiere.base/src/org/compiere/model/MCost.java
+++ b/org.adempiere.base/src/org/compiere/model/MCost.java
@@ -1656,7 +1656,7 @@ public class MCost extends X_M_Cost
 		}
 		
 		//-ve current qty will break moving average costing
-		if ((ce.isAveragePO() || ce.isAverageInvoice()) && is_ValueChanged(COLUMNNAME_CurrentQty)) 
+		if (ce!=null && (ce.isAveragePO() || ce.isAverageInvoice()) && is_ValueChanged(COLUMNNAME_CurrentQty)) 
 		{
 			if (getCurrentQty().signum() < 0)
 			{
diff --git a/org.adempiere.base/src/org/compiere/model/MLookupFactory.java b/org.adempiere.base/src/org/compiere/model/MLookupFactory.java
index 4d80ac42ae..a29c4f8407 100644
--- a/org.adempiere.base/src/org/compiere/model/MLookupFactory.java
+++ b/org.adempiere.base/src/org/compiere/model/MLookupFactory.java
@@ -450,6 +450,8 @@ public class MLookupFactory
 				{
 					s_log.log(Level.INFO, "No Identifier records found: " + KeyColumn);
 				}
+				if (list == null)
+					list = new ArrayList<LookupDisplayColumn>();
 				list.add(new LookupDisplayColumn(KeyColumn, null, false, DisplayType.ID, 0));
 			}
 			// set isTranslated
@@ -699,6 +701,8 @@ public class MLookupFactory
 			{
 				s_log.log(Level.INFO, "No Identifier records found: " + ColumnName);
 			}
+			if (list == null)
+				list = new ArrayList<LookupDisplayColumn>();
 			list.add(new LookupDisplayColumn(KeyColumn, null, false, DisplayType.ID, 0));
 		}
 
diff --git a/org.adempiere.base/src/org/compiere/report/FinReport.java b/org.adempiere.base/src/org/compiere/report/FinReport.java
index 92553320ec..ab37f9f7ec 100644
--- a/org.adempiere.base/src/org/compiere/report/FinReport.java
+++ b/org.adempiere.base/src/org/compiere/report/FinReport.java
@@ -458,7 +458,7 @@ public class FinReport extends SvrProcess
 			if (PostingType != null && PostingType.length() > 0)
 				select.append(" AND PostingType='").append(PostingType).append("'");
 			// globalqss - CarlosRuiz
-			if (PostingType.equals(MReportColumn.POSTINGTYPE_Budget)) {
+			if (MReportColumn.POSTINGTYPE_Budget.equals(PostingType)) {
 				if (m_columns[col].getGL_Budget_ID() > 0)
 					select.append(" AND GL_Budget_ID=" + m_columns[col].getGL_Budget_ID());
 			}
@@ -977,7 +977,7 @@ public class FinReport extends SvrProcess
 				if (PostingType != null && PostingType.length() > 0)
 					select.append(" AND fb.PostingType='").append(PostingType).append("'");
 				// globalqss - CarlosRuiz
-				if (PostingType.equals(MReportColumn.POSTINGTYPE_Budget)) {
+				if (MReportColumn.POSTINGTYPE_Budget.equals(PostingType)) {
 					if (m_columns[col].getGL_Budget_ID() > 0)
 						select.append(" AND GL_Budget_ID=" + m_columns[col].getGL_Budget_ID());
 				}
diff --git a/org.adempiere.base/src/org/idempiere/fa/model/ModelValidator.java b/org.adempiere.base/src/org/idempiere/fa/model/ModelValidator.java
index fa0e9474dd..96bab111a8 100644
--- a/org.adempiere.base/src/org/idempiere/fa/model/ModelValidator.java
+++ b/org.adempiere.base/src/org/idempiere/fa/model/ModelValidator.java
@@ -163,7 +163,7 @@ implements org.compiere.model.ModelValidator, org.compiere.model.FactsValidator
 			if (product_id > 0) {
 				MProduct prod = MProduct.get(m.getCtx(), product_id);
 				isAsset = (prod != null && prod.get_ID() > 0 && prod.isCreateAsset());
-				assetGroup_ID = prod.getA_Asset_Group_ID();
+				assetGroup_ID = prod!=null ? prod.getA_Asset_Group_ID() : 0;
 			}
 				
 			// end modification by @win
diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/PoFiller.java b/org.adempiere.pipo/src/org/adempiere/pipo2/PoFiller.java
index 7e23e4b39b..084acc7cdf 100644
--- a/org.adempiere.pipo/src/org/adempiere/pipo2/PoFiller.java
+++ b/org.adempiere.pipo/src/org/adempiere/pipo2/PoFiller.java
@@ -79,7 +79,7 @@ public class PoFiller{
 		Element e = element.properties.get(qName);
 		String value = e != null ? e.contents.toString() : null;
 
-		if (value.trim().length() == 0)
+		if (value!=null && value.trim().length() == 0)
 			value = null;
 		Timestamp ts = value != null ? Timestamp.valueOf(value) : null;
 
@@ -100,7 +100,7 @@ public class PoFiller{
 		Element e = element.properties.get(qName);
 		String value = e != null ? e.contents.toString() : null;
 
-		if (value.trim().length() == 0)
+		if (value!=null && value.trim().length() == 0)
 			value = null;
 		Integer i = value != null ? new Integer(value) : null;
 
@@ -121,7 +121,7 @@ public class PoFiller{
 		Element e = element.properties.get(qName);
 		String value = e != null ? e.contents.toString() : null;
 
-		if (value.trim().length() == 0)
+		if (value!=null && value.trim().length() == 0)
 			value = null;
 		BigDecimal bd = value != null ? new BigDecimal(value) : null;
 
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/acct/WAcctViewerData.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/acct/WAcctViewerData.java
index a70b3ad905..a16c217966 100755
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/acct/WAcctViewerData.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/acct/WAcctViewerData.java
@@ -519,7 +519,7 @@ public class WAcctViewerData
 		
 			if (column != null && column.startsWith("Date"))
 				rm.addColumn(new RColumn(ctx, column, DisplayType.Date));
-			else if (column.startsWith("UserElement"))
+			else if (column!=null && column.startsWith("UserElement"))
 			{
 				if (column.indexOf('1') != -1)
 					rm.addColumn(new RColumn(ctx, column, DisplayType.TableDir, null, 0, m_ref1));
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java
index ecc540b1ae..8b10a0c64a 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java
@@ -105,11 +105,11 @@ public class GridTabRowRenderer implements RowRenderer<Object[]>, RowRendererExt
 		WEditor editor = editors.get(gridField);
 		if (editor != null)  {
 			prepareFieldEditor(gridField, editor);
+			editor.addValueChangeListener(dataBinder);
+			gridField.removePropertyChangeListener(editor);
+			gridField.addPropertyChangeListener(editor);
+			editor.setValue(gridField.getValue());
 		}
-		editor.addValueChangeListener(dataBinder);
-		gridField.removePropertyChangeListener(editor);
-		gridField.addPropertyChangeListener(editor);
-		editor.setValue(gridField.getValue());
 		return editor;
 	}
 
@@ -305,7 +305,7 @@ public class GridTabRowRenderer implements RowRenderer<Object[]>, RowRendererExt
 					else
 						child = parent;
 				}
-				Component component = (Component) div.getAttribute("display.component");
+				Component component = div!=null ? (Component) div.getAttribute("display.component") : null;
 				if (updateCellLabel) {
 					if (component instanceof Label) {
 						Label label = (Label)component;
@@ -344,21 +344,29 @@ public class GridTabRowRenderer implements RowRenderer<Object[]>, RowRendererExt
 	@Override
 	public void render(Row row, Object[] data, int index) throws Exception {
 		//don't render if not visible
-		if (gridPanel != null && !gridPanel.isVisible()) {
-			return;
+		int columnCount = 0;
+		GridField[] gridPanelFields = null;
+		GridField[] gridTabFields = null;
+		boolean isGridViewCustomized = false;
+		
+		if (gridPanel != null) {
+			if (!gridPanel.isVisible()) {
+				return;
+			}
+			else{
+				gridPanelFields = gridPanel.getFields();
+				columnCount = gridPanelFields.length;
+				gridTabFields = gridTab.getFields();
+				isGridViewCustomized = gridTabFields.length != gridPanelFields.length;
+			}	
 		}
-
+		
 		if (grid == null)
 			grid = (Grid) row.getParent().getParent();
 
 		if (rowListener == null)
 			rowListener = new RowListener((Grid)row.getParent().getParent());
-
-		GridField[] gridPanelFields = gridPanel.getFields();
-		int columnCount = gridPanelFields.length;
 		
-		GridField[] gridTabFields = gridTab.getFields();
-		boolean isGridViewCustomized = gridTabFields.length != gridPanelFields.length;
 		if (!isGridViewCustomized) {
 			for(int i = 0; i < gridTabFields.length; i++) {
 				if (gridPanelFields[i].getAD_Field_ID() != gridTabFields[i].getAD_Field_ID()) {
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WBOMDrop.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WBOMDrop.java
index d02792374e..393b4c78e6 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WBOMDrop.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WBOMDrop.java
@@ -594,7 +594,7 @@ public class WBOMDrop extends ADForm implements EventListener<Event>
 			if (listitem != null)
 				pp = listitem.toKeyNamePair();
 			
-			m_product = MProduct.get (Env.getCtx(), pp.getKey());
+			m_product = pp!= null ? MProduct.get (Env.getCtx(), pp.getKey()) : null;
 			createMainPanel();
 			//sizeIt();
 		}
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/WListbox.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/WListbox.java
index 76f515605b..2aae4a8728 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/WListbox.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/WListbox.java
@@ -1125,7 +1125,7 @@ public class WListbox extends Listbox implements IMiniTable, TableValueChangeLis
 						if(subtotal == null)
 							subtotal = new Double(0);
 						if(amt == null )
-							subtotal = new Double(0);
+							amt = new Double(0);
 						total[col] = subtotal + amt;
 						
 					}		
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/RolePanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/RolePanel.java
index 0542cd2da7..22a4b232ab 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/RolePanel.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/RolePanel.java
@@ -326,7 +326,7 @@ public class RolePanel extends Window implements EventListener<Event>, Deferrabl
         }
         //
 
-        if (m_clientKNPairs.length == 1) {
+        if (m_clientKNPairs!=null && m_clientKNPairs.length == 1) {
         	// don't show client if is just one
 			lstClient.setSelectedIndex(0);
 			lblClient.setVisible(false);
diff --git a/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java b/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java
index 241af0c067..9c0de9b449 100644
--- a/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java
+++ b/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java
@@ -316,7 +316,7 @@ public class ConfigOracle implements IDatabaseConfig
 			monitor.update(new DBConfigStatus(DBConfigStatus.DATABASE_SERVER, "ErrorDatabaseServer",
 				pass, true, error));
 		log.info("OK: Database Server = " + databaseServer);
-		data.setProperty(ConfigurationData.ADEMPIERE_DB_SERVER, databaseServer.getHostName());
+		data.setProperty(ConfigurationData.ADEMPIERE_DB_SERVER, databaseServer!=null ? databaseServer.getHostName() : null);
 		//store as lower case for better script level backward compatibility
 		data.setProperty(ConfigurationData.ADEMPIERE_DB_TYPE, data.getDatabaseType());
 		data.setProperty(ConfigurationData.ADEMPIERE_DB_PATH, data.getDatabaseType().toLowerCase());
diff --git a/org.compiere.db.postgresql.provider/src/org/adempiere/db/postgresql/config/ConfigPostgreSQL.java b/org.compiere.db.postgresql.provider/src/org/adempiere/db/postgresql/config/ConfigPostgreSQL.java
index 28edaf9ef5..04ec2eca1a 100755
--- a/org.compiere.db.postgresql.provider/src/org/adempiere/db/postgresql/config/ConfigPostgreSQL.java
+++ b/org.compiere.db.postgresql.provider/src/org/adempiere/db/postgresql/config/ConfigPostgreSQL.java
@@ -101,7 +101,7 @@ public class ConfigPostgreSQL implements IDatabaseConfig
 			monitor.update(new DBConfigStatus(DBConfigStatus.DATABASE_SERVER, "ErrorDatabaseServer",
 				pass, true, error));
 		log.info("OK: Database Server = " + databaseServer);
-		data.setProperty(ConfigurationData.ADEMPIERE_DB_SERVER, databaseServer.getHostName());
+		data.setProperty(ConfigurationData.ADEMPIERE_DB_SERVER, databaseServer!=null ? databaseServer.getHostName() : null);
 		//store as lower case for better script level backward compatibility
 		data.setProperty(ConfigurationData.ADEMPIERE_DB_TYPE, data.getDatabaseType());
 		data.setProperty(ConfigurationData.ADEMPIERE_DB_PATH, data.getDatabaseType().toLowerCase());
diff --git a/org.compiere.db.postgresql.provider/src/org/compiere/dbPort/Convert_PostgreSQL.java b/org.compiere.db.postgresql.provider/src/org/compiere/dbPort/Convert_PostgreSQL.java
index 8925622806..fdd327f8dc 100644
--- a/org.compiere.db.postgresql.provider/src/org/compiere/dbPort/Convert_PostgreSQL.java
+++ b/org.compiere.db.postgresql.provider/src/org/compiere/dbPort/Convert_PostgreSQL.java
@@ -611,7 +611,7 @@ public class Convert_PostgreSQL extends Convert_SQL92 {
 			
 			Update.append(" SET ");
 			
-			int f = updateFields.length();
+			int f = updateFields!=null ? updateFields.length() : 0;
 			int fj = joinFields.length();
 			String updateField = null;
 			String joinField = null;
diff --git a/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/CreateRecord.java b/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/CreateRecord.java
index 807ce0435a..d4f4c470cd 100644
--- a/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/CreateRecord.java
+++ b/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/CreateRecord.java
@@ -85,7 +85,7 @@ public class CreateRecord extends TableFixture {
 					tableOK = true;
 					gpo = table.getPO(0, null);
 				}
-		    	poinfo = POInfo.getPOInfo(ctx, table.getAD_Table_ID());
+		    	poinfo = POInfo.getPOInfo(ctx, table!=null ? table.getAD_Table_ID() : 0);
 			} else if (cell_title.equalsIgnoreCase("*Save*")) {
 				if (i != rows-1) {
 					exception(getCell(i, 1), new Exception("*Save* must be called in last row"));
diff --git a/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/Login.java b/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/Login.java
index 8090969169..ed39c9d727 100644
--- a/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/Login.java
+++ b/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/Login.java
@@ -139,7 +139,7 @@ public class Login extends TableFixture {
 			)
 			return null; // already logged with same data
 		
-		org.compiere.util.Login login = new org.compiere.util.Login(m_ads.getCtx());
+		org.compiere.util.Login login = new org.compiere.util.Login(m_ads!=null ? m_ads.getCtx() : null);
 		KeyNamePair[] roles = login.getRoles(m_user, m_password);
 		if (roles != null)
 		{
diff --git a/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/ReadRecord.java b/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/ReadRecord.java
index 64e10a604d..28f1eac69e 100644
--- a/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/ReadRecord.java
+++ b/org.idempiere.fitnesse.fixture/src/org/idempiere/fitnesse/fixture/ReadRecord.java
@@ -83,7 +83,7 @@ public class ReadRecord extends TableFixture {
 				} else {
 					tableOK = true;
 				}
-		    	poinfo = POInfo.getPOInfo(ctx, table.getAD_Table_ID());
+		    	poinfo = POInfo.getPOInfo(ctx, table!=null ? table.getAD_Table_ID() : 0);
 			} else if (cell_title.equalsIgnoreCase("*Where*")) {
 				if (i != 1) {
 					exception(getCell(i, 1), new Exception("*Where* must be defined in second row"));
diff --git a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/ADLookup.java b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/ADLookup.java
index bc012596f8..a751b734db 100644
--- a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/ADLookup.java
+++ b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/ADLookup.java
@@ -174,9 +174,9 @@ public class ADLookup {
 			 ile = ile+1;				
 			}*/
 			int ile = 0;
-			finalSQL = info.getSQLCount();
+			finalSQL = info!=null ? info.getSQLCount() : "";
 			PreparedStatement pstmt = DB.prepareStatement(finalSQL, null);
-			info.setParameters (pstmt, true);
+			if (info!=null) info.setParameters (pstmt, true);
 			ResultSet rs = pstmt.executeQuery();
 			if (rs.next())
 				ile = rs.getInt(1);
diff --git a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/ADServiceImpl.java b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/ADServiceImpl.java
index 039b28e729..1ba062ab0f 100644
--- a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/ADServiceImpl.java
+++ b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/ADServiceImpl.java
@@ -1057,7 +1057,8 @@ public class ADServiceImpl implements ADService {
 					value = "2000/01/01 "+ value;
 					d = m_cs.dateTimeFormat.parse(value);
 				}
-				ts = new Timestamp(d.getTime());
+				if (d!=null) 
+					ts = new Timestamp(d.getTime());
 			}
 			catch (Exception e)
 			{

From 7ba478f6c2623da2a184048241d41ba8df7dab8e Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Wed, 12 Dec 2012 16:31:08 -0500
Subject: [PATCH 24/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Pattern ICAST_IDIV_CAST_TO_DOUBLE

---
 .../src/org/compiere/print/layout/TableElement.java           | 2 +-
 org.adempiere.base/src/org/compiere/util/WebUtil.java         | 4 ++--
 .../src/main/servlet/org/compiere/web/AdempiereMonitor.java   | 2 +-
 .../src/org/compiere/wstore/RfQServlet.java                   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/org.adempiere.base/src/org/compiere/print/layout/TableElement.java b/org.adempiere.base/src/org/compiere/print/layout/TableElement.java
index 7b44cde779..37bd630c35 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/TableElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/TableElement.java
@@ -284,7 +284,7 @@ public class TableElement extends PrintElement
 		m_printRows = new SerializableMatrixImpl<ArrayList<Serializable>>("TableElementPrintRows");	//	reset
 
 		//	Max Column Width = 50% of available width (used if maxWidth not set)
-		float dynMxColumnWidth = m_firstPage.width / 2;
+		float dynMxColumnWidth = m_firstPage.width / (float)2;
 
 		//	Width calculation
 		int rows = m_data.getRowCount();
diff --git a/org.adempiere.base/src/org/compiere/util/WebUtil.java b/org.adempiere.base/src/org/compiere/util/WebUtil.java
index 81e7d6db7b..6852a97529 100644
--- a/org.adempiere.base/src/org/compiere/util/WebUtil.java
+++ b/org.adempiere.base/src/org/compiere/util/WebUtil.java
@@ -962,7 +962,7 @@ public final class WebUtil
 			out.close();
 			//
 			time = System.currentTimeMillis() - time;
-			double speed = (fileLength/1024) / ((double)time/1000);
+			double speed = (fileLength/(double)1024) / (time/(double)1000);
 			log.info("Length=" 
 				+ fileLength + " - " 
 				+ time + " ms - " 
@@ -1015,7 +1015,7 @@ public final class WebUtil
 			in.close();
 			//
 			time = System.currentTimeMillis() - time;
-			double speed = (fileLength/1024) / ((double)time/1000);
+			double speed = (fileLength/(double)1024) / (time/(double)1000);
 			log.info("Length=" 
 				+ fileLength + " - " 
 				+ time + " ms - " 
diff --git a/org.adempiere.server/src/main/servlet/org/compiere/web/AdempiereMonitor.java b/org.adempiere.server/src/main/servlet/org/compiere/web/AdempiereMonitor.java
index f83eb0371a..ed7a7eb72e 100644
--- a/org.adempiere.server/src/main/servlet/org/compiere/web/AdempiereMonitor.java
+++ b/org.adempiere.server/src/main/servlet/org/compiere/web/AdempiereMonitor.java
@@ -446,7 +446,7 @@ public class AdempiereMonitor extends HttpServlet
 			fis.close();
 			//
 			time = System.currentTimeMillis() - time;
-			double speed = (fileLength/1024) / ((double)time/1000);
+			double speed = (fileLength/(double)1024) / (time/(double)1000);
 			log.info("length=" 
 				+ fileLength + " - " 
 				+ time + " ms - " 
diff --git a/org.adempiere.webstore.servlet/src/org/compiere/wstore/RfQServlet.java b/org.adempiere.webstore.servlet/src/org/compiere/wstore/RfQServlet.java
index f2df4be5b3..87a0de7861 100644
--- a/org.adempiere.webstore.servlet/src/org/compiere/wstore/RfQServlet.java
+++ b/org.adempiere.webstore.servlet/src/org/compiere/wstore/RfQServlet.java
@@ -182,7 +182,7 @@ public class RfQServlet extends HttpServlet
 			out.close();
 			//
 			time = System.currentTimeMillis() - time;
-			double speed = (fileLength/1024) / ((double)time/1000);
+			double speed = (fileLength/(double)1024) / (time/(double)1000);
 			log.fine("streamInvoice - length=" 
 				+ fileLength + " - " 
 				+ time + " ms - " 

From 624d5862e2423f8f2a51d7d056486a1c522ec608 Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Wed, 12 Dec 2012 17:32:09 -0500
Subject: [PATCH 25/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Eclipse warning -> The serializable class does not declare a static final
 serialVersionUID field of type long

---
 org.adempiere.base/src/org/compiere/model/MAssetClass.java | 5 +++++
 org.adempiere.base/src/org/compiere/model/MAssetUse.java   | 5 +++++
 .../src/org/compiere/model/MDepreciationBuild.java         | 4 ++++
 .../src/org/compiere/model/MDepreciationConvention.java    | 5 +++++
 .../src/org/compiere/model/MDepreciationMethod.java        | 5 +++++
 .../src/org/compiere/model/MQualityTest.java               | 5 +++++
 .../src/org/compiere/model/MQualityTestResult.java         | 5 +++++
 .../src/org/compiere/model/MXIFAJournal.java               | 4 ++++
 .../src/org/compiere/print/layout/BarcodeElement.java      | 5 +++++
 .../src/org/compiere/print/layout/BoxElement.java          | 5 +++++
 .../src/org/compiere/print/layout/GraphElement.java        | 5 +++++
 .../src/org/compiere/print/layout/GridElement.java         | 5 +++++
 .../src/org/compiere/print/layout/HTMLElement.java         | 6 ++++++
 .../src/org/compiere/print/layout/ImageElement.java        | 5 +++++
 .../src/org/compiere/print/layout/LocationElement.java     | 5 +++++
 .../src/org/compiere/print/layout/PInstanceLogElement.java | 4 ++++
 .../src/org/compiere/print/layout/ParameterElement.java    | 5 +++++
 .../src/org/compiere/print/layout/StringElement.java       | 5 +++++
 .../src/org/compiere/print/layout/TableElement.java        | 6 ++++++
 .../WEB-INF/src/org/adempiere/webui/DelegatingServlet.java | 4 ++++
 .../src/org/adempiere/webui/apps/form/WTreeBOM.java        | 5 +++++
 .../src/org/adempiere/webui/component/NumberBox.java       | 7 ++++++-
 .../WEB-INF/src/org/adempiere/webui/event/DrillEvent.java  | 4 ++++
 .../WEB-INF/src/org/adempiere/webui/event/TokenEvent.java  | 4 ++++
 .../WEB-INF/src/org/adempiere/webui/event/ZoomEvent.java   | 4 ++++
 .../org/idempiere/fitnesse/server/slim/SlimServlet.java    | 5 +++++
 .../WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java     | 5 +++++
 27 files changed, 131 insertions(+), 1 deletion(-)

diff --git a/org.adempiere.base/src/org/compiere/model/MAssetClass.java b/org.adempiere.base/src/org/compiere/model/MAssetClass.java
index 0e5cb64f14..f8ddc39768 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetClass.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetClass.java
@@ -18,6 +18,11 @@ import org.idempiere.fa.feature.UseLifeImpl;
  */
 public class MAssetClass extends X_A_Asset_Class
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -6526341869523579715L;
+
 	/**
 	 *
 	 */
diff --git a/org.adempiere.base/src/org/compiere/model/MAssetUse.java b/org.adempiere.base/src/org/compiere/model/MAssetUse.java
index 8a22615c63..126918d73e 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetUse.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetUse.java
@@ -9,6 +9,11 @@ import org.compiere.util.DB;
  ** @version $Id: X_A_Asset.java,v 1.88 2004/08/27 21:26:37 jjanke Exp $ */
 public class MAssetUse extends X_A_Asset_Use
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -1247516669047870893L;
+
 	public MAssetUse (Properties ctx, int A_Asset_Use_ID, String trxName)
 	{
 		super (ctx, A_Asset_Use_ID, trxName);
diff --git a/org.adempiere.base/src/org/compiere/model/MDepreciationBuild.java b/org.adempiere.base/src/org/compiere/model/MDepreciationBuild.java
index f1dca0be17..8992f81431 100644
--- a/org.adempiere.base/src/org/compiere/model/MDepreciationBuild.java
+++ b/org.adempiere.base/src/org/compiere/model/MDepreciationBuild.java
@@ -10,6 +10,10 @@ import java.util.Properties;
  */
 public class MDepreciationBuild extends X_A_Depreciation_Build
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 2075917470265913988L;
 	/** Standard Constructor */
 	public MDepreciationBuild (Properties ctx, int A_Depreciation_Build_ID, String trxName)
 	{
diff --git a/org.adempiere.base/src/org/compiere/model/MDepreciationConvention.java b/org.adempiere.base/src/org/compiere/model/MDepreciationConvention.java
index e802c49a08..1f73dde4a5 100644
--- a/org.adempiere.base/src/org/compiere/model/MDepreciationConvention.java
+++ b/org.adempiere.base/src/org/compiere/model/MDepreciationConvention.java
@@ -16,6 +16,11 @@ import org.compiere.util.DB;
  */
 public class MDepreciationConvention extends X_A_Depreciation_Convention
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 2274629486216430723L;
+
 	/**
 	 * 	Default Constructor
 	 *	@param ctx context
diff --git a/org.adempiere.base/src/org/compiere/model/MDepreciationMethod.java b/org.adempiere.base/src/org/compiere/model/MDepreciationMethod.java
index 625c9d4fdd..7105a7c25f 100644
--- a/org.adempiere.base/src/org/compiere/model/MDepreciationMethod.java
+++ b/org.adempiere.base/src/org/compiere/model/MDepreciationMethod.java
@@ -19,6 +19,11 @@ import org.compiere.util.DB;
  */
 public class MDepreciationMethod extends X_A_Depreciation_Method
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 4622027905888469713L;
+
 	/** Standard Constructor */
 	public MDepreciationMethod (Properties ctx, int A_Depreciation_Method_ID, String trxName)
 	{
diff --git a/org.adempiere.base/src/org/compiere/model/MQualityTest.java b/org.adempiere.base/src/org/compiere/model/MQualityTest.java
index f89bf5d679..eee45562c7 100644
--- a/org.adempiere.base/src/org/compiere/model/MQualityTest.java
+++ b/org.adempiere.base/src/org/compiere/model/MQualityTest.java
@@ -5,6 +5,11 @@ import java.util.Properties;
 
 public class MQualityTest extends X_M_QualityTest {
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -8585270006299484402L;
+
 	public MQualityTest(Properties ctx, int M_QualityTest_ID, String trxName) {
 		super(ctx, M_QualityTest_ID, trxName);
 	}
diff --git a/org.adempiere.base/src/org/compiere/model/MQualityTestResult.java b/org.adempiere.base/src/org/compiere/model/MQualityTestResult.java
index 9c43c9df41..34364b0040 100644
--- a/org.adempiere.base/src/org/compiere/model/MQualityTestResult.java
+++ b/org.adempiere.base/src/org/compiere/model/MQualityTestResult.java
@@ -4,6 +4,11 @@ import java.util.Properties;
 
 public class MQualityTestResult extends X_M_QualityTestResult {
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -4253026765149175778L;
+
 	public MQualityTestResult(Properties ctx, int M_QualityTestResult_ID,
 			String trxName) {
 		super(ctx, M_QualityTestResult_ID, trxName);
diff --git a/org.adempiere.base/src/org/compiere/model/MXIFAJournal.java b/org.adempiere.base/src/org/compiere/model/MXIFAJournal.java
index b7871858e0..f04c5a55f6 100644
--- a/org.adempiere.base/src/org/compiere/model/MXIFAJournal.java
+++ b/org.adempiere.base/src/org/compiere/model/MXIFAJournal.java
@@ -9,6 +9,10 @@ import org.compiere.util.Env;
  ** @version $Id: X_A_Asset.java,v 1.88 2004/08/27 21:26:37 jjanke Exp $ */
 public class MXIFAJournal extends X_I_FAJournal
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -1173588601522240768L;
 	public MXIFAJournal (Properties ctx, int I_FAJournal_ID, String trxName)
 	{
 		super (ctx, I_FAJournal_ID, trxName);
diff --git a/org.adempiere.base/src/org/compiere/print/layout/BarcodeElement.java b/org.adempiere.base/src/org/compiere/print/layout/BarcodeElement.java
index 47327b78d3..f39c41efe3 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/BarcodeElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/BarcodeElement.java
@@ -41,6 +41,11 @@ import org.compiere.print.MPrintFormatItem;
  */
 public class BarcodeElement extends PrintElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -935853466496345172L;
+
 	/**
 	 * 	Barcode Element Constructor
 	 *	@param code barcode data string
diff --git a/org.adempiere.base/src/org/compiere/print/layout/BoxElement.java b/org.adempiere.base/src/org/compiere/print/layout/BoxElement.java
index 3ade066d3a..3a4d379d42 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/BoxElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/BoxElement.java
@@ -33,6 +33,11 @@ import org.compiere.print.MPrintFormatItem;
  */
 public class BoxElement extends PrintElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -1956804687979601523L;
+
 	/**
 	 * 	BoxElement
 	 * 	@param item item
diff --git a/org.adempiere.base/src/org/compiere/print/layout/GraphElement.java b/org.adempiere.base/src/org/compiere/print/layout/GraphElement.java
index aca64e9c5e..a5bb5571d0 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/GraphElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/GraphElement.java
@@ -30,6 +30,11 @@ import org.compiere.print.MPrintGraph;
  */
 public class GraphElement extends PrintElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -1723609598698053387L;
+
 	/**
 	 *	Constructor
 	 *  @param pg graph model
diff --git a/org.adempiere.base/src/org/compiere/print/layout/GridElement.java b/org.adempiere.base/src/org/compiere/print/layout/GridElement.java
index 32c3ef9b3c..8123f324f6 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/GridElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/GridElement.java
@@ -36,6 +36,11 @@ import java.util.Properties;
  */
 public class GridElement extends PrintElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 1744788593309619751L;
+
 	/**
 	 *	Grid Element Constructor
 	 *  Call setData to initialize content
diff --git a/org.adempiere.base/src/org/compiere/print/layout/HTMLElement.java b/org.adempiere.base/src/org/compiere/print/layout/HTMLElement.java
index 85bf53a942..70bfbbaae5 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/HTMLElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/HTMLElement.java
@@ -32,6 +32,12 @@ import java.util.Properties;
  */
 public class HTMLElement extends PrintElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -7752468251586676726L;
+
+
 	/**
 	 * 	HTML String Constructor
 	 * 	@param html html code
diff --git a/org.adempiere.base/src/org/compiere/print/layout/ImageElement.java b/org.adempiere.base/src/org/compiere/print/layout/ImageElement.java
index 2bfcaffa34..6370a56d1c 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/ImageElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/ImageElement.java
@@ -43,6 +43,11 @@ import org.compiere.util.Env;
  */
 public class ImageElement extends PrintElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 905615948952506059L;
+
 	/**
 	 *	Create Image from URL
 	 *	@param imageURLString image url
diff --git a/org.adempiere.base/src/org/compiere/print/layout/LocationElement.java b/org.adempiere.base/src/org/compiere/print/layout/LocationElement.java
index fd720ecacc..94130b191a 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/LocationElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/LocationElement.java
@@ -40,6 +40,11 @@ import org.compiere.model.MLocation;
  */
 public class LocationElement extends GridElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -6740297090803465288L;
+
 	/**
 	 * Constructor
 	 * @param ctx context
diff --git a/org.adempiere.base/src/org/compiere/print/layout/PInstanceLogElement.java b/org.adempiere.base/src/org/compiere/print/layout/PInstanceLogElement.java
index ffd1ae4cd6..be673e4ab3 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/PInstanceLogElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/PInstanceLogElement.java
@@ -31,6 +31,10 @@ import org.compiere.util.Util;
  * 			<li>FR [ 1966406 ] Report Engine: AD_PInstance_Logs should be displayed
  */
 public class PInstanceLogElement extends GridElement {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 8315529954507023182L;
 	private int m_effectiveRowCount = 0;
 	
 	public PInstanceLogElement(Properties ctx, MQuery query, MPrintTableFormat tFormat)
diff --git a/org.adempiere.base/src/org/compiere/print/layout/ParameterElement.java b/org.adempiere.base/src/org/compiere/print/layout/ParameterElement.java
index a9a42ab6cd..d77e1860a1 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/ParameterElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/ParameterElement.java
@@ -30,6 +30,11 @@ import org.compiere.util.Msg;
  */
 public class ParameterElement extends GridElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 4702399095192668527L;
+
 	/**
 	 * 	Parameter Element.
 	 *  <pre>
diff --git a/org.adempiere.base/src/org/compiere/print/layout/StringElement.java b/org.adempiere.base/src/org/compiere/print/layout/StringElement.java
index 82a050ee4b..e7b76c90c6 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/StringElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/StringElement.java
@@ -48,6 +48,11 @@ import org.compiere.util.Util;
  */
 public class StringElement extends PrintElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 239112399504036626L;
+
 	/**
 	 *	Standard Field Constructor.
 	 *  Created in LayoutEngine
diff --git a/org.adempiere.base/src/org/compiere/print/layout/TableElement.java b/org.adempiere.base/src/org/compiere/print/layout/TableElement.java
index 37bd630c35..7a6067018b 100644
--- a/org.adempiere.base/src/org/compiere/print/layout/TableElement.java
+++ b/org.adempiere.base/src/org/compiere/print/layout/TableElement.java
@@ -79,6 +79,12 @@ import org.compiere.util.ValueNamePair;
  */
 public class TableElement extends PrintElement
 {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 4185521888252077894L;
+
+
 	/**
 	 *	Constructor.
 	 *	Created in LayoutEngine.
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/DelegatingServlet.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/DelegatingServlet.java
index 06ec945ff0..9ce7d402db 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/DelegatingServlet.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/DelegatingServlet.java
@@ -12,6 +12,10 @@ import javax.servlet.http.HttpServlet;
 
 public class DelegatingServlet extends HttpServlet {
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 7061080629329202814L;
 	private final HttpServlet delegate;
 
 	public DelegatingServlet(HttpServlet delegate) {
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WTreeBOM.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WTreeBOM.java
index b933f18bb2..7c8994a051 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WTreeBOM.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WTreeBOM.java
@@ -540,6 +540,11 @@ public class WTreeBOM extends TreeBOM implements IFormController, EventListener<
 class mySimpleTreeNode extends DefaultTreeNode<Object>
 {
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -7430786399068849936L;
+
 	public mySimpleTreeNode(Object data, List<TreeNode<Object>> children) {
 		
 		super(data, children);
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/NumberBox.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/NumberBox.java
index 9bcf580563..5861ac1f48 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/NumberBox.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/NumberBox.java
@@ -177,7 +177,12 @@ public class NumberBox extends Div
     private Popup getCalculatorPopup()
     {
         Popup popup = new Popup() {
-        	@Override
+        	/**
+			 * 
+			 */
+			private static final long serialVersionUID = -5991248152956632527L;
+
+			@Override
         	public void onPageAttached(Page newpage, Page oldpage) {
         		super.onPageAttached(newpage, oldpage);
         		if (newpage != null) {
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/DrillEvent.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/DrillEvent.java
index 7b1cd8a89d..e172297719 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/DrillEvent.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/DrillEvent.java
@@ -23,6 +23,10 @@ import org.zkoss.zk.ui.event.Event;
  */
 public class DrillEvent extends Event {
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 4877800961258241047L;
 	public final static String ON_DRILL_DOWN = "onDrillDown";
 	public final static String ON_DRILL_ACROSS = "onDrillAcross";
 	
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/TokenEvent.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/TokenEvent.java
index de046cc48c..352f2afe04 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/TokenEvent.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/TokenEvent.java
@@ -23,6 +23,10 @@ import org.zkoss.zk.ui.event.Event;
  */
 public class TokenEvent extends Event {
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 7727018026113457776L;
 	/** on loading of user token **/
 	public final static String ON_USER_TOKEN = "onUserToken";
 	
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/ZoomEvent.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/ZoomEvent.java
index c24087d64a..a6007b8633 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/ZoomEvent.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/event/ZoomEvent.java
@@ -23,6 +23,10 @@ import org.zkoss.zk.ui.event.Event;
  */
 public class ZoomEvent extends Event {
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -8857628145535148973L;
 	public final static String EVENT_NAME = "onZoom";
 
 	public ZoomEvent(Component target, Object data) {
diff --git a/org.idempiere.fitnesse.server/src/org/idempiere/fitnesse/server/slim/SlimServlet.java b/org.idempiere.fitnesse.server/src/org/idempiere/fitnesse/server/slim/SlimServlet.java
index d50915307f..b148ecafcf 100644
--- a/org.idempiere.fitnesse.server/src/org/idempiere/fitnesse/server/slim/SlimServlet.java
+++ b/org.idempiere.fitnesse.server/src/org/idempiere/fitnesse/server/slim/SlimServlet.java
@@ -15,6 +15,11 @@ import org.idempiere.fitnesse.server.Runner;
  *
  */
 public class SlimServlet extends HttpServlet {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 4811874706328623672L;
+
 	@Override
 	public void service(ServletRequest request, ServletResponse response) throws ServletException, IOException {
 		String portNumber = request.getParameter(SlimServerParameters.PORT);
diff --git a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java
index b2784b4ec6..e1958d84e5 100644
--- a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java
+++ b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java
@@ -22,6 +22,11 @@ public class WWindowStatus
 {
 	public static class AD_WrongTabException extends Exception
 	{
+		/**
+		 * 
+		 */
+		private static final long serialVersionUID = -8949499217396844364L;
+
 		public AD_WrongTabException( String msg ) {
 			super(msg);
 		}

From cbe8d69e30d5793e49d34faee4f3f0b92d1053f1 Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Wed, 12 Dec 2012 17:37:18 -0500
Subject: [PATCH 26/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Generate serialVersionUID instead of the default 1L

---
 org.adempiere.base/src/org/compiere/model/MAssetAcct.java  | 7 ++++++-
 .../src/org/compiere/model/MAssetAddition.java             | 5 ++++-
 org.adempiere.base/src/org/compiere/model/MAssetGroup.java | 5 ++++-
 .../src/org/compiere/model/MAssetGroupAcct.java            | 6 +++++-
 .../src/org/compiere/model/MAssetProduct.java              | 6 +++++-
 org.adempiere.base/src/org/compiere/model/MAssetReval.java | 5 ++++-
 .../src/org/compiere/model/MAssetTransfer.java             | 5 ++++-
 .../src/org/compiere/model/MDepreciation.java              | 6 +++++-
 .../src/org/compiere/model/MDepreciationEntry.java         | 7 ++++++-
 .../src/org/compiere/model/MDepreciationExp.java           | 5 ++++-
 .../src/org/compiere/model/MIFixedAsset.java               | 5 ++++-
 .../exceptions/NoCurrencyConversionException.java          | 6 +++++-
 .../fa/exceptions/AssetAlreadyDepreciatedException.java    | 6 +++++-
 .../fa/exceptions/AssetCheckDocumentException.java         | 6 +++++-
 .../src/org/idempiere/fa/exceptions/AssetException.java    | 6 +++++-
 .../fa/exceptions/AssetInvoiceWithMixedLines_LRO.java      | 6 +++++-
 .../idempiere/fa/exceptions/AssetNotActiveException.java   | 6 +++++-
 .../fa/exceptions/AssetNotImplementedException.java        | 6 +++++-
 .../fa/exceptions/AssetNotSupportedException.java          | 6 +++++-
 .../fa/exceptions/AssetProductStockedException.java        | 6 +++++-
 .../fa/exceptions/AssetStatusChangedException.java         | 6 +++++-
 .../fa/exceptions/DepreciationNoInPeriodException.java     | 6 +++++-
 .../src/org/compiere/apps/form/VTreeBOM.java               | 7 ++++++-
 .../src/org/compiere/grid/VCreateFromDialog.java           | 5 ++++-
 .../src/org/compiere/grid/VCreateFromInvoiceUI.java        | 1 -
 .../src/org/compiere/grid/VCreateFromRMAUI.java            | 1 -
 .../src/org/compiere/grid/VCreateFromStatementUI.java      | 1 -
 .../src/org/compiere/grid/tree/VTreeTransferHandler.java   | 3 ++-
 .../org/adempiere/webui/apps/form/WCreateFromWindow.java   | 5 ++++-
 .../src/org/adempiere/webui/dashboard/CalendarWindow.java  | 5 ++++-
 .../src/org/adempiere/webui/dashboard/DPCalendar.java      | 5 ++++-
 .../src/org/adempiere/webui/dashboard/EventWindow.java     | 5 ++++-
 .../src/org/adempiere/webui/dashboard/RequestWindow.java   | 6 +++++-
 .../WEB-INF/src/org/adempiere/webui/panel/CustomForm.java  | 6 +++++-
 .../src/org/adempiere/webui/session/WebUIServlet.java      | 7 +++++--
 35 files changed, 149 insertions(+), 36 deletions(-)

diff --git a/org.adempiere.base/src/org/compiere/model/MAssetAcct.java b/org.adempiere.base/src/org/compiere/model/MAssetAcct.java
index 45f93ea304..f69e0cdd33 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetAcct.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetAcct.java
@@ -21,7 +21,12 @@ import org.compiere.util.TimeUtil;
  */
 public class MAssetAcct extends X_A_Asset_Acct
 {
-	private static final long serialVersionUID = 1L;
+	
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -3919172418904053712L;
 
 	/**
 	 * DO NOT USE DIRECTLY
diff --git a/org.adempiere.base/src/org/compiere/model/MAssetAddition.java b/org.adempiere.base/src/org/compiere/model/MAssetAddition.java
index 40741be988..065b8c4b6c 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetAddition.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetAddition.java
@@ -35,8 +35,11 @@ import org.idempiere.fa.util.POCacheLocal;
 public class MAssetAddition extends X_A_Asset_Addition
 	implements DocAction
 {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 5977180589101094202L;
 	/** Static Logger */
 	private static CLogger s_log = CLogger.getCLogger(MAssetAddition.class);
 
diff --git a/org.adempiere.base/src/org/compiere/model/MAssetGroup.java b/org.adempiere.base/src/org/compiere/model/MAssetGroup.java
index 422b6ece9a..de3d9bd917 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetGroup.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetGroup.java
@@ -12,8 +12,11 @@ import org.compiere.util.DB;
  */
 public class MAssetGroup extends X_A_Asset_Group
 {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -173157506404569463L;
 	/** Cache: ID -> MAssetGroup */
 	private static CCache<Integer, MAssetGroup> s_cache = new CCache<Integer, MAssetGroup>(Table_Name, 10, 0);
 	
diff --git a/org.adempiere.base/src/org/compiere/model/MAssetGroupAcct.java b/org.adempiere.base/src/org/compiere/model/MAssetGroupAcct.java
index 6bfc1750d7..a3c588f90f 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetGroupAcct.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetGroupAcct.java
@@ -16,7 +16,11 @@ import org.idempiere.fa.feature.UseLifeImpl;
 public class MAssetGroupAcct extends X_A_Asset_Group_Acct
 	implements UseLife
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -3458020679308192943L;
 
 	/**
 	 * Get Asset Group Accountings for given group
diff --git a/org.adempiere.base/src/org/compiere/model/MAssetProduct.java b/org.adempiere.base/src/org/compiere/model/MAssetProduct.java
index 8c5a15e56f..f502c907af 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetProduct.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetProduct.java
@@ -12,7 +12,11 @@ import org.compiere.model.Query;
  */
 public class MAssetProduct extends X_A_Asset_Product
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 2459915999284269350L;
 
 	/** Standard Constructor */
 	public MAssetProduct (Properties ctx, int A_Asset_Product_ID, String trxName)
diff --git a/org.adempiere.base/src/org/compiere/model/MAssetReval.java b/org.adempiere.base/src/org/compiere/model/MAssetReval.java
index 910347b021..822d7094db 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetReval.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetReval.java
@@ -27,8 +27,11 @@ import org.compiere.util.TimeUtil;
 public class MAssetReval extends X_A_Asset_Reval
 implements DocAction
 {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -3937514008250840440L;
 	private boolean		m_justPrepared = false;
 
 	public MAssetReval(Properties ctx, int X_A_Asset_Reval_ID, String trxName)
diff --git a/org.adempiere.base/src/org/compiere/model/MAssetTransfer.java b/org.adempiere.base/src/org/compiere/model/MAssetTransfer.java
index 794f5997fd..3a8174751a 100644
--- a/org.adempiere.base/src/org/compiere/model/MAssetTransfer.java
+++ b/org.adempiere.base/src/org/compiere/model/MAssetTransfer.java
@@ -38,7 +38,10 @@ import org.idempiere.fa.exceptions.AssetAlreadyDepreciatedException;
 public class MAssetTransfer extends X_A_Asset_Transfer
 implements DocAction
 {
-    private static final long serialVersionUID = 1L;
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 2997284714883099922L;
 	/**	Just Prepared Flag			*/
 	private boolean		m_justPrepared = false;
     
diff --git a/org.adempiere.base/src/org/compiere/model/MDepreciation.java b/org.adempiere.base/src/org/compiere/model/MDepreciation.java
index f3e91d9eb6..0dbbcd4510 100644
--- a/org.adempiere.base/src/org/compiere/model/MDepreciation.java
+++ b/org.adempiere.base/src/org/compiere/model/MDepreciation.java
@@ -20,7 +20,11 @@ import org.idempiere.fa.exceptions.AssetNotSupportedException;
  */
 public class MDepreciation extends X_A_Depreciation
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -632058079835100100L;
 
 	/** Standard Constructor */
 	public MDepreciation (Properties ctx, int A_Depreciation_ID, String trxName)
diff --git a/org.adempiere.base/src/org/compiere/model/MDepreciationEntry.java b/org.adempiere.base/src/org/compiere/model/MDepreciationEntry.java
index 2683591635..3ac40faa28 100644
--- a/org.adempiere.base/src/org/compiere/model/MDepreciationEntry.java
+++ b/org.adempiere.base/src/org/compiere/model/MDepreciationEntry.java
@@ -28,7 +28,12 @@ import org.idempiere.fa.exceptions.AssetException;
 public class MDepreciationEntry extends X_A_Depreciation_Entry
 implements DocAction
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 6631244784741228058L;
+
 
 	/** Standard Constructor */
 	public MDepreciationEntry(Properties ctx, int A_Depreciation_Entry_ID, String trxName)
diff --git a/org.adempiere.base/src/org/compiere/model/MDepreciationExp.java b/org.adempiere.base/src/org/compiere/model/MDepreciationExp.java
index 3ceb11a6d0..9b7c694330 100644
--- a/org.adempiere.base/src/org/compiere/model/MDepreciationExp.java
+++ b/org.adempiere.base/src/org/compiere/model/MDepreciationExp.java
@@ -21,8 +21,11 @@ import org.idempiere.fa.exceptions.AssetNotActiveException;
 
 public class MDepreciationExp extends X_A_Depreciation_Exp
 {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 6731366890875525147L;
 	private static CLogger s_log = CLogger.getCLogger(MDepreciationExp.class);
 	private CLogger log = CLogger.getCLogger(this.getClass());
 	
diff --git a/org.adempiere.base/src/org/compiere/model/MIFixedAsset.java b/org.adempiere.base/src/org/compiere/model/MIFixedAsset.java
index b6186c4cb0..ab15920766 100644
--- a/org.adempiere.base/src/org/compiere/model/MIFixedAsset.java
+++ b/org.adempiere.base/src/org/compiere/model/MIFixedAsset.java
@@ -23,8 +23,11 @@ import org.compiere.util.Util;
  */
 public class MIFixedAsset extends X_I_FixedAsset
 {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -6394518107160329652L;
 	/** Default depreciation method */
 	private static final String s_defaultDepreciationType = "SL";
 	
diff --git a/org.adempiere.base/src/org/idempiere/exceptions/NoCurrencyConversionException.java b/org.adempiere.base/src/org/idempiere/exceptions/NoCurrencyConversionException.java
index 4327b4bd31..e21587169c 100644
--- a/org.adempiere.base/src/org/idempiere/exceptions/NoCurrencyConversionException.java
+++ b/org.adempiere.base/src/org/idempiere/exceptions/NoCurrencyConversionException.java
@@ -29,7 +29,11 @@ import org.compiere.util.Env;
  */
 public class NoCurrencyConversionException extends AdempiereException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 1593966161685137709L;
 
 	/**
 	 * 
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetAlreadyDepreciatedException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetAlreadyDepreciatedException.java
index 09a7a34ea6..02bafe784c 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetAlreadyDepreciatedException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetAlreadyDepreciatedException.java
@@ -11,7 +11,11 @@ package org.idempiere.fa.exceptions;
  */
 public class AssetAlreadyDepreciatedException extends AssetException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -2531645693567226455L;
 
 	public AssetAlreadyDepreciatedException()
 	{
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetCheckDocumentException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetCheckDocumentException.java
index 3b87d551ff..27680144c2 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetCheckDocumentException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetCheckDocumentException.java
@@ -10,7 +10,11 @@ package org.idempiere.fa.exceptions;
  */
 public class AssetCheckDocumentException extends AssetException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -8096988198983528889L;
 
 	public AssetCheckDocumentException(String additionalMessage)
 	{
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetException.java
index fb0f6c2619..e1e6473f69 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetException.java
@@ -11,7 +11,11 @@ import org.adempiere.exceptions.AdempiereException;
  */
 public class AssetException extends AdempiereException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -2163958702697438015L;
 
 	public AssetException()
 	{
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetInvoiceWithMixedLines_LRO.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetInvoiceWithMixedLines_LRO.java
index 6ff23f592d..ca332fef12 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetInvoiceWithMixedLines_LRO.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetInvoiceWithMixedLines_LRO.java
@@ -9,7 +9,11 @@ package org.idempiere.fa.exceptions;
  *
  */
 public class AssetInvoiceWithMixedLines_LRO extends AssetException {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 7477049497754422353L;
 
 	public AssetInvoiceWithMixedLines_LRO() {
 		super("No new bills that contain both fixed and normal products");
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotActiveException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotActiveException.java
index f690ca11ba..5589ce5da5 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotActiveException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotActiveException.java
@@ -9,7 +9,11 @@ package org.idempiere.fa.exceptions;
  */
 public class AssetNotActiveException extends AssetException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -958395266586669844L;
 
 	public AssetNotActiveException(int A_Asset_ID)
 	{
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotImplementedException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotImplementedException.java
index e895538d1b..a4a274f8ab 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotImplementedException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotImplementedException.java
@@ -11,7 +11,11 @@ package org.idempiere.fa.exceptions;
  */
 public class AssetNotImplementedException extends AssetException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -7015542410574849684L;
 
 	public AssetNotImplementedException(String additionalMessage)
 	{
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotSupportedException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotSupportedException.java
index 3486889b69..8f2d1d1d34 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotSupportedException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetNotSupportedException.java
@@ -9,7 +9,11 @@ package org.idempiere.fa.exceptions;
  */
 public class AssetNotSupportedException extends AssetException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -9182818872935345775L;
 
 	public AssetNotSupportedException (String funcName, String actualValue)
 	{
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetProductStockedException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetProductStockedException.java
index bf5d05f837..29011ac230 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetProductStockedException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetProductStockedException.java
@@ -11,7 +11,11 @@ import org.compiere.model.MProduct;
  */
 public class AssetProductStockedException extends AssetException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 229246069558704158L;
 
 	public AssetProductStockedException(MProduct product)
 	{
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetStatusChangedException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetStatusChangedException.java
index 7657349d90..a41596ab2a 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetStatusChangedException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/AssetStatusChangedException.java
@@ -11,7 +11,11 @@ import org.compiere.util.Util;
  */
 public class AssetStatusChangedException extends AssetException
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -2015948851153849647L;
 
 	public AssetStatusChangedException()
 	{
diff --git a/org.adempiere.base/src/org/idempiere/fa/exceptions/DepreciationNoInPeriodException.java b/org.adempiere.base/src/org/idempiere/fa/exceptions/DepreciationNoInPeriodException.java
index 77a9f6b09c..f5f7fe2680 100644
--- a/org.adempiere.base/src/org/idempiere/fa/exceptions/DepreciationNoInPeriodException.java
+++ b/org.adempiere.base/src/org/idempiere/fa/exceptions/DepreciationNoInPeriodException.java
@@ -9,8 +9,12 @@ package org.idempiere.fa.exceptions;
  */
 public class DepreciationNoInPeriodException extends AssetException
 {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -6201871355182540721L;
+
 	public DepreciationNoInPeriodException(int A_Asset_ID, int Workfile_Period_ID, int DepExp_Period_ID)
 	{
 		super("Registration is not in balance (ID Asset="+A_Asset_ID
diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/form/VTreeBOM.java b/org.adempiere.ui.swing/src/org/compiere/apps/form/VTreeBOM.java
index e53fd586ec..6b58e98127 100644
--- a/org.adempiere.ui.swing/src/org/compiere/apps/form/VTreeBOM.java
+++ b/org.adempiere.ui.swing/src/org/compiere/apps/form/VTreeBOM.java
@@ -252,7 +252,12 @@ public class VTreeBOM extends CPanel implements FormPanel, ActionListener, TreeS
 				DisplayType.Search, language, MProduct.COLUMNNAME_M_Product_ID, 0, false,
 				" M_Product.IsSummary = 'N'");
 		fieldProduct = new VLookup ("M_Product_ID", false, false, true,  m_fieldProduct) {
-			private static final long serialVersionUID = 1L;
+			
+			/**
+			 * 
+			 */
+			private static final long serialVersionUID = 1084743143950828526L;
+
 			public void setValue(Object value) {
 				super.setValue(value);
 			}
diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromDialog.java b/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromDialog.java
index 0e153f6409..50d5945d04 100644
--- a/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromDialog.java
+++ b/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromDialog.java
@@ -38,8 +38,11 @@ import org.compiere.util.TrxRunnable;
 
 public class VCreateFromDialog extends CDialog implements ActionListener, TableModelListener
 {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -8242250391030501785L;
 	private CreateFrom createFrom;
 	private int windowNo;
 	
diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromInvoiceUI.java b/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromInvoiceUI.java
index c1aac1b4e6..4c03e88a3c 100644
--- a/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromInvoiceUI.java
+++ b/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromInvoiceUI.java
@@ -45,7 +45,6 @@ import org.compiere.util.Msg;
 
 public class VCreateFromInvoiceUI extends CreateFromInvoice implements ActionListener, VetoableChangeListener
 {
-	private static final long serialVersionUID = 1L;
 	
 	private VCreateFromDialog dialog;
 
diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromRMAUI.java b/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromRMAUI.java
index b7e2b70074..2b44a2d540 100644
--- a/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromRMAUI.java
+++ b/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromRMAUI.java
@@ -39,7 +39,6 @@ import org.compiere.util.Msg;
 
 public class VCreateFromRMAUI extends CreateFromRMA implements VetoableChangeListener
 {
-	private static final long serialVersionUID = 1L;
 	
 	private VCreateFromDialog dialog;
 
diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromStatementUI.java b/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromStatementUI.java
index 22ce405941..d41ef431a4 100644
--- a/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromStatementUI.java
+++ b/org.adempiere.ui.swing/src/org/compiere/grid/VCreateFromStatementUI.java
@@ -55,7 +55,6 @@ import org.compiere.util.Msg;
 
 public class VCreateFromStatementUI extends CreateFromStatement implements ActionListener
 {
-	private static final long serialVersionUID = 1L;
 	
 	private VCreateFromDialog dialog;
 
diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/tree/VTreeTransferHandler.java b/org.adempiere.ui.swing/src/org/compiere/grid/tree/VTreeTransferHandler.java
index 9de5485a94..11790db96d 100644
--- a/org.adempiere.ui.swing/src/org/compiere/grid/tree/VTreeTransferHandler.java
+++ b/org.adempiere.ui.swing/src/org/compiere/grid/tree/VTreeTransferHandler.java
@@ -36,10 +36,11 @@ import org.compiere.model.MTreeNode;
  */
 public class VTreeTransferHandler extends TransferHandler {
 
+
 	/**
 	 * 
 	 */
-	private static final long serialVersionUID = 1L;
+	private static final long serialVersionUID = 2799737958477528717L;
 
 	public int getSourceActions(JComponent c) {
 		return TransferHandler.MOVE;
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WCreateFromWindow.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WCreateFromWindow.java
index 25033c3ef4..0c81d7f616 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WCreateFromWindow.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WCreateFromWindow.java
@@ -39,8 +39,11 @@ import org.zkoss.zul.Separator;
 
 public class WCreateFromWindow extends Window implements EventListener<Event>, WTableModelListener, DialogEvents
 {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -3703236565441597403L;
 	private CreateFrom createFrom;
 	private int windowNo;
 	
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/CalendarWindow.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/CalendarWindow.java
index d252120910..86182359bc 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/CalendarWindow.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/CalendarWindow.java
@@ -65,8 +65,11 @@ import org.zkoss.zul.Toolbarbutton;
  *
  */
 public class CalendarWindow extends Window implements EventListener<Event> {
-	private static final long serialVersionUID = 1L;
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 5620139733919619691L;
 	private Calendars calendars;
 	private SimpleCalendarModel scm;
 	private Toolbarbutton btnRefresh;
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/DPCalendar.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/DPCalendar.java
index d39d746feb..85e7459a52 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/DPCalendar.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/DPCalendar.java
@@ -47,8 +47,11 @@ import org.zkoss.zul.Toolbarbutton;
  */
 public class DPCalendar extends DashboardPanel implements EventListener<Event> {
 
-	private static final long serialVersionUID = 1L;
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -224914882522997787L;
 	private Calendars calendars;
 	private SimpleCalendarModel scm;
 	private Toolbarbutton btnCal, btnRefresh;
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/EventWindow.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/EventWindow.java
index 1076ec953c..90c758eec7 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/EventWindow.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/EventWindow.java
@@ -37,8 +37,11 @@ import org.zkoss.zul.South;
  *
  */
 public class EventWindow extends Window implements EventListener<Event> {
-	private static final long serialVersionUID = 1L;
 
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 4758066526040260586L;
 	private DatetimeBox dtBeginDate, dtEndDate;
 	private Textbox txtContent, txtHeaderColor, txtContentColor;
 	private ConfirmPanel confirmPanel;
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/RequestWindow.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/RequestWindow.java
index 801639bef0..982e2b7d34 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/RequestWindow.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/dashboard/RequestWindow.java
@@ -53,8 +53,12 @@ import org.zkoss.zul.Timebox;
  *
  */
 public class RequestWindow extends Window implements EventListener<Event> {
-	private static final long serialVersionUID = 1L;
 	
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 7757368164776005797L;
+
 	private static CLogger log = CLogger.getCLogger(RequestWindow.class);
 	
 	/** Read Only				*/
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomForm.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomForm.java
index e9eded6254..ebce62f905 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomForm.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomForm.java
@@ -2,7 +2,11 @@ package org.adempiere.webui.panel;
 
 public class CustomForm extends ADForm
 {
-	private static final long serialVersionUID = 1L;
+
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -8498084996736578534L;
 
 	@Override
 	protected void initForm() 
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/session/WebUIServlet.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/session/WebUIServlet.java
index 290cb93ed1..d93b1503db 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/session/WebUIServlet.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/session/WebUIServlet.java
@@ -45,9 +45,12 @@ import org.adempiere.util.ServerContextURLHandler;
  */
 public class WebUIServlet extends DHtmlLayoutServlet
 {
-	private static final long    serialVersionUID = 1L;
 
-    /** Logger for the class * */
+    /**
+	 * 
+	 */
+	private static final long serialVersionUID = -5625631664012999381L;
+	/** Logger for the class * */
     private static CLogger logger;
 
     public void init(ServletConfig servletConfig) throws ServletException

From 2cd9a1d0f1f15355256caa73309f58888d675a6e Mon Sep 17 00:00:00 2001
From: Richard Morales <richard.morales@globalqss.com>
Date: Wed, 12 Dec 2012 17:56:24 -0500
Subject: [PATCH 27/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Eclipse warning -> The import ___ is never used

---
 .../src/org/compiere/acct/Doc_BankStatement.java      |  1 -
 .../org/eevolution/process/ImportInventoryMove.java   |  2 --
 .../src/test/functional/AlertTest.java                |  3 ---
 .../src/test/functional/MAttributeTest.java           |  1 -
 .../src/test/functional/MBPartnerTest.java            |  9 ---------
 .../src/test/functional/MPInstanceTest.java           |  2 --
 .../src/test/functional/MPaymentTest.java             |  1 -
 .../src/test/functional/MProductBOMTest.java          |  1 -
 .../src/test/functional/MProductTest.java             | 11 -----------
 .../src/org/adempiere/client/Client.java              |  1 -
 .../src/org/compiere/apps/form/VAttributeGrid.java    |  1 -
 .../src/org/compiere/apps/search/InfoInOut.java       |  1 -
 .../src/org/compiere/apps/wf/WFPopupItem.java         |  1 -
 .../src/org/compiere/grid/VPanel.java                 |  5 -----
 .../src/org/compiere/print/CPrinter.java              |  1 -
 .../src/org/compiere/print/Viewer.java                |  2 --
 .../src/org/compiere/swing/CTextArea.java             |  1 -
 .../src/org/compiere/util/Splash.java                 |  1 -
 .../src/org/adempiere/webui/panel/TimeoutPanel.java   |  2 --
 .../org/compiere/wstore/ProductCategoryListTag.java   |  1 -
 20 files changed, 48 deletions(-)

diff --git a/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java b/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
index 59acb3922c..706ce4b728 100644
--- a/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
+++ b/org.adempiere.base/src/org/compiere/acct/Doc_BankStatement.java
@@ -25,7 +25,6 @@ import org.compiere.model.MAcctSchema;
 import org.compiere.model.MBankAccount;
 import org.compiere.model.MBankStatement;
 import org.compiere.model.MBankStatementLine;
-import org.compiere.model.MPeriod;
 import org.compiere.util.Env;
 
 /**
diff --git a/org.adempiere.base/src/org/eevolution/process/ImportInventoryMove.java b/org.adempiere.base/src/org/eevolution/process/ImportInventoryMove.java
index 351eb37b46..3d9faf9686 100644
--- a/org.adempiere.base/src/org/eevolution/process/ImportInventoryMove.java
+++ b/org.adempiere.base/src/org/eevolution/process/ImportInventoryMove.java
@@ -40,10 +40,8 @@ import org.compiere.model.MTable;
 import org.compiere.model.Query;
 import org.compiere.process.ProcessInfoParameter;
 import org.compiere.process.SvrProcess;
-import org.compiere.util.DB;
 import org.compiere.util.Env;
 import org.compiere.util.Msg;
-import org.eevolution.model.I_I_Movement;
 import org.eevolution.model.X_I_Movement;
 
 
diff --git a/org.adempiere.extend/src/test/functional/AlertTest.java b/org.adempiere.extend/src/test/functional/AlertTest.java
index 4a8d6ad63a..07a4f6b744 100644
--- a/org.adempiere.extend/src/test/functional/AlertTest.java
+++ b/org.adempiere.extend/src/test/functional/AlertTest.java
@@ -28,12 +28,9 @@
 ***********************************************************************/
 package test.functional;
 
-import java.math.BigDecimal;
-
 import org.compiere.model.MAlert;
 import org.compiere.model.MAlertProcessor;
 import org.compiere.model.MAlertProcessorLog;
-import org.compiere.model.MProductPricing;
 import org.compiere.model.X_AD_AlertProcessor;
 import org.compiere.util.CLogger;
 import org.compiere.util.Env;
diff --git a/org.adempiere.extend/src/test/functional/MAttributeTest.java b/org.adempiere.extend/src/test/functional/MAttributeTest.java
index ea9a765897..f00d27e248 100644
--- a/org.adempiere.extend/src/test/functional/MAttributeTest.java
+++ b/org.adempiere.extend/src/test/functional/MAttributeTest.java
@@ -16,7 +16,6 @@ package test.functional;
 import org.compiere.model.MAttribute;
 import org.compiere.model.MAttributeInstance;
 import org.compiere.model.MAttributeValue;
-import org.compiere.model.MInvoice;
 import org.compiere.util.Env;
 
 import test.AdempiereTestCase;
diff --git a/org.adempiere.extend/src/test/functional/MBPartnerTest.java b/org.adempiere.extend/src/test/functional/MBPartnerTest.java
index 06d7efc8f9..66de373ebf 100644
--- a/org.adempiere.extend/src/test/functional/MBPartnerTest.java
+++ b/org.adempiere.extend/src/test/functional/MBPartnerTest.java
@@ -1,17 +1,8 @@
 //MBPartnerTest.java
 package test.functional;
 
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-
-import org.compiere.model.MBPGroup;
 import org.compiere.model.MBPartner;
 import org.compiere.model.MLocation;
-import org.compiere.model.MProductPrice;
-import org.compiere.util.DB;
-import org.compiere.util.Env;
-
 import test.AdempiereTestCase;
 
 public class MBPartnerTest extends AdempiereTestCase {
diff --git a/org.adempiere.extend/src/test/functional/MPInstanceTest.java b/org.adempiere.extend/src/test/functional/MPInstanceTest.java
index efddcafd05..f9c314b22d 100644
--- a/org.adempiere.extend/src/test/functional/MPInstanceTest.java
+++ b/org.adempiere.extend/src/test/functional/MPInstanceTest.java
@@ -15,8 +15,6 @@ package test.functional;
 
 import org.compiere.model.MPInstance;
 import org.compiere.model.MPInstancePara;
-import org.compiere.model.MPaySelection;
-import org.compiere.model.MPaySelectionLine;
 import org.compiere.util.Env;
 
 import test.AdempiereTestCase;
diff --git a/org.adempiere.extend/src/test/functional/MPaymentTest.java b/org.adempiere.extend/src/test/functional/MPaymentTest.java
index 21ddbf3d43..4311d5de0c 100644
--- a/org.adempiere.extend/src/test/functional/MPaymentTest.java
+++ b/org.adempiere.extend/src/test/functional/MPaymentTest.java
@@ -13,7 +13,6 @@
  *****************************************************************************/
 package test.functional;
 
-import org.compiere.model.MInvoice;
 import org.compiere.model.MPayment;
 import org.compiere.util.Env;
 
diff --git a/org.adempiere.extend/src/test/functional/MProductBOMTest.java b/org.adempiere.extend/src/test/functional/MProductBOMTest.java
index 112a90ba73..9b82fb008d 100644
--- a/org.adempiere.extend/src/test/functional/MProductBOMTest.java
+++ b/org.adempiere.extend/src/test/functional/MProductBOMTest.java
@@ -14,7 +14,6 @@
 package test.functional;
 
 import org.compiere.model.MBOM;
-import org.compiere.model.MLocation;
 import org.compiere.model.MProductBOM;
 import org.compiere.util.Env;
 
diff --git a/org.adempiere.extend/src/test/functional/MProductTest.java b/org.adempiere.extend/src/test/functional/MProductTest.java
index af2b077689..e8331be2fb 100644
--- a/org.adempiere.extend/src/test/functional/MProductTest.java
+++ b/org.adempiere.extend/src/test/functional/MProductTest.java
@@ -1,18 +1,7 @@
 //MProductTest.java
 package test.functional;
 
-import java.math.BigDecimal;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-
-import org.compiere.model.MProduct;
 import org.compiere.model.MProductPrice;
-import org.compiere.model.MProductPricing;
-import org.compiere.model.X_I_Product;
-import org.compiere.util.DB;
-import org.compiere.util.Env;
-
 import test.AdempiereTestCase;
 
 public class MProductTest extends AdempiereTestCase {
diff --git a/org.adempiere.ui.swing/src/org/adempiere/client/Client.java b/org.adempiere.ui.swing/src/org/adempiere/client/Client.java
index 9d9aec61dc..7fd0fe916b 100644
--- a/org.adempiere.ui.swing/src/org/adempiere/client/Client.java
+++ b/org.adempiere.ui.swing/src/org/adempiere/client/Client.java
@@ -21,7 +21,6 @@
 package org.adempiere.client;
 
 import org.adempiere.base.Service;
-import org.adempiere.base.ServiceQuery;
 import org.compiere.apps.form.FormPanel;
 
 /**
diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/form/VAttributeGrid.java b/org.adempiere.ui.swing/src/org/compiere/apps/form/VAttributeGrid.java
index e097b3af35..8750d44a18 100644
--- a/org.adempiere.ui.swing/src/org/compiere/apps/form/VAttributeGrid.java
+++ b/org.adempiere.ui.swing/src/org/compiere/apps/form/VAttributeGrid.java
@@ -50,7 +50,6 @@ import org.compiere.model.MAttributeValue;
 import org.compiere.model.MProduct;
 import org.compiere.model.MProductPrice;
 import org.compiere.model.MRole;
-import org.compiere.model.MStorageOnHand;
 import org.compiere.model.MStorageReservation;
 import org.compiere.swing.CComboBox;
 import org.compiere.swing.CLabel;
diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/search/InfoInOut.java b/org.adempiere.ui.swing/src/org/compiere/apps/search/InfoInOut.java
index b639bae8ac..8400e0c13b 100644
--- a/org.adempiere.ui.swing/src/org/compiere/apps/search/InfoInOut.java
+++ b/org.adempiere.ui.swing/src/org/compiere/apps/search/InfoInOut.java
@@ -20,7 +20,6 @@ import java.awt.Frame;
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
 import java.sql.Timestamp;
-import java.util.ArrayList;
 
 import org.adempiere.plaf.AdempierePLAF;
 import org.compiere.apps.ALayout;
diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/wf/WFPopupItem.java b/org.adempiere.ui.swing/src/org/compiere/apps/wf/WFPopupItem.java
index 568faf9150..6725dab422 100644
--- a/org.adempiere.ui.swing/src/org/compiere/apps/wf/WFPopupItem.java
+++ b/org.adempiere.ui.swing/src/org/compiere/apps/wf/WFPopupItem.java
@@ -1,7 +1,6 @@
 package org.compiere.apps.wf;
 
 import javax.swing.JMenuItem;
-import javax.swing.SwingUtilities;
 
 import org.compiere.util.CLogger;
 import org.compiere.util.Env;
diff --git a/org.adempiere.ui.swing/src/org/compiere/grid/VPanel.java b/org.adempiere.ui.swing/src/org/compiere/grid/VPanel.java
index 9456c95f16..bbf6838c86 100644
--- a/org.adempiere.ui.swing/src/org/compiere/grid/VPanel.java
+++ b/org.adempiere.ui.swing/src/org/compiere/grid/VPanel.java
@@ -35,10 +35,7 @@ import net.miginfocom.layout.BoundSize;
 import net.miginfocom.layout.ComponentWrapper;
 import net.miginfocom.layout.ConstraintParser;
 import net.miginfocom.layout.LayoutCallback;
-import net.miginfocom.layout.UnitValue;
 import net.miginfocom.swing.MigLayout;
-import net.miginfocom.swing.SwingComponentWrapper;
-import net.miginfocom.swing.SwingContainerWrapper;
 
 import org.adempiere.plaf.AdempierePLAF;
 import org.compiere.apps.APanel;
@@ -46,7 +43,6 @@ import org.compiere.grid.ed.VButton;
 import org.compiere.grid.ed.VCheckBox;
 import org.compiere.grid.ed.VEditor;
 import org.compiere.grid.ed.VEditorFactory;
-import org.compiere.grid.ed.VLine;
 import org.compiere.model.GridField;
 import org.compiere.model.X_AD_FieldGroup;
 import org.compiere.swing.CLabel;
@@ -54,7 +50,6 @@ import org.compiere.swing.CPanel;
 import org.compiere.swing.CTabbedPane;
 import org.compiere.swing.CollapsiblePanel;
 import org.compiere.util.CLogger;
-import org.compiere.util.DB;
 import org.compiere.util.DisplayType;
 import org.compiere.util.Language;
 import org.compiere.util.Util;
diff --git a/org.adempiere.ui.swing/src/org/compiere/print/CPrinter.java b/org.adempiere.ui.swing/src/org/compiere/print/CPrinter.java
index 527634d799..d3fc14cd53 100644
--- a/org.adempiere.ui.swing/src/org/compiere/print/CPrinter.java
+++ b/org.adempiere.ui.swing/src/org/compiere/print/CPrinter.java
@@ -18,7 +18,6 @@ package org.compiere.print;
 
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
-import java.awt.print.PrinterJob;
 
 import javax.print.PrintService;
 import javax.print.PrintServiceLookup;
diff --git a/org.adempiere.ui.swing/src/org/compiere/print/Viewer.java b/org.adempiere.ui.swing/src/org/compiere/print/Viewer.java
index fce37661a4..4e1300c9d2 100644
--- a/org.adempiere.ui.swing/src/org/compiere/print/Viewer.java
+++ b/org.adempiere.ui.swing/src/org/compiere/print/Viewer.java
@@ -41,7 +41,6 @@ import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.ArrayList;
-import java.util.Calendar;
 import java.util.Properties;
 import java.util.logging.Level;
 
@@ -102,7 +101,6 @@ import org.compiere.util.Language;
 import org.compiere.util.Login;
 import org.compiere.util.Msg;
 import org.compiere.util.NamePair;
-import org.compiere.util.TimeUtil;
 import org.compiere.util.ValueNamePair;
 
 /**
diff --git a/org.adempiere.ui.swing/src/org/compiere/swing/CTextArea.java b/org.adempiere.ui.swing/src/org/compiere/swing/CTextArea.java
index 87ea04dbee..afc494fd65 100644
--- a/org.adempiere.ui.swing/src/org/compiere/swing/CTextArea.java
+++ b/org.adempiere.ui.swing/src/org/compiere/swing/CTextArea.java
@@ -17,7 +17,6 @@
 package org.compiere.swing;
 
 import java.awt.Color;
-import java.awt.Component;
 import java.awt.Insets;
 import java.awt.event.ActionEvent;
 import java.awt.event.FocusEvent;
diff --git a/org.adempiere.ui.swing/src/org/compiere/util/Splash.java b/org.adempiere.ui.swing/src/org/compiere/util/Splash.java
index fc3a358c5c..9b750adc6a 100644
--- a/org.adempiere.ui.swing/src/org/compiere/util/Splash.java
+++ b/org.adempiere.ui.swing/src/org/compiere/util/Splash.java
@@ -36,7 +36,6 @@ import java.net.URL;
 import java.util.Locale;
 
 import org.compiere.Adempiere;
-import org.compiere.AdempiereClient;
 
 /**
  *  Splash Screen.
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/TimeoutPanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/TimeoutPanel.java
index 1121fcb1bc..fe734c421b 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/TimeoutPanel.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/TimeoutPanel.java
@@ -19,8 +19,6 @@ import org.compiere.util.Env;
 import org.compiere.util.Msg;
 import org.zkoss.zhtml.Script;
 import org.zkoss.zk.ui.Executions;
-import org.zkoss.zk.ui.Session;
-import org.zkoss.zk.ui.Sessions;
 import org.zkoss.zk.ui.event.Event;
 import org.zkoss.zk.ui.event.Events;
 import org.zkoss.zul.Borderlayout;
diff --git a/org.adempiere.webstore.servlet/src/org/compiere/wstore/ProductCategoryListTag.java b/org.adempiere.webstore.servlet/src/org/compiere/wstore/ProductCategoryListTag.java
index b3e58ca03c..f30fcb5075 100644
--- a/org.adempiere.webstore.servlet/src/org/compiere/wstore/ProductCategoryListTag.java
+++ b/org.adempiere.webstore.servlet/src/org/compiere/wstore/ProductCategoryListTag.java
@@ -25,7 +25,6 @@ import javax.servlet.jsp.tagext.TagSupport;
 
 import org.apache.ecs.xhtml.option;
 import org.apache.ecs.xhtml.select;
-import org.compiere.model.I_M_Product;
 import org.compiere.model.I_M_Product_Category;
 import org.compiere.util.CCache;
 import org.compiere.util.CLogger;

From 9e77388cf4323f91c247afcc34deedee4333722b Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Wed, 12 Dec 2012 18:11:37 -0500
Subject: [PATCH 28/29] IDEMPIERE-455 Discover and fix FindBugs problems /
 Eclipse warning -> The import ___ is never used

---
 .../src/org/adempiere/util/ModelInterfaceGenerator.java    | 7 +++++--
 .../src/org/eevolution/model/I_C_TaxBase.java              | 1 +
 .../src/org/eevolution/model/I_C_TaxDefinition.java        | 1 +
 .../src/org/eevolution/model/I_C_TaxGroup.java             | 1 +
 .../src/org/eevolution/model/I_C_TaxType.java              | 1 +
 .../src/org/eevolution/model/I_DD_NetworkDistribution.java | 1 +
 .../org/eevolution/model/I_DD_NetworkDistributionLine.java | 1 +
 .../src/org/eevolution/model/I_DD_Order.java               | 1 +
 .../src/org/eevolution/model/I_HR_Concept.java             | 1 +
 .../src/org/eevolution/model/I_HR_Contract.java            | 1 +
 .../src/org/eevolution/model/I_HR_Department.java          | 1 +
 .../src/org/eevolution/model/I_HR_Employee.java            | 1 +
 org.adempiere.base/src/org/eevolution/model/I_HR_Job.java  | 1 +
 org.adempiere.base/src/org/eevolution/model/I_HR_List.java | 1 +
 .../src/org/eevolution/model/I_HR_ListLine.java            | 1 +
 .../src/org/eevolution/model/I_HR_ListType.java            | 1 +
 .../src/org/eevolution/model/I_HR_ListVersion.java         | 1 +
 .../src/org/eevolution/model/I_HR_Movement.java            | 1 +
 .../src/org/eevolution/model/I_HR_Payroll.java             | 1 +
 .../src/org/eevolution/model/I_HR_PayrollConcept.java      | 1 +
 .../src/org/eevolution/model/I_HR_Period.java              | 1 +
 .../src/org/eevolution/model/I_HR_Process.java             | 1 +
 org.adempiere.base/src/org/eevolution/model/I_HR_Year.java | 1 +
 .../src/org/eevolution/model/I_I_HR_Movement.java          | 1 +
 .../src/org/eevolution/model/I_I_ProductPlanning.java      | 1 +
 org.adempiere.base/src/org/eevolution/model/I_PP_MRP.java  | 1 +
 .../src/org/eevolution/model/I_PP_Order_Node.java          | 1 +
 .../src/org/eevolution/model/I_PP_Order_NodeNext.java      | 1 +
 .../src/org/eevolution/model/I_PP_Order_Node_Asset.java    | 1 +
 .../src/org/eevolution/model/I_PP_Order_Node_Product.java  | 1 +
 .../src/org/eevolution/model/I_PP_Order_Workflow.java      | 1 +
 .../src/org/eevolution/model/I_PP_Product_Planning.java    | 1 +
 .../src/org/eevolution/model/I_PP_WF_Node_Asset.java       | 1 +
 .../src/org/eevolution/model/I_PP_WF_Node_Product.java     | 1 +
 .../src/org/eevolution/model/I_QM_Specification.java       | 1 +
 .../src/org/eevolution/model/I_QM_SpecificationLine.java   | 1 +
 .../src/org/eevolution/model/I_T_BOMLine.java              | 1 +
 .../src/org/eevolution/model/I_T_MRP_CRP.java              | 1 +
 38 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/org.adempiere.base/src/org/adempiere/util/ModelInterfaceGenerator.java b/org.adempiere.base/src/org/adempiere/util/ModelInterfaceGenerator.java
index 0d8077ddf3..0420c36f6c 100644
--- a/org.adempiere.base/src/org/adempiere/util/ModelInterfaceGenerator.java
+++ b/org.adempiere.base/src/org/adempiere/util/ModelInterfaceGenerator.java
@@ -189,8 +189,11 @@ public class ModelInterfaceGenerator
 		start.append("/** Generated Interface for ").append(tableName).append("\n")
 			 .append(" *  @author iDempiere (generated) \n")
 			 .append(" *  @version ").append(Adempiere.MAIN_VERSION).append(NL) //.append(" - ").append(s_run).append("\n")
-			 .append(" */\n")
-			 .append("public interface ").append(className).append(" {").append("\n")
+			 .append(" */\n");
+		if (!packageName.equals("org.compiere.model")) {
+			 start.append("@SuppressWarnings(\"unused\")\n");
+		}
+		start.append("public interface ").append(className).append(" {").append("\n")
 
 			 .append("    /** TableName=").append(tableName).append(" */\n")
 			 .append("    public static final String Table_Name = \"").append(tableName).append("\";\n")
diff --git a/org.adempiere.base/src/org/eevolution/model/I_C_TaxBase.java b/org.adempiere.base/src/org/eevolution/model/I_C_TaxBase.java
index 2175ec951e..349dcfda2d 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_C_TaxBase.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_C_TaxBase.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_C_TaxBase 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_C_TaxDefinition.java b/org.adempiere.base/src/org/eevolution/model/I_C_TaxDefinition.java
index 66c1e4159f..4de709547c 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_C_TaxDefinition.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_C_TaxDefinition.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_C_TaxDefinition 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_C_TaxGroup.java b/org.adempiere.base/src/org/eevolution/model/I_C_TaxGroup.java
index cbb262fe29..eb049c08bf 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_C_TaxGroup.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_C_TaxGroup.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_C_TaxGroup 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_C_TaxType.java b/org.adempiere.base/src/org/eevolution/model/I_C_TaxType.java
index ea12ce4e70..90f4a69a7e 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_C_TaxType.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_C_TaxType.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_C_TaxType 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_DD_NetworkDistribution.java b/org.adempiere.base/src/org/eevolution/model/I_DD_NetworkDistribution.java
index 76acfea2f0..97da7d7687 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_DD_NetworkDistribution.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_DD_NetworkDistribution.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_DD_NetworkDistribution 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_DD_NetworkDistributionLine.java b/org.adempiere.base/src/org/eevolution/model/I_DD_NetworkDistributionLine.java
index aa383e106d..bbca9b5eca 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_DD_NetworkDistributionLine.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_DD_NetworkDistributionLine.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_DD_NetworkDistributionLine 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_DD_Order.java b/org.adempiere.base/src/org/eevolution/model/I_DD_Order.java
index 0ecf082769..3bd1d6fbbf 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_DD_Order.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_DD_Order.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_DD_Order 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Concept.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Concept.java
index efb198857f..11936b1214 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Concept.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Concept.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Concept 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Contract.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Contract.java
index 30e9f5d73d..d32ac0b865 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Contract.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Contract.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Contract 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Department.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Department.java
index 8e20fec9cb..9153c22566 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Department.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Department.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Department 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Employee.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Employee.java
index 61c05aeebc..9e66e29582 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Employee.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Employee.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Employee 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Job.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Job.java
index ea896c486b..5d66bd28e5 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Job.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Job.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Job 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_List.java b/org.adempiere.base/src/org/eevolution/model/I_HR_List.java
index 0dca85a597..3143d3c1f7 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_List.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_List.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_List 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_ListLine.java b/org.adempiere.base/src/org/eevolution/model/I_HR_ListLine.java
index 32c558d34d..57ceb11785 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_ListLine.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_ListLine.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_ListLine 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_ListType.java b/org.adempiere.base/src/org/eevolution/model/I_HR_ListType.java
index 495dc7bf93..49a25bc34f 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_ListType.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_ListType.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_ListType 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_ListVersion.java b/org.adempiere.base/src/org/eevolution/model/I_HR_ListVersion.java
index f3835b911f..44360f9df4 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_ListVersion.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_ListVersion.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_ListVersion 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Movement.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Movement.java
index ae9e752c94..ca761c5eb5 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Movement.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Movement.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Movement 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Payroll.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Payroll.java
index 926978b9fc..4a0b4d1738 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Payroll.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Payroll.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Payroll 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_PayrollConcept.java b/org.adempiere.base/src/org/eevolution/model/I_HR_PayrollConcept.java
index 0a94773eae..3fe2e0a99b 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_PayrollConcept.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_PayrollConcept.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_PayrollConcept 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Period.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Period.java
index 2e56a27485..bc786cdde7 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Period.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Period.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Period 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Process.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Process.java
index e7254a68b1..299c30fe2e 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Process.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Process.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Process 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_HR_Year.java b/org.adempiere.base/src/org/eevolution/model/I_HR_Year.java
index 2172b64b0f..dda76c90ab 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_HR_Year.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_HR_Year.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_HR_Year 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_I_HR_Movement.java b/org.adempiere.base/src/org/eevolution/model/I_I_HR_Movement.java
index eaeb5a2d6f..08dc294dfb 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_I_HR_Movement.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_I_HR_Movement.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_I_HR_Movement 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_I_ProductPlanning.java b/org.adempiere.base/src/org/eevolution/model/I_I_ProductPlanning.java
index 98c89f494c..b6546316aa 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_I_ProductPlanning.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_I_ProductPlanning.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_I_ProductPlanning 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_MRP.java b/org.adempiere.base/src/org/eevolution/model/I_PP_MRP.java
index e1aa10aeae..e4792adb8a 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_MRP.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_MRP.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_MRP 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node.java b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node.java
index fb6b21abd3..098a9f5801 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_Order_Node 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_NodeNext.java b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_NodeNext.java
index 02660681c2..7168385af8 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_NodeNext.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_NodeNext.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_Order_NodeNext 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node_Asset.java b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node_Asset.java
index addfeaafd1..8cf91bd74e 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node_Asset.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node_Asset.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_Order_Node_Asset 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node_Product.java b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node_Product.java
index a4375d594e..8770725dfc 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node_Product.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Node_Product.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_Order_Node_Product 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Workflow.java b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Workflow.java
index 6563cda632..222f356cf6 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Workflow.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_Order_Workflow.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_Order_Workflow 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_Product_Planning.java b/org.adempiere.base/src/org/eevolution/model/I_PP_Product_Planning.java
index c84433c8ab..fe2ecb056b 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_Product_Planning.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_Product_Planning.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_Product_Planning 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_WF_Node_Asset.java b/org.adempiere.base/src/org/eevolution/model/I_PP_WF_Node_Asset.java
index 869183c1f8..17114bdcf9 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_WF_Node_Asset.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_WF_Node_Asset.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_WF_Node_Asset 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_PP_WF_Node_Product.java b/org.adempiere.base/src/org/eevolution/model/I_PP_WF_Node_Product.java
index ba6ca0acd8..d22a12e009 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_PP_WF_Node_Product.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_PP_WF_Node_Product.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_PP_WF_Node_Product 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_QM_Specification.java b/org.adempiere.base/src/org/eevolution/model/I_QM_Specification.java
index b02b308de3..d6aa2172b2 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_QM_Specification.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_QM_Specification.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_QM_Specification 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_QM_SpecificationLine.java b/org.adempiere.base/src/org/eevolution/model/I_QM_SpecificationLine.java
index 14f4338292..b247b49b41 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_QM_SpecificationLine.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_QM_SpecificationLine.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_QM_SpecificationLine 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_T_BOMLine.java b/org.adempiere.base/src/org/eevolution/model/I_T_BOMLine.java
index 6c0ed8659e..4176e26023 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_T_BOMLine.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_T_BOMLine.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_T_BOMLine 
 {
 
diff --git a/org.adempiere.base/src/org/eevolution/model/I_T_MRP_CRP.java b/org.adempiere.base/src/org/eevolution/model/I_T_MRP_CRP.java
index 809dbea865..ddddf1e366 100644
--- a/org.adempiere.base/src/org/eevolution/model/I_T_MRP_CRP.java
+++ b/org.adempiere.base/src/org/eevolution/model/I_T_MRP_CRP.java
@@ -25,6 +25,7 @@ import org.compiere.util.KeyNamePair;
  *  @author iDempiere (generated) 
  *  @version Release 1.0a
  */
+@SuppressWarnings("unused")
 public interface I_T_MRP_CRP 
 {
 

From 8f13ed795eb223c0ff6822d330d81f61c8fe93a8 Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Wed, 12 Dec 2012 18:11:53 -0500
Subject: [PATCH 29/29] unnecessary SuppressWarnings

---
 .../src/org/compiere/process/RfQResponseRank.java               | 1 -
 org.adempiere.base/src/org/compiere/model/MCountry.java         | 1 -
 org.adempiere.base/src/org/compiere/model/MRegion.java          | 2 --
 .../src/org/compiere/model/ModelValidationEngine.java           | 1 -
 org.adempiere.base/src/org/compiere/model/ScheduleUtil.java     | 1 -
 org.adempiere.base/src/org/compiere/util/CacheMgt.java          | 2 --
 .../src/org/compiere/server/ReplicationProcessor.java           | 1 -
 .../src/org/adempiere/process/rpl/exp/ExportHelper.java         | 1 -
 .../WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java   | 1 -
 9 files changed, 11 deletions(-)

diff --git a/org.adempiere.base.process/src/org/compiere/process/RfQResponseRank.java b/org.adempiere.base.process/src/org/compiere/process/RfQResponseRank.java
index a7e463e032..05fbc904e3 100644
--- a/org.adempiere.base.process/src/org/compiere/process/RfQResponseRank.java
+++ b/org.adempiere.base.process/src/org/compiere/process/RfQResponseRank.java
@@ -107,7 +107,6 @@ public class RfQResponseRank extends SvrProcess
 	 *	@param rfq RfQ 
 	 *	@param responses responses
 	 */
-	@SuppressWarnings("unchecked")
 	private void rankLines (MRfQ rfq, MRfQResponse[] responses)
 	{
 		MRfQLine[] rfqLines = rfq.getLines();
diff --git a/org.adempiere.base/src/org/compiere/model/MCountry.java b/org.adempiere.base/src/org/compiere/model/MCountry.java
index 2bed6fcefd..5920ceeb5b 100644
--- a/org.adempiere.base/src/org/compiere/model/MCountry.java
+++ b/org.adempiere.base/src/org/compiere/model/MCountry.java
@@ -90,7 +90,6 @@ public final class MCountry extends X_C_Country
 	 * 	@param ctx context
 	 *  @return MCountry Array
 	 */
-	@SuppressWarnings("unchecked")
 	public static MCountry[] getCountries(Properties ctx)
 	{
 		if (s_countries == null || s_countries.size() == 0)
diff --git a/org.adempiere.base/src/org/compiere/model/MRegion.java b/org.adempiere.base/src/org/compiere/model/MRegion.java
index 76ea7a7ec2..661dc7dd43 100644
--- a/org.adempiere.base/src/org/compiere/model/MRegion.java
+++ b/org.adempiere.base/src/org/compiere/model/MRegion.java
@@ -118,7 +118,6 @@ public final class MRegion extends X_C_Region
 	 * 	@param ctx context
 	 *  @return MCountry Array
 	 */
-	@SuppressWarnings("unchecked")
 	public static MRegion[] getRegions(Properties ctx)
 	{
 		if (s_regions == null || s_regions.size() == 0)
@@ -135,7 +134,6 @@ public final class MRegion extends X_C_Region
 	 *  @param C_Country_ID country
 	 *  @return MRegion Array
 	 */
-	@SuppressWarnings("unchecked")
 	public static MRegion[] getRegions (Properties ctx, int C_Country_ID)
 	{
 		if (s_regions == null || s_regions.size() == 0)
diff --git a/org.adempiere.base/src/org/compiere/model/ModelValidationEngine.java b/org.adempiere.base/src/org/compiere/model/ModelValidationEngine.java
index 02a2c0721a..b8899fe390 100644
--- a/org.adempiere.base/src/org/compiere/model/ModelValidationEngine.java
+++ b/org.adempiere.base/src/org/compiere/model/ModelValidationEngine.java
@@ -884,7 +884,6 @@ public class ModelValidationEngine
 		}
 
 		//osgi event handlers
-		@SuppressWarnings("rawtypes")
 		Event event = new Event(IEventTopics.PREF_AFTER_LOAD, (Map<String, ?>)null);
 		EventManager.getInstance().sendEvent(event);
 	}
diff --git a/org.adempiere.base/src/org/compiere/model/ScheduleUtil.java b/org.adempiere.base/src/org/compiere/model/ScheduleUtil.java
index cb4c13095e..74a4975a03 100644
--- a/org.adempiere.base/src/org/compiere/model/ScheduleUtil.java
+++ b/org.adempiere.base/src/org/compiere/model/ScheduleUtil.java
@@ -98,7 +98,6 @@ public class ScheduleUtil
 	 *	@param trxName transaction
 	 *  @return Array of existing Assignments or null - if free
 	 */
-	@SuppressWarnings("unchecked")
 	public MAssignmentSlot[] getAssignmentSlots (int S_Resource_ID,
 		Timestamp start_Date, Timestamp end_Date,
 		BigDecimal qty, boolean getAll, String trxName)
diff --git a/org.adempiere.base/src/org/compiere/util/CacheMgt.java b/org.adempiere.base/src/org/compiere/util/CacheMgt.java
index f59c0a11ed..b76247acf9 100644
--- a/org.adempiere.base/src/org/compiere/util/CacheMgt.java
+++ b/org.adempiere.base/src/org/compiere/util/CacheMgt.java
@@ -218,7 +218,6 @@ public class CacheMgt
 	 * 	@param Record_ID record if applicable or 0 for all
 	 * 	@return number of deleted cache entries
 	 */
-	@SuppressWarnings("unchecked")
 	protected int resetLocalCache (String tableName, int Record_ID)
 	{
 		if (tableName == null)
@@ -253,7 +252,6 @@ public class CacheMgt
 	 * 	Total Cached Elements
 	 *	@return count
 	 */
-	@SuppressWarnings("unchecked")
 	public int getElementCount()
 	{
 		int total = 0;
diff --git a/org.adempiere.replication.server/src/org/compiere/server/ReplicationProcessor.java b/org.adempiere.replication.server/src/org/compiere/server/ReplicationProcessor.java
index 126dd5a7ec..a82b582023 100644
--- a/org.adempiere.replication.server/src/org/compiere/server/ReplicationProcessor.java
+++ b/org.adempiere.replication.server/src/org/compiere/server/ReplicationProcessor.java
@@ -83,7 +83,6 @@ public class ReplicationProcessor extends AdempiereServer {
 		m_client = MClient.get(mImportProcessor.getCtx(), mImportProcessor.getAD_Client_ID());
 	}
 	
-	@SuppressWarnings("unchecked")
 	@Override
 	protected void doWork() 
 	{
diff --git a/org.adempiere.replication/src/org/adempiere/process/rpl/exp/ExportHelper.java b/org.adempiere.replication/src/org/adempiere/process/rpl/exp/ExportHelper.java
index a878a024a3..2f6ba861e6 100644
--- a/org.adempiere.replication/src/org/adempiere/process/rpl/exp/ExportHelper.java
+++ b/org.adempiere.replication/src/org/adempiere/process/rpl/exp/ExportHelper.java
@@ -104,7 +104,6 @@ public class ExportHelper {
 	 * 	Process - Generate Export Format
 	 *	@return info
 	 */
-	@SuppressWarnings("unchecked")
 	public String exportRecord (PO po, Integer ReplicationMode , String ReplicationType, Integer ReplicationEvent) throws Exception
 	{
 		MClient client = MClient.get (po.getCtx(), m_AD_Client_ID);
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java
index b7c4cdf2c1..e74a1ebcbe 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/editor/WStringEditor.java
@@ -48,7 +48,6 @@ public class WStringEditor extends WEditor implements ContextMenuListener
 
     private String oldValue;
 
-    @SuppressWarnings("unused")
 	private boolean tableEditor = false;
 
     /**