midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-3350 Accounting Processor GL postings to "secondary" schema unreliable. Caching of report tree ( organization tree, product tree, etc ) by tenant is not safe - due to access right of user+role, each combination of user+role might get a different report tree.

This commit is contained in:
Heng Sin Low 2017-06-09 15:48:08 +08:00
parent 296878a2c3
commit 952ac436af
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
org.adempiere.base/src/org/compiere/report/MReportTree.java
View File

@ -26,6 +26,7 @@ import java.util.logging.Level;
import org.compiere.model.MAcctSchemaElement; import org.compiere.model.MAcctSchemaElement;
import org.compiere.model.MHierarchy; import org.compiere.model.MHierarchy;
import org.compiere.model.MRole;
import org.compiere.model.MTree; import org.compiere.model.MTree;
import org.compiere.model.MTreeNode; import org.compiere.model.MTreeNode;
import org.compiere.util.CCache; import org.compiere.util.CCache;
@ -49,8 +50,14 @@ public class MReportTree
* @return tree * @return tree
*/ */
public static MReportTree get (Properties ctx, int PA_Hierarchy_ID, String ElementType) public static MReportTree get (Properties ctx, int PA_Hierarchy_ID, String ElementType)
{ {
String key = Env.getAD_Client_ID(ctx) + "_" + PA_Hierarchy_ID + ElementType; MRole role = MRole.getDefault();
String key = Env.getAD_Client_ID(ctx) + "_" + role.getAD_Role_ID() + "_" + PA_Hierarchy_ID + "_" + ElementType;
if (!role.isAccessAllOrgs() && role.isUseUserOrgAccess() )
{
key = Env.getAD_Client_ID(ctx) + "_" + Env.getAD_User_ID(ctx) + "_" + role.getAD_Role_ID() + "_" + PA_Hierarchy_ID + "_" + ElementType;
}
MReportTree tree = (MReportTree)s_trees.get(key); MReportTree tree = (MReportTree)s_trees.get(key);
if (tree == null) if (tree == null)
{ {