IDEMPIERE-455 Discover and fix FindBugs problems / Eclipse warning -> raw type

org.adempiere.replication.server/src/org/compiere/server/ReplicationProcessor.java

@@ -114,7 +114,7 @@ public class ReplicationProcessor extends AdempiereServer {
 		    IImportProcessor importProcessor = null;
 		    try 
 		    {
-			Class clazz = Class.forName(javaClass);
+			Class<?> clazz = Class.forName(javaClass);
 			importProcessor = (IImportProcessor)clazz.newInstance();				
 			importProcessor.process(mImportProcessor.getCtx(), this, trxName );
 		    } 

org.adempiere.report.jasper.swing/src/org/compiere/report/JasperViewer.java

@@ -104,7 +104,7 @@ public class JasperViewer extends javax.swing.JFrame {
 	public static void main(String args[]) {
         try {
         	JasperReport myjasperReport = (JasperReport) JasperCompileManager.compileReport(args[0] );
-        	JasperPrint myjasperPrint = JasperFillManager.fillReport( myjasperReport, new HashMap(), getConnection());
+        	JasperPrint myjasperPrint = JasperFillManager.fillReport( myjasperReport, new HashMap<String,Object>(), getConnection());
             JasperViewer.viewReport(myjasperPrint);
            } 
         catch (Exception e) {

org.adempiere.ui.swing/src/org/compiere/acct/AcctViewer.java

@@ -602,7 +602,7 @@ public class AcctViewer extends CFrame
 				m_data.AD_Org_ID = kp.getKey();
 			para.append(", AD_Org_ID=").append(m_data.AD_Org_ID);
 			//
-			Iterator it = m_data.whereInfo.values().iterator();
+			Iterator<String> it = m_data.whereInfo.values().iterator();
 			while (it.hasNext())
 				para.append(", ").append(it.next());
 		}

org.adempiere.ui.swing/src/org/compiere/apps/OnlineHelp.java

@@ -284,7 +284,7 @@ class Worker extends Thread
 				//  key keys
 				if (target == null || href == null)
 				{
-					Enumeration en = as.getAttributeNames();
+					Enumeration<?> en = as.getAttributeNames();
 					while (en.hasMoreElements())
 					{
 						Object o = en.nextElement();

org.adempiere.ui.swing/src/org/compiere/apps/Preference.java

@@ -669,8 +669,8 @@ public final class Preference extends CDialog
 	 */
 	private void cmd_displayErrors()
 	{
-		Vector data = CLogErrorBuffer.get(true).getLogData(bErrorsOnly.isSelected());
+		Vector<Vector<Object>> data = CLogErrorBuffer.get(true).getLogData(bErrorsOnly.isSelected());
-		Vector columnNames = CLogErrorBuffer.get(true).getColumnNames(Env.getCtx());
+		Vector<String> columnNames = CLogErrorBuffer.get(true).getColumnNames(Env.getCtx());
 		DefaultTableModel model = new DefaultTableModel(data, columnNames);
 		errorTable.setModel(model);
 		//

org.adempiere.ui.swing/src/org/compiere/apps/ScreenShot.java

@@ -67,8 +67,8 @@ public class ScreenShot
 			file.delete();
 
 		//	Get Writer
-		Iterator writers = ImageIO.getImageWritersByFormatName("jpg");
+		Iterator<ImageWriter> writers = ImageIO.getImageWritersByFormatName("jpg");
-		ImageWriter writer = (ImageWriter)writers.next();
+		ImageWriter writer = writers.next();
 		if (writer == null)
 		{
 			log.log(Level.SEVERE, "no ImageWriter");

org.adempiere.ui.swing/src/org/compiere/apps/WindowMenu.java

@@ -194,7 +194,7 @@ public class WindowMenu extends JMenu {
 		Image image = bi.getScaledInstance(width, height, Image.SCALE_SMOOTH);
 		
 		final JXTitledPanel box = new JXTitledPanel();
-		final Painter painter = box.getTitlePainter();
+		final Painter<?> painter = box.getTitlePainter();
 		box.setTitlePainter(null);
 		box.setFocusable(true);
 		box.setTitle(window.getTitle());

org.adempiere.ui.swing/src/org/compiere/apps/form/VBOMDrop.java

@@ -27,6 +27,7 @@ import java.util.HashMap;
 import java.util.Iterator;
 import java.util.logging.Level;
 
+import javax.swing.AbstractButton;
 import javax.swing.ButtonGroup;
 import javax.swing.JCheckBox;
 import javax.swing.JRadioButton;
@@ -464,17 +465,17 @@ public class VBOMDrop extends CPanel
 			if (source instanceof JRadioButton)
 			{
 				//	find Button Group
-				Iterator it = m_buttonGroups.values().iterator();
+				Iterator<ButtonGroup> it = m_buttonGroups.values().iterator();
 				while (it.hasNext())
 				{
-					ButtonGroup group = (ButtonGroup)it.next();
+					ButtonGroup group = it.next();
-					Enumeration en = group.getElements();
+					Enumeration<AbstractButton> en = group.getElements();
 					while (en.hasMoreElements())
 					{
 						//	We found the group
 						if (source == en.nextElement())
 						{
-							Enumeration info = group.getElements();
+							Enumeration<AbstractButton> info = group.getElements();
 							while (info.hasMoreElements())
 							{
 								Object infoObj = info.nextElement();

org.adempiere.ui.swing/src/org/compiere/grid/ed/ADempiereAutoCompleteDecorator.java

@@ -55,7 +55,7 @@ public class ADempiereAutoCompleteDecorator extends AutoCompleteDecorator{
      * @param items contains the items that are used for autocompletion
      * @param strictMatching <tt>true</tt>, if only given items should be allowed to be entered
      */
-    public static void decorate(JTextComponent textComponent, List items, boolean strictMatching) {
+    public static void decorate(JTextComponent textComponent, List<?> items, boolean strictMatching) {
         decorate(textComponent, items, strictMatching, ObjectToStringConverter.DEFAULT_IMPLEMENTATION);
     }
     
@@ -68,7 +68,7 @@ public class ADempiereAutoCompleteDecorator extends AutoCompleteDecorator{
      * @param strictMatching <tt>true</tt>, if only given items should be allowed to be entered
      * @param stringConverter the converter used to transform items to strings
      */
-    public static void decorate(JTextComponent textComponent, List items, boolean strictMatching, ObjectToStringConverter stringConverter) {
+    public static void decorate(JTextComponent textComponent, List<?> items, boolean strictMatching, ObjectToStringConverter stringConverter) {
         AbstractAutoCompleteAdaptor adaptor = new TextComponentAdaptor(textComponent, items);
         AutoCompleteDocument document = new AutoCompleteDocument(adaptor, strictMatching, stringConverter);
         decorate(textComponent, document, adaptor);

org.adempiere.ui.swing/src/org/compiere/grid/ed/HTMLEditor.java

@@ -310,7 +310,7 @@ public class HTMLEditor extends CDialog
 	 *	@param actions lookup
 	 *	@return menu
 	 */
-	private JMenu buildMenu(String name, HTMLEditor_MenuAction[] menuActions, Hashtable actions) 
+	private JMenu buildMenu(String name, HTMLEditor_MenuAction[] menuActions, Hashtable<Object,Action> actions) 
 	{
 		JMenu menu = new JMenu(name);
 		for (int i = 0; i < menuActions.length; i++) 

org.adempiere.ui.swing/src/org/compiere/grid/ed/VButton.java

@@ -337,7 +337,7 @@ public final class VButton extends CButton
 	 *	Return value/name
 	 *  @return HashMap with Value/Names
 	 */
-	public HashMap getValues()
+	public HashMap<String,String> getValues()
 	{
 		return m_values;
 	}	//	getValues

org.adempiere.ui.swing/src/org/compiere/grid/ed/VStringBeanInfo.java

@@ -31,7 +31,7 @@ import java.beans.SimpleBeanInfo;
 
 public class VStringBeanInfo extends SimpleBeanInfo
 {
-	private Class beanClass = VString.class;
+	private Class<?> beanClass = VString.class;
 	private String iconColor16x16Filename;
 	private String iconColor32x32Filename;
 	private String iconMono16x16Filename;
@@ -81,7 +81,7 @@ public class VStringBeanInfo extends SimpleBeanInfo
 	}
 	public BeanInfo[] getAdditionalBeanInfo()
 	{
-		Class superclass = beanClass.getSuperclass();
+		Class<?> superclass = beanClass.getSuperclass();
 		try
 		{
 			BeanInfo superBeanInfo = Introspector.getBeanInfo(superclass);

org.adempiere.ui.swing/src/org/compiere/grid/ed/VTextBeanInfo.java

@@ -31,7 +31,7 @@ import java.beans.SimpleBeanInfo;
 
 public class VTextBeanInfo extends SimpleBeanInfo
 {
-	private Class beanClass = VText.class;
+	private Class<?> beanClass = VText.class;
 	private String iconColor16x16Filename;
 	private String iconColor32x32Filename;
 	private String iconMono16x16Filename;
@@ -93,7 +93,7 @@ public class VTextBeanInfo extends SimpleBeanInfo
 	}
 	public BeanInfo[] getAdditionalBeanInfo()
 	{
-		Class superclass = beanClass.getSuperclass();
+		Class<?> superclass = beanClass.getSuperclass();
 		try
 		{
 			BeanInfo superBeanInfo = Introspector.getBeanInfo(superclass);

org.adempiere.ui.swing/src/org/compiere/minigrid/MiniCellEditor.java

@@ -47,7 +47,7 @@ public class MiniCellEditor extends AbstractCellEditor implements TableCellEdito
 	 *  Default Constructor
 	 *  @param c Class
 	 */
-	public MiniCellEditor(Class c)
+	public MiniCellEditor(Class<?> c)
 	{
 		super();
 		//  Date

org.adempiere.ui.swing/src/org/compiere/minigrid/MiniTable.java

@@ -326,7 +326,7 @@ public class MiniTable extends CTable implements IMiniTable
 	 *  @param c   class of column - determines renderere
 	 *  @param readOnly read only flag
 	 */
-	public void setColumnClass (int index, Class c, boolean readOnly)
+	public void setColumnClass (int index, Class<?> c, boolean readOnly)
 	{
 		setColumnClass(index, c, readOnly, null);
 	}   //  setColumnClass
@@ -341,7 +341,7 @@ public class MiniTable extends CTable implements IMiniTable
 	 *  @param readOnly read only flag
 	 *  @param header optional header value
 	 */
-	public void setColumnClass (int index, Class c, boolean readOnly, String header)
+	public void setColumnClass (int index, Class<?> c, boolean readOnly, String header)
 	{
 	//	log.config( "MiniTable.setColumnClass - " + index, c.getName() + ", r/o=" + readOnly);
 		TableColumn tc = getColumnModel().getColumn(index);

org.adempiere.ui.swing/src/org/compiere/swing/CColumnControlButton.java

@@ -703,7 +703,7 @@ public class CColumnControlButton extends JButton {
      * @return a list containing all additional actions to include into the popup.
      */
     protected List<Action> getAdditionalActions() {
-        List actionKeys = getColumnControlActionKeys();
+        List<Object> actionKeys = getColumnControlActionKeys();
         List<Action> actions = new ArrayList<Action>();
         for (Object key : actionKeys) {
           actions.add(table.getActionMap().get(key));
@@ -722,9 +722,9 @@ public class CColumnControlButton extends JButton {
      *   action should be included into the popup.
      */
     @SuppressWarnings("unchecked")
-    protected List getColumnControlActionKeys() {
+    protected List<Object> getColumnControlActionKeys() {
         Object[] allKeys = table.getActionMap().allKeys();
-        List columnKeys = new ArrayList();
+        List columnKeys = new ArrayList<Object>();
         for (int i = 0; i < allKeys.length; i++) {
             if (isColumnControlActionKey(allKeys[i])) {
                 columnKeys.add(allKeys[i]);

org.adempiere.ui.swing/src/org/compiere/swing/CComboBoxEditable.java

@@ -118,7 +118,7 @@ public class CComboBoxEditable extends JComboBox
 	 * @param items  an array of vectors to insert into the combo box
 	 * @see DefaultComboBoxModel
 	 */
-	public CComboBoxEditable(Vector items)
+	public CComboBoxEditable(Vector<Object> items)
 	{
 		super(items);
 		init();

org.adempiere.ui.swing/src/org/compiere/swing/CTable.java

@@ -378,8 +378,8 @@ public class CTable extends JTable
 		// teo_sarca: [ 1585369 ] CTable sorting is TOO LAZY
 		Collections.sort(model.getDataVector(), new Comparator<Object>() {
 			public int compare(Object o1, Object o2) {
-				Object item1 = ((Vector)o1).get(modelColumnIndex);
+				Object item1 = ((Vector<Object>)o1).get(modelColumnIndex);
-				Object item2 = ((Vector)o2).get(modelColumnIndex);
+				Object item2 = ((Vector<Object>)o2).get(modelColumnIndex);
 				return sort.compare(item1, item2);
 			}
 		});

org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/ListModelTable.java

@@ -51,7 +51,7 @@ public class ListModelTable extends ListModelList implements ListModelExt
 	/** The number of columns in the table. */
 	private int m_noColumns;
 
-	private ListModelExt sorter = null;
+	private ListModelExt<Object> sorter = null;
 
 	/**
 	 * Default constructor.
@@ -388,7 +388,7 @@ public class ListModelTable extends ListModelList implements ListModelExt
 		}
 	}
 
-	public void setSorter(ListModelExt lme)
+	public void setSorter(ListModelExt<Object> lme)
 	{
 		sorter = lme;
 	}

org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/SimpleListModel.java

@@ -45,8 +45,8 @@ public class SimpleListModel extends AbstractListModel<Object> implements Listit
 		this(new ArrayList<Object>());
 	}
 	
-	public SimpleListModel(List list) {
+	public SimpleListModel(List<?> list) {
-		this.list = list;
+		this.list = (List<Object>)list;
 	}
 	
 	public Object getElementAt(int index) {

org.adempiere.webstore.servlet/src/org/compiere/wstore/BasketServlet.java

@@ -168,7 +168,7 @@ public class BasketServlet extends HttpServlet
 		String sPrice = WebUtil.getParameter (request, "Price");
 
 		//	Search for Product ID	Add_134 = Add
-		Enumeration en = request.getParameterNames ();
+		Enumeration<String> en = request.getParameterNames ();
 		while (M_Product_ID == 0 && en.hasMoreElements ())
 		{
 			String parameter = (String)en.nextElement ();
@@ -282,7 +282,7 @@ public class BasketServlet extends HttpServlet
 		{
 			log.log(Level.SEVERE, "Set CharacterEncoding=" + WebEnv.ENCODING, e);
 		}
-		Enumeration en = request.getParameterNames();
+		Enumeration<String> en = request.getParameterNames();
 		while (en.hasMoreElements())
 		{
 			String parameter = (String)en.nextElement();

org.adempiere.webstore.servlet/src/org/compiere/wstore/Click.java

@@ -150,7 +150,7 @@ public class Click  extends HttpServlet
 		//	Check parameters		-	/click?www...
 		if (url == null || url.length() == 0)
 		{
-			Enumeration e = request.getParameterNames ();
+			Enumeration<String> e = request.getParameterNames ();
 			if (e.hasMoreElements ())
 				url = (String)e.nextElement ();
 		}

org.apache.ecs/src/org/apache/ecs/storage/Array.java

@@ -18,7 +18,7 @@ package org.apache.ecs.storage;
 
 import java.io.Serializable;
 
-public class Array implements java.util.Enumeration, Serializable
+public class Array implements java.util.Enumeration<Object>, Serializable
 {
     /**
 	 * 
@@ -166,7 +166,7 @@ public class Array implements java.util.Enumeration, Serializable
         return elements[location];
     }
 
-    public java.util.Enumeration elements()
+    public java.util.Enumeration<Object> elements()
     {
         return this;
     }

org.apache.ecs/src/org/apache/ecs/storage/Hash.java

@@ -95,7 +95,7 @@ public class Hash implements java.io.Serializable
         }
     }
 
-    public Enumeration keys()
+    public Enumeration<Object> keys()
     {
         return keys;
     }
@@ -113,7 +113,7 @@ public class Hash implements java.io.Serializable
         return(true);
     }
 
-    public Enumeration elements()
+    public Enumeration<Object> elements()
     {
         return elements;
     }

org.apache.ecs/src/org/apache/ecs/xhtml/a.java

@@ -504,7 +504,7 @@ public class a extends MultiPartElement
 	 */
 	public boolean getNeedLineBreak ()
 	{
-		java.util.Enumeration en = elements ();
+		java.util.Enumeration<Element> en = elements ();
 		int i = 0;
 		int j = 0;
 		while (en.hasMoreElements ())

org.apache.ecs/src/org/apache/ecs/xhtml/td.java

@@ -561,7 +561,7 @@ public class td extends MultiPartElement
 	 */
 	public boolean getNeedLineBreak ()
 	{
-		java.util.Enumeration en = elements ();
+		java.util.Enumeration<Element> en = elements ();
 		int i = 0;
 		int j = 0;
 		while (en.hasMoreElements ())

org.apache.ecs/src/org/apache/ecs/xml/XML.java

@@ -196,7 +196,7 @@ public class XML extends MultiPartElement
 	{
 		boolean linebreak = true;
 
-		java.util.Enumeration en = elements ();
+		java.util.Enumeration<Element> en = elements ();
 
 		// if this tag has one child, and it's a String, then don't
 		// do any linebreaks to preserve whitespace