midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Importer for Price List 

Fix some errors
- not taking IsActive into account
- setting M_PriceList_Version_ID
- avoid ignoring SQLException
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2690930
This commit is contained in:
Carlos Ruiz 2009-12-16 17:59:59 +00:00
parent 5299cb5451
commit 887ef24b8a
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
base/src/org/adempiere/process/ImportPriceList.java
View File

@ -21,13 +21,12 @@
* * * *
* Contributors: * * Contributors: *
* - Carlos Ruiz - globalqss * * - Carlos Ruiz - globalqss *
***********************************************************************/ **********************************************************************/
package org.adempiere.process; package org.adempiere.process;
import java.math.BigDecimal; import java.math.BigDecimal;
import java.sql.PreparedStatement; import java.sql.PreparedStatement;
import java.sql.ResultSet; import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.logging.Level; import java.util.logging.Level;
import org.compiere.model.MPriceList; import org.compiere.model.MPriceList;
@ -283,7 +282,7 @@ public class ImportPriceList extends SvrProcess
{ {
// Set Imported = Y // Set Imported = Y
pstmt_setImported = DB.prepareStatement pstmt_setImported = DB.prepareStatement
("UPDATE I_PriceList SET I_IsImported='Y', M_PriceList_ID=?, " ("UPDATE I_PriceList SET I_IsImported='Y', M_PriceList_ID=?, M_PriceList_Version_ID=?, "
+ "Updated=SysDate, Processed='Y' WHERE I_PriceList_ID=?", get_TrxName()); + "Updated=SysDate, Processed='Y' WHERE I_PriceList_ID=?", get_TrxName());
// //
@ -296,7 +295,7 @@ public class ImportPriceList extends SvrProcess
int M_PriceList_ID = imp.getM_PriceList_ID(); int M_PriceList_ID = imp.getM_PriceList_ID();
if (M_PriceList_ID == 0) { if (M_PriceList_ID == 0) {
// try to obtain the ID directly from DB // try to obtain the ID directly from DB
M_PriceList_ID = DB.getSQLValue(get_TrxName(), "SELECT M_PriceList_ID FROM M_PriceList WHERE AD_Client_ID=? AND Name=?", m_AD_Client_ID, imp.getName()); M_PriceList_ID = DB.getSQLValue(get_TrxName(), "SELECT M_PriceList_ID FROM M_PriceList WHERE IsActive='Y' AND AD_Client_ID=? AND Name=?", m_AD_Client_ID, imp.getName());
if (M_PriceList_ID < 0) if (M_PriceList_ID < 0)
M_PriceList_ID = 0; M_PriceList_ID = 0;
} }
@ -330,7 +329,7 @@ public class ImportPriceList extends SvrProcess
int M_PriceList_Version_ID = imp.getM_PriceList_Version_ID(); int M_PriceList_Version_ID = imp.getM_PriceList_Version_ID();
if (M_PriceList_Version_ID == 0) { if (M_PriceList_Version_ID == 0) {
// try to obtain the ID directly from DB // try to obtain the ID directly from DB
M_PriceList_Version_ID = DB.getSQLValue(get_TrxName(), "SELECT M_PriceList_Version_ID FROM M_PriceList_Version WHERE ValidFrom=? AND M_PriceList_ID=?", new Object[]{imp.getValidFrom(), M_PriceList_ID}); M_PriceList_Version_ID = DB.getSQLValue(get_TrxName(), "SELECT M_PriceList_Version_ID FROM M_PriceList_Version WHERE IsActive='Y' AND ValidFrom=? AND M_PriceList_ID=?", new Object[]{imp.getValidFrom(), M_PriceList_ID});
if (M_PriceList_Version_ID < 0) if (M_PriceList_Version_ID < 0)
M_PriceList_Version_ID = 0; M_PriceList_Version_ID = 0;
} }
@ -373,6 +372,7 @@ public class ImportPriceList extends SvrProcess
"SELECT M_ProductPriceVendorBreak_ID " + "SELECT M_ProductPriceVendorBreak_ID " +
"FROM M_ProductPriceVendorBreak " + "FROM M_ProductPriceVendorBreak " +
"WHERE M_PriceList_Version_ID=? AND " + "WHERE M_PriceList_Version_ID=? AND " +
"IsActive='Y' AND " +
"C_BPartner_ID=? AND " + "C_BPartner_ID=? AND " +
"M_Product_ID=? AND " + "M_Product_ID=? AND " +
"BreakValue=?", "BreakValue=?",
@ -442,16 +442,14 @@ public class ImportPriceList extends SvrProcess
// Update I_PriceList // Update I_PriceList
pstmt_setImported.setInt(1, M_PriceList_ID); pstmt_setImported.setInt(1, M_PriceList_ID);
pstmt_setImported.setInt(2, I_PriceList_ID); pstmt_setImported.setInt(2, M_PriceList_Version_ID);
pstmt_setImported.setInt(3, I_PriceList_ID);
no = pstmt_setImported.executeUpdate(); no = pstmt_setImported.executeUpdate();
// //
commitEx(); commitEx();
} // for all I_PriceList } // for all I_PriceList
// //
} }
catch (SQLException e)
{
}
finally finally
{ {
DB.close(rs, pstmt); DB.close(rs, pstmt);