midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*BF [ 1874419 ] JDBC Statement not close in a finally block

This commit is contained in:
Redhuan D. Oon 2008-02-08 09:46:03 +00:00
parent dc20d4e7b3
commit 84ed404db1
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
base/src/org/adempiere/pipo/handler/MessageElementHandler.java
View File

@ -85,11 +85,12 @@ public class MessageElementHandler extends AbstractElementHandler {
String sql = "SELECT value FROM AD_Message WHERE AD_Message_ID= " + AD_Message_ID; String sql = "SELECT value FROM AD_Message WHERE AD_Message_ID= " + AD_Message_ID;
AttributesImpl atts = new AttributesImpl(); AttributesImpl atts = new AttributesImpl();
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
pstmt = DB.prepareStatement (sql, getTrxName(ctx)); pstmt = DB.prepareStatement (sql, getTrxName(ctx));
try { try {
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
while (rs.next()) while (rs.next())
{ {
@ -98,21 +99,15 @@ public class MessageElementHandler extends AbstractElementHandler {
document.startElement("","","message",atts); document.startElement("","","message",atts);
document.endElement("","","message"); document.endElement("","","message");
} }
rs.close();
pstmt.close();
pstmt = null;
} }
catch (Exception e){ catch (Exception e){
log.log(Level.SEVERE,"getProcess", e); log.log(Level.SEVERE,"getProcess", e);
} }
finally{ finally
try { {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
}
catch (Exception e){}
pstmt = null;
} }
} }