midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1874419 ] JDBC Statement not close in a finally block - fixed 

* reorganized imports
This commit is contained in:
Redhuan D. Oon 2008-02-07 14:52:40 +00:00
parent 19bc8038df
commit 71ee0da862
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
base/src/org/compiere/wf/DocWorkflowManager.java
View File

@ -16,12 +16,17 @@
*****************************************************************************/ *****************************************************************************/
package org.compiere.wf; package org.compiere.wf;
import java.sql.*; import java.sql.PreparedStatement;
import java.util.logging.*; import java.sql.ResultSet;
import java.util.logging.Level;
import org.compiere.model.*; import org.compiere.model.DocWorkflowMgr;
import org.compiere.process.*; import org.compiere.model.PO;
import org.compiere.util.*; import org.compiere.process.ProcessInfo;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
import org.compiere.util.Env;
import org.compiere.util.Evaluator;
/** /**
@ -163,6 +168,7 @@ public class DocWorkflowManager implements DocWorkflowMgr
.append(" AND wfp.AD_Workflow_ID=?") // #4 .append(" AND wfp.AD_Workflow_ID=?") // #4
.append(" AND SUBSTR(wfp.WFState,1,1)='O')"); .append(" AND SUBSTR(wfp.WFState,1,1)='O')");
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql.toString(), document.get_TrxName()); pstmt = DB.prepareStatement (sql.toString(), document.get_TrxName());
@ -170,28 +176,22 @@ public class DocWorkflowManager implements DocWorkflowMgr
pstmt.setInt (2, document.get_ID()); pstmt.setInt (2, document.get_ID());
pstmt.setInt (3, document.get_Table_ID()); pstmt.setInt (3, document.get_Table_ID());
pstmt.setInt (4, wf.getAD_Workflow_ID()); pstmt.setInt (4, wf.getAD_Workflow_ID());
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
if (rs.next ()) if (rs.next ())
retValue = true; retValue = true;
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
log.log (Level.SEVERE, "Logic=" + logic log.log (Level.SEVERE, "Logic=" + logic
+ " - SQL=" + sql.toString(), e); + " - SQL=" + sql.toString(), e);
} }
try finally
{
if (pstmt != null)
pstmt.close ();
pstmt = null;
}
catch (Exception e)
{ {
DB.close(rs, pstmt);
rs = null;
pstmt = null; pstmt = null;
} }
return retValue; return retValue;
} // testStart } // testStart