midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-5520 Navigation between Tabs leave Detached DOM objects (Leak) (#1669) 

- Fix "Not unique in the ID space of" when tab where clause have context variables
This commit is contained in:
Carlos Ruiz 2023-02-12 13:08:50 +01:00 committed by GitHub
parent 1daa1c70e2
commit 6c643a3ffd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/FindWindow.java
View File

@ -350,6 +350,7 @@ public class FindWindow extends Window implements EventListener<Event>, ValueCha
this.setWidgetAttribute(AdempiereWebUI.WIDGET_INSTANCE_NAME, "findWindow"); this.setWidgetAttribute(AdempiereWebUI.WIDGET_INSTANCE_NAME, "findWindow");
this.setId("findWindow_"+targetWindowNo+"_"+targetTabNo); this.setId("findWindow_"+targetWindowNo+"_"+targetTabNo);
System.out.println("this.setId -> findWindow_"+targetWindowNo+"_"+targetTabNo);
LayoutUtils.addSclass("find-window", this); LayoutUtils.addSclass("find-window", this);
addEventListener(Events.ON_CANCEL, e -> onCancel()); addEventListener(Events.ON_CANCEL, e -> onCancel());
@ -389,6 +390,7 @@ public class FindWindow extends Window implements EventListener<Event>, ValueCha
if ((title == null && m_title != null) || (title != null && m_title == null) || !(title.equals(m_title))) return false; if ((title == null && m_title != null) || (title != null && m_title == null) || !(title.equals(m_title))) return false;
if (AD_Table_ID != m_AD_Table_ID) return false; if (AD_Table_ID != m_AD_Table_ID) return false;
if ((tableName == null && m_tableName != null) || (tableName != null && m_tableName == null) || !(tableName.equals(m_tableName))) return false; if ((tableName == null && m_tableName != null) || (tableName != null && m_tableName == null) || !(tableName.equals(m_tableName))) return false;
whereExtended = Env.parseContext(Env.getCtx(), targetWindowNo, whereExtended, false);
if ((whereExtended == null && m_whereExtended != null) || (whereExtended != null && m_whereExtended == null) || !(whereExtended.equals(m_whereExtended))) return false; if ((whereExtended == null && m_whereExtended != null) || (whereExtended != null && m_whereExtended == null) || !(whereExtended.equals(m_whereExtended))) return false;
if (adTabId != m_AD_Tab_ID) return false; if (adTabId != m_AD_Tab_ID) return false;
if ((findFields == null && m_findFields != null) || (findFields != null && m_findFields == null) || (findFields.length != m_findFields.length)) return false; if ((findFields == null && m_findFields != null) || (findFields != null && m_findFields == null) || (findFields.length != m_findFields.length)) return false;