midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1874419 ] JDBC Statement not close in a finally block

This commit is contained in:
Redhuan D. Oon 2008-07-03 14:38:40 +00:00
parent ca5a97280c
commit 6bcf6c444d
1 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
base/src/org/compiere/FA/Depreciation.java
View File

@ -728,8 +728,9 @@ public class Depreciation {
//System.out.println("SYD: "+sqlB.toString()); //System.out.println("SYD: "+sqlB.toString());
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
pstmt = DB.prepareStatement (sqlB.toString(),null); pstmt = DB.prepareStatement (sqlB.toString(),null);
ResultSet rs = null;
try { try {
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
while (rs.next()){ while (rs.next()){
int v_life_current_year = (int)(p_A_CURRENT_PERIOD/(12))+1; int v_life_current_year = (int)(p_A_CURRENT_PERIOD/(12))+1;
@ -749,14 +750,8 @@ public class Depreciation {
} }
finally finally
{ {
try DB.close(rs, pstmt);
{ rs = null; pstmt = null;
if (pstmt != null)
pstmt.close ();
}
catch (Exception e)
{}
pstmt = null;
} }
return A_Period_Exp; return A_Period_Exp;
} }
@ -782,8 +777,9 @@ public class Depreciation {
//System.out.println("TAB: "+sqlB.toString()); //System.out.println("TAB: "+sqlB.toString());
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
pstmt = DB.prepareStatement (sqlB.toString(),null); pstmt = DB.prepareStatement (sqlB.toString(),null);
ResultSet rs = null;
try { try {
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
while (rs.next()){ while (rs.next()){
@ -912,14 +908,9 @@ public class Depreciation {
} }
finally finally
{ {
try DB.close(rs, pstmt);
{ rs = null; pstmt = null;
if (pstmt != null)
pstmt.close ();
}
catch (Exception e)
{}
pstmt = null;
} }
return A_Period_Exp; return A_Period_Exp;
} }