midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*BF [ 1874419 ] JDBC Statement not close in a finally block 

organize imports
This commit is contained in:
Redhuan D. Oon 2008-02-19 10:33:12 +00:00
parent e956f4561f
commit 67b98722a5
1 changed files with 24 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
base/src/org/compiere/wf/MWorkflowProcessor.java
View File

@ -16,11 +16,18 @@
*****************************************************************************/ *****************************************************************************/
package org.compiere.wf; package org.compiere.wf;
import java.sql.*; import java.sql.PreparedStatement;
import java.util.*; import java.sql.ResultSet;
import org.compiere.model.*; import java.sql.Timestamp;
import java.util.logging.*; import java.util.ArrayList;
import org.compiere.util.*; import java.util.Properties;
import java.util.logging.Level;
import org.compiere.model.AdempiereProcessor;
import org.compiere.model.AdempiereProcessorLog;
import org.compiere.model.X_AD_WorkflowProcessor;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
/** /**
@ -42,30 +49,24 @@ public class MWorkflowProcessor extends X_AD_WorkflowProcessor
ArrayList<MWorkflowProcessor> list = new ArrayList<MWorkflowProcessor>(); ArrayList<MWorkflowProcessor> list = new ArrayList<MWorkflowProcessor>();
String sql = "SELECT * FROM AD_WorkflowProcessor WHERE IsActive='Y'"; String sql = "SELECT * FROM AD_WorkflowProcessor WHERE IsActive='Y'";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
list.add (new MWorkflowProcessor (ctx, rs, null)); list.add (new MWorkflowProcessor (ctx, rs, null));
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
s_log.log(Level.SEVERE, sql, e); s_log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
MWorkflowProcessor[] retValue = new MWorkflowProcessor[list.size ()]; MWorkflowProcessor[] retValue = new MWorkflowProcessor[list.size ()];
list.toArray (retValue); list.toArray (retValue);
return retValue; return retValue;
@ -131,31 +132,25 @@ public class MWorkflowProcessor extends X_AD_WorkflowProcessor
+ "WHERE AD_WorkflowProcessor_ID=? " + "WHERE AD_WorkflowProcessor_ID=? "
+ "ORDER BY Created DESC"; + "ORDER BY Created DESC";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, get_TrxName()); pstmt = DB.prepareStatement (sql, get_TrxName());
pstmt.setInt (1, getAD_WorkflowProcessor_ID()); pstmt.setInt (1, getAD_WorkflowProcessor_ID());
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
list.add (new MWorkflowProcessorLog (getCtx(), rs, get_TrxName())); list.add (new MWorkflowProcessorLog (getCtx(), rs, get_TrxName()));
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
MWorkflowProcessorLog[] retValue = new MWorkflowProcessorLog[list.size ()]; MWorkflowProcessorLog[] retValue = new MWorkflowProcessorLog[list.size ()];
list.toArray (retValue); list.toArray (retValue);
return retValue; return retValue;