midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

1003875 From server log - Fixed NPE in AbstractDesktop.

This commit is contained in:
Heng Sin Low 2014-03-26 20:41:39 +08:00
parent cb485f7191
commit 61cb022c41
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/desktop/AbstractDesktop.java
View File

@ -26,6 +26,7 @@ import org.adempiere.webui.part.AbstractUIPart;
import org.compiere.model.MMenu; import org.compiere.model.MMenu;
import org.compiere.util.CLogger; import org.compiere.util.CLogger;
import org.compiere.util.Env; import org.compiere.util.Env;
import org.zkoss.zk.ui.Desktop;
import org.zkoss.zk.ui.Executions; import org.zkoss.zk.ui.Executions;
import org.zkoss.zk.ui.Session; import org.zkoss.zk.ui.Session;
import org.zkoss.zk.ui.event.Event; import org.zkoss.zk.ui.event.Event;
@ -122,7 +123,7 @@ public abstract class AbstractDesktop extends AbstractUIPart implements IDesktop
*/ */
public void unregisterWindow(int WindowNo) { public void unregisterWindow(int WindowNo) {
List<Object> windows = getWindows(); List<Object> windows = getWindows();
if (WindowNo < windows.size()) if (windows != null && WindowNo < windows.size())
windows.set(WindowNo, null); windows.set(WindowNo, null);
Env.clearWinContext(WindowNo); Env.clearWinContext(WindowNo);
} }
@ -134,7 +135,7 @@ public abstract class AbstractDesktop extends AbstractUIPart implements IDesktop
*/ */
public Object findWindow(int WindowNo) { public Object findWindow(int WindowNo) {
List<Object> windows = getWindows(); List<Object> windows = getWindows();
if (WindowNo < windows.size()) if (windows != null && WindowNo < windows.size())
return windows.get(WindowNo); return windows.get(WindowNo);
else else
return null; return null;
@ -299,14 +300,19 @@ public abstract class AbstractDesktop extends AbstractUIPart implements IDesktop
} }
protected List<Object> getWindows(){ protected List<Object> getWindows(){
Session session = getComponent().getDesktop().getSession(); Desktop desktop = getComponent().getDesktop();
@SuppressWarnings("unchecked") if (desktop != null) {
List<Object> list = (List<Object>) session.getAttribute("windows.list"); Session session = desktop.getSession();
if (list == null) { @SuppressWarnings("unchecked")
list = new ArrayList<Object>(); List<Object> list = (List<Object>) session.getAttribute("windows.list");
session.setAttribute("windows.list", list); if (list == null) {
list = new ArrayList<Object>();
session.setAttribute("windows.list", list);
}
return Collections.synchronizedList(list);
} else {
return null;
} }
return Collections.synchronizedList(list);
} }
} }