midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-5698 - Improvement for display all events errors (#1807) 

* IDEMPIERE-5698 - mprovement for display all events errors

* IDEMPIERE-5698 - Improvement for display all events errors in all methods of class
This commit is contained in:
Jose Leite 2023-04-28 11:55:43 -03:00 committed by GitHub
parent 1de363d65d
commit 61118b8877
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 33 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
org.adempiere.base/src/org/compiere/model/ModelValidationEngine.java
View File

@ -17,6 +17,7 @@
package org.compiere.model; package org.compiere.model;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collections;
import java.util.Hashtable; import java.util.Hashtable;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
@ -267,8 +268,14 @@ public class ModelValidationEngine
EventManager.getInstance().sendEvent(event); EventManager.getInstance().sendEvent(event);
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
List<String> errors = (List<String>) event.getProperty(IEventManager.EVENT_ERROR_MESSAGES); List<String> errors = (List<String>) event.getProperty(IEventManager.EVENT_ERROR_MESSAGES);
if (errors != null && !errors.isEmpty()) if (errors != null && !errors.isEmpty()) {
return errors.get(0); Collections.reverse(errors);
StringBuilder eventErrors = new StringBuilder("");
for (String error : errors) {
eventErrors.append(error).append("<br>");
}
return eventErrors.toString();
}
if ((AD_User_ID == SystemIDs.USER_SYSTEM || AD_User_ID == SystemIDs.USER_SUPERUSER) && AD_Role_ID == SystemIDs.ROLE_SYSTEM) if ((AD_User_ID == SystemIDs.USER_SYSTEM || AD_User_ID == SystemIDs.USER_SUPERUSER) && AD_Role_ID == SystemIDs.ROLE_SYSTEM)
; // don't validate for user system on role system ; // don't validate for user system on role system
@ -406,8 +413,14 @@ public class ModelValidationEngine
EventManager.getInstance().sendEvent(event); EventManager.getInstance().sendEvent(event);
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
List<String> errors = (List<String>) event.getProperty(IEventManager.EVENT_ERROR_MESSAGES); List<String> errors = (List<String>) event.getProperty(IEventManager.EVENT_ERROR_MESSAGES);
if (errors != null && !errors.isEmpty()) if (errors != null && !errors.isEmpty()) {
return errors.get(0); Collections.reverse(errors);
StringBuilder eventErrors = new StringBuilder("");
for (String error : errors) {
eventErrors.append(error).append("<br>");
}
return eventErrors.toString();
}
return null; return null;
} // fireModelChange } // fireModelChange
@ -573,9 +586,14 @@ public class ModelValidationEngine
EventManager.getInstance().sendEvent(event); EventManager.getInstance().sendEvent(event);
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
List<String> errors = (List<String>) event.getProperty(IEventManager.EVENT_ERROR_MESSAGES); List<String> errors = (List<String>) event.getProperty(IEventManager.EVENT_ERROR_MESSAGES);
if (errors != null && !errors.isEmpty()) if (errors != null && !errors.isEmpty()) {
return errors.get(0); Collections.reverse(errors);
StringBuilder eventErrors = new StringBuilder("");
for (String error : errors) {
eventErrors.append(error).append("<br>");
}
return eventErrors.toString();
}
return null; return null;
} // fireDocValidate } // fireDocValidate
@ -722,8 +740,14 @@ public class ModelValidationEngine
EventManager.getInstance().sendEvent(event); EventManager.getInstance().sendEvent(event);
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
List<String> errors = (List<String>) event.getProperty(IEventManager.EVENT_ERROR_MESSAGES); List<String> errors = (List<String>) event.getProperty(IEventManager.EVENT_ERROR_MESSAGES);
if (errors != null && !errors.isEmpty()) if (errors != null && !errors.isEmpty()) {
return errors.get(0); Collections.reverse(errors);
StringBuilder eventErrors = new StringBuilder("");
for (String error : errors) {
eventErrors.append(error).append("<br>");
}
return eventErrors.toString();
}
return null; return null;
} // fireFactsValidate } // fireFactsValidate