Peer review [ 1867464 ] Incorrect Partner Location when create manual shipment

Small refactoring
This commit is contained in:
Carlos Ruiz 2008-01-14 23:07:58 +00:00
parent c937785ed0
commit 6005e2cfb1
1 changed files with 50 additions and 53 deletions

View File

@ -185,12 +185,11 @@ public class CalloutInOut extends CalloutEngine
PreparedStatement pstmt = DB.prepareStatement(sql, null); PreparedStatement pstmt = DB.prepareStatement(sql, null);
pstmt.setInt(1, C_BPartner_ID.intValue()); pstmt.setInt(1, C_BPartner_ID.intValue());
ResultSet rs = pstmt.executeQuery(); ResultSet rs = pstmt.executeQuery();
BigDecimal bd;
if (rs.next()) if (rs.next())
{ {
//[ 1867464 ] //[ 1867464 ]
boolean IsSOTrx = Env.getContext(ctx, WindowNo, "IsSOTrx").equals("Y"); boolean IsSOTrx = "Y".equals(Env.getContext(ctx, WindowNo, "IsSOTrx"));
if(!IsSOTrx) if (!IsSOTrx)
{ {
// Location // Location
Integer ii = new Integer(rs.getInt("C_BPartner_Location_ID")); Integer ii = new Integer(rs.getInt("C_BPartner_Location_ID"));
@ -207,7 +206,6 @@ public class CalloutInOut extends CalloutEngine
} }
//Bugs item #1679818: checking for SOTrx only //Bugs item #1679818: checking for SOTrx only
//boolean IsSOTrx = Env.getContext(ctx, WindowNo, "IsSOTrx").equals("Y");
if (IsSOTrx) if (IsSOTrx)
{ {
// CreditAvailable // CreditAvailable
@ -259,7 +257,6 @@ public class CalloutInOut extends CalloutEngine
PreparedStatement pstmt = DB.prepareStatement(sql, null); PreparedStatement pstmt = DB.prepareStatement(sql, null);
pstmt.setInt(1, M_Warehouse_ID.intValue()); pstmt.setInt(1, M_Warehouse_ID.intValue());
ResultSet rs = pstmt.executeQuery(); ResultSet rs = pstmt.executeQuery();
BigDecimal bd;
if (rs.next()) if (rs.next())
{ {
// Org // Org