From 5bc3fbc260515f1608c791d0075cb0390e4bb1ff Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Mon, 16 Mar 2009 21:14:54 +0000 Subject: [PATCH] Implement [1762461] - Remove hardcoded list items checking in generated models https://sourceforge.net/tracker2/index.php?func=detail&aid=1762461&group_id=176962&atid=879335 Show valid values in error message --- base/src/org/compiere/model/PO.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/base/src/org/compiere/model/PO.java b/base/src/org/compiere/model/PO.java index e723d6c179..a4f6d0751f 100644 --- a/base/src/org/compiere/model/PO.java +++ b/base/src/org/compiere/model/PO.java @@ -785,9 +785,13 @@ public abstract class PO if (MRefList.get(getCtx(), p_info.getColumn(index).AD_Reference_Value_ID, (String) value, get_TrxName()) != null) ; - else + else { + StringBuffer validValues = new StringBuffer(); + for (ValueNamePair vp : MRefList.getList(getCtx(), p_info.getColumn(index).AD_Reference_Value_ID, false)) + validValues.append(" - ").append(vp.getValue()); throw new IllegalArgumentException(ColumnName + " Invalid value - " - + value + " - Reference_ID=" + p_info.getColumn(index).AD_Reference_Value_ID); + + value + " - Reference_ID=" + p_info.getColumn(index).AD_Reference_Value_ID + validValues.toString()); + } } if (CLogMgt.isLevelFinest()) log.finest(ColumnName + " = " + m_newValues[index] + " (OldValue="+m_oldValues[index]+")");