midsuit
/
core-jgi
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-6160 Remove Eclipse warnings (#2379)

This commit is contained in:
Carlos Ruiz 2024-05-29 15:07:59 +02:00
parent 69995b178b
commit 5994292dbb
4 changed files with 24 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java
View File

@ -245,7 +245,8 @@ public abstract class OFXBankStatementHandler extends DefaultHandler
if (isOfx1) if (isOfx1)
{ {
m_reader = new BufferedReader(new InputStreamReader(new OFX1ToXML(reader))); OFX1ToXML in = new OFX1ToXML(reader);
m_reader = new BufferedReader(new InputStreamReader(in));
} }
else else
{ {
@ -257,9 +258,12 @@ public abstract class OFXBankStatementHandler extends DefaultHandler
{ {
m_errorMessage = new StringBuffer("ErrorReadingData"); m_errorMessage = new StringBuffer("ErrorReadingData");
m_errorDescription = new StringBuffer(e.getMessage()); m_errorDescription = new StringBuffer(e.getMessage());
closeBufferedReader();
return result; return result;
} }
finally
{
closeBufferedReader();
}
return result; return result;
} // attachInput } // attachInput

8
org.adempiere.base/src/org/compiere/impexp/OFXFileBankStatementLoader.java
View File

@ -17,6 +17,7 @@
package org.compiere.impexp; package org.compiere.impexp;
import java.io.FileInputStream; import java.io.FileInputStream;
import java.io.IOException;
import org.compiere.model.MBankStatementLoader; import org.compiere.model.MBankStatementLoader;
import org.xml.sax.SAXException; import org.xml.sax.SAXException;
@ -70,6 +71,13 @@ public final class OFXFileBankStatementLoader extends OFXBankStatementHandler im
m_errorMessage = new StringBuffer("ErrorReadingData"); m_errorMessage = new StringBuffer("ErrorReadingData");
m_errorDescription = new StringBuffer(); m_errorDescription = new StringBuffer();
} }
finally
{
if (m_stream != null)
try {
m_stream.close();
} catch (IOException e) {}
}
return result; return result;
} // init } // init

7
org.adempiere.install/src/org/compiere/install/ConfigurationData.java
View File

@ -831,6 +831,13 @@ public class ConfigurationData
if (log.isLoggable(Level.FINE)) log.fine(host + ":" + port + " - " + e.getMessage()); if (log.isLoggable(Level.FINE)) log.fine(host + ":" + port + " - " + e.getMessage());
return false; return false;
} }
finally
{
if (pingSocket != null)
try {
pingSocket.close();
} catch (IOException e) {}
}
if (!shouldBeUsed) if (!shouldBeUsed)
log.warning("Open Socket " + host + ":" + port + " - " + pingSocket); log.warning("Open Socket " + host + ":" + port + " - " + pingSocket);

3
org.adempiere.ui/src/org/compiere/apps/form/PayPrint.java
View File

@ -346,8 +346,9 @@ public class PayPrint {
if (pdfFile != null) if (pdfFile != null)
{ {
// increase the check document no by the number of pages of the generated pdf file // increase the check document no by the number of pages of the generated pdf file
PdfReader document = new PdfReader(pdfFile.getAbsolutePath()); try (PdfReader document = new PdfReader(pdfFile.getAbsolutePath())) {
lastDocumentNo += document.getNumberOfPages(); lastDocumentNo += document.getNumberOfPages();
}
pdfList.add(pdfFile); pdfList.add(pdfFile);
} }
} }