From 58e44e1b5c8ea46ee4b63e60f6f1d775dd873d90 Mon Sep 17 00:00:00 2001
From: hengsin <hengsin@gmail.com>
Date: Fri, 15 Dec 2023 16:47:25 +0800
Subject: [PATCH] IDEMPIERE-5888 Login Preferences are created on System tenant
 (#2143)

Fix NPE - oldValue sometime can be null
---
 .../WEB-INF/src/org/adempiere/webui/util/UserPreference.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/util/UserPreference.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/util/UserPreference.java
index 9bd4459aba..f553e900a8 100644
--- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/util/UserPreference.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/util/UserPreference.java
@@ -125,7 +125,7 @@ public final class UserPreference implements Serializable {
 						preference.setAttribute(attribute);
 					}
 					String oldValue = preference.getValue();
-					if (! oldValue.equals(value)) {
+					if (! value.equals(oldValue)) {
 						try {
 							PO.setCrossTenantSafe();
 							preference.setValue(value);