midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-1248 Performance Optimization: Eliminate the fire and processing of duplicate event. Fixed regression - post of dynamic display break lookup editor.

This commit is contained in:
Heng Sin Low 2013-08-05 12:25:49 +08:00
parent 5f38260736
commit 570b5dd012
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java
View File

@ -78,6 +78,7 @@ import org.compiere.util.Util;
import org.zkoss.zk.au.out.AuFocus; import org.zkoss.zk.au.out.AuFocus;
import org.zkoss.zk.au.out.AuScript; import org.zkoss.zk.au.out.AuScript;
import org.zkoss.zk.ui.Component; import org.zkoss.zk.ui.Component;
import org.zkoss.zk.ui.Execution;
import org.zkoss.zk.ui.Executions; import org.zkoss.zk.ui.Executions;
import org.zkoss.zk.ui.HtmlBasedComponent; import org.zkoss.zk.ui.HtmlBasedComponent;
import org.zkoss.zk.ui.IdSpace; import org.zkoss.zk.ui.IdSpace;
@ -127,9 +128,9 @@ DataStatusListener, IADTabpanel, IdSpace, IFieldEditorContainer
public static final String ON_DYNAMIC_DISPLAY_EVENT = "onDynamicDisplay"; public static final String ON_DYNAMIC_DISPLAY_EVENT = "onDynamicDisplay";
public static final String ON_DEFER_DYNAMIC_DISPLAY_EVENT = "onDeferDynamicDisplay"; public static final String ON_DYNAMIC_DISPLAY_CALL_EVENT = "onDynamicDisplayCall";
public static final String ON_DEFER_DYNAMIC_DISPLAY_EVENT_ATTR = "onDeferDynamicDisplay.Event.Posted"; public static final String ON_DYNAMIC_DISPLAY_CALL_EVENT_ATTR = "onDynamicDisplayCall.Event.Posted";
/** /**
* *
@ -223,7 +224,7 @@ DataStatusListener, IADTabpanel, IdSpace, IFieldEditorContainer
}); });
addEventListener(ON_POST_INIT_EVENT, this); addEventListener(ON_POST_INIT_EVENT, this);
addEventListener(ON_SAVE_OPEN_PREFERENCE_EVENT, this); addEventListener(ON_SAVE_OPEN_PREFERENCE_EVENT, this);
addEventListener(ON_DEFER_DYNAMIC_DISPLAY_EVENT, this); addEventListener(ON_DYNAMIC_DISPLAY_CALL_EVENT, this);
} }
private void initComponents() private void initComponents()
@ -666,16 +667,16 @@ DataStatusListener, IADTabpanel, IdSpace, IFieldEditorContainer
//0 and -1 is same //0 and -1 is same
if (col < 0) if (col < 0)
col = 0; col = 0;
if (getAttribute(ON_DEFER_DYNAMIC_DISPLAY_EVENT_ATTR+"_"+col) == null) Execution exec = Executions.getCurrent();
if (exec.getAttribute(ON_DYNAMIC_DISPLAY_CALL_EVENT_ATTR+"_"+col) == null)
{ {
setAttribute(ON_DEFER_DYNAMIC_DISPLAY_EVENT_ATTR+"_"+col, Boolean.TRUE); exec.setAttribute(ON_DYNAMIC_DISPLAY_CALL_EVENT_ATTR+"_"+col, Boolean.TRUE);
Events.postEvent(ON_DEFER_DYNAMIC_DISPLAY_EVENT, this, col); Events.sendEvent(ON_DYNAMIC_DISPLAY_CALL_EVENT, this, col);
} }
} }
private void onDeferDynamicDisplay (int col) private void onDynamicDisplayCall (int col)
{ {
removeAttribute(ON_DEFER_DYNAMIC_DISPLAY_EVENT_ATTR+"_"+col);
if (!gridTab.isOpen()) if (!gridTab.isOpen())
{ {
return; return;
@ -1080,9 +1081,9 @@ DataStatusListener, IADTabpanel, IdSpace, IFieldEditorContainer
Env.getCtx().setProperty("P"+windowId+"|"+adTabId+"|DetailPane.IsOpen", value ? "Y" : "N"); Env.getCtx().setProperty("P"+windowId+"|"+adTabId+"|DetailPane.IsOpen", value ? "Y" : "N");
} }
} }
else if (event.getName().equals(ON_DEFER_DYNAMIC_DISPLAY_EVENT)) { else if (event.getName().equals(ON_DYNAMIC_DISPLAY_CALL_EVENT)) {
Integer col = (Integer) event.getData(); Integer col = (Integer) event.getData();
onDeferDynamicDisplay(col); onDynamicDisplayCall(col);
} }
} }