midsuit
/
core-jgi
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*BF [ 1874419 ] JDBC Statement not close in a finally block 

organize imports
This commit is contained in:
Redhuan D. Oon 2008-02-19 13:39:40 +00:00
parent 78f067a5b6
commit 563a2ba707
1 changed files with 29 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
base/src/org/adempiere/util/GenerateModelJPA.java
View File

@ -15,12 +15,20 @@
*****************************************************************************/ *****************************************************************************/
package org.adempiere.util; package org.adempiere.util;
import java.io.*; import java.io.File;
import java.math.*; import java.io.FileWriter;
import java.sql.*; import java.math.BigDecimal;
import java.util.logging.*; import java.sql.PreparedStatement;
import org.compiere.*; import java.sql.ResultSet;
import org.compiere.util.*; import java.sql.Timestamp;
import java.util.logging.Level;
import org.compiere.Adempiere;
import org.compiere.util.CLogMgt;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
import org.compiere.util.DisplayType;
import org.compiere.util.Env;
/** /**
* Generate Model Classes extending PO. * Generate Model Classes extending PO.
@ -238,11 +246,12 @@ public class GenerateModelJPA
+ " AND c.ColumnName NOT LIKE 'Updated%' " + " AND c.ColumnName NOT LIKE 'Updated%' "
+ "ORDER BY c.ColumnName"; + "ORDER BY c.ColumnName";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement(sql, null); pstmt = DB.prepareStatement(sql, null);
pstmt.setInt(1, AD_Table_ID); pstmt.setInt(1, AD_Table_ID);
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
while (rs.next()) while (rs.next())
{ {
String columnName = rs.getString(1); String columnName = rs.getString(1);
@ -273,9 +282,6 @@ public class GenerateModelJPA
if (seqNo == 1) if (seqNo == 1)
sb.append(createKeyNamePair(columnName, displayType)); sb.append(createKeyNamePair(columnName, displayType));
} }
rs.close();
pstmt.close();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
@ -283,14 +289,8 @@ public class GenerateModelJPA
} }
finally finally
{ {
try DB.close(rs, pstmt);
{ rs = null; pstmt = null;
if (pstmt != null)
pstmt.close ();
}
catch (Exception e)
{}
pstmt = null;
} }
return sb; return sb;
} // createColumns } // createColumns
@ -555,11 +555,12 @@ public class GenerateModelJPA
// //
String sql = "SELECT Value, Name FROM AD_Ref_List WHERE AD_Reference_ID=?"; String sql = "SELECT Value, Name FROM AD_Ref_List WHERE AD_Reference_ID=?";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement(sql, null); pstmt = DB.prepareStatement(sql, null);
pstmt.setInt(1, AD_Reference_ID); pstmt.setInt(1, AD_Reference_ID);
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
while (rs.next()) while (rs.next())
{ {
String value = rs.getString(1); String value = rs.getString(1);
@ -624,10 +625,7 @@ public class GenerateModelJPA
.append("_").append(nameClean) .append("_").append(nameClean)
.append(" = \"").append(value).append("\";"); .append(" = \"").append(value).append("\";");
} }
rs.close(); }
pstmt.close();
pstmt = null;
}
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
@ -635,14 +633,8 @@ public class GenerateModelJPA
} }
finally finally
{ {
try DB.close(rs, pstmt);
{ rs = null; pstmt = null;
if (pstmt != null)
pstmt.close ();
}
catch (Exception e)
{}
pstmt = null;
} }
statement.append(")" statement.append(")"
+ "; " + "; "
@ -799,34 +791,27 @@ public class GenerateModelJPA
// //
int count = 0; int count = 0;
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement(sql.toString(), null); pstmt = DB.prepareStatement(sql.toString(), null);
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
while (rs.next()) while (rs.next())
{ {
new GenerateModelJPA(rs.getInt(1), directory, packageName); new GenerateModelJPA(rs.getInt(1), directory, packageName);
count++; count++;
} }
rs.close(); }
pstmt.close();
pstmt = null;
}
catch (Exception e) catch (Exception e)
{ {
log.severe("main - " + e); log.severe("main - " + e);
} }
finally finally
{ {
try DB.close(rs, pstmt);
{ rs = null; pstmt = null;
if (pstmt != null)
pstmt.close ();
}
catch (Exception e)
{}
pstmt = null;
} }
log.info("Generated = " + count); log.info("Generated = " + count);
} // main } // main