IDEMPIERE-455 Discover and fix FindBugs problems / Pattern NP_NULL_ON_SOME_PATH_EXCEPTION

org.adempiere.base.process/src/org/adempiere/process/ApplyMigrationScripts.java

@@ -156,7 +156,7 @@ public class ApplyMigrationScripts extends SvrProcess {
 						log.saveError("Error", msglog.toString());
 						log.severe(e.getMessage());
 					} finally {
-						stmt.close();
+						if (stmt != null)stmt.close();
 						if(execOk)
 							conn.commit();
 						else

org.adempiere.base/src/org/adempiere/base/DefaultModelFactory.java

@@ -269,7 +269,7 @@ public class DefaultModelFactory implements IModelFactory {
 				s_log.warning("No transaction Constructor for " + clazz + " (" + msg + ")");
 			}
 
-			PO po = (PO)constructor.newInstance(new Object[] {Env.getCtx(), new Integer(Record_ID), trxName});
+			PO po = constructor!=null ? (PO)constructor.newInstance(new Object[] {Env.getCtx(), new Integer(Record_ID), trxName}) : null;
 			return po;
 		}
 		catch (Exception e)

org.adempiere.base/src/org/compiere/print/PrintData.java

@@ -639,11 +639,14 @@ public class PrintData implements Serializable
 			e.printStackTrace();
 		}
 		//	Root
-		Element root = document.createElement(PrintData.XML_TAG);
+		if (document != null) {
-		root.setAttribute(XML_ATTRIBUTE_NAME, getName());
+			Element root = document.createElement(PrintData.XML_TAG);
-		root.setAttribute(XML_ATTRIBUTE_COUNT, String.valueOf(getRowCount()));
+			root.setAttribute(XML_ATTRIBUTE_NAME, getName());
-		document.appendChild(root);
+			root.setAttribute(XML_ATTRIBUTE_COUNT, String.valueOf(getRowCount()));
-		processXML (this, document, root);
+			document.appendChild(root);
+			processXML (this, document, root);
+		}
+		
 		return document;
 	}	//	getDocument
 

org.adempiere.base/src/org/compiere/util/Ini.java

@@ -329,9 +329,11 @@ public final class Ini implements Serializable
 
 		try
 		{
-			InputStream is = fc.getInputStream();
+			if (fc != null) {
-			s_prop.load(is);
+				InputStream is = fc.getInputStream();
-			is.close();
+				s_prop.load(is);
+				is.close();
+			}			
 		}
 		catch (Throwable t)
 		{

org.adempiere.base/src/org/compiere/util/Secure.java

@@ -352,16 +352,19 @@ public class Secure implements SecureInterface
 				nsae.printStackTrace();
 			}
 		}
-		//	Reset MessageDigest object
+        //	Convert String to array of bytes
-		m_md.reset();
-		//	Convert String to array of bytes
 		byte[] input = value.getBytes();
-		//	feed this array of bytes to the MessageDigest object
+		byte[] output = null;
-		m_md.update(input);
+		//	Reset MessageDigest object
-		//	 Get the resulting bytes after the encryption process
+		if (m_md != null) {
-		byte[] output = m_md.digest();
+			m_md.reset();		
-		m_md.reset();
+			//	feed this array of bytes to the MessageDigest object
-		//
+			m_md.update(input);
+			//	 Get the resulting bytes after the encryption process
+			output = m_md.digest();
+			m_md.reset();
+			//
+		}
 		return convertToHexString(output);
 	}	//	getDigest
 

org.adempiere.pipo/src/org/adempiere/pipo2/GridTab2PackExporter.java

@@ -103,7 +103,7 @@ public class GridTab2PackExporter implements IGridTabExporter {
 			}
 		}
 		try {
-			packOut.export(getPackoutDirectory(), file.getAbsolutePath(), packoutDocument, packoutItems, null);
+			packOut.export(getPackoutDirectory(), file!=null ? file.getAbsolutePath() : null , packoutDocument, packoutItems, null);
 		} catch (Exception e) {
 			throw new AdempiereException(e);
 		}

org.compiere.db.postgresql.provider/src/org/compiere/db/DB_PostgreSQL.java

@@ -1032,7 +1032,7 @@ public class DB_PostgreSQL implements AdempiereDatabase
 				throw new DBException("Could not lock record for " + po.toString() + " caused by " + e.getLocalizedMessage());
 			} finally {
 				try {
-					setStatementTimeout(stmt.getConnection(), currentTimeout);
+					if(stmt!=null)setStatementTimeout(stmt.getConnection(), currentTimeout);
 				} catch (SQLException e) {}
 				DB.close(rs, stmt);
 			}