midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF2779181 PackIn fails on strings with single quotes 

Use PO instead of direct DB insert
This commit is contained in:
phib 2009-05-12 06:14:52 +00:00
parent a563185d39
commit 4791007b14
3 changed files with 31 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

101
base/src/org/adempiere/pipo/AbstractElementHandler.java
View File

@ -26,8 +26,10 @@ import java.util.logging.Level;
import javax.xml.transform.sax.TransformerHandler;
import org.compiere.model.MSequence;
import org.compiere.model.PO;
import org.compiere.model.POInfo;
import org.compiere.model.X_AD_Package_Imp_Detail;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
import org.compiere.util.Env;
@ -79,8 +81,9 @@ public abstract class AbstractElementHandler implements ElementHandler {
int id = 0;
TransformerHandler hd_document = getLogDocument(ctx);
AttributesImpl attsOut = new AttributesImpl();
if (success == 1){
//hd_documemt.startElement("","","Successfull",attsOut);
String result = success == 1 ? "Success" : "Failure";
//hd_documemt.startElement("","","Successful",attsOut);
recordLayout.append("Type:")
.append(objectType)
.append(" - Name:")
@ -89,91 +92,29 @@ public abstract class AbstractElementHandler implements ElementHandler {
.append(objectID)
.append(" - Action:")
.append(objectStatus)
.append(" - Success");
.append(" - " + result);
hd_document.startElement("","","Success",attsOut);
hd_document.startElement("","",result,attsOut);
hd_document.characters(recordLayout.toString().toCharArray(),0,recordLayout.length());
hd_document.endElement("","","Success");
//hd_documemt.endElement("","","Successfull");
hd_document.endElement("","",result);
//String sql2 = "SELECT MAX(AD_PACKAGE_IMP_DETAIL_ID) FROM AD_PACKAGE_IMP_DETAIL";
//int id = DB.getSQLValue(m_trxName, sql2)+1;
X_AD_Package_Imp_Detail detail = new X_AD_Package_Imp_Detail(ctx, 0, getTrxName(ctx));
detail.setAD_Package_Imp_ID(getPackageImpId(ctx));
detail.setAD_Org_ID(Env.getAD_Org_ID(ctx) );
detail.setType(objectType);
detail.setName(objectName);
detail.setAction(objectStatus);
detail.setSuccess(result);
detail.setAD_Original_ID(objectID);
detail.setAd_Backup_ID(objectIDBackup);
detail.setTableName(tableName);
detail.setAD_Table_ID(AD_Table_ID);
id = DB.getNextID (Env.getAD_Client_ID(ctx), "AD_Package_Imp_Detail", getTrxName(ctx));
StringBuffer sqlB = new StringBuffer ("Insert INTO AD_Package_Imp_Detail")
.append( "(AD_Client_ID, AD_Org_ID, CreatedBy, UpdatedBy, " )
.append( "AD_PACKAGE_IMP_DETAIL_ID, AD_PACKAGE_IMP_ID, TYPE, NAME," )
.append( " ACTION, SUCCESS, AD_ORIGINAL_ID, AD_BACKUP_ID, TABLENAME, AD_TABLE_ID)" )
.append( "VALUES(" )
.append( " "+ Env.getAD_Client_ID(ctx) )
.append( ", "+ Env.getAD_Org_ID(ctx) )
.append( ", "+ Env.getAD_User_ID(ctx) )
.append( ", "+ Env.getAD_User_ID(ctx) )
.append( ", " + id )
.append( ", " + getPackageImpId(ctx) )
.append( ", '" + objectType )
.append( "', '" + objectName )
.append( "', '" + objectStatus )
.append( "', 'Success'" )
.append( ", "+objectID )
.append( ", "+objectIDBackup )
.append( ", '"+tableName )
.append( "', "+AD_Table_ID )
.append(")");
int no = DB.executeUpdate (sqlB.toString(), getTrxName(ctx));
if (no == -1)
if ( !detail.save(getTrxName(ctx)) )
log.info("Insert to import detail failed");
}
else{
String PK_Status = "Completed with errors";
hd_document.startElement("","","Failure",attsOut);
recordLayout.append("Type:")
.append(objectType)
.append(" - Name:")
.append(tableName)
.append(" - ID:")
.append(objectID)
.append(" - Action:")
.append(objectStatus)
.append(" - Failure");
//hd_documemt.startElement("","","Success",attsOut);
hd_document.characters(recordLayout.toString().toCharArray(),0,recordLayout.length());
//hd_documemt.endElement("","","Success");
hd_document.endElement("","","Failure");
id = detail.get_ID();
//String sql2 = "SELECT MAX(AD_PACKAGE_IMP_DETAIL_ID) FROM AD_PACKAGE_IMP_DETAIL";
//int id = DB.getSQLValue(m_trxName,sql2)+1;
id = DB.getNextID (Env.getAD_Client_ID(ctx), "AD_Package_Imp_Detail", getTrxName(ctx));
StringBuffer sqlB = new StringBuffer ("Insert INTO AD_Package_Imp_Detail")
.append( "(AD_Client_ID, AD_Org_ID, CreatedBy, UpdatedBy, " )
.append( "AD_PACKAGE_IMP_DETAIL_ID, AD_PACKAGE_IMP_ID, TYPE, NAME," )
.append( " ACTION, SUCCESS, AD_ORIGINAL_ID, AD_BACKUP_ID, TABLENAME, AD_TABLE_ID)" )
.append( "VALUES(" )
.append( " "+ Env.getAD_Client_ID(ctx) )
.append( ", "+ Env.getAD_Org_ID(ctx) )
.append( ", "+ Env.getAD_User_ID(ctx) )
.append( ", "+ Env.getAD_User_ID(ctx) )
.append( ", " + id )
.append( ", " + getPackageImpId(ctx) )
.append( ", '" + objectType )
.append( "', '" + objectName )
.append( "', '" + objectStatus )
.append( "', 'Failure'" )
.append( ", "+objectID )
.append( ", "+objectIDBackup )
.append( ", '"+tableName )
.append( "', "+AD_Table_ID )
.append( ")");
int no = DB.executeUpdate (sqlB.toString(), getTrxName(ctx));
if (no == -1)
log.info("Insert to import detail failed");
}
String Object_Status = "Status not set";
return id;
}

5
migration/353a-trunk/oracle/465_BF2779181_PackIn_ImportDetail.sql Normal file
View File

@ -0,0 +1,5 @@
-- 12/05/2009 16:04:45
-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
UPDATE AD_Column SET IsKey='Y', IsParent='N', IsUpdateable='N',Updated=TO_DATE('2009-05-12 16:04:45','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=50065
;

5
migration/353a-trunk/postgresql/465_BF2779181_PackIn_ImportDetail.sql Normal file
View File

@ -0,0 +1,5 @@
-- 12/05/2009 16:04:45
-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
UPDATE AD_Column SET IsKey='Y', IsParent='N', IsUpdateable='N',Updated=TO_TIMESTAMP('2009-05-12 16:04:45','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Column_ID=50065
;