midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor peer review for IDEMPIERE-1657 IDEMPIERE-2109 IDEMPIERE-2105 IDEMPIERE-1555 IDEMPIERE-2152 IDEMPIERE-1969

This commit is contained in:
Carlos Ruiz 2015-01-14 09:54:35 -05:00
parent cf32e66554
commit 42f507f250
22 changed files with 42 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
migration/i2.1z/oracle/201411091604_IDEMPIERE-2152.sql
View File

@ -2,7 +2,7 @@ SET SQLBLANKLINES ON
SET DEFINE OFF
-- Sep 11, 2014 9:56:05 AM ICT
-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
-- IDEMPIERE-2152 Info Window - Join related tabs on other columns than primary key
INSERT INTO AD_Element (ColumnName,AD_Element_ID,Help,Name,Description,PrintName,AD_Element_UU,AD_Org_ID,CreatedBy,UpdatedBy,IsActive,AD_Client_ID,EntityType,Created,Updated) VALUES ('ParentRelatedColumn_ID',202792,'default column RelatedColumn in Relate Info window will link with key column of main info window
column define in ParentRelatedColumn will replace key column','Parent Related Column','column in parent info window, link with column in this relate info','Parent Related Column','d35a2b4b-6022-4b52-bace-93f05958a77a',0,100,100,'Y',0,'D',TO_DATE('2014-09-11 09:55:54','YYYY-MM-DD HH24:MI:SS'),TO_DATE('2014-09-11 09:55:54','YYYY-MM-DD HH24:MI:SS'))
;

2
migration/i2.1z/oracle/201417091982-IDEMPIERE-1969.sql
View File

@ -2,7 +2,7 @@ SET SQLBLANKLINES ON
SET DEFINE OFF
-- Sep 17, 2014 11:44:24 AM ICT
-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
-- IDEMPIERE-1969 Contextual Menu for Info Window Parameters
INSERT INTO AD_Column (SeqNoSelection,IsSyncDatabase,Version,AD_Column_ID,IsMandatory,IsTranslated,IsIdentifier,SeqNo,IsParent,FieldLength,IsSelectionColumn,IsKey,IsAutocomplete,IsAllowLogging,AD_Column_UU,IsUpdateable,ColumnName,Description,Help,Name,IsAllowCopy,Updated,CreatedBy,AD_Org_ID,IsActive,Created,UpdatedBy,IsToolbarButton,IsAlwaysUpdateable,AD_Client_ID,EntityType,IsEncrypted,IsSecure,FKConstraintName,FKConstraintType,AD_Element_ID,AD_Reference_ID,AD_Table_ID) VALUES (0,'N',0,211766,'N','N','N',0,'N',10,'N','N','N','Y','d32e78d0-660c-4e82-9797-52a00ce3042f','N','AD_InfoWindow_ID','Info and search/select Window','The Info window is used to search and select records as well as display information relevant to the selection.','Info Window','Y',TO_DATE('2014-09-17 11:44:23','YYYY-MM-DD HH24:MI:SS'),100,0,'Y',TO_DATE('2014-09-17 11:44:23','YYYY-MM-DD HH24:MI:SS'),100,'N','N',0,'D','N','N','ad_infowindow_preference','N',3068,19,195)
;

2
migration/i2.1z/postgresql/201411091604_IDEMPIERE-2152.sql
View File

@ -1,5 +1,5 @@
-- Sep 11, 2014 9:56:05 AM ICT
-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
-- IDEMPIERE-2152 Info Window - Join related tabs on other columns than primary key
INSERT INTO AD_Element (ColumnName,AD_Element_ID,Help,Name,Description,PrintName,AD_Element_UU,AD_Org_ID,CreatedBy,UpdatedBy,IsActive,AD_Client_ID,EntityType,Created,Updated) VALUES ('ParentRelatedColumn_ID',202792,'default column RelatedColumn in Relate Info window will link with key column of main info window
column define in ParentRelatedColumn will replace key column','Parent Related Column','column in parent info window, link with column in this relate info','Parent Related Column','d35a2b4b-6022-4b52-bace-93f05958a77a',0,100,100,'Y',0,'D',TO_TIMESTAMP('2014-09-11 09:55:54','YYYY-MM-DD HH24:MI:SS'),TO_TIMESTAMP('2014-09-11 09:55:54','YYYY-MM-DD HH24:MI:SS'))
;

2
migration/i2.1z/postgresql/201417091982-IDEMPIERE-1969.sql
View File

@ -1,5 +1,5 @@
-- Sep 17, 2014 11:44:24 AM ICT
-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
-- IDEMPIERE-1969 Contextual Menu for Info Window Parameters
INSERT INTO AD_Column (SeqNoSelection,IsSyncDatabase,Version,AD_Column_ID,IsMandatory,IsTranslated,IsIdentifier,SeqNo,IsParent,FieldLength,IsSelectionColumn,IsKey,IsAutocomplete,IsAllowLogging,AD_Column_UU,IsUpdateable,ColumnName,Description,Help,Name,IsAllowCopy,Updated,CreatedBy,AD_Org_ID,IsActive,Created,UpdatedBy,IsToolbarButton,IsAlwaysUpdateable,AD_Client_ID,EntityType,IsEncrypted,IsSecure,FKConstraintName,FKConstraintType,AD_Element_ID,AD_Reference_ID,AD_Table_ID) VALUES (0,'N',0,211766,'N','N','N',0,'N',10,'N','N','N','Y','d32e78d0-660c-4e82-9797-52a00ce3042f','N','AD_InfoWindow_ID','Info and search/select Window','The Info window is used to search and select records as well as display information relevant to the selection.','Info Window','Y',TO_TIMESTAMP('2014-09-17 11:44:23','YYYY-MM-DD HH24:MI:SS'),100,0,'Y',TO_TIMESTAMP('2014-09-17 11:44:23','YYYY-MM-DD HH24:MI:SS'),100,'N','N',0,'D','N','N','ad_infowindow_preference','N',3068,19,195)
;

3
org.adempiere.base/src/org/adempiere/model/MInfoProcess.java
View File

@ -31,11 +31,10 @@ import org.compiere.util.Evaluator;
*
*/
public class MInfoProcess extends X_AD_InfoProcess implements IInfoColumn {
/**
*
*/
private static final long serialVersionUID = 6603281032935632048L;
private static final long serialVersionUID = -5586972894900686397L;
/**
* {@inheritDoc}

3
org.adempiere.base/src/org/adempiere/model/MInfoRelated.java
View File

@ -22,11 +22,10 @@ import org.compiere.model.Query;
import org.compiere.model.X_AD_InfoRelated;
public class MInfoRelated extends X_AD_InfoRelated implements IInfoColumn {
/**
*
*/
private static final long serialVersionUID = -4239930986439783006L;
private static final long serialVersionUID = -6216174103510277333L;
public MInfoRelated(Properties ctx, int AD_InfoRelated_ID, String trxName) {
super(ctx, AD_InfoRelated_ID, trxName);

2
org.adempiere.base/src/org/compiere/model/GridField.java
View File

@ -81,7 +81,7 @@ public class GridField
/**
*
*/
private static final long serialVersionUID = 8596059010377209016L;
private static final long serialVersionUID = -5875251339128387039L;
/**
* Field Constructor.

2
org.adempiere.base/src/org/compiere/model/GridFieldVO.java
View File

@ -47,7 +47,7 @@ public class GridFieldVO implements Serializable
/**
*
*/
private static final long serialVersionUID = -7001013190366328211L;
private static final long serialVersionUID = 5633655630654835665L;
/**
* Return the SQL statement used for the MFieldVO.create

3
org.adempiere.extend/src/test/functional/QueryTest.java
View File

@ -15,11 +15,8 @@ package test.functional;
import java.sql.Timestamp;
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import org.adempiere.exceptions.DBException;
import org.compiere.model.MTable;

2
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/ValuePreference.java
View File

@ -67,7 +67,7 @@ public class ValuePreference extends Window implements EventListener<Event>
/**
*
*/
private static final long serialVersionUID = 737741552754618206L;
private static final long serialVersionUID = 7594680475358417813L;
/**
* Factory

10
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/StatusBar.java
View File

@ -18,7 +18,6 @@
package org.adempiere.webui.adwindow;
import org.adempiere.webui.LayoutUtils;
import org.adempiere.webui.apps.AEnv;
import org.adempiere.webui.component.DocumentLink;
import org.adempiere.webui.component.Label;
import org.adempiere.webui.component.Panel;
@ -33,7 +32,6 @@ import org.zkoss.zk.ui.event.Event;
import org.zkoss.zk.ui.event.EventListener;
import org.zkoss.zk.ui.event.Events;
import org.zkoss.zk.ui.util.Clients;
import org.zkoss.zul.A;
import org.zkoss.zul.Caption;
import org.zkoss.zul.Div;
import org.zkoss.zul.Hlayout;
@ -50,12 +48,12 @@ import org.zkoss.zul.Space;
*/
public class StatusBar extends Panel implements EventListener<Event>
{
/**
*
/**
*
*/
private static final long serialVersionUID = -3262889055635240201L;
private static final long serialVersionUID = 1519490416637936553L;
private Label infoLine;
private Label infoLine;
private Div west;

10
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/ProcessDialog.java
View File

@ -100,13 +100,13 @@ import com.lowagie.text.pdf.PdfWriter;
*/
public class ProcessDialog extends AbstractProcessDialog implements EventListener<Event>, IHelpContext
{
/**
*
*/
private static final long serialVersionUID = 1320565116095846687L;
public static final String ON_INITIAL_FOCUS_EVENT = "onInitialFocus";
/**
* generate serial version ID
*/
private static final long serialVersionUID = 3329046204196602797L;
private static final String MESSAGE_DIV_STYLE = "max-height: 150pt; overflow: auto; margin: 10px;";
/** Logger */

2
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/ProcessParameterPanel.java
View File

@ -77,7 +77,7 @@ public class ProcessParameterPanel extends Panel implements
/**
*
*/
private static final long serialVersionUID = 195320654866887445L;
private static final long serialVersionUID = -5730428618898681676L;
private String width;

4
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WAllocation.java
View File

@ -25,7 +25,6 @@ import java.util.Calendar;
import java.util.Vector;
import java.util.logging.Level;
import org.adempiere.webui.apps.AEnv;
import org.adempiere.webui.component.Button;
import org.adempiere.webui.component.Checkbox;
import org.adempiere.webui.component.DocumentLink;
@ -60,11 +59,8 @@ import org.compiere.util.Msg;
import org.compiere.util.Trx;
import org.compiere.util.TrxRunnable;
import org.compiere.util.Util;
import org.zkoss.zk.ui.Component;
import org.zkoss.zk.ui.event.Event;
import org.zkoss.zk.ui.event.EventListener;
import org.zkoss.zk.ui.event.Events;
import org.zkoss.zul.A;
import org.zkoss.zul.Borderlayout;
import org.zkoss.zul.Center;
import org.zkoss.zul.Hbox;

7
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/apps/form/WGenForm.java
View File

@ -67,14 +67,13 @@ import org.zkoss.zk.ui.event.Event;
import org.zkoss.zk.ui.event.EventListener;
import org.zkoss.zk.ui.event.Events;
import org.zkoss.zk.ui.util.Clients;
import org.zkoss.zul.A;
import org.zkoss.zul.Borderlayout;
import org.zkoss.zul.Center;
import org.zkoss.zul.Div;
import org.zkoss.zul.Html;
import org.zkoss.zul.Label;
import org.zkoss.zul.North;
import org.zkoss.zul.South;
import org.zkoss.zul.Div;
import org.zkoss.zul.Html;
/**
* Generate custom form window
@ -85,7 +84,7 @@ public class WGenForm extends ADForm implements EventListener<Event>, WTableMode
/**
*
*/
private static final long serialVersionUID = -8669256486969882958L;
private static final long serialVersionUID = 4240430312911412710L;
private GenForm genForm;

7
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/DocumentLink.java
View File

@ -35,8 +35,11 @@ import org.zkoss.zul.A;
*
*/
public class DocumentLink extends A implements EventListener<Event> {
private static final long serialVersionUID = -2950001959302619043L;
/**
*
*/
private static final long serialVersionUID = 1498406053715803814L;
public static final String ATT_RECORD_ID = "Record_ID";
public static final String ATT_AD_TABLE_ID = "AD_Table_ID";

5
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Mask.java
View File

@ -20,11 +20,10 @@ import org.zkoss.zul.Div;
*
*/
public class Mask extends Div {
/**
* generated serial
*
*/
private static final long serialVersionUID = -9068605816183445421L;
private static final long serialVersionUID = 7462166722064971644L;
/**
* default constructor

7
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/ProcessInfoDialog.java
View File

@ -32,7 +32,6 @@ import org.zkoss.zk.ui.Component;
import org.zkoss.zk.ui.event.Event;
import org.zkoss.zk.ui.event.EventListener;
import org.zkoss.zk.ui.event.Events;
import org.zkoss.zul.A;
import org.zkoss.zul.Hbox;
import org.zkoss.zul.Image;
import org.zkoss.zul.Separator;
@ -43,7 +42,11 @@ import org.zkoss.zul.Separator;
* @author Deepak Pansheriya
*/
public class ProcessInfoDialog extends Window implements EventListener<Event> {
private static final long serialVersionUID = -4957498533838144942L;
/**
*
*/
private static final long serialVersionUID = 4479446865514015847L;
private static final String MESSAGE_PANEL_STYLE = "text-align:left; word-break: break-all; overflow: auto; max-height: 250pt; min-width: 230pt; max-width: 450pt;";
private Text lblMsg = new Text();

4
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Tabpanel.java
View File

@ -31,10 +31,10 @@ import org.zkoss.zul.Tab;
*/
public class Tabpanel extends org.zkoss.zul.Tabpanel implements IdSpace, ISupportMask
{
/**
/**
*
*/
private static final long serialVersionUID = -3392752891445762516L;
private static final long serialVersionUID = -1057250877531248907L;
private ITabOnCloseHandler onCloseHandler = null;

5
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Window.java
View File

@ -33,10 +33,11 @@ import org.zkoss.zk.ui.event.Events;
*/
public class Window extends org.zkoss.zul.Window implements ISupportMask
{
/**
/**
*
*/
private static final long serialVersionUID = -977158068979292880L;
private static final long serialVersionUID = -8249071775776387012L;
/*** Show as modal window ***/
public static final String MODE_MODAL = "modal";
/*** Show as popup window ***/

2
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/info/InfoWindow.java
View File

@ -98,7 +98,7 @@ public class InfoWindow extends InfoPanel implements ValueChangeListener, EventL
/**
*
*/
private static final long serialVersionUID = 2751982942639167289L;
private static final long serialVersionUID = -19192097402087013L;
protected Grid parameterGrid;
private Borderlayout layout;

2
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/part/AbstractUIPart.java
View File

@ -12,6 +12,8 @@
*****************************************************************************/
package org.adempiere.webui.part;
import java.awt.BorderLayout;
import org.adempiere.webui.ISupportMask;
import org.adempiere.webui.component.Mask;
import org.adempiere.webui.desktop.IDesktop;