From 0b35edfacf675b0af4189b22ec72857bd02ce21d Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Sat, 3 Oct 2020 20:23:48 +0200
Subject: [PATCH] IDEMPIERE-3862 ORACLE - Update datatype NVARCHAR2 to VARCHAR2

Fix view to avoid compilation errors
---
 db/ddlutils/oracle/views/RV_PP_MRP.sql        |   6 +-
 .../oracle/202010032020_IDEMPIERE-3862.sql    | 105 ++++++++++++++++++
 .../202010032020_IDEMPIERE-3862.sql           |   6 +
 3 files changed, 114 insertions(+), 3 deletions(-)
 create mode 100644 migration/i7.1z/oracle/202010032020_IDEMPIERE-3862.sql
 create mode 100644 migration/i7.1z/postgresql/202010032020_IDEMPIERE-3862.sql

diff --git a/db/ddlutils/oracle/views/RV_PP_MRP.sql b/db/ddlutils/oracle/views/RV_PP_MRP.sql
index edbde2f8a6..5103930521 100644
--- a/db/ddlutils/oracle/views/RV_PP_MRP.sql
+++ b/db/ddlutils/oracle/views/RV_PP_MRP.sql
@@ -71,7 +71,7 @@ SYSDATE, --mrp.datestartschedule,
 SYSDATE, --mrp.datefinishschedule,
 SYSDATE, --mrp.datestart,
 SYSDATE, --mrp.datesimulation,
-CAST('CO' AS nvarchar2(2)),  --mrp.docstatus,
+CAST('CO' AS varchar2(2 char)),  --mrp.docstatus,
 null, --mrp.m_forecast_id,
 null, --mrp.m_forecastline_id,
 null, --mrp.value,
@@ -87,12 +87,12 @@ pp.safetystock - bomqtyonhand(pp.M_Product_ID,pp.M_Warehouse_ID, 0) AS qty, --mr
 pp.s_resource_id,
 null, --planner_id
 null, --mrp.priority,
-CAST('STK' AS nvarchar2(3)), --mrp.ordertype,
+CAST('STK' AS varchar2(3 char)), --mrp.ordertype,
 'D' , --mrp.typemrp,
 p.LowLevel,
 null, --C_BPartner_ID
 null,
-CAST('Safety Stock' AS nvarchar2(80))   --documentNo(mrp.pp_mrp_id) AS documentNo
+CAST('Safety Stock' AS varchar2(80 char))   --documentNo(mrp.pp_mrp_id) AS documentNo
 FROM pp_product_planning pp 
 INNER JOIN M_Product p ON (pp.M_Product_ID = p.M_Product_ID)
 WHERE bomqtyonhand(pp.M_Product_ID,pp.M_Warehouse_ID, 0) < pp.safetystock 
diff --git a/migration/i7.1z/oracle/202010032020_IDEMPIERE-3862.sql b/migration/i7.1z/oracle/202010032020_IDEMPIERE-3862.sql
new file mode 100644
index 0000000000..3465d60f20
--- /dev/null
+++ b/migration/i7.1z/oracle/202010032020_IDEMPIERE-3862.sql
@@ -0,0 +1,105 @@
+-- IDEMPIERE-3862 ORACLE - Update datatype NVARCHAR2 to VARCHAR2
+-- Fix view to avoid compilation errors
+
+CREATE OR REPLACE VIEW rv_pp_mrp AS 
+SELECT 
+mrp.pp_mrp_id,
+mrp.ad_client_id,
+mrp.ad_org_id,
+mrp.created,
+mrp.createdby,
+mrp.isactive,
+mrp.isavailable,
+mrp.updated,
+mrp.updatedby,
+pp.ismps,
+mrp.name,
+mrp.description,
+mrp.c_order_id,
+mrp.c_orderline_id,
+mrp.dateordered,
+mrp.dateconfirm,
+mrp.datepromised,
+mrp.datestartschedule,
+mrp.datefinishschedule,
+mrp.datestart,
+mrp.datesimulation,
+mrp.docstatus,
+mrp.m_forecast_id,
+mrp.m_forecastline_id,
+mrp.value,
+mrp.m_product_id,
+mrp.m_requisition_id,
+mrp.m_requisitionline_id,
+mrp.m_warehouse_id,
+mrp.pp_order_id,
+mrp.pp_order_bomline_id,
+mrp.dd_order_id,
+mrp.dd_orderline_id,
+mrp.qty,
+mrp.s_resource_id,
+mrp.planner_id,
+mrp.priority,
+mrp.ordertype,
+mrp.typemrp,
+p.LowLevel,
+mrp.C_BPartner_ID,
+mrp.version,
+documentNo(mrp.pp_mrp_id) AS documentNo
+FROM pp_mrp mrp
+INNER JOIN M_Product p ON (mrp.M_Product_ID = p.M_Product_ID)
+LEFT JOIN pp_product_planning pp ON (pp.m_product_id = mrp.m_product_id AND mrp.m_warehouse_id = pp.m_warehouse_id)
+WHERE mrp.Qty<>0
+UNION
+SELECT 
+0 ,
+pp.ad_client_id,
+pp.ad_org_id,
+pp.created,
+pp.createdby,
+pp.isactive,
+'Y',--mrp.isavailable
+pp.updated,
+pp.updatedby,
+pp.ismps,
+null, --name
+null, --description
+null, --mrp.c_order_id
+null, --mrp.c_orderline_id
+SYSDATE, --mrp.dateordered,
+SYSDATE, --mrp.dateconfirm,
+SYSDATE, --mrp.datepromised,
+SYSDATE, --mrp.datestartschedule,
+SYSDATE, --mrp.datefinishschedule,
+SYSDATE, --mrp.datestart,
+SYSDATE, --mrp.datesimulation,
+CAST('CO' AS varchar2(2 char)),  --mrp.docstatus,
+null, --mrp.m_forecast_id,
+null, --mrp.m_forecastline_id,
+null, --mrp.value,
+pp.m_product_id,
+null, --mrp.m_requisition_id,
+null, --mrp.m_requisitionline_id,
+pp.m_warehouse_id,
+null, --mrp.pp_order_id,
+null, --pp_order_bomline_id
+null, --mrp.dd_order_id,
+null, --mrp.dd_orderline_id,
+pp.safetystock - bomqtyonhand(pp.M_Product_ID,pp.M_Warehouse_ID, 0) AS qty, --mrp.qty,
+pp.s_resource_id,
+null, --planner_id
+null, --mrp.priority,
+CAST('STK' AS varchar2(3 char)), --mrp.ordertype,
+'D' , --mrp.typemrp,
+p.LowLevel,
+null, --C_BPartner_ID
+null,
+CAST('Safety Stock' AS varchar2(80 char))   --documentNo(mrp.pp_mrp_id) AS documentNo
+FROM pp_product_planning pp 
+INNER JOIN M_Product p ON (pp.M_Product_ID = p.M_Product_ID)
+WHERE bomqtyonhand(pp.M_Product_ID,pp.M_Warehouse_ID, 0) < pp.safetystock 
+;
+
+SELECT register_migration_script('202010032020_IDEMPIERE-3862.sql') FROM dual
+;
+
diff --git a/migration/i7.1z/postgresql/202010032020_IDEMPIERE-3862.sql b/migration/i7.1z/postgresql/202010032020_IDEMPIERE-3862.sql
new file mode 100644
index 0000000000..e59c2f8156
--- /dev/null
+++ b/migration/i7.1z/postgresql/202010032020_IDEMPIERE-3862.sql
@@ -0,0 +1,6 @@
+-- IDEMPIERE-3862 ORACLE - Update datatype NVARCHAR2 to VARCHAR2
+-- Placeholder - just for oracle
+
+SELECT register_migration_script('202010032020_IDEMPIERE-3862.sql') FROM dual
+;
+